thrivekit 2.0.13 → 2.0.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "thrivekit",
-  "version": "2.0.13",
+  "version": "2.0.15",
   "description": "Tools to thrive with agentic coding - RALPH autonomous loop, Claude Code hooks, PRD-driven development",
   "author": "Allie Jones <allie@allthrive.ai>",
   "license": "MIT",

package/ralph/loop.sh

@@ -2,6 +2,90 @@
 # shellcheck shell=bash
 # loop.sh - The autonomous development loop
 
+# Pre-flight checks to catch common issues before wasting iterations
+preflight_checks() {
+  echo "--- Pre-flight Checks ---"
+  local warnings=0
+
+  # Check API connectivity if configured
+  local api_url
+  api_url=$(get_config '.api.baseUrl' "")
+  if [[ -n "$api_url" ]]; then
+    printf "  API connectivity ($api_url)... "
+    if curl -sf --connect-timeout 5 "$api_url" >/dev/null 2>&1 || \
+       curl -sf --connect-timeout 5 "${api_url}/health" >/dev/null 2>&1 || \
+       curl -sf --connect-timeout 5 "${api_url}/api/health" >/dev/null 2>&1; then
+      print_success "ok"
+    else
+      print_warning "unreachable"
+      echo "    Is your API server running?"
+      ((warnings++))
+    fi
+  fi
+
+  # Check frontend connectivity if configured
+  local test_url
+  test_url=$(get_config '.testUrlBase' "")
+  if [[ -n "$test_url" ]]; then
+    printf "  Frontend connectivity ($test_url)... "
+    if curl -sf --connect-timeout 5 "$test_url" >/dev/null 2>&1; then
+      print_success "ok"
+    else
+      print_warning "unreachable"
+      echo "    Is your frontend dev server running?"
+      ((warnings++))
+    fi
+  fi
+
+  # Check for common migration issues in Python projects
+  local backend_dir
+  backend_dir=$(get_config '.directories.backend' "")
+  if [[ -n "$backend_dir" && -d "$backend_dir" ]]; then
+    # Check for alembic migrations
+    if [[ -d "$backend_dir/alembic" ]] || [[ -d "$backend_dir/migrations" ]]; then
+      printf "  Database migrations... "
+      # Try to verify DB connection via alembic or Django
+      if [[ -f "$backend_dir/alembic.ini" ]]; then
+        if (cd "$backend_dir" && alembic current >/dev/null 2>&1); then
+          print_success "ok"
+        else
+          print_warning "check DB connection"
+          echo "    Run: cd $backend_dir && alembic current"
+          ((warnings++))
+        fi
+      fi
+    fi
+  fi
+
+  # Check Docker if docker-compose exists
+  for compose_file in "docker-compose.yml" "docker-compose.yaml" "compose.yml"; do
+    if [[ -f "$compose_file" ]]; then
+      printf "  Docker services... "
+      if docker compose ps --quiet 2>/dev/null | grep -q .; then
+        print_success "running"
+      elif docker-compose ps --quiet 2>/dev/null | grep -q .; then
+        print_success "running"
+      else
+        print_warning "not running"
+        echo "    Run: docker compose up -d"
+        ((warnings++))
+      fi
+      break
+    fi
+  done
+
+  echo ""
+  if [[ $warnings -gt 0 ]]; then
+    print_warning "$warnings pre-flight warning(s) - loop may fail on connectivity issues"
+    echo ""
+    read -r -p "Continue anyway? [Y/n] " response
+    if [[ "$response" =~ ^[Nn] ]]; then
+      echo "Aborted. Fix the issues and try again."
+      exit 1
+    fi
+  fi
+}
+
 run_loop() {
   local max_iterations="$DEFAULT_MAX_ITERATIONS"
   local specific_story=""
@@ -26,6 +110,9 @@ run_loop() {
   # Validate prerequisites
   check_dependencies
 
+  # Pre-flight checks to catch issues before wasting iterations
+  preflight_checks
+
   if [[ ! -f "$RALPH_DIR/prd.json" ]]; then
     # Check for misplaced PRD in subdirectories
     local found_prd
@@ -73,7 +160,11 @@ run_loop() {
   local iteration=0
   local last_story=""
   local consecutive_failures=0
-  local max_story_retries=3
+  local max_story_retries=5
+  local total_attempts=0
+  local skipped_stories=()
+  local start_time
+  start_time=$(date +%s)
 
   while [[ $iteration -lt $max_iterations ]]; do
     # Check for stop signal
@@ -108,19 +199,37 @@ run_loop() {
     fi
 
     if [[ -z "$story" ]]; then
+      print_progress_summary "$start_time" "$total_attempts" "${#skipped_stories[@]}"
       send_notification "✅ Ralph finished: All stories passed!"
       archive_feature
       return 0
     fi
 
+    ((total_attempts++))
+
     # Track repeated failures on same story
     if [[ "$story" == "$last_story" ]]; then
       ((consecutive_failures++))
-      if [[ $consecutive_failures -ge $max_story_retries ]]; then
-        print_warning "$story failed $consecutive_failures times - check failure context above"
-      else
-        print_warning "Retry $consecutive_failures/$max_story_retries for $story (failure context included)"
+
+      # Circuit breaker: skip to next story after max retries
+      if [[ $consecutive_failures -gt $max_story_retries ]]; then
+        print_error "Circuit breaker: $story failed $max_story_retries times, skipping to next story"
+        echo ""
+        echo "  Saved failure context to: $RALPH_DIR/failures/$story.txt"
+        mkdir -p "$RALPH_DIR/failures"
+        cp "$RALPH_DIR/last_failure.txt" "$RALPH_DIR/failures/$story.txt" 2>/dev/null || true
+        skipped_stories+=("$story")
+        # Mark as skipped (not passed, but move on)
+        jq --arg id "$story" '(.stories[] | select(.id==$id)) |= . + {skipped: true}' "$RALPH_DIR/prd.json" > "$RALPH_DIR/prd.json.tmp" && mv "$RALPH_DIR/prd.json.tmp" "$RALPH_DIR/prd.json"
+        last_story=""
+        consecutive_failures=0
+        continue
       fi
+
+      # Exponential backoff before retry
+      local backoff=$((2 ** (consecutive_failures - 1)))
+      print_warning "Retry $consecutive_failures/$max_story_retries for $story (waiting ${backoff}s...)"
+      sleep "$backoff"
     else
       consecutive_failures=1
       last_story="$story"
@@ -305,9 +414,10 @@ run_loop() {
   done
 
   print_warning "Max iterations ($max_iterations) reached"
+  print_progress_summary "$start_time" "$total_attempts" "${#skipped_stories[@]}"
   local passed failed
   passed=$(jq '[.stories[] | select(.passes==true)] | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
-  failed=$(jq '[.stories[] | select(.passes==false)] | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
+  failed=$(jq '[.stories[] | select(.passes==false and .skipped!=true)] | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
   send_notification "⚠️ Ralph stopped: $passed passed, $failed remaining (max iterations reached)"
   return 1
 }
@@ -532,6 +642,39 @@ build_prompt() {
   _inject_developer_dna
 }
 
+# Print progress summary at end of run
+print_progress_summary() {
+  local start_time="$1"
+  local total_attempts="$2"
+  local skipped_count="$3"
+
+  local end_time
+  end_time=$(date +%s)
+  local duration=$((end_time - start_time))
+  local hours=$((duration / 3600))
+  local minutes=$(((duration % 3600) / 60))
+
+  local passed failed total
+  passed=$(jq '[.stories[] | select(.passes==true)] | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
+  failed=$(jq '[.stories[] | select(.passes==false and .skipped!=true)] | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
+  total=$(jq '.stories | length' "$RALPH_DIR/prd.json" 2>/dev/null || echo "0")
+
+  echo ""
+  echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+  print_success "COMPLETE"
+  echo ""
+  echo "  Stories:    $passed/$total passed"
+  [[ "$skipped_count" -gt 0 ]] && echo "  Skipped:    $skipped_count (hit circuit breaker)"
+  echo "  Attempts:   $total_attempts total iterations"
+  if [[ $hours -gt 0 ]]; then
+    echo "  Duration:   ${hours}h ${minutes}m"
+  else
+    echo "  Duration:   ${minutes}m"
+  fi
+  echo ""
+  echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+}
+
 # Mark feature as complete (keep PRD for appending new stories)
 archive_feature() {
   local feature_name

package/ralph/verify/review.sh

@@ -78,21 +78,9 @@ Check for these issues:
 
 ## Response Format
 
-Respond with ONLY a JSON object:
-{
-  "pass": true/false,
-  "issues": [
-    {
-      "severity": "critical|warning|info",
-      "category": "security|error-handling|edge-case|quality|performance|scalability|a11y|architecture|compliance",
-      "file": "path/to/file",
-      "line": 123,
-      "message": "Description of the issue",
-      "suggestion": "How to fix it"
-    }
-  ],
-  "summary": "Brief overall assessment"
-}
+IMPORTANT: Output ONLY raw JSON, no markdown formatting, no code blocks, no explanation.
+
+{"pass": true/false, "issues": [{"severity": "critical|warning|info", "category": "security|error-handling|edge-case|quality|performance|scalability|a11y|architecture|compliance", "file": "path/to/file", "line": 123, "message": "Description", "suggestion": "Fix"}], "summary": "Brief assessment"}
 
 Only fail (pass: false) for critical or multiple warning-level issues.
 EOF