npm - three-stdlib - Versions diffs - 2.23.13 → 2.23.14 - Mend

three-stdlib 2.23.13 → 2.23.14

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/controls/OrbitControls.cjs +4 -1
package/controls/OrbitControls.js +4 -1
package/package.json +1 -1

package/controls/OrbitControls.cjs CHANGED Viewed

@@ -150,13 +150,16 @@ class OrbitControls extends THREE.EventDispatcher {
     };
     this.update = (() => {
       const offset = new THREE.Vector3();
-      const quat = new THREE.Quaternion().setFromUnitVectors(object.up, new THREE.Vector3(0, 1, 0));
+      const up = new THREE.Vector3(0, 1, 0);
+      const quat = new THREE.Quaternion().setFromUnitVectors(object.up, up);
       const quatInverse = quat.clone().invert();
       const lastPosition = new THREE.Vector3();
       const lastQuaternion = new THREE.Quaternion();
       const twoPI = 2 * Math.PI;
       return function update() {
         const position = scope.object.position;
+        quat.setFromUnitVectors(object.up, up);
+        quatInverse.copy(quat).invert();
         offset.copy(position).sub(scope.target);
         offset.applyQuaternion(quat);
         spherical.setFromVector3(offset);

package/controls/OrbitControls.js CHANGED Viewed

@@ -148,13 +148,16 @@ class OrbitControls extends EventDispatcher {
     };
     this.update = (() => {
       const offset = new Vector3();
-      const quat = new Quaternion().setFromUnitVectors(object.up, new Vector3(0, 1, 0));
+      const up = new Vector3(0, 1, 0);
+      const quat = new Quaternion().setFromUnitVectors(object.up, up);
       const quatInverse = quat.clone().invert();
       const lastPosition = new Vector3();
       const lastQuaternion = new Quaternion();
       const twoPI = 2 * Math.PI;
       return function update() {
         const position = scope.object.position;
+        quat.setFromUnitVectors(object.up, up);
+        quatInverse.copy(quat).invert();
         offset.copy(position).sub(scope.target);
         offset.applyQuaternion(quat);
         spherical.setFromVector3(offset);

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "three-stdlib",
-  "version": "2.23.13",
+  "version": "2.23.14",
   "description": "stand-alone library of threejs examples",
   "keywords": [
     "three",