three-gpu-pathtracer 0.0.16 → 0.0.17

package/build/index.umd.cjs

@@ -340,9 +340,9 @@
 
 	// Seeds
 	uniform sampler2D sobolTexture;
-	uint sobolPixelIndex;
-	uint sobolPathIndex;
-	uint sobolBounceIndex;
+	uint sobolPixelIndex = 0u;
+	uint sobolPathIndex = 0u;
+	uint sobolBounceIndex = 0u;
 
 	uint sobolGetSeed( uint bounce, uint effect ) {
 
@@ -704,18 +704,22 @@
 			this._currentTile = 0;
 
 			this._sobolTarget = new SobolNumberMapGenerator().generate( renderer );
+
+			// will be null if extension not supported
+			const floatLinearExtensionSupported = renderer.extensions.get( 'OES_texture_float_linear' );
+
 			this._primaryTarget = new three.WebGLRenderTarget( 1, 1, {
 				format: three.RGBAFormat,
-				type: three.FloatType,
+				type: floatLinearExtensionSupported ? three.FloatType : three.HalfFloatType,
 			} );
 			this._blendTargets = [
 				new three.WebGLRenderTarget( 1, 1, {
 					format: three.RGBAFormat,
-					type: three.FloatType,
+					type: floatLinearExtensionSupported ? three.FloatType : three.HalfFloatType,
 				} ),
 				new three.WebGLRenderTarget( 1, 1, {
 					format: three.RGBAFormat,
-					type: three.FloatType,
+					type: floatLinearExtensionSupported ? three.FloatType : three.HalfFloatType,
 				} ),
 			];
 
@@ -1196,6 +1200,12 @@
 			const geometry = options.cloneGeometry ? originalGeometry.clone() : originalGeometry;
 			geometry.applyMatrix4( mesh.matrixWorld );
 
+			if ( mesh.matrixWorld.determinant() < 0 ) {
+
+				geometry.index.array.reverse();
+
+			}
+
 			// ensure our geometry has common attributes
 			setCommonAttributes( geometry, {
 				attributes: options.attributes,
@@ -1227,7 +1237,7 @@
 
 		} );
 
-		const geometry = BufferGeometryUtils_js.mergeBufferGeometries( transformedGeometry, false );
+		const geometry = BufferGeometryUtils_js.mergeGeometries( transformedGeometry, false );
 		const textures = Array.from( textureSet );
 		return { geometry, materials, textures };
 
@@ -1264,7 +1274,12 @@
 
 						meshes.push( c );
 
-					} else if ( c.isRectAreaLight || c.isSpotLight || c.isDirectionalLight || c.isPointLight ) {
+					} else if (
+						c.isRectAreaLight ||
+						c.isSpotLight ||
+						c.isPointLight ||
+						c.isDirectionalLight
+					) {
 
 						lights.push( c );
 
@@ -1335,7 +1350,7 @@
 
 		generate() {
 
-			const { objects, staticGeometryGenerator, geometry } = this;
+			const { objects, staticGeometryGenerator, geometry, lights } = this;
 			if ( this.bvh === null ) {
 
 				const attributes = [ 'position', 'normal', 'tangent', 'uv', 'color' ];
@@ -1349,9 +1364,14 @@
 							const normalMapRequired = ! ! c.material.normalMap;
 							setCommonAttributes( c.geometry, { attributes, normalMapRequired } );
 
-						} else if ( c.isRectAreaLight || c.isSpotLight ) {
+						} else if (
+							c.isRectAreaLight ||
+							c.isSpotLight ||
+							c.isPointLight ||
+							c.isDirectionalLight
+						) {
 
-							this.lights.push( c );
+							lights.push( c );
 
 						}
 
@@ -1776,11 +1796,11 @@
 	const _color = new three.Color();
 	class ProceduralEquirectTexture extends three.DataTexture {
 
-		constructor( width, height ) {
+		constructor( width = 512, height = 512 ) {
 
 			super(
-				new Float32Array( width * height * 4 ),
-				width, height, three.RGBAFormat, three.FloatType, three.EquirectangularReflectionMapping,
+				new Uint16Array( width * height * 4 ),
+				width, height, three.RGBAFormat, three.HalfFloatType, three.EquirectangularReflectionMapping,
 				three.RepeatWrapping, three.ClampToEdgeWrapping, three.LinearFilter, three.LinearFilter,
 			);
 
@@ -1812,10 +1832,10 @@
 
 					const i = y * width + x;
 					const i4 = 4 * i;
-					data[ i4 + 0 ] = _color.r;
-					data[ i4 + 1 ] = _color.g;
-					data[ i4 + 2 ] = _color.b;
-					data[ i4 + 3 ] = 1.0;
+					data[ i4 + 0 ] = three.DataUtils.toHalfFloat( _color.r );
+					data[ i4 + 1 ] = three.DataUtils.toHalfFloat( _color.g );
+					data[ i4 + 2 ] = three.DataUtils.toHalfFloat( _color.b );
+					data[ i4 + 3 ] = three.DataUtils.toHalfFloat( 1.0 );
 
 				}
 
@@ -1949,6 +1969,8 @@
 			this.type = three.FloatType;
 			this.wrapS = three.ClampToEdgeWrapping;
 			this.wrapT = three.ClampToEdgeWrapping;
+			this.minFilter = three.NearestFilter;
+			this.magFilter = three.NearestFilter;
 			this.generateMipmaps = false;
 			this.threeCompatibilityTransforms = false;
 			this.features = new MaterialFeatures();
@@ -2483,6 +2505,19 @@
 
 	}
 
+	function toHalfFloatArray( f32Array ) {
+
+		const f16Array = new Uint16Array( f32Array.length );
+		for ( let i = 0, n = f32Array.length; i < n; ++ i ) {
+
+			f16Array[ i ] = three.DataUtils.toHalfFloat( f32Array[ i ] );
+
+		}
+
+		return f16Array;
+
+	}
+
 	function binarySearchFindClosestIndexOf( array, targetValue, offset = 0, count = array.length ) {
 
 		let lower = offset;
@@ -2532,15 +2567,15 @@
 		let newData = data;
 		if ( map.type === three.HalfFloatType ) {
 
-			newData = new Float32Array( data.length );
+			newData = new Uint16Array( data.length );
 			for ( const i in data ) {
 
-				newData[ i ] = three.DataUtils.fromHalfFloat( data[ i ] );
+				newData[ i ] = data[ i ];
 
 			}
 
 			map.image.data = newData;
-			map.type = three.FloatType;
+			map.type = three.HalfFloatType;
 
 		}
 
@@ -2581,8 +2616,8 @@
 
 			// Default to a white texture and associated weights so we don't
 			// just render black initially.
-			const whiteTex = new three.DataTexture( new Float32Array( [ 1, 1, 1, 1 ] ), 1, 1 );
-			whiteTex.type = three.FloatType;
+			const whiteTex = new three.DataTexture( toHalfFloatArray( new Float32Array( [ 1, 1, 1, 1 ] ) ), 1, 1 );
+			whiteTex.type = three.HalfFloatType;
 			whiteTex.format = three.RGBAFormat;
 			whiteTex.minFilter = three.LinearFilter;
 			whiteTex.magFilter = three.LinearFilter;
@@ -2593,8 +2628,8 @@
 
 			// Stores a map of [0, 1] value -> cumulative importance row & pdf
 			// used to sampling a random value to a relevant row to sample from
-			const marginalWeights = new three.DataTexture( new Float32Array( [ 0, 1 ] ), 1, 2 );
-			marginalWeights.type = three.FloatType;
+			const marginalWeights = new three.DataTexture( toHalfFloatArray( new Float32Array( [ 0, 1 ] ) ), 1, 2 );
+			marginalWeights.type = three.HalfFloatType;
 			marginalWeights.format = three.RedFormat;
 			marginalWeights.minFilter = three.LinearFilter;
 			marginalWeights.magFilter = three.LinearFilter;
@@ -2603,8 +2638,8 @@
 
 			// Stores a map of [0, 1] value -> cumulative importance column & pdf
 			// used to sampling a random value to a relevant pixel to sample from
-			const conditionalWeights = new three.DataTexture( new Float32Array( [ 0, 0, 1, 1 ] ), 2, 2 );
-			conditionalWeights.type = three.FloatType;
+			const conditionalWeights = new three.DataTexture( toHalfFloatArray( new Float32Array( [ 0, 0, 1, 1 ] ) ), 2, 2 );
+			conditionalWeights.type = three.HalfFloatType;
 			conditionalWeights.format = three.RedFormat;
 			conditionalWeights.minFilter = three.LinearFilter;
 			conditionalWeights.magFilter = three.LinearFilter;
@@ -2654,9 +2689,9 @@
 				for ( let x = 0; x < width; x ++ ) {
 
 					const i = y * width + x;
-					const r = data[ 4 * i + 0 ];
-					const g = data[ 4 * i + 1 ];
-					const b = data[ 4 * i + 2 ];
+					const r = three.DataUtils.fromHalfFloat( data[ 4 * i + 0 ] );
+					const g = three.DataUtils.fromHalfFloat( data[ 4 * i + 1 ] );
+					const b = three.DataUtils.fromHalfFloat( data[ 4 * i + 2 ] );
 
 					// the probability of the pixel being selected in this row is the
 					// scale of the luminance relative to the rest of the pixels.
@@ -2708,8 +2743,8 @@
 			// the marginal and conditional data. These will be used to sample with a random number
 			// to retrieve a uv value to sample in the environment map.
 			// These values continually increase so it's okay to interpolate between them.
-			const marginalDataArray = new Float32Array( height );
-			const conditionalDataArray = new Float32Array( width * height );
+			const marginalDataArray = new Uint16Array( height );
+			const conditionalDataArray = new Uint16Array( width * height );
 
 			// we add a half texel offset so we're sampling the center of the pixel
 			for ( let i = 0; i < height; i ++ ) {
@@ -2717,7 +2752,7 @@
 				const dist = ( i + 1 ) / height;
 				const row = binarySearchFindClosestIndexOf( cdfMarginal, dist );
 
-				marginalDataArray[ i ] = ( row + 0.5 ) / height;
+				marginalDataArray[ i ] = three.DataUtils.toHalfFloat( ( row + 0.5 ) / height );
 
 			}
 
@@ -2729,7 +2764,7 @@
 					const dist = ( x + 1 ) / width;
 					const col = binarySearchFindClosestIndexOf( cdfConditional, dist, y * width, width );
 
-					conditionalDataArray[ i ] = ( col + 0.5 ) / width;
+					conditionalDataArray[ i ] = three.DataUtils.toHalfFloat( ( col + 0.5 ) / width );
 
 				}
 
@@ -2803,6 +2838,8 @@
 			tex.wrapS = three.ClampToEdgeWrapping;
 			tex.wrapT = three.ClampToEdgeWrapping;
 			tex.generateMipmaps = false;
+			tex.minFilter = three.NearestFilter;
+			tex.magFilter = three.NearestFilter;
 
 			this.tex = tex;
 			this.count = 0;
@@ -2833,7 +2870,7 @@
 			const worldQuaternion = new three.Quaternion();
 			const eye = new three.Vector3();
 			const target = new three.Vector3();
-			const up = new three.Vector3();
+			const up = new three.Vector3( 0, 1, 0 );
 
 			for ( let i = 0, l = lights.length; i < l; i ++ ) {
 
@@ -3276,7 +3313,7 @@
 			loader.setPath( this.path );
 			loader.setRequestHeader( this.requestHeader );
 
-			const texture = new three.DataTexture( null, 360, 180, three.RedFormat, three.FloatType );
+			const texture = new three.DataTexture( null, 360, 180, three.RedFormat, three.HalfFloatType );
 			texture.minFilter = three.LinearFilter;
 			texture.magFilter = three.LinearFilter;
 
@@ -3284,7 +3321,7 @@
 
 				const iesLamp = new IESLamp( text );
 
-				texture.image.data = this._getIESValues( iesLamp );
+				texture.image.data = toHalfFloatArray( this._getIESValues( iesLamp ) );
 				texture.needsUpdate = true;
 
 				if ( onLoad !== undefined ) {
@@ -3302,10 +3339,10 @@
 		parse( text ) {
 
 			const iesLamp = new IESLamp( text );
-			const texture = new three.DataTexture( null, 360, 180, three.RedFormat, three.FloatType );
+			const texture = new three.DataTexture( null, 360, 180, three.RedFormat, three.HalfFloatType );
 			texture.minFilter = three.LinearFilter;
 			texture.magFilter = three.LinearFilter;
-			texture.image.data = this._getIESValues( iesLamp );
+			texture.image.data = toHalfFloatArray( this._getIESValues( iesLamp ) );
 			texture.needsUpdate = true;
 
 			return texture;
@@ -3323,7 +3360,7 @@
 
 			const tex = this.texture;
 			tex.format = three.RGBAFormat;
-			tex.type = three.FloatType;
+			tex.type = three.HalfFloatType;
 			tex.minFilter = three.LinearFilter;
 			tex.magFilter = three.LinearFilter;
 			tex.wrapS = three.ClampToEdgeWrapping;
@@ -3574,7 +3611,7 @@
 			this.renderer = renderer;
 			this.pmremGenerator = new three.PMREMGenerator( renderer );
 			this.copyQuad = new Pass_js.FullScreenQuad( new PMREMCopyMaterial() );
-			this.renderTarget = new three.WebGLRenderTarget( 1, 1, { type: three.FloatType, format: three.RGBAFormat } );
+			this.renderTarget = new three.WebGLRenderTarget( 1, 1, { type: three.HalfFloatType, format: three.RGBAFormat } );
 
 		}
 
@@ -3611,10 +3648,10 @@
 			renderer.autoClear = prevClear;
 
 			// read the data back
-			const buffer = new Float32Array( width * height * 4 );
+			const buffer = new Uint16Array( width * height * 4 );
 			renderer.readRenderTargetPixels( renderTarget, 0, 0, width, height, buffer );
 
-			const result = new three.DataTexture( buffer, width, height, three.RGBAFormat, three.FloatType );
+			const result = new three.DataTexture( buffer, width, height, three.RGBAFormat, three.HalfFloatType );
 			result.minFilter = texture.minFilter;
 			result.magFilter = texture.magFilter;
 			result.wrapS = texture.wrapS;
@@ -3756,7 +3793,7 @@
 
 					gl_FragColor = smartDeNoise( map, vec2( vUv.x, vUv.y ), sigma, kSigma, threshold );
 					#include <tonemapping_fragment>
-					#include <encodings_fragment>
+					#include <colorspace_fragment>
 					#include <premultiplied_alpha_fragment>
 
 				}
@@ -3839,7 +3876,7 @@
 					gl_FragColor.rgb = vec3( mix( minColor, maxColor, t ) );
 					gl_FragColor.a = 1.0;
 
-					#include <encodings_fragment>
+					#include <colorspace_fragment>
 
 				}`,
 
@@ -4048,7 +4085,7 @@
 
 					}
 
-					#include <encodings_fragment>
+					#include <colorspace_fragment>
 
 				}
 
@@ -4390,7 +4427,18 @@
 
 			l.coneCos = s5.r;
 			l.penumbraCos = s5.g;
-			l.iesProfile = int( round ( s5.b ) );
+			l.iesProfile = int( round( s5.b ) );
+
+		} else {
+
+			l.radius = 0.0;
+			l.near = 0.0;
+			l.decay = 0.0;
+			l.distance = 0.0;
+
+			l.coneCos = 0.0;
+			l.penumbraCos = 0.0;
+			l.iesProfile = - 1;
 
 		}
 
@@ -4586,21 +4634,22 @@
 
 		uint firstTextureTransformIdx = i + 15u;
 
-		m.mapTransform = m.map == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx );
-		m.metalnessMapTransform = m.metalnessMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 2u );
-		m.roughnessMapTransform = m.roughnessMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 4u );
-		m.transmissionMapTransform = m.transmissionMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 6u );
-		m.emissiveMapTransform = m.emissiveMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 8u );
-		m.normalMapTransform = m.normalMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 10u );
-		m.clearcoatMapTransform = m.clearcoatMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 12u );
-		m.clearcoatNormalMapTransform = m.clearcoatNormalMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 14u );
-		m.clearcoatRoughnessMapTransform = m.clearcoatRoughnessMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 16u );
-		m.sheenColorMapTransform = m.sheenColorMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 18u );
-		m.sheenRoughnessMapTransform = m.sheenRoughnessMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 20u );
-		m.iridescenceMapTransform = m.iridescenceMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 22u );
-		m.iridescenceThicknessMapTransform = m.iridescenceThicknessMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 24u );
-		m.specularColorMapTransform = m.specularColorMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 26u );
-		m.specularIntensityMapTransform = m.specularIntensityMap == - 1 ? mat3( 0 ) : readTextureTransform( tex, firstTextureTransformIdx + 28u );
+		// mat3( 1.0 ) is an identity matrix
+		m.mapTransform = m.map == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx );
+		m.metalnessMapTransform = m.metalnessMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 2u );
+		m.roughnessMapTransform = m.roughnessMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 4u );
+		m.transmissionMapTransform = m.transmissionMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 6u );
+		m.emissiveMapTransform = m.emissiveMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 8u );
+		m.normalMapTransform = m.normalMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 10u );
+		m.clearcoatMapTransform = m.clearcoatMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 12u );
+		m.clearcoatNormalMapTransform = m.clearcoatNormalMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 14u );
+		m.clearcoatRoughnessMapTransform = m.clearcoatRoughnessMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 16u );
+		m.sheenColorMapTransform = m.sheenColorMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 18u );
+		m.sheenRoughnessMapTransform = m.sheenRoughnessMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 20u );
+		m.iridescenceMapTransform = m.iridescenceMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 22u );
+		m.iridescenceThicknessMapTransform = m.iridescenceThicknessMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 24u );
+		m.specularColorMapTransform = m.specularColorMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 26u );
+		m.specularIntensityMapTransform = m.specularIntensityMap == - 1 ? mat3( 1.0 ) : readTextureTransform( tex, firstTextureTransformIdx + 28u );
 
 		return m;
 
@@ -4625,9 +4674,9 @@ bool isMaterialFogVolume( sampler2D materials, uint materialIndex ) {
 
 // returns true if we're within the first fog volume we hit
 bool bvhIntersectFogVolumeHit(
-	BVH bvh, vec3 rayOrigin, vec3 rayDirection,
+	vec3 rayOrigin, vec3 rayDirection,
 	usampler2D materialIndexAttribute, sampler2D materials,
-	out Material material
+	inout Material material
 ) {
 
 	material.fogVolume = false;
@@ -5087,7 +5136,7 @@ bool bvhIntersectFogVolumeHit(
 	${ iridescenceGLSL }
 
 	// diffuse
-	float diffuseEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, out vec3 color ) {
+	float diffuseEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, inout vec3 color ) {
 
 		// https://schuttejoe.github.io/post/disneybsdf/
 		float fl = schlickFresnel( wi.z, 0.0 );
@@ -5118,7 +5167,7 @@ bool bvhIntersectFogVolumeHit(
 	}
 
 	// specular
-	float specularEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, out vec3 color ) {
+	float specularEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, inout vec3 color ) {
 
 		// if roughness is set to 0 then D === NaN which results in black pixels
 		float metalness = surf.metalness;
@@ -5165,7 +5214,7 @@ bool bvhIntersectFogVolumeHit(
 
 	// transmission
 	/*
-	float transmissionEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, out vec3 color ) {
+	float transmissionEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, inout vec3 color ) {
 
 		// See section 4.2 in https://www.cs.cornell.edu/~srm/publications/EGSR07-btdf.pdf
 
@@ -5208,7 +5257,7 @@ bool bvhIntersectFogVolumeHit(
 
 	// TODO: This is just using a basic cosine-weighted specular distribution with an
 	// incorrect PDF value at the moment. Update it to correctly use a GGX distribution
-	float transmissionEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, out vec3 color ) {
+	float transmissionEval( vec3 wo, vec3 wi, vec3 wh, SurfaceRecord surf, inout vec3 color ) {
 
 		color = surf.transmission * surf.color;
 
@@ -5299,7 +5348,7 @@ bool bvhIntersectFogVolumeHit(
 	// bsdf
 	void getLobeWeights(
 		vec3 wo, vec3 wi, vec3 wh, vec3 clearcoatWo, SurfaceRecord surf,
-		out float diffuseWeight, out float specularWeight, out float transmissionWeight, out float clearcoatWeight
+		inout float diffuseWeight, inout float specularWeight, inout float transmissionWeight, inout float clearcoatWeight
 	) {
 
 		float metalness = surf.metalness;
@@ -5323,7 +5372,7 @@ bool bvhIntersectFogVolumeHit(
 
 	float bsdfEval(
 		vec3 wo, vec3 clearcoatWo, vec3 wi, vec3 clearcoatWi, SurfaceRecord surf,
-		float diffuseWeight, float specularWeight, float transmissionWeight, float clearcoatWeight, out float specularPdf, out vec3 color
+		float diffuseWeight, float specularWeight, float transmissionWeight, float clearcoatWeight, inout float specularPdf, inout vec3 color
 	) {
 
 		float metalness = surf.metalness;
@@ -5386,7 +5435,7 @@ bool bvhIntersectFogVolumeHit(
 
 	}
 
-	float bsdfResult( vec3 worldWo, vec3 worldWi, SurfaceRecord surf, out vec3 color ) {
+	float bsdfResult( vec3 worldWo, vec3 worldWi, SurfaceRecord surf, inout vec3 color ) {
 
 		if ( surf.volumeParticle ) {
 
@@ -5554,14 +5603,14 @@ bool bvhIntersectFogVolumeHit(
 	}
 
 	// samples the color given env map with CDF and returns the pdf of the direction
-	float sampleEquirect( EquirectHdrInfo info, vec3 direction, out vec3 color ) {
+	float sampleEquirect( vec3 direction, inout vec3 color ) {
 
 		vec2 uv = equirectDirectionToUv( direction );
-		color = texture2D( info.map, uv ).rgb;
+		color = texture2D( envMapInfo.map, uv ).rgb;
 
-		float totalSum = info.totalSum;
+		float totalSum = envMapInfo.totalSum;
 		float lum = luminance( color );
-		ivec2 resolution = textureSize( info.map, 0 );
+		ivec2 resolution = textureSize( envMapInfo.map, 0 );
 		float pdf = lum / totalSum;
 
 		return float( resolution.x * resolution.y ) * pdf * equirectDirectionPdf( direction );
@@ -5569,20 +5618,20 @@ bool bvhIntersectFogVolumeHit(
 	}
 
 	// samples a direction of the envmap with color and retrieves pdf
-	float sampleEquirectProbability( EquirectHdrInfo info, vec2 r, out vec3 color, out vec3 direction ) {
+	float sampleEquirectProbability( vec2 r, inout vec3 color, inout vec3 direction ) {
 
 		// sample env map cdf
-		float v = texture2D( info.marginalWeights, vec2( r.x, 0.0 ) ).x;
-		float u = texture2D( info.conditionalWeights, vec2( r.y, v ) ).x;
+		float v = texture2D( envMapInfo.marginalWeights, vec2( r.x, 0.0 ) ).x;
+		float u = texture2D( envMapInfo.conditionalWeights, vec2( r.y, v ) ).x;
 		vec2 uv = vec2( u, v );
 
 		vec3 derivedDirection = equirectUvToDirection( uv );
 		direction = derivedDirection;
-		color = texture2D( info.map, uv ).rgb;
+		color = texture2D( envMapInfo.map, uv ).rgb;
 
-		float totalSum = info.totalSum;
+		float totalSum = envMapInfo.totalSum;
 		float lum = luminance( color );
-		ivec2 resolution = textureSize( info.map, 0 );
+		ivec2 resolution = textureSize( envMapInfo.map, 0 );
 		float pdf = lum / totalSum;
 
 		return float( resolution.x * resolution.y ) * pdf * equirectDirectionPdf( direction );
@@ -5635,24 +5684,17 @@ bool bvhIntersectFogVolumeHit(
 
 	};
 
-	bool lightsClosestHit( sampler2D lights, uint lightCount, vec3 rayOrigin, vec3 rayDirection, out LightRecord lightRec ) {
+	bool intersectLightAtIndex( sampler2D lights, vec3 rayOrigin, vec3 rayDirection, uint l, inout LightRecord lightRec ) {
 
 		bool didHit = false;
-		uint l;
-		for ( l = 0u; l < lightCount; l ++ ) {
-
-			Light light = readLightInfo( lights, l );
-
-			vec3 u = light.u;
-			vec3 v = light.v;
-
-			// check for backface
-			vec3 normal = normalize( cross( u, v ) );
-			if ( dot( normal, rayDirection ) < 0.0 ) {
+		Light light = readLightInfo( lights, l );
 
-				continue;
+		vec3 u = light.u;
+		vec3 v = light.v;
 
-			}
+		// check for backface
+		vec3 normal = normalize( cross( u, v ) );
+		if ( dot( normal, rayDirection ) > 0.0 ) {
 
 			u *= 1.0 / dot( u, u );
 			v *= 1.0 / dot( v, v );
@@ -5665,17 +5707,13 @@ bool bvhIntersectFogVolumeHit(
 				( light.type == CIRC_AREA_LIGHT_TYPE && intersectsCircle( light.position, normal, u, v, rayOrigin, rayDirection, dist ) )
 			) {
 
-				if ( ! didHit || dist < lightRec.dist ) {
-
-					float cosTheta = dot( rayDirection, normal );
-					didHit = true;
-					lightRec.dist = dist;
-					lightRec.pdf = ( dist * dist ) / ( light.area * cosTheta );
-					lightRec.emission = light.color * light.intensity;
-					lightRec.direction = rayDirection;
-					lightRec.type = light.type;
-
-				}
+				float cosTheta = dot( rayDirection, normal );
+				didHit = true;
+				lightRec.dist = dist;
+				lightRec.pdf = ( dist * dist ) / ( light.area * cosTheta );
+				lightRec.emission = light.color * light.intensity;
+				lightRec.direction = rayDirection;
+				lightRec.type = light.type;
 
 			}
 
@@ -5687,11 +5725,6 @@ bool bvhIntersectFogVolumeHit(
 
 	LightRecord randomAreaLightSample( Light light, vec3 rayOrigin, vec2 ruv ) {
 
-		LightRecord lightRec;
-		lightRec.type = light.type;
-
-		lightRec.emission = light.color * light.intensity;
-
 		vec3 randomPos;
 		if( light.type == RECT_AREA_LIGHT_TYPE ) {
 
@@ -5712,12 +5745,17 @@ bool bvhIntersectFogVolumeHit(
 
 		vec3 toLight = randomPos - rayOrigin;
 		float lightDistSq = dot( toLight, toLight );
-		lightRec.dist = sqrt( lightDistSq );
+		float dist = sqrt( lightDistSq );
+		vec3 direction = toLight / dist;
+		vec3 lightNormal = normalize( cross( light.u, light.v ) );
 
-		vec3 direction = toLight / lightRec.dist;
+		LightRecord lightRec;
+		lightRec.type = light.type;
+		lightRec.emission = light.color * light.intensity;
+		lightRec.dist = dist;
 		lightRec.direction = direction;
 
-		vec3 lightNormal = normalize( cross( light.u, light.v ) );
+		// TODO: the denominator is potentially zero
 		lightRec.pdf = lightDistSq / ( light.area * dot( direction, lightNormal ) );
 
 		return lightRec;
@@ -5765,13 +5803,15 @@ bool bvhIntersectFogVolumeHit(
 
 	LightRecord randomLightSample( sampler2D lights, sampler2DArray iesProfiles, uint lightCount, vec3 rayOrigin, vec3 ruv ) {
 
+		LightRecord result;
+
 		// pick a random light
 		uint l = uint( ruv.x * float( lightCount ) );
 		Light light = readLightInfo( lights, l );
 
 		if ( light.type == SPOT_LIGHT_TYPE ) {
 
-			return randomSpotLightSample( light, iesProfiles, rayOrigin, ruv.yz );
+			result = randomSpotLightSample( light, iesProfiles, rayOrigin, ruv.yz );
 
 		} else if ( light.type == POINT_LIGHT_TYPE ) {
 
@@ -5791,7 +5831,7 @@ bool bvhIntersectFogVolumeHit(
 			rec.pdf = 1.0;
 			rec.emission = light.color * light.intensity * distanceFalloff;
 			rec.type = light.type;
-			return rec;
+			result = rec;
 
 		} else if ( light.type == DIR_LIGHT_TYPE ) {
 
@@ -5802,15 +5842,17 @@ bool bvhIntersectFogVolumeHit(
 			rec.emission = light.color * light.intensity;
 			rec.type = light.type;
 
-			return rec;
+			result = rec;
 
 		} else {
 
 			// sample the light
-			return randomAreaLightSample( light, rayOrigin, ruv.yz );
+			result = randomAreaLightSample( light, rayOrigin, ruv.yz );
 
 		}
 
+		return result;
+
 	}
 
 `;
@@ -5907,7 +5949,7 @@ bool bvhIntersectFogVolumeHit(
 	// Finds the point where the ray intersects the plane defined by u and v and checks if this point
 	// falls in the bounds of the rectangle on that same plane.
 	// Plane intersection: https://lousodrome.net/blog/light/2020/07/03/intersection-of-a-ray-and-a-plane/
-	bool intersectsRectangle( vec3 center, vec3 normal, vec3 u, vec3 v, vec3 rayOrigin, vec3 rayDirection, out float dist ) {
+	bool intersectsRectangle( vec3 center, vec3 normal, vec3 u, vec3 v, vec3 rayOrigin, vec3 rayDirection, inout float dist ) {
 
 		float t = dot( center - rayOrigin, normal ) / dot( rayDirection, normal );
 
@@ -5938,7 +5980,7 @@ bool bvhIntersectFogVolumeHit(
 
 	// Finds the point where the ray intersects the plane defined by u and v and checks if this point
 	// falls in the bounds of the circle on that same plane. See above URL for a description of the plane intersection algorithm.
-	bool intersectsCircle( vec3 position, vec3 normal, vec3 u, vec3 v, vec3 rayOrigin, vec3 rayDirection, out float dist ) {
+	bool intersectsCircle( vec3 position, vec3 normal, vec3 u, vec3 v, vec3 rayOrigin, vec3 rayDirection, inout float dist ) {
 
 		float t = dot( position - rayOrigin, normal ) / dot( rayDirection, normal );
 
@@ -6370,7 +6412,7 @@ bool bvhIntersectFogVolumeHit(
 	// step through multiple surface hits and accumulate color attenuation based on transmissive surfaces
 	// returns true if a solid surface was hit
 	bool attenuateHit(
-		BVH bvh, RenderState state,
+		RenderState state,
 		Ray ray, float rayDist,
 		out vec3 color
 	) {
@@ -6384,7 +6426,6 @@ bool bvhIntersectFogVolumeHit(
 
 		// hit results
 		SurfaceHit surfaceHit;
-		LightRecord lightRec;
 
 		color = vec3( 1.0 );
 
@@ -6392,20 +6433,12 @@ bool bvhIntersectFogVolumeHit(
 		// and then reset.
 		for ( int i = 0; i < traversals; i ++ ) {
 
-			int hitType = traceScene(
-				ray, bvh, lights, fogMaterial,
-				surfaceHit, lightRec
-			);
+			int hitType = traceScene( ray, fogMaterial, surfaceHit );
 
 			if ( hitType == FOG_HIT ) {
 
 				return true;
 
-			} else if ( hitType == LIGHT_HIT ) {
-
-				float totalDist = distance( startPoint, ray.origin + ray.direction * lightRec.dist );
-				return totalDist < rayDist - max( totalDist, rayDist ) * 1e-4;
-
 			} else if ( hitType == SURFACE_HIT ) {
 
 				float totalDist = distance( startPoint, ray.origin + ray.direction * surfaceHit.dist );
@@ -6550,22 +6583,26 @@ bool bvhIntersectFogVolumeHit(
 	#define LIGHT_HIT 2
 	#define FOG_HIT 3
 
+	// Passing the global variable 'lights' into this function caused shader program errors.
+	// So global variables like 'lights' and 'bvh' were moved out of the function parameters.
+	// For more information, refer to: https://github.com/gkjohnson/three-gpu-pathtracer/pull/457
 	int traceScene(
 
-		Ray ray, BVH bvh, LightsInfo lights, Material fogMaterial,
-		out SurfaceHit surfaceHit, out LightRecord lightRec
+		Ray ray, Material fogMaterial, inout SurfaceHit surfaceHit
 
 	) {
 
+		int result = NO_HIT;
 		bool hit = bvhIntersectFirstHit( bvh, ray.origin, ray.direction, surfaceHit.faceIndices, surfaceHit.faceNormal, surfaceHit.barycoord, surfaceHit.side, surfaceHit.dist );
-		bool lightHit = lightsClosestHit( lights.tex, lights.count, ray.origin, ray.direction, lightRec );
 
 		#if FEATURE_FOG
 
 		if ( fogMaterial.fogVolume ) {
 
+			// offset the distance so we don't run into issues with particles on the same surface
+			// as other objects
 			float particleDist = intersectFogVolume( fogMaterial, sobol( 1 ) );
-			if ( particleDist + 1e-4 < surfaceHit.dist && ( particleDist + 1e-4 < lightRec.dist || ! lightHit ) ) {
+			if ( particleDist + RAY_OFFSET < surfaceHit.dist ) {
 
 				surfaceHit.side = 1.0;
 				surfaceHit.faceNormal = normalize( - ray.direction );
@@ -6578,19 +6615,13 @@ bool bvhIntersectFogVolumeHit(
 
 		#endif
 
-		if ( lightHit && ( lightRec.dist < surfaceHit.dist || ! hit ) ) {
-
-			return LIGHT_HIT;
-
-		}
-
 		if ( hit ) {
 
-			return SURFACE_HIT;
+			result = SURFACE_HIT;
 
 		}
 
-		return NO_HIT;
+		return result;
 
 	}
 
@@ -6603,7 +6634,7 @@ bool bvhIntersectFogVolumeHit(
 	int getSurfaceRecord(
 		Material material, SurfaceHit surfaceHit, sampler2DArray attributesArray,
 		float accumulatedRoughness,
-		out SurfaceRecord surf
+		inout SurfaceRecord surf
 	) {
 
 		if ( material.fogVolume ) {
@@ -6923,6 +6954,8 @@ bool bvhIntersectFogVolumeHit(
 
 	vec3 directLightContribution( vec3 worldWo, SurfaceRecord surf, RenderState state, vec3 rayOrigin ) {
 
+		vec3 result = vec3( 0.0 );
+
 		// uniformly pick a light or environment map
 		if( lightsDenom != 0.0 && sobol( 5 ) < float( lights.count ) / lightsDenom ) {
 
@@ -6944,7 +6977,7 @@ bool bvhIntersectFogVolumeHit(
 			if (
 				lightRec.pdf > 0.0 &&
 				isDirectionValid( lightRec.direction, surf.normal, surf.faceNormal ) &&
-				! attenuateHit( bvh, state, lightRay, lightRec.dist, attenuatedColor )
+				! attenuateHit( state, lightRay, lightRec.dist, attenuatedColor )
 			) {
 
 				// get the material pdf
@@ -6956,7 +6989,7 @@ bool bvhIntersectFogVolumeHit(
 					// weight the direct light contribution
 					float lightPdf = lightRec.pdf / lightsDenom;
 					float misWeight = lightRec.type == SPOT_LIGHT_TYPE || lightRec.type == DIR_LIGHT_TYPE || lightRec.type == POINT_LIGHT_TYPE ? 1.0 : misHeuristic( lightPdf, lightMaterialPdf );
-					return attenuatedColor * lightRec.emission * state.throughputColor * sampleColor * misWeight / lightPdf;
+					result = attenuatedColor * lightRec.emission * state.throughputColor * sampleColor * misWeight / lightPdf;
 
 				}
 
@@ -6966,7 +6999,7 @@ bool bvhIntersectFogVolumeHit(
 
 			// find a sample in the environment map to include in the contribution
 			vec3 envColor, envDirection;
-			float envPdf = sampleEquirectProbability( envMapInfo, sobol2( 7 ), envColor, envDirection );
+			float envPdf = sampleEquirectProbability( sobol2( 7 ), envColor, envDirection );
 			envDirection = invEnvRotation3x3 * envDirection;
 
 			// this env sampling is not set up for transmissive sampling and yields overly bright
@@ -6987,7 +7020,7 @@ bool bvhIntersectFogVolumeHit(
 			if (
 				envPdf > 0.0 &&
 				isDirectionValid( envDirection, surf.normal, surf.faceNormal ) &&
-				! attenuateHit( bvh, state, envRay, INFINITY, attenuatedColor )
+				! attenuateHit( state, envRay, INFINITY, attenuatedColor )
 			) {
 
 				// get the material pdf
@@ -6999,7 +7032,7 @@ bool bvhIntersectFogVolumeHit(
 					// weight the direct light contribution
 					envPdf /= lightsDenom;
 					float misWeight = misHeuristic( envPdf, envMaterialPdf );
-					return attenuatedColor * environmentIntensity * envColor * state.throughputColor * sampleColor * misWeight / envPdf;
+					result = attenuatedColor * environmentIntensity * envColor * state.throughputColor * sampleColor * misWeight / envPdf;
 
 				}
 
@@ -7007,7 +7040,9 @@ bool bvhIntersectFogVolumeHit(
 
 		}
 
-		return vec3( 0.0 );
+		// Function changed to have a single return statement to potentially help with crashes on Mac OS.
+		// See issue #470
+		return result;
 
 	}
 
@@ -7036,6 +7071,7 @@ bool bvhIntersectFogVolumeHit(
 					FEATURE_DOF: 1,
 					FEATURE_BACKGROUND_MAP: 0,
 					FEATURE_FOG: 1,
+					FEATURE_SOBOL: 0,
 					// 0 = Perspective
 					// 1 = Orthographic
 					// 2 = Equirectangular
@@ -7105,13 +7141,36 @@ bool bvhIntersectFogVolumeHit(
 				#include <common>
 
 				// bvh intersection
-				${ threeMeshBvh.shaderStructs }
-				${ threeMeshBvh.shaderIntersectFunction }
+				${ threeMeshBvh.BVHShaderGLSL.common_functions }
+				${ threeMeshBvh.BVHShaderGLSL.bvh_struct_definitions }
+				${ threeMeshBvh.BVHShaderGLSL.bvh_ray_functions }
+
+				// uniform structs
+				${ cameraStructGLSL }
+				${ lightsStructGLSL }
+				${ equirectStructGLSL }
+				${ materialStructGLSL }
 
 				// random
 				${ pcgGLSL }
-				${ sobolCommonGLSL }
-				${ sobolSamplingGLSL }
+				#if FEATURE_SOBOL
+
+					${ sobolCommonGLSL }
+					${ sobolSamplingGLSL }
+
+				#else
+
+					// Using the sobol functions seems to break the the compiler on MacOS
+					// - specifically the "sobolReverseBits" function.
+					uint sobolPixelIndex = 0u;
+					uint sobolPathIndex = 0u;
+					uint sobolBounceIndex = 0u;
+					float sobol( int v ) { return rand(); }
+					vec2 sobol2( int v ) { return rand2(); }
+					vec3 sobol3( int v ) { return rand3(); }
+					vec4 sobol4( int v ) { return rand4(); }
+
+				#endif
 
 				// common
 				${ arraySamplerTexelFetchGLSL }
@@ -7120,20 +7179,6 @@ bool bvhIntersectFogVolumeHit(
 				${ mathGLSL }
 				${ intersectShapesGLSL }
 
-				// uniform structs
-				${ cameraStructGLSL }
-				${ lightsStructGLSL }
-				${ equirectStructGLSL }
-				${ materialStructGLSL }
-				${ fogMaterialBvhGLSL }
-
-				// sampling
-				${ shapeSamplingGLSL }
-				${ bsdfSamplingGLSL }
-				${ equirectSamplingGLSL }
-				${ lightSamplingGLSL }
-				${ fogGLSL }
-
 				// environment
 				uniform EquirectHdrInfo envMapInfo;
 				uniform mat4 environmentRotation;
@@ -7185,6 +7230,14 @@ bool bvhIntersectFogVolumeHit(
 				mat3 invEnvRotation3x3;
 				float lightsDenom;
 
+				// sampling
+				${ fogMaterialBvhGLSL }
+				${ shapeSamplingGLSL }
+				${ bsdfSamplingGLSL }
+				${ equirectSamplingGLSL }
+				${ lightSamplingGLSL }
+				${ fogGLSL }
+
 				float applyFilteredGlossy( float roughness, float accumulatedRoughness ) {
 
 					return clamp(
@@ -7224,7 +7277,7 @@ bool bvhIntersectFogVolumeHit(
 
 					// init
 					rng_initialize( gl_FragCoord.xy, seed );
-					sobolPixelIndex = ( uint( gl_FragCoord.x ) << 16 ) |  uint( gl_FragCoord.y );
+					sobolPixelIndex = ( uint( gl_FragCoord.x ) << 16 ) | uint( gl_FragCoord.y );
 					sobolPathIndex = uint( seed );
 
 					// get camera ray
@@ -7240,7 +7293,6 @@ bool bvhIntersectFogVolumeHit(
 
 					// surface results
 					SurfaceHit surfaceHit;
-					LightRecord lightRec;
 					ScatterRecord scatterRec;
 
 					// path tracing state
@@ -7249,7 +7301,7 @@ bool bvhIntersectFogVolumeHit(
 					#if FEATURE_FOG
 
 					state.fogMaterial.fogVolume = bvhIntersectFogVolumeHit(
-						bvh, ray.origin, - ray.direction,
+						ray.origin, - ray.direction,
 						materialIndexAttribute, materials,
 						state.fogMaterial
 					);
@@ -7264,44 +7316,42 @@ bool bvhIntersectFogVolumeHit(
 						state.traversals = bounces - i;
 						state.firstRay = i == 0 && state.transmissiveTraversals == transmissiveBounces;
 
-						int hitType = traceScene(
-							ray, bvh, lights, state.fogMaterial,
-							surfaceHit, lightRec
-						);
+						int hitType = traceScene( ray, state.fogMaterial, surfaceHit );
 
-						if ( hitType == LIGHT_HIT ) {
+						// check if we intersect any lights and accumulate the light contribution
+						// TODO: we can add support for light surface rendering in the else condition if we
+						// add the ability to toggle visibility of the the light
+						if ( ! state.firstRay && ! state.transmissiveRay ) {
 
-							if ( state.firstRay || state.transmissiveRay ) {
+							LightRecord lightRec;
+							float lightDist = hitType == NO_HIT ? INFINITY : surfaceHit.dist;
+							for ( uint i = 0u; i < lights.count; i ++ ) {
 
-								gl_FragColor.rgb += lightRec.emission * state.throughputColor;
+								if (
+									intersectLightAtIndex( lights.tex, ray.origin, ray.direction, i, lightRec ) &&
+									lightRec.dist < lightDist
+								) {
 
-							} else {
-
-								#if FEATURE_MIS
-
-								// NOTE: we skip MIS for punctual lights since they are not supported in forward PT case
-								if ( lightRec.type == SPOT_LIGHT_TYPE || lightRec.type == DIR_LIGHT_TYPE || lightRec.type == POINT_LIGHT_TYPE ) {
-
-									gl_FragColor.rgb += lightRec.emission * state.throughputColor;
-
-								} else {
+									#if FEATURE_MIS
 
 									// weight the contribution
+									// NOTE: Only area lights are supported for forward sampling and can be hit
 									float misWeight = misHeuristic( scatterRec.pdf, lightRec.pdf / lightsDenom );
 									gl_FragColor.rgb += lightRec.emission * state.throughputColor * misWeight;
 
-								}
+									#else
 
-								#else
+									gl_FragColor.rgb += lightRec.emission * state.throughputColor;
 
-								gl_FragColor.rgb += lightRec.emission * state.throughputColor;
+									#endif
 
-								#endif
+								}
 
 							}
-							break;
 
-						} else if ( hitType == NO_HIT ) {
+						}
+
+						if ( hitType == NO_HIT ) {
 
 							if ( state.firstRay || state.transmissiveRay ) {
 
@@ -7314,7 +7364,7 @@ bool bvhIntersectFogVolumeHit(
 
 								// get the PDF of the hit envmap point
 								vec3 envColor;
-								float envPdf = sampleEquirect( envMapInfo, envRotation3x3 * ray.direction, envColor );
+								float envPdf = sampleEquirect( envRotation3x3 * ray.direction, envColor );
 								envPdf /= lightsDenom;
 
 								// and weight the contribution