threadwire 0.1.22 → 0.1.23

package/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+- Complete every short filesystem write while spooling oversized worker JSONL
+  records, preventing truncated or corrupted worker output. Reject stalled,
+  invalid, or impossible write counts and clean up the private spool artifact
+  instead of silently accepting partial data.
+
 - Fix Node 24 release-prepublish timeouts in `run-worker` process-tree cleanup.
   The dedicated `npm-release` service now runs with Docker's `init: true` so
   terminated descendants are reaped instead of becoming zombies that keep the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadwire",
-  "version": "0.1.22",
+  "version": "0.1.23",
   "description": "Stream Codex, Claude, Kimi Code, and OpenCode worker progress to an explicit Telegram destination",
   "keywords": [
     "ai-agent",

package/src/jsonl-record-spool.js

@@ -4,6 +4,14 @@ import {closeSync, mkdtempSync, openSync, readFileSync, rmSync, unlinkSync, writ
 import {tmpdir} from "node:os"
 import {isAbsolute, join, normalize} from "node:path"
 
+const filesystemOperations = {writeSync}
+
+/**
+ * @typedef {object} FilesystemOperations
+ * @property {(fileDescriptor: number, buffer: Buffer, offset: number, length: number) => number} writeSync
+ *   Write bytes to a file descriptor and return the count written.
+ */
+
 /**
  * Single-owner byte-oriented spool for one worker's pending JSONL record.
  *
@@ -21,13 +29,14 @@ import {isAbsolute, join, normalize} from "node:path"
  * owner calls it on every settlement path.
  */
 export class JsonlRecordSpool {
-  /** @param {{memoryBytes: number, maxBytes: number, directory?: string}} options */
+  /** @param {{memoryBytes: number, maxBytes: number, directory?: string, filesystem?: FilesystemOperations}} options */
   constructor(options) {
     this.memoryBytes = positiveSafeInteger(options.memoryBytes, "memoryBytes")
     this.maxBytes = positiveSafeInteger(options.maxBytes, "maxBytes")
     const directory = options.directory ?? tmpdir()
     if (!isAbsolute(directory) || normalize(directory) !== directory) throw new Error("directory must be a normalized absolute path")
     this.directory = directory
+    this.filesystem = options.filesystem ?? filesystemOperations
     /** @type {Buffer[]} */
     this.segments = []
     this.pendingBytes = 0
@@ -120,7 +129,7 @@ export class JsonlRecordSpool {
     if (this.file === null) this.append(finalSegment)
     else {
       this.pendingBytes = recordBytes
-      writeSync(this.file.fd, finalSegment)
+      this.writeAll(this.file.fd, finalSegment)
     }
     const file = this.file
     if (file === null) throw new Error("JSONL record spool file is unavailable")
@@ -137,7 +146,7 @@ export class JsonlRecordSpool {
     this.pendingBytes += segment.length
     if (this.pendingBytes > this.maxBytes) throw new StdoutRecordTooLargeError()
     if (this.file !== null) {
-      writeSync(this.file.fd, segment)
+      this.writeAll(this.file.fd, segment)
       return
     }
     if (this.pendingBytes <= this.memoryBytes) {
@@ -150,9 +159,26 @@ export class JsonlRecordSpool {
     const path = join(this.ownedDirectory, "pending-record")
     const fd = openSync(path, "wx", 0o600)
     this.file = {fd, path}
-    for (const buffered of this.segments) writeSync(fd, buffered)
+    for (const buffered of this.segments) this.writeAll(fd, buffered)
     this.segments = []
-    writeSync(fd, segment)
+    this.writeAll(fd, segment)
+  }
+
+  /**
+   * Write a complete Buffer to one file descriptor, looping over short writes.
+   * @param {number} fd
+   * @param {Buffer} buffer
+   */
+  writeAll(fd, buffer) {
+    let offset = 0
+    while (offset < buffer.length) {
+      const written = this.filesystem.writeSync(fd, buffer, offset, buffer.length - offset)
+      if (written === 0) throw new Error("Spool write made zero bytes of progress")
+      if (!Number.isSafeInteger(written) || written < 0 || written > buffer.length - offset) {
+        throw new Error(`Spool write returned invalid byte count: ${written}`)
+      }
+      offset += written
+    }
   }
 
   /** Remove the current record's private spill directory, if one exists. */