threadlines 0.2.9 → 0.2.11

package/dist/git/github.js

@@ -12,47 +12,14 @@
  * - commitAuthor: { name: string; email: string }
  * - prTitle?: string
  */
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || (function () {
-    var ownKeys = function(o) {
-        ownKeys = Object.getOwnPropertyNames || function (o) {
-            var ar = [];
-            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
-            return ar;
-        };
-        return ownKeys(o);
-    };
-    return function (mod) {
-        if (mod && mod.__esModule) return mod;
-        var result = {};
-        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
-        __setModuleDefault(result, mod);
-        return result;
-    };
-})();
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getGitHubContext = getGitHubContext;
 const simple_git_1 = __importDefault(require("simple-git"));
-const fs = __importStar(require("fs"));
 const diff_1 = require("./diff");
+const logger_1 = require("../utils/logger");
 /**
  * Gets all GitHub context
  */
@@ -69,8 +36,13 @@ async function getGitHubContext(repoRoot) {
     const branchName = await getBranchName();
     const context = detectContext();
     const commitSha = getCommitSha(context);
-    // Note: commitSha parameter not needed - GitHub reads from GITHUB_EVENT_PATH JSON
-    const commitAuthor = await getCommitAuthor();
+    // Validate commit SHA is available (should always be set in GitHub Actions)
+    if (!commitSha) {
+        throw new Error('GitHub Actions: GITHUB_SHA environment variable is not set. ' +
+            'This should be automatically provided by GitHub Actions.');
+    }
+    // Get commit author using git commands (same approach as Bitbucket/Local)
+    const commitAuthor = await (0, diff_1.getCommitAuthor)(repoRoot, commitSha);
     // Get commit message if we have a SHA
     let commitMessage;
     if (commitSha) {
@@ -81,6 +53,11 @@ async function getGitHubContext(repoRoot) {
     }
     // Get PR title if in PR context
     const prTitle = getPRTitle(context);
+    // Validate commit author was found
+    if (!commitAuthor) {
+        throw new Error(`GitHub Actions: Failed to get commit author from git log for commit ${commitSha || 'HEAD'}. ` +
+            'This should be automatically available in the git repository.');
+    }
     return {
         diff,
         repoName,
@@ -96,29 +73,37 @@ async function getGitHubContext(repoRoot) {
  * Gets diff for GitHub Actions CI environment
  *
  * Strategy:
- * - PR context: Compare source branch vs target branch (full PR diff)
+ * - PR context: Fetch base branch on-demand, compare base vs HEAD (full PR diff)
  * - Any push (main or feature branch): Compare last commit only (HEAD~1...HEAD)
  *
- * Note: Unlike GitLab/Bitbucket, we don't need to fetch branches on-demand here.
- * GitHub Actions' `actions/checkout` automatically fetches both base and head refs
- * for pull_request events, even with the default shallow clone (fetch-depth: 1).
- * The refs `origin/${GITHUB_BASE_REF}` and `origin/${GITHUB_HEAD_REF}` are available
- * immediately after checkout.
+ * Note: GitHub Actions does shallow clones by default (fetch-depth: 1), so we fetch
+ * the base branch on-demand. HEAD points to the merge commit which contains all PR changes.
  */
 async function getDiff(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);
     const eventName = process.env.GITHUB_EVENT_NAME;
     const baseRef = process.env.GITHUB_BASE_REF;
-    const headRef = process.env.GITHUB_HEAD_REF;
-    // PR Context: Compare source vs target branch
-    // No fetch needed - GitHub Actions provides both refs automatically
+    // PR Context: Only pull_request events have GITHUB_BASE_REF set
     if (eventName === 'pull_request') {
-        if (!baseRef || !headRef) {
-            throw new Error('GitHub PR context detected but GITHUB_BASE_REF or GITHUB_HEAD_REF is missing. ' +
+        if (!baseRef) {
+            throw new Error('GitHub PR context detected but GITHUB_BASE_REF is missing. ' +
                 'This should be automatically provided by GitHub Actions.');
         }
-        const diff = await git.diff([`origin/${baseRef}...origin/${headRef}`, '-U200']);
-        const diffSummary = await git.diffSummary([`origin/${baseRef}...origin/${headRef}`]);
+        // Fetch base branch on-demand (works with shallow clones)
+        logger_1.logger.debug(`Fetching base branch: origin/${baseRef}`);
+        try {
+            await git.fetch(['origin', `${baseRef}:refs/remotes/origin/${baseRef}`, '--depth=1']);
+        }
+        catch (fetchError) {
+            throw new Error(`Failed to fetch base branch origin/${baseRef}. ` +
+                `This is required for PR diff comparison. Error: ${fetchError instanceof Error ? fetchError.message : 'Unknown error'}`);
+        }
+        logger_1.logger.debug(`PR context, using origin/${baseRef}..HEAD (two dots for direct comparison)`);
+        // Use two dots (..) instead of three dots (...) for direct comparison
+        // Three dots requires finding merge base which can fail with shallow clones
+        // Two dots shows all changes in HEAD that aren't in origin/${baseRef}
+        const diff = await git.diff([`origin/${baseRef}..HEAD`, '-U200']);
+        const diffSummary = await git.diffSummary([`origin/${baseRef}..HEAD`]);
         const changedFiles = diffSummary.files.map(f => f.file);
         return {
             diff: diff || '',
@@ -126,13 +111,15 @@ async function getDiff(repoRoot) {
         };
     }
     // Any push (main or feature branch): Review last commit only
-    const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
-    const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
-    const changedFiles = diffSummary.files.map(f => f.file);
-    return {
-        diff: diff || '',
-        changedFiles
-    };
+    // Use git show HEAD - works with shallow clones and shows the commit diff
+    const diff = await git.show(['HEAD', '--format=', '--no-color', '-U200']);
+    // Extract changed files from git show
+    const showNameOnly = await git.show(['HEAD', '--name-only', '--format=', '--pretty=format:']);
+    const changedFiles = showNameOnly
+        .split('\n')
+        .filter(line => line.trim().length > 0)
+        .map(line => line.trim());
+    return { diff: diff || '', changedFiles };
 }
 /**
  * Gets repository name for GitHub Actions
@@ -201,59 +188,6 @@ function getCommitSha(context) {
     }
     return undefined;
 }
-/**
- * Gets commit author for GitHub Actions
- * Reads from GITHUB_EVENT_PATH JSON file (most reliable)
- * Note: commitSha parameter not used - GitHub provides author info in event JSON
- */
-async function getCommitAuthor() {
-    const eventPath = process.env.GITHUB_EVENT_PATH;
-    if (!eventPath) {
-        throw new Error('GitHub Actions: GITHUB_EVENT_PATH environment variable is not set. ' +
-            'This should be automatically provided by GitHub Actions.');
-    }
-    if (!fs.existsSync(eventPath)) {
-        throw new Error(`GitHub Actions: GITHUB_EVENT_PATH file does not exist: ${eventPath}. ` +
-            'This should be automatically provided by GitHub Actions.');
-    }
-    try {
-        const eventData = JSON.parse(fs.readFileSync(eventPath, 'utf-8'));
-        // For push events, use head_commit.author
-        if (eventData.head_commit?.author) {
-            return {
-                name: eventData.head_commit.author.name,
-                email: eventData.head_commit.author.email
-            };
-        }
-        // For PR events, use commits[0].author (first commit in the PR)
-        if (eventData.commits && eventData.commits.length > 0 && eventData.commits[0].author) {
-            return {
-                name: eventData.commits[0].author.name,
-                email: eventData.commits[0].author.email
-            };
-        }
-        // Fallback to pull_request.head.commit.author for PR events
-        if (eventData.pull_request?.head?.commit?.author) {
-            return {
-                name: eventData.pull_request.head.commit.author.name,
-                email: eventData.pull_request.head.commit.author.email
-            };
-        }
-        // If we get here, the event JSON doesn't contain author info
-        throw new Error(`GitHub Actions: GITHUB_EVENT_PATH JSON does not contain commit author information. ` +
-            `Event type: ${eventData.action || 'unknown'}. ` +
-            `This should be automatically provided by GitHub Actions.`);
-    }
-    catch (error) {
-        // If JSON parsing fails, fail loudly
-        if (error instanceof Error && error.message.includes('GitHub Actions:')) {
-            throw error; // Re-throw our own errors
-        }
-        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-        throw new Error(`GitHub Actions: Failed to read or parse GITHUB_EVENT_PATH JSON: ${errorMessage}. ` +
-            'This should be automatically provided by GitHub Actions.');
-    }
-}
 /**
  * Gets PR title for GitHub Actions
  * Note: GitHub Actions doesn't provide PR title as an env var by default.

package/package.json

@@ -1,9 +1,10 @@
 {
   "name": "threadlines",
-  "version": "0.2.9",
+  "version": "0.2.11",
   "description": "Threadlines CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {
+    "threadlines": "./bin/threadline",
     "threadline": "./bin/threadline"
   },
   "files": [