threadlines 0.2.4 → 0.2.7

package/dist/git/github.js

@@ -1,6 +1,6 @@
 "use strict";
 /**
- * GitHub Actions Environment - Complete Isolation
+ * GitHub Actions Environment
  *
  * All GitHub-specific logic is contained in this file.
  * No dependencies on other environment implementations.
@@ -52,10 +52,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getGitHubContext = getGitHubContext;
 const simple_git_1 = __importDefault(require("simple-git"));
 const fs = __importStar(require("fs"));
-const repo_1 = require("./repo");
 const diff_1 = require("./diff");
 /**
- * Gets all GitHub context in one call - completely isolated from other environments.
+ * Gets all GitHub context
  */
 async function getGitHubContext(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);
@@ -70,7 +69,6 @@ async function getGitHubContext(repoRoot) {
     const branchName = await getBranchName();
     const context = detectContext();
     const commitSha = getCommitSha(context);
-    // Get commit author (fails loudly if unavailable)
     // Note: commitSha parameter not needed - GitHub reads from GITHUB_EVENT_PATH JSON
     const commitAuthor = await getCommitAuthor();
     // Get commit message if we have a SHA
@@ -96,17 +94,17 @@ async function getGitHubContext(repoRoot) {
 }
 /**
  * Gets diff for GitHub Actions CI environment
+ *
+ * Strategy:
+ * - PR context: Compare source branch vs target branch (full PR diff)
+ * - Any push (main or feature branch): Compare last commit only (HEAD~1...HEAD)
  */
 async function getDiff(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);
-    const defaultBranch = await (0, repo_1.getDefaultBranchName)(repoRoot);
-    // Determine context from GitHub environment variables
     const eventName = process.env.GITHUB_EVENT_NAME;
     const baseRef = process.env.GITHUB_BASE_REF;
     const headRef = process.env.GITHUB_HEAD_REF;
-    const refName = process.env.GITHUB_REF_NAME;
-    const commitSha = process.env.GITHUB_SHA;
-    // Scenario 1: PR Context
+    // PR Context: Compare source vs target branch
     if (eventName === 'pull_request') {
         if (!baseRef || !headRef) {
             throw new Error('GitHub PR context detected but GITHUB_BASE_REF or GITHUB_HEAD_REF is missing. ' +
@@ -120,36 +118,14 @@ async function getDiff(repoRoot) {
             changedFiles
         };
     }
-    // Scenario 2 & 4: Default Branch Push
-    if (refName === defaultBranch && commitSha) {
-        try {
-            const diff = await git.diff([`origin/${defaultBranch}~1...origin/${defaultBranch}`, '-U200']);
-            const diffSummary = await git.diffSummary([`origin/${defaultBranch}~1...origin/${defaultBranch}`]);
-            const changedFiles = diffSummary.files.map(f => f.file);
-            return {
-                diff: diff || '',
-                changedFiles
-            };
-        }
-        catch (error) {
-            const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-            throw new Error(`Could not get diff for default branch '${defaultBranch}'. ` +
-                `This might be the first commit on the branch. Error: ${errorMessage}`);
-        }
-    }
-    // Scenario 3: Feature Branch Push
-    if (refName) {
-        const diff = await git.diff([`origin/${defaultBranch}...origin/${refName}`, '-U200']);
-        const diffSummary = await git.diffSummary([`origin/${defaultBranch}...origin/${refName}`]);
-        const changedFiles = diffSummary.files.map(f => f.file);
-        return {
-            diff: diff || '',
-            changedFiles
-        };
-    }
-    throw new Error('GitHub Actions environment detected but no valid context found. ' +
-        'Expected GITHUB_EVENT_NAME="pull_request" (with GITHUB_BASE_REF/GITHUB_HEAD_REF) ' +
-        'or GITHUB_REF_NAME for branch context.');
+    // Any push (main or feature branch): Review last commit only
+    const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
+    const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
+    const changedFiles = diffSummary.files.map(f => f.file);
+    return {
+        diff: diff || '',
+        changedFiles
+    };
 }
 /**
  * Gets repository name for GitHub Actions
@@ -175,10 +151,13 @@ async function getBranchName() {
     return refName;
 }
 /**
- * Detects GitHub context (PR, branch, or commit)
+ * Detects GitHub context (PR or commit)
+ *
+ * - PR context: When GITHUB_EVENT_NAME is 'pull_request'
+ * - Commit context: Any push (main or feature branch) - reviews single commit
  */
 function detectContext() {
-    // 1. Check for PR context
+    // PR context
     if (process.env.GITHUB_EVENT_NAME === 'pull_request') {
         const targetBranch = process.env.GITHUB_BASE_REF;
         const sourceBranch = process.env.GITHUB_HEAD_REF;
@@ -192,22 +171,16 @@ function detectContext() {
             };
         }
     }
-    // 2. Check for branch context
-    if (process.env.GITHUB_REF_NAME) {
-        return {
-            type: 'branch',
-            branchName: process.env.GITHUB_REF_NAME
-        };
-    }
-    // 3. Check for commit context
+    // Any push (main or feature branch) → commit context
     if (process.env.GITHUB_SHA) {
         return {
             type: 'commit',
             commitSha: process.env.GITHUB_SHA
         };
     }
-    // 4. Fallback to local (shouldn't happen in GitHub Actions, but TypeScript needs it)
-    return { type: 'local' };
+    throw new Error('GitHub Actions: Could not detect context. ' +
+        'Expected GITHUB_EVENT_NAME="pull_request" or GITHUB_SHA to be set. ' +
+        'This should be automatically provided by GitHub Actions.');
 }
 /**
  * Gets commit SHA from context
@@ -216,7 +189,7 @@ function getCommitSha(context) {
     if (context.type === 'commit') {
         return context.commitSha;
     }
-    if (context.type === 'branch' || context.type === 'pr') {
+    if (context.type === 'pr') {
         return process.env.GITHUB_SHA;
     }
     return undefined;

package/dist/git/gitlab.js

@@ -1,6 +1,6 @@
 "use strict";
 /**
- * GitLab CI Environment - Complete Isolation
+ * GitLab CI Environment
  *
  * All GitLab-specific logic is contained in this file.
  * No dependencies on other environment implementations.
@@ -20,7 +20,7 @@ exports.getGitLabContext = getGitLabContext;
 const simple_git_1 = __importDefault(require("simple-git"));
 const diff_1 = require("./diff");
 /**
- * Gets all GitLab context in one call - completely isolated from other environments.
+ * Gets all GitLab context
  */
 async function getGitLabContext(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);
@@ -61,29 +61,19 @@ async function getGitLabContext(repoRoot) {
 /**
  * Get diff for GitLab CI environment
  *
- * GitLab CI does a shallow clone of ONLY the current branch. The default branch
- * (e.g., origin/main) is NOT available by default. We fetch it on-demand.
+ * Strategy:
+ * - MR context: Fetch target branch, compare source vs target (full MR diff)
+ * - Any push (main or feature branch): Compare last commit only (HEAD~1...HEAD)
  *
- * Scenarios handled:
- *
- * 1. MR Context (CI_MERGE_REQUEST_IID is set):
- *    - Fetch target branch, then diff target vs source
- *
- * 2. Feature Branch Push (CI_COMMIT_REF_NAME != CI_DEFAULT_BRANCH):
- *    - Fetch default branch, then diff default vs feature
- *
- * 3. Default Branch Push (CI_COMMIT_REF_NAME == CI_DEFAULT_BRANCH):
- *    - Use HEAD~1...HEAD (last commit only, no fetch needed)
+ * Note: GitLab CI does a shallow clone, so we fetch the target branch for MR context.
+ * For regular pushes, HEAD~1...HEAD works without additional fetching.
  */
 async function getDiff(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);
-    // Get GitLab CI environment variables
     const mrIid = process.env.CI_MERGE_REQUEST_IID;
     const targetBranch = process.env.CI_MERGE_REQUEST_TARGET_BRANCH_NAME;
     const sourceBranch = process.env.CI_MERGE_REQUEST_SOURCE_BRANCH_NAME;
-    const refName = process.env.CI_COMMIT_REF_NAME;
-    const defaultBranch = process.env.CI_DEFAULT_BRANCH || 'main';
-    // Scenario 1: MR Context
+    // MR Context: Fetch target branch and compare
     if (mrIid) {
         if (!targetBranch || !sourceBranch) {
             throw new Error('GitLab MR context detected but CI_MERGE_REQUEST_TARGET_BRANCH_NAME or ' +
@@ -97,23 +87,9 @@ async function getDiff(repoRoot) {
         const changedFiles = diffSummary.files.map(f => f.file);
         return { diff: diff || '', changedFiles };
     }
-    if (!refName) {
-        throw new Error('GitLab CI: CI_COMMIT_REF_NAME environment variable is not set. ' +
-            'This should be automatically provided by GitLab CI.');
-    }
-    // Scenario 3: Default Branch Push
-    if (refName === defaultBranch) {
-        console.log(`  [GitLab] Push to default branch (${defaultBranch}), using HEAD~1...HEAD`);
-        const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
-        const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
-        const changedFiles = diffSummary.files.map(f => f.file);
-        return { diff: diff || '', changedFiles };
-    }
-    // Scenario 2: Feature Branch Push
-    console.log(`  [GitLab] Feature branch push, fetching default branch: origin/${defaultBranch}`);
-    await git.fetch(['origin', `${defaultBranch}:refs/remotes/origin/${defaultBranch}`, '--depth=1']);
-    const diff = await git.diff([`origin/${defaultBranch}...origin/${refName}`, '-U200']);
-    const diffSummary = await git.diffSummary([`origin/${defaultBranch}...origin/${refName}`]);
+    // Any push (main or feature branch): Review last commit only
+    const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
+    const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
     const changedFiles = diffSummary.files.map(f => f.file);
     return { diff: diff || '', changedFiles };
 }
@@ -140,10 +116,13 @@ async function getBranchName() {
     return refName;
 }
 /**
- * Detects GitLab context (MR, branch, or commit)
+ * Detects GitLab context (MR or commit)
+ *
+ * - MR context: When CI_MERGE_REQUEST_IID is set
+ * - Commit context: Any push (main or feature branch) - reviews single commit
  */
 function detectContext() {
-    // 1. Check for MR context
+    // MR context
     const mrIid = process.env.CI_MERGE_REQUEST_IID;
     if (mrIid) {
         const targetBranch = process.env.CI_MERGE_REQUEST_TARGET_BRANCH_NAME;
@@ -157,22 +136,16 @@ function detectContext() {
             };
         }
     }
-    // 2. Check for branch context
-    if (process.env.CI_COMMIT_REF_NAME) {
-        return {
-            type: 'branch',
-            branchName: process.env.CI_COMMIT_REF_NAME
-        };
-    }
-    // 3. Check for commit context
+    // Any push (main or feature branch) → commit context
     if (process.env.CI_COMMIT_SHA) {
         return {
             type: 'commit',
             commitSha: process.env.CI_COMMIT_SHA
         };
     }
-    // 4. Fallback to local (shouldn't happen in GitLab CI, but TypeScript needs it)
-    return { type: 'local' };
+    throw new Error('GitLab CI: Could not detect context. ' +
+        'Expected CI_MERGE_REQUEST_IID or CI_COMMIT_SHA to be set. ' +
+        'This should be automatically provided by GitLab CI.');
 }
 /**
  * Gets commit SHA from context
@@ -181,7 +154,7 @@ function getCommitSha(context) {
     if (context.type === 'commit') {
         return context.commitSha;
     }
-    if (context.type === 'branch' || context.type === 'mr') {
+    if (context.type === 'mr') {
         return process.env.CI_COMMIT_SHA;
     }
     return undefined;

package/dist/git/local.js

@@ -1,6 +1,6 @@
 "use strict";
 /**
- * Local Environment - Complete Isolation
+ * Local Environment
  *
  * All Local-specific logic is contained in this file.
  * No dependencies on other environment implementations.
@@ -19,7 +19,7 @@ exports.getLocalContext = getLocalContext;
 const simple_git_1 = __importDefault(require("simple-git"));
 const diff_1 = require("./diff");
 /**
- * Gets all Local context in one call - completely isolated from other environments.
+ * Gets all Local context
  */
 async function getLocalContext(repoRoot, commitSha) {
     const git = (0, simple_git_1.default)(repoRoot);

package/dist/git/vercel.js

@@ -1,6 +1,6 @@
 "use strict";
 /**
- * Vercel Environment - Complete Isolation
+ * Vercel Environment
  *
  * All Vercel-specific logic is contained in this file.
  * No dependencies on other environment implementations.
@@ -20,7 +20,7 @@ const simple_git_1 = __importDefault(require("simple-git"));
 const child_process_1 = require("child_process");
 const diff_1 = require("./diff");
 /**
- * Gets all Vercel context in one call - completely isolated from other environments.
+ * Gets all Vercel context
  */
 async function getVercelContext(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);

package/dist/index.js

@@ -63,7 +63,6 @@ program
     .description('Check code against your threadlines')
     .option('--api-url <url>', 'Threadline server URL', process.env.THREADLINE_API_URL || 'https://devthreadline.com')
     .option('--full', 'Show all results (compliant, attention, not_relevant). Default: only attention items')
-    .option('--branch <name>', 'Review all commits in branch vs base (e.g., --branch feature/new-feature)')
     .option('--commit <ref>', 'Review specific commit. Accepts commit SHA or git reference (e.g., HEAD, HEAD~1, abc123). Example: --commit HEAD')
     .option('--file <path>', 'Review entire file (all lines as additions)')
     .option('--folder <path>', 'Review all files in folder recursively')
@@ -72,13 +71,12 @@ program
 Examples:
   $ threadlines check                    # Check staged/unstaged changes (local dev)
   $ threadlines check --commit HEAD      # Check latest commit locally
-  $ threadlines check --branch main      # Check all commits in branch vs base
   $ threadlines check --file src/api.ts  # Check entire file
   $ threadlines check --full             # Show all results (not just attention items)
 
 Auto-detection in CI:
-  - CI with branch detected → reviews all commits in branch vs base
-  - CI with commit SHA detected → reviews specific commit
+  - PR/MR context → reviews all changes in the PR/MR
+  - Push to any branch → reviews the commit being pushed
   - Local development → reviews staged/unstaged changes
 `)
     .action(check_1.checkCommand);

package/dist/types/git.js

@@ -0,0 +1,5 @@
+"use strict";
+/**
+ * Git-related type definitions
+ */
+Object.defineProperty(exports, "__esModule", { value: true });

package/dist/utils/context.js

@@ -1,148 +1,10 @@
 "use strict";
 /**
- * Review Context Detection
+ * Review Context Types
  *
- * Determines what type of code review context we're in:
- * - PR/MR: Multiple commits comparing two branches
- * - Branch: All commits on a branch vs base branch
- * - Commit: Single commit changes
+ * Type definitions for the different code review contexts:
+ * - PR/MR: Comparing source branch vs target branch (branch-level diff)
+ * - Commit: Single commit changes (any push without PR/MR)
  * - Local: Staged/unstaged changes in working directory
- *
- * Context detection is environment-specific - each CI platform
- * provides different environment variables.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.detectContext = detectContext;
-/**
- * Detects the review context based on the environment.
- *
- * Each environment has different environment variables available,
- * so detection logic is environment-specific.
- */
-function detectContext(environment) {
-    switch (environment) {
-        case 'github':
-            return detectGitHubContext();
-        case 'gitlab':
-            return detectGitLabContext();
-        case 'vercel':
-            return detectVercelContext();
-        case 'local':
-            return { type: 'local' };
-        default:
-            return { type: 'local' };
-    }
-}
-/**
- * GitHub Actions context detection
- *
- * Environment Variables:
- * - PR: GITHUB_EVENT_NAME='pull_request', GITHUB_BASE_REF, GITHUB_HEAD_REF, GITHUB_EVENT_NUMBER
- * - Branch: GITHUB_REF_NAME
- * - Commit: GITHUB_SHA
- */
-function detectGitHubContext() {
-    // 1. Check for PR context
-    if (process.env.GITHUB_EVENT_NAME === 'pull_request') {
-        const targetBranch = process.env.GITHUB_BASE_REF;
-        const sourceBranch = process.env.GITHUB_HEAD_REF;
-        const prNumber = process.env.GITHUB_EVENT_PULL_REQUEST_NUMBER || process.env.GITHUB_EVENT_NUMBER;
-        if (targetBranch && sourceBranch && prNumber) {
-            return {
-                type: 'pr',
-                prNumber,
-                sourceBranch,
-                targetBranch
-            };
-        }
-    }
-    // 2. Check for branch context
-    if (process.env.GITHUB_REF_NAME) {
-        return {
-            type: 'branch',
-            branchName: process.env.GITHUB_REF_NAME
-        };
-    }
-    // 3. Check for commit context
-    if (process.env.GITHUB_SHA) {
-        return {
-            type: 'commit',
-            commitSha: process.env.GITHUB_SHA
-        };
-    }
-    // 4. Fallback to local
-    return { type: 'local' };
-}
-/**
- * GitLab CI context detection
- *
- * Environment Variables:
- * - MR: CI_MERGE_REQUEST_IID, CI_MERGE_REQUEST_TARGET_BRANCH_NAME, CI_MERGE_REQUEST_SOURCE_BRANCH_NAME, CI_MERGE_REQUEST_TITLE
- * - Branch: CI_COMMIT_REF_NAME
- * - Commit: CI_COMMIT_SHA
- */
-function detectGitLabContext() {
-    // 1. Check for MR context
-    if (process.env.CI_MERGE_REQUEST_IID) {
-        const targetBranch = process.env.CI_MERGE_REQUEST_TARGET_BRANCH_NAME;
-        const sourceBranch = process.env.CI_MERGE_REQUEST_SOURCE_BRANCH_NAME;
-        const mrNumber = process.env.CI_MERGE_REQUEST_IID;
-        const mrTitle = process.env.CI_MERGE_REQUEST_TITLE;
-        if (targetBranch && sourceBranch && mrNumber) {
-            return {
-                type: 'mr',
-                mrNumber,
-                sourceBranch,
-                targetBranch,
-                prTitle: mrTitle || undefined
-            };
-        }
-    }
-    // 2. Check for branch context
-    if (process.env.CI_COMMIT_REF_NAME) {
-        return {
-            type: 'branch',
-            branchName: process.env.CI_COMMIT_REF_NAME
-        };
-    }
-    // 3. Check for commit context
-    if (process.env.CI_COMMIT_SHA) {
-        return {
-            type: 'commit',
-            commitSha: process.env.CI_COMMIT_SHA
-        };
-    }
-    // 4. Fallback to local
-    return { type: 'local' };
-}
-/**
- * Vercel context detection
- *
- * Environment Variables:
- * - Branch: VERCEL_GIT_COMMIT_REF
- * - Commit: VERCEL_GIT_COMMIT_SHA
- *
- * Vercel Limitation:
- * Vercel performs shallow clones of the repository, typically fetching only the
- * specific commit being deployed. The git repository in Vercel's build environment
- * does not contain the full git history or remote branch references (e.g., origin/main).
- * This means branch-based diff operations (comparing feature branch against base branch)
- * are not possible because the base branch refs are not available in the repository.
- *
- * Solution:
- * We hardcode commit context for Vercel, using VERCEL_GIT_COMMIT_SHA to get a
- * commit-based diff (comparing the commit against its parent). This works within
- * Vercel's constraints since we only need the commit SHA, not branch references.
- */
-function detectVercelContext() {
-    // Hardcode commit context for Vercel due to shallow clone limitations
-    // Vercel's git repository doesn't have base branch refs available
-    if (process.env.VERCEL_GIT_COMMIT_SHA) {
-        return {
-            type: 'commit',
-            commitSha: process.env.VERCEL_GIT_COMMIT_SHA
-        };
-    }
-    // Fallback to local
-    return { type: 'local' };
-}

package/dist/utils/environment.js

@@ -15,7 +15,8 @@ exports.isCIEnvironment = isCIEnvironment;
  * 1. Vercel: VERCEL=1
  * 2. GitHub Actions: GITHUB_ACTIONS=1
  * 3. GitLab CI: GITLAB_CI=1 or (CI=1 + CI_COMMIT_SHA)
- * 4. Local: None of the above
+ * 4. Bitbucket Pipelines: BITBUCKET_BUILD_NUMBER exists
+ * 5. Local: None of the above
  */
 function detectEnvironment() {
     if (process.env.VERCEL)
@@ -24,6 +25,8 @@ function detectEnvironment() {
         return 'github';
     if (process.env.GITLAB_CI || (process.env.CI && process.env.CI_COMMIT_SHA))
         return 'gitlab';
+    if (process.env.BITBUCKET_BUILD_NUMBER)
+        return 'bitbucket';
     return 'local';
 }
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadlines",
-  "version": "0.2.4",
+  "version": "0.2.7",
   "description": "Threadlines CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {

package/dist/git/context.js

@@ -1,55 +0,0 @@
-"use strict";
-/**
- * Unified Git Context Collection
- *
- * Collects all git-related information (diff, repo name, branch name) in a unified way.
- * Each environment has isolated implementations - changes to one don't affect others.
- */
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.getGitContextForEnvironment = getGitContextForEnvironment;
-const git_diff_executor_1 = require("../utils/git-diff-executor");
-const repo_1 = require("./repo");
-const repo_2 = require("./repo");
-/**
- * Collects all git context (diff, repo name, branch name) for the given environment.
- *
- * Each environment has a single, specific implementation:
- * - GitHub: Uses GITHUB_REPOSITORY, GITHUB_REF_NAME, and GitHub-specific diff logic
- * - Vercel: Uses VERCEL_GIT_REPO_OWNER/SLUG, VERCEL_GIT_COMMIT_REF, and Vercel-specific diff logic
- * - GitLab: Uses CI_PROJECT_URL, CI_COMMIT_REF_NAME, and GitLab-specific diff logic
- *           (fetches default branch on-demand since GitLab only clones current branch)
- * - Local: Uses git commands for repo/branch, and local diff logic
- *
- * All methods fail loudly if they can't get the required information.
- */
-async function getGitContextForEnvironment(environment, repoRoot) {
-    switch (environment) {
-        case 'github':
-            return {
-                diff: await (0, git_diff_executor_1.getDiffForEnvironment)('github', repoRoot),
-                repoName: await (0, repo_1.getGitHubRepoName)(repoRoot),
-                branchName: await (0, repo_2.getGitHubBranchName)(repoRoot)
-            };
-        case 'vercel':
-            return {
-                diff: await (0, git_diff_executor_1.getDiffForEnvironment)('vercel', repoRoot),
-                repoName: await (0, repo_1.getVercelRepoName)(repoRoot),
-                branchName: await (0, repo_2.getVercelBranchName)(repoRoot)
-            };
-        case 'local':
-            return {
-                diff: await (0, git_diff_executor_1.getDiffForEnvironment)('local', repoRoot),
-                repoName: await (0, repo_1.getLocalRepoName)(repoRoot),
-                branchName: await (0, repo_2.getLocalBranchName)(repoRoot)
-            };
-        case 'gitlab':
-            return {
-                diff: await (0, git_diff_executor_1.getDiffForEnvironment)('gitlab', repoRoot),
-                repoName: await (0, repo_1.getGitLabRepoName)(repoRoot),
-                branchName: await (0, repo_2.getGitLabBranchName)(repoRoot)
-            };
-        default:
-            const _exhaustive = environment;
-            throw new Error(`Unknown environment: ${_exhaustive}`);
-    }
-}