threadlines 0.2.15 → 0.2.16

package/dist/git/bitbucket.js

@@ -69,36 +69,26 @@ async function getBitbucketContext(repoRoot) {
  * Get diff for Bitbucket Pipelines environment
  *
  * Strategy:
- * - PR context: Fetch destination branch on-demand, compare source vs target (full PR diff)
+ * - PR context: Uses shared getPRDiff() - fetches destination branch, compares against HEAD
  * - Any push (main or feature branch): Compare last commit only (HEAD~1...HEAD)
  *
  * Note: We fetch the destination branch on-demand so this works with shallow clones.
  * Users don't need `depth: full` in their bitbucket-pipelines.yml.
  */
 async function getDiff(repoRoot) {
-    const git = (0, simple_git_1.default)(repoRoot);
     const prId = process.env.BITBUCKET_PR_ID;
     const prDestinationBranch = process.env.BITBUCKET_PR_DESTINATION_BRANCH;
-    // PR Context: Fetch destination branch and compare
+    // PR Context: Use shared getPRDiff() implementation
     if (prId) {
         if (!prDestinationBranch) {
             throw new Error('Bitbucket PR context detected but BITBUCKET_PR_DESTINATION_BRANCH is not set. ' +
                 'This should be automatically provided by Bitbucket Pipelines.');
         }
-        // Fetch destination branch on-demand (works with shallow clones)
-        logger_1.logger.debug(`Fetching destination branch: origin/${prDestinationBranch}`);
-        await git.fetch(['origin', `${prDestinationBranch}:refs/remotes/origin/${prDestinationBranch}`, '--depth=1']);
-        logger_1.logger.debug(`PR #${prId}, using origin/${prDestinationBranch}...HEAD`);
-        const diff = await git.diff([`origin/${prDestinationBranch}...HEAD`, '-U200']);
-        const diffSummary = await git.diffSummary([`origin/${prDestinationBranch}...HEAD`]);
-        const changedFiles = diffSummary.files.map(f => f.file);
-        return { diff: diff || '', changedFiles };
+        return (0, diff_1.getPRDiff)(repoRoot, prDestinationBranch, logger_1.logger);
     }
     // Any push (main or feature branch): Review last commit only
-    const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
-    const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
-    const changedFiles = diffSummary.files.map(f => f.file);
-    return { diff: diff || '', changedFiles };
+    // Use shared getCommitDiff (defaults to HEAD)
+    return (0, diff_1.getCommitDiff)(repoRoot);
 }
 /**
  * Gets repository name for Bitbucket Pipelines

package/dist/git/diff.js

@@ -80,14 +80,8 @@ async function getCommitAuthor(repoRoot, sha) {
  * - origin/${sourceBranch} doesn't exist until explicitly fetched
  * - HEAD IS the source branch in PR/MR pipelines
  *
- * Currently used by:
- * - GitLab CI (gitlab.ts)
- *
- * Future plan:
- * - Azure DevOps will use this when added
- * - Once proven stable in multiple environments, consider migrating
- *   GitHub (github.ts) and Bitbucket (bitbucket.ts) to use this shared
- *   implementation instead of their inline versions.
+ * Used by: GitHub, GitLab, Bitbucket (all PR/MR contexts)
+ * Future: Azure DevOps will use this when added
  *
  * @param repoRoot - Path to the repository root
  * @param targetBranch - The branch being merged INTO (e.g., "main", "develop")
@@ -118,21 +112,24 @@ async function getPRDiff(repoRoot, targetBranch, logger) {
     };
 }
 /**
- * Get diff for a specific commit
+ * Get diff for a specific commit (or HEAD if no SHA provided).
+ *
+ * Uses `git show` which works reliably with shallow clones (depth=1).
+ * This is safer than `HEAD~1...HEAD` which requires depth >= 2.
+ *
+ * Used by:
+ * - All CI environments for push/commit context (GitHub, GitLab, Bitbucket, Vercel)
+ * - Local environment for --commit flag
+ *
+ * @param repoRoot - Path to the repository root
+ * @param sha - Commit SHA to get diff for (defaults to HEAD)
  */
-async function getCommitDiff(repoRoot, sha) {
+async function getCommitDiff(repoRoot, sha = 'HEAD') {
     const git = (0, simple_git_1.default)(repoRoot);
-    // Check if we're in a git repo
-    const isRepo = await git.checkIsRepo();
-    if (!isRepo) {
-        throw new Error('Not a git repository. Threadline requires a git repository.');
-    }
-    // Get diff for the commit
-    // Use git show to get the commit diff
+    // Get diff using git show
     let diff;
     let changedFiles;
     try {
-        // Get diff using git show
         diff = await git.show([sha, '--format=', '--no-color', '-U200']);
         // Get changed files using git show --name-only
         const commitFiles = await git.show([sha, '--name-only', '--format=', '--pretty=format:']);
@@ -142,18 +139,8 @@ async function getCommitDiff(repoRoot, sha) {
             .map(line => line.trim());
     }
     catch (error) {
-        // Fallback: try git diff format
-        try {
-            diff = await git.diff([`${sha}^..${sha}`, '-U200']);
-            // Get files from diff summary
-            const diffSummary = await git.diffSummary([`${sha}^..${sha}`]);
-            changedFiles = diffSummary.files.map(f => f.file);
-        }
-        catch (diffError) {
-            const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-            const diffErrorMessage = diffError instanceof Error ? diffError.message : 'Unknown error';
-            throw new Error(`Commit ${sha} not found or invalid: ${errorMessage || diffErrorMessage}`);
-        }
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        throw new Error(`Failed to get diff for commit ${sha}: ${errorMessage}`);
     }
     return {
         diff: diff || '',

package/dist/git/github.js

@@ -71,53 +71,26 @@ async function getGitHubContext(repoRoot) {
  * Gets diff for GitHub Actions CI environment
  *
  * Strategy:
- * - PR context: Fetch base branch on-demand, compare base vs HEAD (full PR diff)
- * - Any push (main or feature branch): Compare last commit only (HEAD~1...HEAD)
+ * - PR context: Uses shared getPRDiff() - fetches base branch, compares against HEAD
+ * - Any push (main or feature branch): Compare last commit only using git show HEAD
  *
  * Note: GitHub Actions does shallow clones by default (fetch-depth: 1), so we fetch
  * the base branch on-demand. HEAD points to the merge commit which contains all PR changes.
  */
 async function getDiff(repoRoot) {
-    const git = (0, simple_git_1.default)(repoRoot);
     const eventName = process.env.GITHUB_EVENT_NAME;
     const baseRef = process.env.GITHUB_BASE_REF;
-    // PR Context: Only pull_request events have GITHUB_BASE_REF set
+    // PR Context: Use shared getPRDiff() implementation
     if (eventName === 'pull_request') {
         if (!baseRef) {
             throw new Error('GitHub PR context detected but GITHUB_BASE_REF is missing. ' +
                 'This should be automatically provided by GitHub Actions.');
         }
-        // Fetch base branch on-demand (works with shallow clones)
-        logger_1.logger.debug(`Fetching base branch: origin/${baseRef}`);
-        try {
-            await git.fetch(['origin', `${baseRef}:refs/remotes/origin/${baseRef}`, '--depth=1']);
-        }
-        catch (fetchError) {
-            throw new Error(`Failed to fetch base branch origin/${baseRef}. ` +
-                `This is required for PR diff comparison. Error: ${fetchError instanceof Error ? fetchError.message : 'Unknown error'}`);
-        }
-        logger_1.logger.debug(`PR context, using origin/${baseRef}..HEAD (two dots for direct comparison)`);
-        // Use two dots (..) instead of three dots (...) for direct comparison
-        // Three dots requires finding merge base which can fail with shallow clones
-        // Two dots shows all changes in HEAD that aren't in origin/${baseRef}
-        const diff = await git.diff([`origin/${baseRef}..HEAD`, '-U200']);
-        const diffSummary = await git.diffSummary([`origin/${baseRef}..HEAD`]);
-        const changedFiles = diffSummary.files.map(f => f.file);
-        return {
-            diff: diff || '',
-            changedFiles
-        };
+        return (0, diff_1.getPRDiff)(repoRoot, baseRef, logger_1.logger);
     }
     // Any push (main or feature branch): Review last commit only
-    // Use git show HEAD - works with shallow clones and shows the commit diff
-    const diff = await git.show(['HEAD', '--format=', '--no-color', '-U200']);
-    // Extract changed files from git show
-    const showNameOnly = await git.show(['HEAD', '--name-only', '--format=', '--pretty=format:']);
-    const changedFiles = showNameOnly
-        .split('\n')
-        .filter(line => line.trim().length > 0)
-        .map(line => line.trim());
-    return { diff: diff || '', changedFiles };
+    // Use shared getCommitDiff (defaults to HEAD)
+    return (0, diff_1.getCommitDiff)(repoRoot);
 }
 /**
  * Gets repository name for GitHub Actions

package/dist/git/gitlab.js

@@ -73,7 +73,6 @@ async function getGitLabContext(repoRoot) {
  * For regular pushes, HEAD~1...HEAD works without additional fetching.
  */
 async function getDiff(repoRoot) {
-    const git = (0, simple_git_1.default)(repoRoot);
     const mrIid = process.env.CI_MERGE_REQUEST_IID;
     const targetBranch = process.env.CI_MERGE_REQUEST_TARGET_BRANCH_NAME;
     // MR Context: Use shared getPRDiff() implementation
@@ -85,10 +84,8 @@ async function getDiff(repoRoot) {
         return (0, diff_1.getPRDiff)(repoRoot, targetBranch, logger_1.logger);
     }
     // Any push (main or feature branch): Review last commit only
-    const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
-    const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
-    const changedFiles = diffSummary.files.map(f => f.file);
-    return { diff: diff || '', changedFiles };
+    // Use shared getCommitDiff (defaults to HEAD)
+    return (0, diff_1.getCommitDiff)(repoRoot);
 }
 /**
  * Gets repository name for GitLab CI

package/dist/git/local.js

@@ -29,7 +29,7 @@ async function getLocalContext(repoRoot, commitSha) {
         throw new Error('Not a git repository. Threadline requires a git repository.');
     }
     // Get all Local context
-    const diff = commitSha ? await getCommitDiff(repoRoot, commitSha) : await getDiff(repoRoot);
+    const diff = commitSha ? await (0, diff_1.getCommitDiff)(repoRoot, commitSha) : await getDiff(repoRoot);
     const repoName = await getRepoName(repoRoot);
     const branchName = await getBranchName(repoRoot);
     const context = commitSha ? { type: 'commit', commitSha } : { type: 'local' };
@@ -96,24 +96,6 @@ async function getDiff(repoRoot) {
         changedFiles
     };
 }
-/**
- * Get diff for a specific commit (when --commit flag is used)
- */
-async function getCommitDiff(repoRoot, commitSha) {
-    const git = (0, simple_git_1.default)(repoRoot);
-    // Get diff using git show
-    const diff = await git.show([commitSha, '--format=', '--no-color', '-U200']);
-    // Get changed files using git show --name-only
-    const commitFiles = await git.show([commitSha, '--name-only', '--format=', '--pretty=format:']);
-    const changedFiles = commitFiles
-        .split('\n')
-        .filter(line => line.trim().length > 0)
-        .map(line => line.trim());
-    return {
-        diff: diff || '',
-        changedFiles
-    };
-}
 /**
  * Gets repository name for local environment
  */

package/dist/git/vercel.js

@@ -58,29 +58,13 @@ async function getVercelContext(repoRoot) {
 /**
  * Get diff for Vercel CI environment
  *
- * Vercel provides VERCEL_GIT_COMMIT_SHA which contains the commit being deployed.
- * This function gets the diff for that specific commit using git show.
+ * Vercel only supports commit context (no PRs).
+ * Uses shared getCommitDiff with HEAD (which equals VERCEL_GIT_COMMIT_SHA).
  */
 async function getDiff(repoRoot) {
-    const git = (0, simple_git_1.default)(repoRoot);
-    // Get commit SHA from Vercel environment variable
-    const commitSha = process.env.VERCEL_GIT_COMMIT_SHA;
-    if (!commitSha) {
-        throw new Error('VERCEL_GIT_COMMIT_SHA environment variable is not set. ' +
-            'This should be automatically provided by Vercel CI.');
-    }
-    // Get diff using git show - this is the ONLY way we get diff in Vercel
-    const diff = await git.show([commitSha, '--format=', '--no-color', '-U200']);
-    // Get changed files using git show --name-only
-    const commitFiles = await git.show([commitSha, '--name-only', '--format=', '--pretty=format:']);
-    const changedFiles = commitFiles
-        .split('\n')
-        .filter(line => line.trim().length > 0)
-        .map(line => line.trim());
-    return {
-        diff: diff || '', // Empty diff is legitimate (e.g., metadata-only commits, merge commits)
-        changedFiles
-    };
+    // Use shared getCommitDiff (defaults to HEAD)
+    // In Vercel, HEAD is the commit being deployed
+    return (0, diff_1.getCommitDiff)(repoRoot);
 }
 /**
  * Gets repository name for Vercel

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadlines",
-  "version": "0.2.15",
+  "version": "0.2.16",
   "description": "Threadlines CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {