threadlines 0.2.13 → 0.2.14

package/dist/commands/check.js

@@ -47,7 +47,6 @@ const gitlab_1 = require("../git/gitlab");
 const bitbucket_1 = require("../git/bitbucket");
 const vercel_1 = require("../git/vercel");
 const local_1 = require("../git/local");
-const diff_1 = require("../git/diff");
 const config_file_1 = require("../utils/config-file");
 const logger_1 = require("../utils/logger");
 const fs = __importStar(require("fs"));
@@ -68,8 +67,11 @@ async function getContextForEnvironment(environment, repoRoot, commitSha) {
             return (0, bitbucket_1.getBitbucketContext)(repoRoot);
         case 'vercel':
             return (0, vercel_1.getVercelContext)(repoRoot);
-        default:
+        case 'local':
             return (0, local_1.getLocalContext)(repoRoot, commitSha);
+        default:
+            // TypeScript exhaustiveness check - should never happen
+            throw new Error(`Unrecognized environment: ${environment}`);
     }
 }
 // Get CLI version from package.json
@@ -93,18 +95,20 @@ async function checkCommand(options) {
         }
         gitRoot = (await git.revparse(['--show-toplevel'])).trim();
     }
-    catch {
-        logger_1.logger.error('Failed to get git root. Make sure you are in a git repository.');
+    catch (error) {
+        const message = error instanceof Error ? error.message : String(error);
+        logger_1.logger.error(`Failed to get git root: ${message}`);
         process.exit(1);
     }
     // Pre-flight check: Validate ALL required environment variables at once
     const apiKey = (0, config_1.getThreadlineApiKey)();
     const account = (0, config_1.getThreadlineAccount)();
     const missingVars = [];
-    // Check for undefined, empty string, or literal unexpanded variable (GitLab keeps "$VAR" literal)
-    if (!apiKey || apiKey.startsWith('$'))
+    // Check for undefined, empty string, or literal unexpanded variable
+    // GitLab CI keeps variables as literal "$VAR" if not defined in CI/CD settings
+    if (!apiKey || apiKey === '$THREADLINE_API_KEY')
         missingVars.push('THREADLINE_API_KEY');
-    if (!account || account.startsWith('$'))
+    if (!account || account === '$THREADLINE_ACCOUNT')
         missingVars.push('THREADLINE_ACCOUNT');
     if (missingVars.length > 0) {
         logger_1.logger.error('Missing required environment variables:');
@@ -134,189 +138,171 @@ async function checkCommand(options) {
         console.log(chalk_1.default.gray('Get your credentials at: https://devthreadline.com/settings'));
         process.exit(1);
     }
-    try {
-        // 1. Find and validate threadlines
-        logger_1.logger.info('Finding threadlines...');
-        const threadlines = await (0, experts_1.findThreadlines)(cwd, gitRoot);
-        console.log(chalk_1.default.green(`✓ Found ${threadlines.length} threadline(s)\n`));
-        if (threadlines.length === 0) {
-            console.log(chalk_1.default.yellow('⚠️  No valid threadlines found.'));
-            console.log(chalk_1.default.gray('   Run `npx threadlines init` to create your first threadline.'));
-            process.exit(0);
-        }
-        // 2. Detect environment and context
-        const environment = (0, environment_1.detectEnvironment)();
-        let gitDiff;
-        let repoName;
-        let branchName;
-        let reviewContext;
-        let metadata = {};
-        // Check for explicit flags
-        const explicitFlags = [options.commit, options.file, options.folder, options.files].filter(Boolean);
-        // Validate mutually exclusive flags
-        if (explicitFlags.length > 1) {
-            logger_1.logger.error('Only one review option can be specified at a time');
-            console.log(chalk_1.default.gray('   Options: --commit, --file, --folder, --files'));
-            process.exit(1);
+    // 1. Find and validate threadlines
+    logger_1.logger.info('Finding threadlines...');
+    const threadlines = await (0, experts_1.findThreadlines)(cwd, gitRoot);
+    console.log(chalk_1.default.green(`✓ Found ${threadlines.length} threadline(s)\n`));
+    if (threadlines.length === 0) {
+        console.log(chalk_1.default.yellow('⚠️  No valid threadlines found.'));
+        console.log(chalk_1.default.gray('   Run `npx threadlines init` to create your first threadline.'));
+        process.exit(0);
+    }
+    // 2. Detect environment and context
+    const environment = (0, environment_1.detectEnvironment)();
+    let gitDiff;
+    let repoName;
+    let branchName;
+    let reviewContext;
+    let metadata = {};
+    // Check for explicit flags
+    const explicitFlags = [options.commit, options.file, options.folder, options.files].filter(Boolean);
+    // Validate mutually exclusive flags
+    if (explicitFlags.length > 1) {
+        logger_1.logger.error('Only one review option can be specified at a time');
+        console.log(chalk_1.default.gray('   Options: --commit, --file, --folder, --files'));
+        process.exit(1);
+    }
+    // CI environments: auto-detect only, flags are ignored with warning
+    // Local: full flag support for developer flexibility
+    if ((0, environment_1.isCIEnvironment)(environment)) {
+        // Warn if flags are passed in CI - they're meant for local development
+        if (explicitFlags.length > 0) {
+            const flagName = options.commit ? '--commit' :
+                options.file ? '--file' :
+                    options.folder ? '--folder' : '--files';
+            logger_1.logger.warn(`${flagName} flag ignored in CI environment. Using auto-detection.`);
         }
-        // CI environments: auto-detect only, flags are ignored with warning
-        // Local: full flag support for developer flexibility
-        if ((0, environment_1.isCIEnvironment)(environment)) {
-            // Warn if flags are passed in CI - they're meant for local development
-            if (explicitFlags.length > 0) {
-                const flagName = options.commit ? '--commit' :
-                    options.file ? '--file' :
-                        options.folder ? '--folder' : '--files';
-                logger_1.logger.warn(`${flagName} flag ignored in CI environment. Using auto-detection.`);
-            }
-            // CI auto-detect: use environment-specific context
-            const envNames = {
-                vercel: 'Vercel',
-                github: 'GitHub Actions',
-                gitlab: 'GitLab CI',
-                bitbucket: 'Bitbucket Pipelines'
-            };
-            logger_1.logger.info(`Collecting git context for ${envNames[environment]}...`);
-            const envContext = await getContextForEnvironment(environment, repoRoot);
-            gitDiff = envContext.diff;
-            repoName = envContext.repoName;
-            branchName = envContext.branchName;
-            reviewContext = envContext.reviewContext; // Get from CI context
-            metadata = {
-                commitSha: envContext.commitSha,
-                commitMessage: envContext.commitMessage,
-                commitAuthorName: envContext.commitAuthor.name,
-                commitAuthorEmail: envContext.commitAuthor.email,
-                prTitle: envContext.prTitle
-            };
+        // CI auto-detect: use environment-specific context
+        const envNames = {
+            vercel: 'Vercel',
+            github: 'GitHub Actions',
+            gitlab: 'GitLab CI',
+            bitbucket: 'Bitbucket Pipelines'
+        };
+        logger_1.logger.info(`Collecting git context for ${envNames[environment]}...`);
+        const envContext = await getContextForEnvironment(environment, repoRoot);
+        gitDiff = envContext.diff;
+        repoName = envContext.repoName;
+        branchName = envContext.branchName;
+        reviewContext = envContext.reviewContext; // Get from CI context
+        metadata = {
+            commitSha: envContext.commitSha,
+            commitMessage: envContext.commitMessage,
+            commitAuthorName: envContext.commitAuthor.name,
+            commitAuthorEmail: envContext.commitAuthor.email,
+            prTitle: envContext.prTitle
+        };
+    }
+    else {
+        // Local environment: all flags share the same metadata
+        // 1. Get context and metadata (pass commit SHA if provided)
+        logger_1.logger.info('Collecting local context...');
+        const localContext = await (0, local_1.getLocalContext)(repoRoot, options.commit);
+        repoName = localContext.repoName;
+        branchName = localContext.branchName;
+        metadata = {
+            commitSha: localContext.commitSha,
+            commitMessage: localContext.commitMessage,
+            commitAuthorName: localContext.commitAuthor.name,
+            commitAuthorEmail: localContext.commitAuthor.email
+        };
+        // 2. Get diff (override with specific content if flag provided)
+        if (options.file) {
+            reviewContext = 'file';
+            logger_1.logger.info(`Reading file: ${options.file}...`);
+            gitDiff = await (0, file_1.getFileContent)(repoRoot, options.file);
         }
-        else {
-            // Local environment: support all flags
-            // Detect review context from flags (priority order: file > folder > files > commit > local)
-            if (options.file) {
-                reviewContext = 'file';
-            }
-            else if (options.folder) {
-                reviewContext = 'folder';
-            }
-            else if (options.files && options.files.length > 0) {
-                reviewContext = 'files';
-            }
-            else if (options.commit) {
-                reviewContext = 'commit';
-            }
-            else {
-                reviewContext = 'local';
-            }
-            if (options.file) {
-                logger_1.logger.info(`Reading file: ${options.file}...`);
-                gitDiff = await (0, file_1.getFileContent)(repoRoot, options.file);
-            }
-            else if (options.folder) {
-                logger_1.logger.info(`Reading folder: ${options.folder}...`);
-                gitDiff = await (0, file_1.getFolderContent)(repoRoot, options.folder);
-            }
-            else if (options.files && options.files.length > 0) {
-                logger_1.logger.info(`Reading ${options.files.length} file(s)...`);
-                gitDiff = await (0, file_1.getMultipleFilesContent)(repoRoot, options.files);
-            }
-            else if (options.commit) {
-                logger_1.logger.info(`Collecting git changes for commit: ${options.commit}...`);
-                gitDiff = await (0, diff_1.getCommitDiff)(repoRoot, options.commit);
-                // Use local context for metadata, passing commit SHA for author lookup
-                const localContext = await (0, local_1.getLocalContext)(repoRoot, options.commit);
-                repoName = localContext.repoName;
-                branchName = localContext.branchName;
-                metadata = {
-                    commitSha: localContext.commitSha,
-                    commitMessage: localContext.commitMessage,
-                    commitAuthorName: localContext.commitAuthor.name,
-                    commitAuthorEmail: localContext.commitAuthor.email
-                };
-            }
-            else {
-                // Local auto-detect: staged/unstaged changes
-                logger_1.logger.info('Collecting git context for Local...');
-                const localContext = await (0, local_1.getLocalContext)(repoRoot);
-                gitDiff = localContext.diff;
-                repoName = localContext.repoName;
-                branchName = localContext.branchName;
-                metadata = {
-                    commitSha: localContext.commitSha,
-                    commitMessage: localContext.commitMessage,
-                    commitAuthorName: localContext.commitAuthor.name,
-                    commitAuthorEmail: localContext.commitAuthor.email
-                };
-            }
+        else if (options.folder) {
+            reviewContext = 'folder';
+            logger_1.logger.info(`Reading folder: ${options.folder}...`);
+            gitDiff = await (0, file_1.getFolderContent)(repoRoot, options.folder);
         }
-        if (gitDiff.changedFiles.length === 0) {
-            console.error(chalk_1.default.bold('ℹ️ No changes detected.'));
-            process.exit(0);
+        else if (options.files && options.files.length > 0) {
+            reviewContext = 'files';
+            logger_1.logger.info(`Reading ${options.files.length} file(s)...`);
+            gitDiff = await (0, file_1.getMultipleFilesContent)(repoRoot, options.files);
         }
-        // Check for zero diff (files changed but no actual code changes)
-        if (!gitDiff.diff || gitDiff.diff.trim() === '') {
-            console.log(chalk_1.default.blue('ℹ️  No code changes detected. Diff contains zero lines added or removed.'));
-            console.log(chalk_1.default.gray(`   ${gitDiff.changedFiles.length} file(s) changed but no content modifications detected.`));
-            console.log('');
-            console.log(chalk_1.default.bold('Results:\n'));
-            console.log(chalk_1.default.gray(`${threadlines.length} threadlines checked`));
-            console.log(chalk_1.default.gray(`  ${threadlines.length} not relevant`));
-            console.log('');
-            process.exit(0);
+        else {
+            // Default: use diff from localContext (handles commit and staged/unstaged)
+            reviewContext = options.commit ? 'commit' : 'local';
+            gitDiff = localContext.diff;
         }
-        console.log(chalk_1.default.green(`✓ Found ${gitDiff.changedFiles.length} changed file(s)\n`));
-        // 4. Read context files for each threadline
-        const threadlinesWithContext = threadlines.map(threadline => {
-            const contextContent = {};
-            if (threadline.contextFiles) {
-                for (const contextFile of threadline.contextFiles) {
-                    const fullPath = path.join(repoRoot, contextFile);
-                    if (fs.existsSync(fullPath)) {
+    }
+    if (gitDiff.changedFiles.length === 0) {
+        console.error(chalk_1.default.bold('ℹ️ No changes detected.'));
+        process.exit(0);
+    }
+    // Check for zero diff (files changed but no actual code changes)
+    if (!gitDiff.diff || gitDiff.diff.trim() === '') {
+        console.log(chalk_1.default.blue('ℹ️  No code changes detected. Diff contains zero lines added or removed.'));
+        console.log(chalk_1.default.gray(`   ${gitDiff.changedFiles.length} file(s) changed but no content modifications detected.`));
+        console.log('');
+        console.log(chalk_1.default.bold('Results:\n'));
+        console.log(chalk_1.default.gray(`${threadlines.length} threadlines checked`));
+        console.log(chalk_1.default.gray(`  ${threadlines.length} not relevant`));
+        console.log('');
+        process.exit(0);
+    }
+    console.log(chalk_1.default.green(`✓ Found ${gitDiff.changedFiles.length} changed file(s)\n`));
+    // Log the files being sent
+    for (const file of gitDiff.changedFiles) {
+        logger_1.logger.info(`  → ${file}`);
+    }
+    // 4. Read context files for each threadline
+    const threadlinesWithContext = threadlines.map(threadline => {
+        const contextContent = {};
+        if (threadline.contextFiles) {
+            for (const contextFile of threadline.contextFiles) {
+                const fullPath = path.join(repoRoot, contextFile);
+                if (fs.existsSync(fullPath)) {
+                    try {
                         contextContent[contextFile] = fs.readFileSync(fullPath, 'utf-8');
                     }
+                    catch (error) {
+                        const message = error instanceof Error ? error.message : String(error);
+                        throw new Error(`Failed to read context file '${contextFile}' for threadline '${threadline.id}': ${message}`);
+                    }
+                }
+                else {
+                    throw new Error(`Context file not found for threadline '${threadline.id}': ${contextFile}`);
                 }
             }
-            return {
-                id: threadline.id,
-                version: threadline.version,
-                patterns: threadline.patterns,
-                content: threadline.content,
-                filePath: threadline.filePath,
-                contextFiles: threadline.contextFiles,
-                contextContent
-            };
-        });
-        // 5. Call review API
-        logger_1.logger.info('Running threadline checks...');
-        const client = new client_1.ReviewAPIClient(config.api_url);
-        const response = await client.review({
-            threadlines: threadlinesWithContext,
-            diff: gitDiff.diff,
-            files: gitDiff.changedFiles,
-            apiKey: apiKey,
-            account: account,
-            repoName: repoName,
-            branchName: branchName,
-            commitSha: metadata.commitSha,
-            commitMessage: metadata.commitMessage,
-            commitAuthorName: metadata.commitAuthorName,
-            commitAuthorEmail: metadata.commitAuthorEmail,
-            prTitle: metadata.prTitle,
-            environment: environment,
-            cliVersion: CLI_VERSION,
-            reviewContext: reviewContext
-        });
-        // 7. Display results (with filtering if --full not specified)
-        displayResults(response, options.full || false);
-        // Exit with appropriate code (attention or errors = failure)
-        const hasIssues = response.results.some(r => r.status === 'attention' || r.status === 'error');
-        process.exit(hasIssues ? 1 : 0);
-    }
-    catch (error) {
-        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-        logger_1.logger.error(errorMessage);
-        process.exit(1);
-    }
+        }
+        return {
+            id: threadline.id,
+            version: threadline.version,
+            patterns: threadline.patterns,
+            content: threadline.content,
+            filePath: threadline.filePath,
+            contextFiles: threadline.contextFiles,
+            contextContent
+        };
+    });
+    // 5. Call review API
+    logger_1.logger.info('Running threadline checks...');
+    const client = new client_1.ReviewAPIClient(config.api_url);
+    const response = await client.review({
+        threadlines: threadlinesWithContext,
+        diff: gitDiff.diff,
+        files: gitDiff.changedFiles,
+        apiKey: apiKey,
+        account: account,
+        repoName: repoName,
+        branchName: branchName,
+        commitSha: metadata.commitSha,
+        commitMessage: metadata.commitMessage,
+        commitAuthorName: metadata.commitAuthorName,
+        commitAuthorEmail: metadata.commitAuthorEmail,
+        prTitle: metadata.prTitle,
+        environment: environment,
+        cliVersion: CLI_VERSION,
+        reviewContext: reviewContext
+    });
+    // 7. Display results (with filtering if --full not specified)
+    displayResults(response, options.full || false);
+    // Exit with appropriate code (attention or errors = failure)
+    const hasIssues = response.results.some(r => r.status === 'attention' || r.status === 'error');
+    process.exit(hasIssues ? 1 : 0);
 }
 function displayResults(response, showFull) {
     const { results, metadata, message } = response;
@@ -429,10 +415,6 @@ function displayResults(response, showFull) {
                     console.log(chalk_1.default.gray(JSON.stringify(item.error.rawResponse, null, 2).split('\n').map(line => '    ' + line).join('\n')));
                 }
             }
-            else if (item.reasoning) {
-                // Fallback to reasoning if no error object
-                console.log(chalk_1.default.red(`  ${item.reasoning}`));
-            }
             console.log(''); // Empty line between errors
         }
     }

package/dist/git/file.js

@@ -56,15 +56,17 @@ async function getFileContent(repoRoot, filePath) {
     }
     // Read file content
     const content = fs.readFileSync(fullPath, 'utf-8');
+    // Normalize path to forward slashes for cross-platform consistency (git uses forward slashes)
+    const normalizedPath = filePath.replace(/\\/g, '/');
     // Create artificial diff (all lines as additions)
     const lines = content.split('\n');
     const diff = lines.map((line) => `+${line}`).join('\n');
-    // Add diff header
-    const diffHeader = `--- /dev/null\n+++ ${filePath}\n@@ -0,0 +1,${lines.length} @@\n`;
+    // Add git diff header (matches format expected by server's filterDiffByFiles)
+    const diffHeader = `diff --git a/${normalizedPath} b/${normalizedPath}\n--- /dev/null\n+++ b/${normalizedPath}\n@@ -0,0 +1,${lines.length} @@\n`;
     const fullDiff = diffHeader + diff;
     return {
         diff: fullDiff,
-        changedFiles: [filePath]
+        changedFiles: [normalizedPath]
     };
 }
 /**
@@ -81,8 +83,8 @@ async function getFolderContent(repoRoot, folderPath) {
     if (!stats.isDirectory()) {
         throw new Error(`Path '${folderPath}' is not a folder`);
     }
-    // Find all files recursively
-    const pattern = path.join(fullPath, '**', '*');
+    // Find all files recursively (normalize to forward slashes for glob on Windows)
+    const pattern = path.join(fullPath, '**', '*').replace(/\\/g, '/');
     const files = await (0, glob_1.glob)(pattern, {
         cwd: repoRoot,
         absolute: false,
@@ -108,11 +110,13 @@ async function getFolderContent(repoRoot, folderPath) {
         try {
             const content = fs.readFileSync(path.resolve(repoRoot, filePath), 'utf-8');
             const lines = content.split('\n');
-            // Create artificial diff for this file
+            // Normalize path to forward slashes for cross-platform consistency
+            const normalizedPath = filePath.replace(/\\/g, '/');
+            // Create artificial diff for this file (git diff format)
             const fileDiff = lines.map((line) => `+${line}`).join('\n');
-            const diffHeader = `--- /dev/null\n+++ ${filePath}\n@@ -0,0 +1,${lines.length} @@\n`;
+            const diffHeader = `diff --git a/${normalizedPath} b/${normalizedPath}\n--- /dev/null\n+++ b/${normalizedPath}\n@@ -0,0 +1,${lines.length} @@\n`;
             diffs.push(diffHeader + fileDiff);
-            changedFiles.push(filePath);
+            changedFiles.push(normalizedPath);
         }
         catch (error) {
             // Skip files that can't be read (permissions, etc.)
@@ -148,11 +152,13 @@ async function getMultipleFilesContent(repoRoot, filePaths) {
         // Read file content
         const content = fs.readFileSync(fullPath, 'utf-8');
         const lines = content.split('\n');
-        // Create artificial diff for this file
+        // Normalize path to forward slashes for cross-platform consistency
+        const normalizedPath = filePath.replace(/\\/g, '/');
+        // Create artificial diff for this file (git diff format)
         const fileDiff = lines.map((line) => `+${line}`).join('\n');
-        const diffHeader = `--- /dev/null\n+++ ${filePath}\n@@ -0,0 +1,${lines.length} @@\n`;
+        const diffHeader = `diff --git a/${normalizedPath} b/${normalizedPath}\n--- /dev/null\n+++ b/${normalizedPath}\n@@ -0,0 +1,${lines.length} @@\n`;
         diffs.push(diffHeader + fileDiff);
-        changedFiles.push(filePath);
+        changedFiles.push(normalizedPath);
     }
     return {
         diff: diffs.join('\n'),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadlines",
-  "version": "0.2.13",
+  "version": "0.2.14",
   "description": "Threadlines CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {