threadlines 0.2.10 → 0.2.12

package/dist/git/diff.js

@@ -7,6 +7,7 @@ exports.getCommitMessage = getCommitMessage;
 exports.getCommitAuthor = getCommitAuthor;
 exports.getCommitDiff = getCommitDiff;
 const simple_git_1 = __importDefault(require("simple-git"));
+const child_process_1 = require("child_process");
 /**
  * Get commit message for a specific commit SHA
  * Returns full commit message (subject + body) or null if commit not found
@@ -26,26 +27,25 @@ async function getCommitMessage(repoRoot, sha) {
 /**
  * Get commit author name and email for a specific commit SHA or HEAD.
  *
- * Uses git log to extract author information from the commit.
+ * Uses raw git log command to extract author information.
  * Works in all environments where git is available.
  */
 async function getCommitAuthor(repoRoot, sha) {
-    const git = (0, simple_git_1.default)(repoRoot);
     try {
-        let logResult;
-        if (sha) {
-            // Use git log for specific commit SHA
-            logResult = await git.log({ from: sha, to: sha, maxCount: 1 });
-        }
-        else {
-            // Use git log for HEAD (local environment only)
-            logResult = await git.log({ maxCount: 1 });
-        }
-        if (!logResult.latest) {
+        // Use raw git command (same as test scripts) - more reliable than simple-git API
+        const commitRef = sha || 'HEAD';
+        const command = `git log -1 --format="%an <%ae>" ${commitRef}`;
+        const output = (0, child_process_1.execSync)(command, {
+            encoding: 'utf-8',
+            cwd: repoRoot
+        }).trim();
+        // Parse output: "Name <email>"
+        const match = output.match(/^(.+?)\s*<(.+?)>$/);
+        if (!match) {
             return null;
         }
-        const name = logResult.latest.author_name?.trim();
-        const email = logResult.latest.author_email?.trim();
+        const name = match[1].trim();
+        const email = match[2].trim();
         if (!name || !email) {
             return null;
         }

package/dist/git/github.js

@@ -83,7 +83,7 @@ async function getDiff(repoRoot) {
     const git = (0, simple_git_1.default)(repoRoot);
     const eventName = process.env.GITHUB_EVENT_NAME;
     const baseRef = process.env.GITHUB_BASE_REF;
-    // PR Context: Fetch base branch and compare with HEAD (merge commit)
+    // PR Context: Only pull_request events have GITHUB_BASE_REF set
     if (eventName === 'pull_request') {
         if (!baseRef) {
             throw new Error('GitHub PR context detected but GITHUB_BASE_REF is missing. ' +
@@ -91,10 +91,19 @@ async function getDiff(repoRoot) {
         }
         // Fetch base branch on-demand (works with shallow clones)
         logger_1.logger.debug(`Fetching base branch: origin/${baseRef}`);
-        await git.fetch(['origin', `${baseRef}:refs/remotes/origin/${baseRef}`, '--depth=1']);
-        logger_1.logger.debug(`PR context, using origin/${baseRef}...HEAD`);
-        const diff = await git.diff([`origin/${baseRef}...HEAD`, '-U200']);
-        const diffSummary = await git.diffSummary([`origin/${baseRef}...HEAD`]);
+        try {
+            await git.fetch(['origin', `${baseRef}:refs/remotes/origin/${baseRef}`, '--depth=1']);
+        }
+        catch (fetchError) {
+            throw new Error(`Failed to fetch base branch origin/${baseRef}. ` +
+                `This is required for PR diff comparison. Error: ${fetchError instanceof Error ? fetchError.message : 'Unknown error'}`);
+        }
+        logger_1.logger.debug(`PR context, using origin/${baseRef}..HEAD (two dots for direct comparison)`);
+        // Use two dots (..) instead of three dots (...) for direct comparison
+        // Three dots requires finding merge base which can fail with shallow clones
+        // Two dots shows all changes in HEAD that aren't in origin/${baseRef}
+        const diff = await git.diff([`origin/${baseRef}..HEAD`, '-U200']);
+        const diffSummary = await git.diffSummary([`origin/${baseRef}..HEAD`]);
         const changedFiles = diffSummary.files.map(f => f.file);
         return {
             diff: diff || '',
@@ -102,13 +111,15 @@ async function getDiff(repoRoot) {
         };
     }
     // Any push (main or feature branch): Review last commit only
-    const diff = await git.diff(['HEAD~1...HEAD', '-U200']);
-    const diffSummary = await git.diffSummary(['HEAD~1...HEAD']);
-    const changedFiles = diffSummary.files.map(f => f.file);
-    return {
-        diff: diff || '',
-        changedFiles
-    };
+    // Use git show HEAD - works with shallow clones and shows the commit diff
+    const diff = await git.show(['HEAD', '--format=', '--no-color', '-U200']);
+    // Extract changed files from git show
+    const showNameOnly = await git.show(['HEAD', '--name-only', '--format=', '--pretty=format:']);
+    const changedFiles = showNameOnly
+        .split('\n')
+        .filter(line => line.trim().length > 0)
+        .map(line => line.trim());
+    return { diff: diff || '', changedFiles };
 }
 /**
  * Gets repository name for GitHub Actions

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadlines",
-  "version": "0.2.10",
+  "version": "0.2.12",
   "description": "Threadlines CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {