threadlines 0.1.32 → 0.1.33

package/dist/commands/check.js

@@ -181,6 +181,14 @@ async function checkCommand(options) {
         }
         // 3. Collect metadata (commit SHA, commit message, PR title)
         const metadata = await (0, metadata_1.collectMetadata)(context, environment, repoRoot);
+        // Debug: Log collected metadata
+        console.log(`[DEBUG] Metadata after collectMetadata: ${JSON.stringify(metadata)}`);
+        if (metadata.commitAuthorName || metadata.commitAuthorEmail) {
+            console.log(chalk_1.default.gray(`   Author: ${metadata.commitAuthorName} <${metadata.commitAuthorEmail}>`));
+        }
+        else {
+            console.log(`[DEBUG] No author info - commitAuthorName=${metadata.commitAuthorName}, commitAuthorEmail=${metadata.commitAuthorEmail}`);
+        }
         if (gitDiff.changedFiles.length === 0) {
             console.error(chalk_1.default.red('❌ Error: No changes detected.'));
             console.error(chalk_1.default.red('   Threadline check requires code changes to analyze.'));
@@ -225,7 +233,7 @@ async function checkCommand(options) {
         // 6. Call review API
         console.log(chalk_1.default.gray('🤖 Running threadline checks...'));
         const client = new client_1.ReviewAPIClient(apiUrl);
-        const response = await client.review({
+        const reviewRequest = {
             threadlines: threadlinesWithContext,
             diff: gitDiff.diff,
             files: gitDiff.changedFiles,
@@ -235,9 +243,13 @@ async function checkCommand(options) {
             branchName: branchName,
             commitSha: metadata.commitSha,
             commitMessage: metadata.commitMessage,
+            commitAuthorName: metadata.commitAuthorName,
+            commitAuthorEmail: metadata.commitAuthorEmail,
             prTitle: metadata.prTitle,
             environment: environment
-        });
+        };
+        console.log(`[DEBUG] Sending to API - commitAuthorName: ${reviewRequest.commitAuthorName}, commitAuthorEmail: ${reviewRequest.commitAuthorEmail}`);
+        const response = await client.review(reviewRequest);
         // 7. Display results (with filtering if --full not specified)
         displayResults(response, options.full || false);
         // Exit with appropriate code
@@ -260,38 +272,68 @@ function displayResults(response, showFull) {
     if (message) {
         console.log('\n' + chalk_1.default.blue('ℹ️  ' + message));
     }
-    console.log('\n' + chalk_1.default.bold('Results:\n'));
-    console.log(chalk_1.default.gray(`${metadata.totalThreadlines} threadlines checked`));
     const notRelevant = results.filter((r) => r.status === 'not_relevant').length;
     const compliant = results.filter((r) => r.status === 'compliant').length;
     const attention = results.filter((r) => r.status === 'attention').length;
-    if (showFull) {
-        // Show all results when --full flag is used
-        if (notRelevant > 0) {
-            console.log(chalk_1.default.gray(`  ${notRelevant} not relevant`));
-        }
-        if (compliant > 0) {
-            console.log(chalk_1.default.green(`  ${compliant} compliant`));
-        }
-        if (attention > 0) {
-            console.log(chalk_1.default.yellow(`  ${attention} attention`));
-        }
+    const attentionItems = filteredResults.filter((r) => r.status === 'attention');
+    // Build summary parts
+    const summaryParts = [];
+    if (notRelevant > 0) {
+        summaryParts.push(`${notRelevant} not relevant`);
     }
-    else {
-        // Default: only show attention items
-        if (attention > 0) {
-            console.log(chalk_1.default.yellow(`  ${attention} attention`));
-        }
+    if (compliant > 0) {
+        summaryParts.push(`${compliant} compliant`);
+    }
+    if (attention > 0) {
+        summaryParts.push(`${attention} attention`);
     }
     if (metadata.timedOut > 0) {
-        console.log(chalk_1.default.yellow(`  ${metadata.timedOut} timed out`));
+        summaryParts.push(`${metadata.timedOut} timed out`);
     }
     if (metadata.errors > 0) {
-        console.log(chalk_1.default.red(`  ${metadata.errors} errors`));
+        summaryParts.push(`${metadata.errors} errors`);
+    }
+    // Display informational message if present (e.g., zero diffs)
+    if (message) {
+        console.log('\n' + chalk_1.default.blue('ℹ️  ' + message));
+    }
+    // Show success message with breakdown if no issues
+    if (attention === 0 && metadata.timedOut === 0 && metadata.errors === 0) {
+        const summary = summaryParts.length > 0 ? ` (${summaryParts.join(', ')})` : '';
+        console.log('\n' + chalk_1.default.green(`✓ Threadline check passed${summary}`));
+        console.log(chalk_1.default.gray(`  ${metadata.totalThreadlines} threadline${metadata.totalThreadlines !== 1 ? 's' : ''} checked\n`));
+    }
+    else {
+        // Show detailed breakdown when there are issues
+        console.log('\n' + chalk_1.default.bold('Results:\n'));
+        console.log(chalk_1.default.gray(`${metadata.totalThreadlines} threadlines checked`));
+        if (showFull) {
+            // Show all results when --full flag is used
+            if (notRelevant > 0) {
+                console.log(chalk_1.default.gray(`  ${notRelevant} not relevant`));
+            }
+            if (compliant > 0) {
+                console.log(chalk_1.default.green(`  ${compliant} compliant`));
+            }
+            if (attention > 0) {
+                console.log(chalk_1.default.yellow(`  ${attention} attention`));
+            }
+        }
+        else {
+            // Default: only show attention items
+            if (attention > 0) {
+                console.log(chalk_1.default.yellow(`  ${attention} attention`));
+            }
+        }
+        if (metadata.timedOut > 0) {
+            console.log(chalk_1.default.yellow(`  ${metadata.timedOut} timed out`));
+        }
+        if (metadata.errors > 0) {
+            console.log(chalk_1.default.red(`  ${metadata.errors} errors`));
+        }
+        console.log('');
     }
-    console.log('');
     // Show attention items
-    const attentionItems = filteredResults.filter((r) => r.status === 'attention');
     if (attentionItems.length > 0) {
         for (const item of attentionItems) {
             console.log(chalk_1.default.yellow(`⚠️  ${item.expertId}`));
@@ -308,15 +350,4 @@ function displayResults(response, showFull) {
         }
         console.log('');
     }
-    // Show compliant items (only when --full flag is used)
-    if (showFull) {
-        const compliantItems = filteredResults.filter((r) => r.status === 'compliant');
-        if (compliantItems.length > 0 && attentionItems.length === 0) {
-            console.log(chalk_1.default.green('✓ All threadlines passed!\n'));
-        }
-    }
-    else if (attentionItems.length === 0 && compliant > 0) {
-        // Default: show success message if no attention items
-        console.log(chalk_1.default.green('✓ All threadlines passed!\n'));
-    }
 }

package/dist/git/diff.js

@@ -5,6 +5,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getBranchDiff = getBranchDiff;
 exports.getCommitMessage = getCommitMessage;
+exports.getCommitAuthor = getCommitAuthor;
 exports.getCommitDiff = getCommitDiff;
 exports.getPRMRDiff = getPRMRDiff;
 const simple_git_1 = __importDefault(require("simple-git"));
@@ -197,6 +198,38 @@ async function getCommitMessage(repoRoot, sha) {
         return null;
     }
 }
+/**
+ * Get commit author name and email for a specific commit SHA or HEAD.
+ *
+ * Uses git log to extract author information from the commit.
+ * Works in all environments where git is available.
+ */
+async function getCommitAuthor(repoRoot, sha) {
+    const git = (0, simple_git_1.default)(repoRoot);
+    try {
+        let logResult;
+        if (sha) {
+            // Use git log for specific commit SHA
+            logResult = await git.log({ from: sha, to: sha, maxCount: 1 });
+        }
+        else {
+            // Use git log for HEAD (local environment only)
+            logResult = await git.log({ maxCount: 1 });
+        }
+        if (!logResult.latest) {
+            return null;
+        }
+        const name = logResult.latest.author_name?.trim();
+        const email = logResult.latest.author_email?.trim();
+        if (!name || !email) {
+            return null;
+        }
+        return { name, email };
+    }
+    catch {
+        return null;
+    }
+}
 /**
  * Get diff for a specific commit
  */

package/dist/utils/metadata.js

@@ -10,9 +10,47 @@
  * Metadata collection is environment-specific because each CI platform
  * provides different environment variables.
  */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.collectMetadata = collectMetadata;
 const diff_1 = require("../git/diff");
+const fs = __importStar(require("fs"));
+const simple_git_1 = __importDefault(require("simple-git"));
 /**
  * Collects metadata for the given context and environment.
  *
@@ -23,12 +61,29 @@ async function collectMetadata(context, environment, repoRoot) {
     const metadata = {};
     // Collect commit SHA (environment-specific)
     metadata.commitSha = getCommitSha(context, environment);
-    // Collect commit message (if we have a commit SHA)
+    // Collect commit message and author (environment-specific)
     if (metadata.commitSha) {
         const message = await (0, diff_1.getCommitMessage)(repoRoot, metadata.commitSha);
         if (message) {
             metadata.commitMessage = message;
         }
+        // Get commit author - environment-specific approach
+        const author = await getCommitAuthorForEnvironment(environment, repoRoot, metadata.commitSha);
+        if (author) {
+            metadata.commitAuthorName = author.name;
+            metadata.commitAuthorEmail = author.email;
+        }
+    }
+    else {
+        // For local environment without explicit commit SHA:
+        // Use git config (who will commit staged/unstaged changes)
+        // No fallbacks - if git config fails, the error propagates and fails the check
+        console.log('[DEBUG] Local environment - calling getGitConfigUser()');
+        const author = await getGitConfigUser(repoRoot);
+        console.log(`[DEBUG] getGitConfigUser returned: ${JSON.stringify(author)}`);
+        metadata.commitAuthorName = author.name;
+        metadata.commitAuthorEmail = author.email;
+        console.log(`[DEBUG] metadata after assignment: commitAuthorName=${metadata.commitAuthorName}, commitAuthorEmail=${metadata.commitAuthorEmail}`);
     }
     // Collect PR/MR title (environment-specific)
     metadata.prTitle = getPRTitle(context, environment);
@@ -69,6 +124,109 @@ function getCommitSha(context, environment) {
     }
     return undefined;
 }
+/**
+ * Gets commit author information using environment-specific methods.
+ *
+ * For GitHub: Reads from GITHUB_EVENT_PATH JSON file (most reliable)
+ * For GitLab: Uses CI_COMMIT_AUTHOR environment variable (most reliable)
+ * For Local: Uses git config (for uncommitted changes, represents who will commit)
+ * For other environments: Uses git log command
+ */
+async function getCommitAuthorForEnvironment(environment, repoRoot, commitSha) {
+    if (environment === 'github') {
+        // GitHub: Read from GITHUB_EVENT_PATH JSON file
+        // This is more reliable than git commands, especially in shallow clones
+        const eventPath = process.env.GITHUB_EVENT_PATH;
+        if (eventPath && fs.existsSync(eventPath)) {
+            try {
+                const eventData = JSON.parse(fs.readFileSync(eventPath, 'utf-8'));
+                // For push events, use head_commit.author
+                if (eventData.head_commit?.author) {
+                    return {
+                        name: eventData.head_commit.author.name,
+                        email: eventData.head_commit.author.email
+                    };
+                }
+                // For PR events, use commits[0].author (first commit in the PR)
+                if (eventData.commits && eventData.commits.length > 0 && eventData.commits[0].author) {
+                    return {
+                        name: eventData.commits[0].author.name,
+                        email: eventData.commits[0].author.email
+                    };
+                }
+                // Fallback to pull_request.head.commit.author for PR events
+                if (eventData.pull_request?.head?.commit?.author) {
+                    return {
+                        name: eventData.pull_request.head.commit.author.name,
+                        email: eventData.pull_request.head.commit.author.email
+                    };
+                }
+            }
+            catch (error) {
+                // If JSON parsing fails, fall through to git command
+                const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+                console.warn(`Warning: Failed to read GitHub event JSON: ${errorMessage}`);
+            }
+        }
+    }
+    if (environment === 'gitlab') {
+        // GitLab: Use CI_COMMIT_AUTHOR environment variable
+        // Format: "name <email>" (e.g., "ngrootscholten <niels.grootscholten@gmail.com>")
+        // This is more reliable than git commands, especially in shallow clones
+        const commitAuthor = process.env.CI_COMMIT_AUTHOR;
+        if (commitAuthor) {
+            // Parse "name <email>" format
+            const match = commitAuthor.match(/^(.+?)\s*<(.+?)>$/);
+            if (match) {
+                return {
+                    name: match[1].trim(),
+                    email: match[2].trim()
+                };
+            }
+            // If format doesn't match expected pattern, try to extract anyway
+            // Some GitLab versions might format differently
+            const parts = commitAuthor.trim().split(/\s+/);
+            if (parts.length >= 2) {
+                // Assume last part is email if it contains @
+                const emailIndex = parts.findIndex(p => p.includes('@'));
+                if (emailIndex >= 0) {
+                    const email = parts[emailIndex].replace(/[<>]/g, '').trim();
+                    const name = parts.slice(0, emailIndex).join(' ').trim();
+                    if (name && email) {
+                        return { name, email };
+                    }
+                }
+            }
+        }
+    }
+    // Fallback to git command for all environments (including GitHub/GitLab if env vars unavailable)
+    return await (0, diff_1.getCommitAuthor)(repoRoot, commitSha);
+}
+/**
+ * Gets git user info from git config (for local uncommitted changes).
+ * This represents who is currently working on the changes and will commit them.
+ *
+ * No fallbacks - if git config is not set or fails, throws an error.
+ */
+async function getGitConfigUser(repoRoot) {
+    const git = (0, simple_git_1.default)(repoRoot);
+    try {
+        const name = await git.getConfig('user.name');
+        const email = await git.getConfig('user.email');
+        if (!name.value || !email.value) {
+            throw new Error('Git config user.name or user.email is not set. ' +
+                'Run: git config user.name "Your Name" && git config user.email "your.email@example.com"');
+        }
+        return {
+            name: name.value.trim(),
+            email: email.value.trim()
+        };
+    }
+    catch (error) {
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        throw new Error(`Failed to get git config user: ${errorMessage}`);
+    }
+}
 /**
  * Extracts PR/MR title from context and environment.
  *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadlines",
-  "version": "0.1.32",
+  "version": "0.1.33",
   "description": "Threadline CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {
@@ -27,7 +27,7 @@
     "directory": "packages/cli"
   },
   "scripts": {
-    "build": "npm run check && (npm run threadlines || exit 0) && tsc",
+    "build": "npm run check && tsc",
     "dev": "tsc --watch",
     "start": "node dist/index.js",
     "prepublishOnly": "npm run build",