threadlines 0.1.27 → 0.1.29

package/dist/api/client.js

@@ -21,14 +21,16 @@ class ReviewAPIClient {
             return response.data;
         }
         catch (error) {
-            if (error.response) {
-                throw new Error(`API error: ${error.response.status} - ${error.response.data?.message || error.message}`);
+            if (error && typeof error === 'object' && 'response' in error) {
+                const axiosError = error;
+                throw new Error(`API error: ${axiosError.response.status} - ${axiosError.response.data?.message || axiosError.message || 'Unknown error'}`);
             }
-            else if (error.request) {
+            else if (error && typeof error === 'object' && 'request' in error) {
                 throw new Error(`Network error: Could not reach Threadline server at ${this.client.defaults.baseURL}`);
             }
             else {
-                throw new Error(`Request error: ${error.message}`);
+                const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+                throw new Error(`Request error: ${errorMessage}`);
             }
         }
     }

package/dist/commands/check.js

@@ -59,11 +59,8 @@ async function checkCommand(options) {
     // Pre-flight check: Validate ALL required environment variables at once
     const apiKey = (0, config_1.getThreadlineApiKey)();
     const account = (0, config_1.getThreadlineAccount)();
-    // Debug: Show what we got (masked for security)
-    console.log(chalk_1.default.gray(`  [Debug] THREADLINE_API_KEY: ${apiKey ? `"${apiKey.substring(0, 4)}..."` : 'undefined'}`));
-    console.log(chalk_1.default.gray(`  [Debug] THREADLINE_ACCOUNT: ${account ? `"${account.substring(0, 4)}..."` : 'undefined'}`));
     const missingVars = [];
-    // Check for undefined, empty string, or literal unexpanded variable
+    // Check for undefined, empty string, or literal unexpanded variable (GitLab keeps "$VAR" literal)
     if (!apiKey || apiKey.startsWith('$'))
         missingVars.push('THREADLINE_API_KEY');
     if (!account || account.startsWith('$'))
@@ -187,7 +184,6 @@ async function checkCommand(options) {
         if (gitDiff.changedFiles.length === 0) {
             console.error(chalk_1.default.red('❌ Error: No changes detected.'));
             console.error(chalk_1.default.red('   Threadline check requires code changes to analyze.'));
-            console.error(chalk_1.default.red('   This may indicate a problem with git diff detection.'));
             process.exit(1);
         }
         // Check for zero diff (files changed but no actual code changes)
@@ -249,7 +245,8 @@ async function checkCommand(options) {
         process.exit(hasAttention ? 1 : 0);
     }
     catch (error) {
-        console.error(chalk_1.default.red(`\n❌ Error: ${error.message}`));
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        console.error(chalk_1.default.red(`\n❌ Error: ${errorMessage}`));
         process.exit(1);
     }
 }

package/dist/commands/init.js

@@ -108,7 +108,8 @@ async function initCommand() {
         console.log(chalk_1.default.gray('     (Use npx --yes threadlines check in non-interactive environments)'));
     }
     catch (error) {
-        console.error(chalk_1.default.red(`\n❌ Error: ${error.message}`));
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        console.error(chalk_1.default.red(`\n❌ Error: ${errorMessage}`));
         process.exit(1);
     }
 }

package/dist/git/diff.js

@@ -45,7 +45,8 @@ async function getBranchDiff(repoRoot, branchName, baseBranch) {
             }
             catch (error) {
                 // If no previous commit, return empty (first commit)
-                console.log(`[DEBUG] No previous commit found (first commit or error): ${error.message || 'HEAD~1 does not exist'}`);
+                const errorMessage = error instanceof Error ? error.message : 'HEAD~1 does not exist';
+                console.log(`[DEBUG] No previous commit found (first commit or error): ${errorMessage}`);
                 return {
                     diff: '',
                     changedFiles: []
@@ -88,7 +89,8 @@ async function getBranchDiff(repoRoot, branchName, baseBranch) {
             }
         }
         catch (error) {
-            console.log(`[DEBUG] Upstream tracking branch not set for '${branchName}': ${error.message || 'no upstream configured'}`);
+            const errorMessage = error instanceof Error ? error.message : 'no upstream configured';
+            console.log(`[DEBUG] Upstream tracking branch not set for '${branchName}': ${errorMessage}`);
         }
         // Strategy 2: Try default branch from origin/HEAD (reliable if configured)
         try {
@@ -117,7 +119,8 @@ async function getBranchDiff(repoRoot, branchName, baseBranch) {
             }
         }
         catch (error) {
-            console.log(`[DEBUG] Default branch (refs/remotes/origin/HEAD) not configured: ${error.message || 'not found'}`);
+            const errorMessage = error instanceof Error ? error.message : 'not found';
+            console.log(`[DEBUG] Default branch (refs/remotes/origin/HEAD) not configured: ${errorMessage}`);
         }
         // Strategy 3: Try common branch names by checking remote refs first, then local branches
         // This works reliably in CI with fetch-depth: 0, and also works locally
@@ -146,7 +149,8 @@ async function getBranchDiff(repoRoot, branchName, baseBranch) {
                 }
             }
             catch (error) {
-                console.log(`[DEBUG] Remote branch 'origin/${candidate}' not found: ${error.message || 'does not exist'}`);
+                const errorMessage = error instanceof Error ? error.message : 'does not exist';
+                console.log(`[DEBUG] Remote branch 'origin/${candidate}' not found: ${errorMessage}`);
                 // If remote doesn't exist, also try local branch (especially for CI like Vercel)
                 try {
                     await git.revparse([candidate]);
@@ -154,7 +158,8 @@ async function getBranchDiff(repoRoot, branchName, baseBranch) {
                     return candidate;
                 }
                 catch (localError) {
-                    console.log(`[DEBUG] Local branch '${candidate}' also not found: ${localError.message || 'does not exist'}`);
+                    const localErrorMessage = localError instanceof Error ? localError.message : 'does not exist';
+                    console.log(`[DEBUG] Local branch '${candidate}' also not found: ${localErrorMessage}`);
                     // Continue to next candidate
                 }
             }
@@ -187,7 +192,7 @@ async function getCommitMessage(repoRoot, sha) {
         const message = await git.show([sha, '--format=%B', '--no-patch']);
         return message.trim() || null;
     }
-    catch (error) {
+    catch {
         // Commit not found or invalid
         return null;
     }
@@ -225,7 +230,9 @@ async function getCommitDiff(repoRoot, sha) {
             changedFiles = diffSummary.files.map(f => f.file);
         }
         catch (diffError) {
-            throw new Error(`Commit ${sha} not found or invalid: ${error.message || diffError.message}`);
+            const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+            const diffErrorMessage = diffError instanceof Error ? diffError.message : 'Unknown error';
+            throw new Error(`Commit ${sha} not found or invalid: ${errorMessage || diffErrorMessage}`);
         }
     }
     return {

package/dist/git/file.js

@@ -57,7 +57,7 @@ async function getFileContent(repoRoot, filePath) {
     const content = fs.readFileSync(fullPath, 'utf-8');
     // Create artificial diff (all lines as additions)
     const lines = content.split('\n');
-    const diff = lines.map((line, index) => `+${line}`).join('\n');
+    const diff = lines.map((line) => `+${line}`).join('\n');
     // Add diff header
     const diffHeader = `--- /dev/null\n+++ ${filePath}\n@@ -0,0 +1,${lines.length} @@\n`;
     const fullDiff = diffHeader + diff;
@@ -108,14 +108,15 @@ async function getFolderContent(repoRoot, folderPath) {
             const content = fs.readFileSync(path.resolve(repoRoot, filePath), 'utf-8');
             const lines = content.split('\n');
             // Create artificial diff for this file
-            const fileDiff = lines.map((line, index) => `+${line}`).join('\n');
+            const fileDiff = lines.map((line) => `+${line}`).join('\n');
             const diffHeader = `--- /dev/null\n+++ ${filePath}\n@@ -0,0 +1,${lines.length} @@\n`;
             diffs.push(diffHeader + fileDiff);
             changedFiles.push(filePath);
         }
         catch (error) {
             // Skip files that can't be read (permissions, etc.)
-            console.warn(`Warning: Could not read file '${filePath}': ${error.message}`);
+            const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+            console.warn(`Warning: Could not read file '${filePath}': ${errorMessage}`);
         }
     }
     return {
@@ -147,7 +148,7 @@ async function getMultipleFilesContent(repoRoot, filePaths) {
         const content = fs.readFileSync(fullPath, 'utf-8');
         const lines = content.split('\n');
         // Create artificial diff for this file
-        const fileDiff = lines.map((line, index) => `+${line}`).join('\n');
+        const fileDiff = lines.map((line) => `+${line}`).join('\n');
         const diffHeader = `--- /dev/null\n+++ ${filePath}\n@@ -0,0 +1,${lines.length} @@\n`;
         diffs.push(diffHeader + fileDiff);
         changedFiles.push(filePath);

package/dist/git/github-diff.js

@@ -87,8 +87,9 @@ async function getGitHubDiff(repoRoot) {
         }
         catch (error) {
             // If we can't get the diff (e.g., first commit on branch), throw a clear error
+            const errorMessage = error instanceof Error ? error.message : 'Unknown error';
             throw new Error(`Could not get diff for default branch '${defaultBranch}'. ` +
-                `This might be the first commit on the branch. Error: ${error.message}`);
+                `This might be the first commit on the branch. Error: ${errorMessage}`);
         }
     }
     // Scenario 3: Feature Branch Push

package/dist/git/repo.js

@@ -54,7 +54,7 @@ const path = __importStar(require("path"));
  * Uses GITHUB_REPOSITORY environment variable (format: "owner/repo").
  * This is the ONLY method for GitHub - no fallbacks, no alternatives.
  */
-async function getGitHubRepoName(repoRoot) {
+async function getGitHubRepoName(_repoRoot) {
     const githubRepo = process.env.GITHUB_REPOSITORY;
     if (!githubRepo) {
         throw new Error('GitHub Actions: GITHUB_REPOSITORY environment variable is not set. ' +
@@ -69,7 +69,7 @@ async function getGitHubRepoName(repoRoot) {
  * Uses VERCEL_GIT_REPO_OWNER and VERCEL_GIT_REPO_SLUG environment variables.
  * This is the ONLY method for Vercel - no fallbacks, no alternatives.
  */
-async function getVercelRepoName(repoRoot) {
+async function getVercelRepoName(_repoRoot) {
     const owner = process.env.VERCEL_GIT_REPO_OWNER;
     const slug = process.env.VERCEL_GIT_REPO_SLUG;
     if (!owner || !slug) {
@@ -103,11 +103,12 @@ async function getLocalRepoName(repoRoot) {
     }
     catch (error) {
         // If it's already our error, re-throw it
-        if (error.message.includes('Local:')) {
+        if (error instanceof Error && error.message.includes('Local:')) {
             throw error;
         }
         // Otherwise, wrap it
-        throw new Error(`Local: Failed to get repository name from git: ${error.message}`);
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        throw new Error(`Local: Failed to get repository name from git: ${errorMessage}`);
     }
 }
 /**
@@ -116,7 +117,7 @@ async function getLocalRepoName(repoRoot) {
  * Uses GITHUB_REF_NAME environment variable.
  * This is the ONLY method for GitHub - no fallbacks, no alternatives.
  */
-async function getGitHubBranchName(repoRoot) {
+async function getGitHubBranchName(_repoRoot) {
     const refName = process.env.GITHUB_REF_NAME;
     if (!refName) {
         throw new Error('GitHub Actions: GITHUB_REF_NAME environment variable is not set. ' +
@@ -130,7 +131,7 @@ async function getGitHubBranchName(repoRoot) {
  * Uses VERCEL_GIT_COMMIT_REF environment variable.
  * This is the ONLY method for Vercel - no fallbacks, no alternatives.
  */
-async function getVercelBranchName(repoRoot) {
+async function getVercelBranchName(_repoRoot) {
     const branchName = process.env.VERCEL_GIT_COMMIT_REF;
     if (!branchName) {
         throw new Error('Vercel: VERCEL_GIT_COMMIT_REF environment variable is not set. ' +
@@ -168,11 +169,12 @@ async function getLocalBranchName(repoRoot) {
     }
     catch (error) {
         // If it's already our error, re-throw it
-        if (error.message.includes('Local:')) {
+        if (error instanceof Error && error.message.includes('Local:')) {
             throw error;
         }
         // Otherwise, wrap it
-        throw new Error(`Local: Failed to get branch name from git: ${error.message}`);
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        throw new Error(`Local: Failed to get branch name from git: ${errorMessage}`);
     }
 }
 /**
@@ -181,7 +183,7 @@ async function getLocalBranchName(repoRoot) {
  * Uses CI_PROJECT_URL environment variable.
  * This is the ONLY method for GitLab - no fallbacks, no alternatives.
  */
-async function getGitLabRepoName(repoRoot) {
+async function getGitLabRepoName(_repoRoot) {
     const projectUrl = process.env.CI_PROJECT_URL;
     if (!projectUrl) {
         throw new Error('GitLab CI: CI_PROJECT_URL environment variable is not set. ' +
@@ -197,7 +199,7 @@ async function getGitLabRepoName(repoRoot) {
  * Uses CI_COMMIT_REF_NAME environment variable.
  * This is the ONLY method for GitLab - no fallbacks, no alternatives.
  */
-async function getGitLabBranchName(repoRoot) {
+async function getGitLabBranchName(_repoRoot) {
     const refName = process.env.CI_COMMIT_REF_NAME;
     if (!refName) {
         throw new Error('GitLab CI: CI_COMMIT_REF_NAME environment variable is not set. ' +
@@ -217,7 +219,7 @@ async function getGitLabBranchName(repoRoot) {
  * Returns the branch name (e.g., "main", "master") without the "origin/" prefix.
  * Throws an error if the default branch cannot be detected.
  */
-async function getDefaultBranchName(repoRoot) {
+async function getDefaultBranchName(_repoRoot) {
     // GitHub Actions provides GITHUB_EVENT_PATH which contains repository.default_branch
     const githubEventPath = process.env.GITHUB_EVENT_PATH;
     if (!githubEventPath) {
@@ -240,11 +242,12 @@ async function getDefaultBranchName(repoRoot) {
     }
     catch (error) {
         // If it's already our error, re-throw it
-        if (error.message.includes('GITHUB_EVENT_PATH') || error.message.includes('default_branch')) {
+        if (error instanceof Error && (error.message.includes('GITHUB_EVENT_PATH') || error.message.includes('default_branch'))) {
             throw error;
         }
         // Otherwise, wrap it
-        throw new Error(`Failed to read or parse GITHUB_EVENT_PATH: ${error.message}. ` +
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+        throw new Error(`Failed to read or parse GITHUB_EVENT_PATH: ${errorMessage}. ` +
             'This should be automatically provided by GitHub Actions.');
     }
 }

package/dist/utils/git-diff-executor.js

@@ -26,7 +26,7 @@ const gitlab_diff_1 = require("../git/gitlab-diff");
  * No fallbacks - if the environment-specific implementation fails, we fail clearly.
  * Each environment is completely isolated - changes to one don't affect others.
  */
-async function getDiffForEnvironment(environment, repoRoot, context) {
+async function getDiffForEnvironment(environment, repoRoot, _context) {
     switch (environment) {
         case 'vercel':
             // Vercel: Single implementation using commit SHA

package/dist/validators/experts.js

@@ -85,7 +85,7 @@ async function validateThreadline(filePath, repoRoot) {
         if (frontmatter.patterns && !Array.isArray(frontmatter.patterns)) {
             errors.push('patterns must be an array');
         }
-        if (frontmatter.patterns && frontmatter.patterns.length === 0) {
+        if (Array.isArray(frontmatter.patterns) && frontmatter.patterns.length === 0) {
             errors.push('patterns array cannot be empty');
         }
         // Validate context_files if present
@@ -96,9 +96,11 @@ async function validateThreadline(filePath, repoRoot) {
             else {
                 // Check if context files exist
                 for (const contextFile of frontmatter.context_files) {
-                    const fullPath = path.join(repoRoot, contextFile);
-                    if (!fs.existsSync(fullPath)) {
-                        errors.push(`Context file not found: ${contextFile}`);
+                    if (typeof contextFile === 'string') {
+                        const fullPath = path.join(repoRoot, contextFile);
+                        if (!fs.existsSync(fullPath)) {
+                            errors.push(`Context file not found: ${contextFile}`);
+                        }
                     }
                 }
             }
@@ -108,26 +110,28 @@ async function validateThreadline(filePath, repoRoot) {
             errors.push('Threadline body cannot be empty');
         }
         // Validate version format (basic semver check)
-        if (frontmatter.version && !/^\d+\.\d+\.\d+/.test(frontmatter.version)) {
+        if (frontmatter.version && typeof frontmatter.version === 'string' && !/^\d+\.\d+\.\d+/.test(frontmatter.version)) {
             errors.push('version must be in semver format (e.g., 1.0.0)');
         }
         if (errors.length > 0) {
             return { valid: false, errors };
         }
+        // Type assertions for required fields (already validated above)
         const threadline = {
             id: frontmatter.id,
             version: frontmatter.version,
             patterns: frontmatter.patterns,
-            contextFiles: frontmatter.context_files || [],
+            contextFiles: (Array.isArray(frontmatter.context_files) ? frontmatter.context_files.filter((f) => typeof f === 'string') : []),
             content: body,
             filePath: path.relative(repoRoot, filePath)
         };
         return { valid: true, threadline };
     }
     catch (error) {
+        const errorMessage = error instanceof Error ? error.message : 'Unknown error';
         return {
             valid: false,
-            errors: [`Failed to parse threadline file: ${error.message}`]
+            errors: [`Failed to parse threadline file: ${errorMessage}`]
         };
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "threadlines",
-  "version": "0.1.27",
+  "version": "0.1.29",
   "description": "Threadline CLI - AI-powered linter based on your natural language documentation",
   "main": "dist/index.js",
   "bin": {
@@ -27,10 +27,17 @@
     "directory": "packages/cli"
   },
   "scripts": {
-    "build": "tsc",
+    "build": "npm run check && (npm run threadlines || exit 0) && tsc",
     "dev": "tsc --watch",
     "start": "node dist/index.js",
-    "prepublishOnly": "npm run build"
+    "prepublishOnly": "npm run build",
+    "lint": "eslint src/**/*.ts",
+    "lint:fix": "eslint src/**/*.ts --fix",
+    "typecheck": "tsc --noEmit",
+    "check": "npm run lint && npm run typecheck",
+    "threadlines": "npx -y threadlines check",
+    "threadlines:local": "npx -y threadlines check || true",
+    "check:all": "npm run check && npm run threadlines"
   },
   "dependencies": {
     "axios": "^1.7.9",
@@ -45,6 +52,9 @@
     "@types/glob": "^8.1.0",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "^22.10.2",
+    "@typescript-eslint/eslint-plugin": "^8.51.0",
+    "@typescript-eslint/parser": "^8.51.0",
+    "eslint": "^9.39.2",
     "typescript": "^5.7.2"
   }
 }