thread-stream 3.1.0 → 4.0.0

package/test/bench.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
 const { join } = require('path')
 const ThreadStream = require('..')
 const { file } = require('./helper')
@@ -13,7 +13,7 @@ for (let i = 0; i < 10; i++) {
   str += 'hello'
 }
 
-test('base', function (t) {
+test('base', function (t, done) {
   const dest = file()
   const stream = new ThreadStream({
     filename: join(__dirname, 'to-file.js'),
@@ -33,6 +33,6 @@ test('base', function (t) {
   }
   benchThreadStream()
   stream.on('finish', function () {
-    t.end()
+    done()
   })
 })

package/test/bundlers.test.js

@@ -1,13 +1,12 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const { join } = require('path')
 const { file } = require('./helper')
 const ThreadStream = require('..')
 
-test('bundlers support with .js file', function (t) {
-  t.plan(1)
-
+test('bundlers support with .js file', function (t, done) {
   globalThis.__bundlerPathsOverrides = {
     'thread-stream-worker': join(__dirname, 'custom-worker.js')
   }
@@ -26,15 +25,14 @@ test('bundlers support with .js file', function (t) {
 
   stream.worker.removeAllListeners('message')
   stream.worker.once('message', message => {
-    t.equal(message.code, 'CUSTOM-WORKER-CALLED')
+    assert.strictEqual(message.code, 'CUSTOM-WORKER-CALLED')
+    done()
   })
 
   stream.end()
 })
 
-test('bundlers support with .mjs file', function (t) {
-  t.plan(1)
-
+test('bundlers support with .mjs file', function (t, done) {
   globalThis.__bundlerPathsOverrides = {
     'thread-stream-worker': join(__dirname, 'custom-worker.js')
   }
@@ -53,7 +51,8 @@ test('bundlers support with .mjs file', function (t) {
 
   stream.worker.removeAllListeners('message')
   stream.worker.once('message', message => {
-    t.equal(message.code, 'CUSTOM-WORKER-CALLED')
+    assert.strictEqual(message.code, 'CUSTOM-WORKER-CALLED')
+    done()
   })
 
   stream.end()

package/test/commonjs-fallback.test.js

@@ -1,6 +1,7 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const { join } = require('path')
 const { MessageChannel } = require('worker_threads')
 const { once } = require('events')
@@ -8,11 +9,9 @@ const ThreadStream = require('..')
 
 const isYarnPnp = process.versions.pnp !== undefined
 
-test('yarn module resolution', { skip: !isYarnPnp }, t => {
-  t.plan(6)
-
+test('yarn module resolution', { skip: !isYarnPnp }, (t, done) => {
   const modulePath = require.resolve('pino-elasticsearch')
-  t.match(modulePath, /.*\.zip.*/)
+  assert.match(modulePath, /.*\.zip.*/)
 
   const stream = new ThreadStream({
     filename: modulePath,
@@ -20,20 +19,18 @@ test('yarn module resolution', { skip: !isYarnPnp }, t => {
     sync: true
   })
 
-  t.same(stream.writableErrored, null)
+  assert.deepStrictEqual(stream.writableErrored, null)
   stream.on('error', (err) => {
-    t.same(stream.writableErrored, err)
-    t.pass('error emitted')
+    assert.deepStrictEqual(stream.writableErrored, err)
   })
 
-  t.ok(stream.write('hello world\n'))
-  t.ok(stream.writable)
+  assert.ok(stream.write('hello world\n'))
+  assert.ok(stream.writable)
   stream.end()
+  done()
 })
 
 test('yarn module resolution for directories with special characters', { skip: !isYarnPnp }, async t => {
-  t.plan(3)
-
   const { port1, port2 } = new MessageChannel()
   const stream = new ThreadStream({
     filename: join(__dirname, 'dir with spaces', 'test-package.zip', 'worker.js'),
@@ -43,21 +40,19 @@ test('yarn module resolution for directories with special characters', { skip: !
     },
     sync: false
   })
-  t.teardown(() => {
+  t.after(() => {
     stream.end()
   })
 
-  t.ok(stream.write('hello world\n'))
-  t.ok(stream.write('something else\n'))
+  assert.ok(stream.write('hello world\n'))
+  assert.ok(stream.write('something else\n'))
 
   const [strings] = await once(port2, 'message')
 
-  t.equal(strings, 'hello world\nsomething else\n')
+  assert.strictEqual(strings, 'hello world\nsomething else\n')
 })
 
 test('yarn module resolution for typescript commonjs modules', { skip: !isYarnPnp }, async t => {
-  t.plan(3)
-
   const { port1, port2 } = new MessageChannel()
   const stream = new ThreadStream({
     filename: join(__dirname, 'ts-commonjs-default-export.zip', 'worker.js'),
@@ -67,14 +62,14 @@ test('yarn module resolution for typescript commonjs modules', { skip: !isYarnPn
     },
     sync: false
   })
-  t.teardown(() => {
+  t.after(() => {
     stream.end()
   })
 
-  t.ok(stream.write('hello world\n'))
-  t.ok(stream.write('something else\n'))
+  assert.ok(stream.write('hello world\n'))
+  assert.ok(stream.write('something else\n'))
 
   const [strings] = await once(port2, 'message')
 
-  t.equal(strings, 'hello world\nsomething else\n')
+  assert.strictEqual(strings, 'hello world\nsomething else\n')
 })

package/test/context.test.js

@@ -1,21 +1,21 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const { join } = require('path')
 const ThreadStream = require('..')
 const { version } = require('../package.json')
-require('why-is-node-running')
 
-test('get context', (t) => {
+test('get context', (t, done) => {
   const stream = new ThreadStream({
     filename: join(__dirname, 'get-context.js'),
     workerData: {},
     sync: true
   })
-  t.on('end', () => stream.end())
+  t.after(() => stream.end())
   stream.on('context', (ctx) => {
-    t.same(ctx.threadStreamVersion, version)
-    t.end()
+    assert.deepStrictEqual(ctx.threadStreamVersion, version)
+    done()
   })
   stream.write('hello')
 })

package/test/end.test.js

@@ -1,14 +1,13 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const { join } = require('path')
 const { readFile } = require('fs')
 const { file } = require('./helper')
 const ThreadStream = require('..')
 
-test('destroy support', function (t) {
-  t.plan(7)
-
+test('destroy support', function (t, done) {
   const dest = file()
   const stream = new ThreadStream({
     filename: join(__dirname, 'to-file-on-destroy.js'),
@@ -17,25 +16,22 @@ test('destroy support', function (t) {
   })
 
   stream.on('close', () => {
-    t.notOk(stream.writable)
-    t.pass('close emitted')
+    assert.ok(!stream.writable)
+    readFile(dest, 'utf8', (err, data) => {
+      assert.ifError(err)
+      assert.strictEqual(data, 'hello world\nsomething else\n')
+      done()
+    })
   })
 
-  t.ok(stream.write('hello world\n'))
-  t.ok(stream.write('something else\n'))
-  t.ok(stream.writable)
+  assert.ok(stream.write('hello world\n'))
+  assert.ok(stream.write('something else\n'))
+  assert.ok(stream.writable)
 
   stream.end()
-
-  readFile(dest, 'utf8', (err, data) => {
-    t.error(err)
-    t.equal(data, 'hello world\nsomething else\n')
-  })
 })
 
-test('synchronous _final support', function (t) {
-  t.plan(7)
-
+test('synchronous _final support', function (t, done) {
   const dest = file()
   const stream = new ThreadStream({
     filename: join(__dirname, 'to-file-on-final.js'),
@@ -44,18 +40,17 @@ test('synchronous _final support', function (t) {
   })
 
   stream.on('close', () => {
-    t.notOk(stream.writable)
-    t.pass('close emitted')
+    assert.ok(!stream.writable)
+    readFile(dest, 'utf8', (err, data) => {
+      assert.ifError(err)
+      assert.strictEqual(data, 'hello world\nsomething else\n')
+      done()
+    })
   })
 
-  t.ok(stream.write('hello world\n'))
-  t.ok(stream.write('something else\n'))
-  t.ok(stream.writable)
+  assert.ok(stream.write('hello world\n'))
+  assert.ok(stream.write('something else\n'))
+  assert.ok(stream.writable)
 
   stream.end()
-
-  readFile(dest, 'utf8', (err, data) => {
-    t.error(err)
-    t.equal(data, 'hello world\nsomething else\n')
-  })
 })

package/test/esm.test.mjs

@@ -1,4 +1,5 @@
-import { test } from 'tap'
+import { test } from 'node:test'
+import assert from 'node:assert'
 import { readFile } from 'fs'
 import ThreadStream from '../index.js'
 import { join } from 'desm'
@@ -6,9 +7,7 @@ import { pathToFileURL } from 'url'
 import { file } from './helper.js'
 
 function basic (text, filename) {
-  test(text, function (t) {
-    t.plan(5)
-
+  test(text, function (t, done) {
     const dest = file()
     const stream = new ThreadStream({
       filename,
@@ -18,17 +17,17 @@ function basic (text, filename) {
 
     stream.on('finish', () => {
       readFile(dest, 'utf8', (err, data) => {
-        t.error(err)
-        t.equal(data, 'hello world\nsomething else\n')
+        assert.ifError(err)
+        assert.strictEqual(data, 'hello world\nsomething else\n')
       })
     })
 
     stream.on('close', () => {
-      t.pass('close emitted')
+      done()
     })
 
-    t.ok(stream.write('hello world\n'))
-    t.ok(stream.write('something else\n'))
+    assert.ok(stream.write('hello world\n'))
+    assert.ok(stream.write('something else\n'))
 
     stream.end()
   })

package/test/event.test.js

@@ -1,23 +1,24 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const { join } = require('path')
 const ThreadStream = require('..')
 
-test('event propagate', t => {
+test('event propagate', (t, done) => {
   const stream = new ThreadStream({
     filename: join(__dirname, 'emit-event.js'),
     workerData: {},
     sync: true
   })
-  t.on('end', () => stream.end())
+  t.after(() => stream.end())
   stream.on('socketError', function (a, b, c, n, error) {
-    t.same(a, 'list')
-    t.same(b, 'of')
-    t.same(c, 'args')
-    t.same(n, 123)
-    t.same(error, new Error('unable to write data to the TCP socket'))
-    t.end()
+    assert.deepStrictEqual(a, 'list')
+    assert.deepStrictEqual(b, 'of')
+    assert.deepStrictEqual(c, 'args')
+    assert.deepStrictEqual(n, 123)
+    assert.deepStrictEqual(error, new Error('unable to write data to the TCP socket'))
+    done()
   })
   stream.write('hello')
 })

package/test/helper.js

@@ -3,7 +3,6 @@
 const { join } = require('path')
 const { tmpdir } = require('os')
 const { unlinkSync } = require('fs')
-const t = require('tap')
 
 const files = []
 let count = 0
@@ -15,21 +14,13 @@ function file () {
 }
 
 process.on('beforeExit', () => {
-  t.comment('unlink files')
   for (const file of files) {
     try {
-      t.comment(`unliking ${file}`)
       unlinkSync(file)
     } catch (e) {
-      console.log(e)
+      // ignore cleanup errors
     }
   }
-  t.comment('unlink completed')
 })
 
 module.exports.file = file
-
-if (process.env.SKIP_PROCESS_EXIT_CHECK !== 'true') {
-  const why = require('why-is-node-running')
-  setInterval(why, 10000).unref()
-}

package/test/indexes.test.js

@@ -1,11 +1,11 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const indexes = require('../lib/indexes')
 
 for (const index of Object.keys(indexes)) {
-  test(`${index} is lock free`, function (t) {
-    t.equal(Atomics.isLockFree(indexes[index]), true)
-    t.end()
+  test(`${index} is lock free`, function () {
+    assert.strictEqual(Atomics.isLockFree(indexes[index]), true)
   })
 }

package/test/multibyte-chars.test.mjs

@@ -1,11 +1,11 @@
-import { test } from 'tap'
+import { test } from 'node:test'
+import assert from 'node:assert'
 import { readFile } from 'fs'
 import ThreadStream from '../index.js'
 import { join } from 'desm'
 import { file } from './helper.js'
 
-test('break up utf8 multibyte (sync)', (t) => {
-  t.plan(2)
+test('break up utf8 multibyte (sync)', (t, done) => {
   const longString = '\u03A3'.repeat(16)
 
   const dest = file()
@@ -18,8 +18,9 @@ test('break up utf8 multibyte (sync)', (t) => {
 
   stream.on('finish', () => {
     readFile(dest, 'utf8', (err, data) => {
-      t.error(err)
-      t.equal(data, longString)
+      assert.ifError(err)
+      assert.strictEqual(data, longString)
+      done()
     })
   })
 
@@ -27,8 +28,7 @@ test('break up utf8 multibyte (sync)', (t) => {
   stream.end()
 })
 
-test('break up utf8 multibyte (async)', (t) => {
-  t.plan(2)
+test('break up utf8 multibyte (async)', (t, done) => {
   const longString = '\u03A3'.repeat(16)
 
   const dest = file()
@@ -41,8 +41,9 @@ test('break up utf8 multibyte (async)', (t) => {
 
   stream.on('finish', () => {
     readFile(dest, 'utf8', (err, data) => {
-      t.error(err)
-      t.equal(data, longString)
+      assert.ifError(err)
+      assert.strictEqual(data, longString)
+      done()
     })
   })
 
@@ -50,8 +51,7 @@ test('break up utf8 multibyte (async)', (t) => {
   stream.end()
 })
 
-test('break up utf8 multibyte several times bigger than write buffer', (t) => {
-  t.plan(2)
+test('break up utf8 multibyte several times bigger than write buffer', (t, done) => {
   const longString = '\u03A3'.repeat(32)
 
   const dest = file()
@@ -64,8 +64,9 @@ test('break up utf8 multibyte several times bigger than write buffer', (t) => {
 
   stream.on('finish', () => {
     readFile(dest, 'utf8', (err, data) => {
-      t.error(err)
-      t.equal(data, longString)
+      assert.ifError(err)
+      assert.strictEqual(data, longString)
+      done()
     })
   })
 

package/test/pkg/index.js

@@ -1,37 +1,37 @@
 'use strict'
 
 /**
- * This file is packaged using pkg in order to test if worker.js works in that context
+ * This file is packaged using pkg in order to test if worker.js works in that context.
+ * Note: We can't use node:test here because it crashes inside pkg bundles due to V8 internals.
  */
 
-const { test } = require('tap')
+const assert = require('node:assert')
 const { join } = require('path')
 const { file } = require('../helper')
 const ThreadStream = require('../..')
 
-test('bundlers support with .js file', function (t) {
-  t.plan(1)
+globalThis.__bundlerPathsOverrides = {
+  'thread-stream-worker': join(__dirname, '..', 'custom-worker.js')
+}
 
-  globalThis.__bundlerPathsOverrides = {
-    'thread-stream-worker': join(__dirname, '..', 'custom-worker.js')
-  }
+const dest = file()
 
-  const dest = file()
-
-  process.on('uncaughtException', (error) => {
-    console.log(error)
-  })
-
-  const stream = new ThreadStream({
-    filename: join(__dirname, '..', 'to-file.js'),
-    workerData: { dest },
-    sync: true
-  })
+process.on('uncaughtException', (error) => {
+  console.error(error)
+  process.exit(1)
+})
 
-  stream.worker.removeAllListeners('message')
-  stream.worker.once('message', (message) => {
-    t.equal(message.code, 'CUSTOM-WORKER-CALLED')
-  })
+const stream = new ThreadStream({
+  filename: join(__dirname, '..', 'to-file.js'),
+  workerData: { dest },
+  sync: true
+})
 
-  stream.end()
+stream.worker.removeAllListeners('message')
+stream.worker.once('message', (message) => {
+  assert.strictEqual(message.code, 'CUSTOM-WORKER-CALLED')
+  console.log('pkg test passed')
+  process.exit(0)
 })
+
+stream.end()

package/test/pkg/pkg.config.json

@@ -5,10 +5,9 @@
             "../to-file.js"
         ],
         "targets": [
-            "node14",
-            "node16",
-            "node18",
-            "node20"
+            "node20",
+            "node22",
+            "node24"
         ],
         "outputPath": "test/pkg"
     }

package/test/pkg/pkg.test.js

@@ -1,6 +1,7 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const config = require('./pkg.config.json')
 const { promisify } = require('util')
 const { unlink } = require('fs/promises')
@@ -8,7 +9,7 @@ const { join } = require('path')
 const { platform } = require('process')
 const exec = promisify(require('child_process').exec)
 
-test('worker test when packaged into executable using pkg', async (t) => {
+test('worker test when packaged into executable using pkg', async () => {
   const packageName = 'index'
 
   // package the app into several node versions, check config for more info
@@ -19,7 +20,7 @@ test('worker test when packaged into executable using pkg', async (t) => {
   const { stderr } = await exec(`npx pkg ${filePath} --config ${configPath}`)
 
   // there should be no error when packaging
-  t.equal(stderr, '')
+  assert.strictEqual(stderr, '')
 
   // pkg outputs files in the following format by default: {filename}-{node version}
   for (const target of config.pkg.targets) {
@@ -36,11 +37,9 @@ test('worker test when packaged into executable using pkg', async (t) => {
     const { stderr } = await exec(executablePath)
 
     // check if there were no errors
-    t.equal(stderr, '')
+    assert.strictEqual(stderr, '')
 
     // clean up afterwards
     await unlink(executablePath)
   }
-
-  t.end()
 })

package/test/post-message.test.js

@@ -1,24 +1,23 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
+const assert = require('node:assert')
 const { join } = require('path')
 const { once } = require('events')
 const { MessageChannel } = require('worker_threads')
 const ThreadStream = require('..')
 
 test('message events emitted on the stream are posted to the worker', async function (t) {
-  t.plan(1)
-
   const { port1, port2 } = new MessageChannel()
   const stream = new ThreadStream({
     filename: join(__dirname, 'on-message.js'),
     sync: false
   })
-  t.teardown(() => {
+  t.after(() => {
     stream.end()
   })
 
   stream.emit('message', { text: 'hello', takeThisPortPlease: port1 }, [port1])
   const [confirmation] = await once(port2, 'message')
-  t.equal(confirmation, 'received: hello')
+  assert.strictEqual(confirmation, 'received: hello')
 })