thread-stream 0.15.0 → 1.0.0

package/.github/workflows/ci.yml

@@ -12,9 +12,12 @@ jobs:
   test:
     runs-on: ${{ matrix.os }}
 
+    permissions:
+      contents: read
+
     strategy:
       matrix:
-        node-version: [12, 14, 16]
+        node-version: [14, 16, 18]
         os: [macos-latest, ubuntu-latest, windows-latest]
 
     steps:
@@ -55,7 +58,10 @@ jobs:
   automerge:
     needs: test
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+      contents: write
     steps:
-      - uses: fastify/github-action-merge-dependabot@v2.7.1
+      - uses: fastify/github-action-merge-dependabot@v3
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

package/.github/workflows/package-manager-ci.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       matrix:
         os: [macOS-latest, windows-latest]
-        node-version: [12, 14, 16]
+        node-version: [14, 16, 18]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -38,7 +38,7 @@ jobs:
     strategy:
       matrix:
         os: [macOS-latest]
-        node-version: [12, 14, 16]
+        node-version: [14, 16, 18]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}

package/README.md

@@ -2,7 +2,6 @@
 [![npm version](https://img.shields.io/npm/v/thread-stream)](https://www.npmjs.com/package/thread-stream)
 [![Build Status](https://img.shields.io/github/workflow/status/pinojs/thread-stream/CI)](https://github.com/pinojs/thread-stream/actions)
 [![Known Vulnerabilities](https://snyk.io/test/github/pinojs/thread-stream/badge.svg)](https://snyk.io/test/github/pinojs/thread-stream)
-[![Coverage Status](https://coveralls.io/repos/github/pinojs/thread-stream/badge.svg?branch=master)](https://coveralls.io/github/pinojs/thread-stream?branch=master)
 [![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](https://standardjs.com/)
 
 A streaming way to send data to a Node.js Worker Thread.

package/index.js

@@ -251,7 +251,7 @@ class ThreadStream extends EventEmitter {
 
   end () {
     if (this[kImpl].destroyed) {
-      throw new Error('the worker has exited')
+      return
     }
 
     this[kImpl].ending = true
@@ -286,7 +286,7 @@ class ThreadStream extends EventEmitter {
 
   flushSync () {
     if (this[kImpl].destroyed) {
-      throw new Error('the worker has exited')
+      return
     }
 
     writeSync(this)

package/lib/worker.js

@@ -19,16 +19,16 @@ const data = Buffer.from(dataBuf)
 async function start () {
   let fn
   try {
-    // TODO: fix loading .ts files in Windows. See: ../test/ts.test.ts
     if (filename.endsWith('.ts') || filename.endsWith('.cts')) {
       // TODO: add support for the TSM modules loader ( https://github.com/lukeed/tsm ).
-      if (process[Symbol.for('ts-node.register.instance')]) {
+      if (!process[Symbol.for('ts-node.register.instance')]) {
         realRequire('ts-node/register')
       } else if (process.env.TS_NODE_DEV) {
         realRequire('ts-node-dev')
       }
       // TODO: Support ES imports once tsc, tap & ts-node provide better compatibility guarantees.
-      fn = realRequire(decodeURIComponent(filename.replace('file://', '')))
+      // Remove extra forwardslash on Windows
+      fn = realRequire(decodeURIComponent(filename.replace(process.platform === 'win32' ? 'file:///' : 'file://', '')))
     } else {
       fn = (await realImport(filename))
     }

package/package.json

@@ -1,23 +1,24 @@
 {
   "name": "thread-stream",
-  "version": "0.15.0",
+  "version": "1.0.0",
   "description": "A streaming way to send data to a Node.js Worker Thread",
   "main": "index.js",
+  "types": "index.d.ts",
   "dependencies": {
     "real-require": "^0.1.0"
   },
   "devDependencies": {
-    "@types/node": "^12.0.0",
+    "@types/node": "^17.0.37",
     "@types/tap": "^15.0.0",
-    "desm": "^1.1.0",
+    "desm": "^1.3.0",
     "fastbench": "^1.0.1",
-    "husky": "^7.0.0",
-    "sonic-boom": "^2.0.1",
-    "standard": "^16.0.3",
-    "tap": "^16.0.0",
-    "ts-node": "^10.7.0",
-    "typescript": "^4.6.0",
-    "why-is-node-running": "^2.2.0"
+    "husky": "^8.0.1",
+    "sonic-boom": "^2.8.0",
+    "standard": "^17.0.0",
+    "tap": "^16.2.0",
+    "ts-node": "^10.8.0",
+    "typescript": "^4.7.2",
+    "why-is-node-running": "^2.2.2"
   },
   "scripts": {
     "test": "standard && npm run transpile && tap test/*.test.*js && tap --ts test/*.test.*ts",

package/test/base.test.js

@@ -248,7 +248,7 @@ test('pass down MessagePorts', async function (t) {
 })
 
 test('destroy does not error', function (t) {
-  t.plan(3)
+  t.plan(5)
 
   const dest = file()
   const stream = new ThreadStream({
@@ -267,5 +267,7 @@ test('destroy does not error', function (t) {
     stream.flush((err) => {
       t.equal(err.message, 'the worker has exited')
     })
+    t.doesNotThrow(() => stream.flushSync())
+    t.doesNotThrow(() => stream.end())
   })
 })

package/test/ts.test.ts

@@ -6,12 +6,6 @@ import { file } from './helper.js'
 
 
 test('typescript module', function (t) {
-  if (process.platform === 'win32') {
-    // TODO: Implement .ts files loading support for Windows
-    t.plan(0)
-    return
-  }
-
   t.plan(5)
 
   const dest = file()