thirdweb 5.89.1 → 5.90.0

package/src/extensions/erc721/drop721.test.ts

@@ -96,19 +96,9 @@ describe.runIf(process.env.TW_SECRET_KEY)(
       });
 
       await expect(nextTokenIdToMint({ contract })).resolves.toBe(10n);
-      await expect(
-        getNFT({ contract, tokenId: 0n }),
-      ).resolves.toMatchInlineSnapshot(`
-        {
-          "id": 0n,
-          "metadata": {
-            "name": "Test NFT",
-          },
-          "owner": null,
-          "tokenURI": "ipfs://QmY1Rr4C7cYVPAaXykMMxg3AVbatDZ6Rd7u3gzt79CiDSB/0",
-          "type": "ERC721",
-        }
-      `);
+      expect((await getNFT({ contract, tokenId: 0n })).metadata.name).toBe(
+        "Test NFT",
+      );
     });
 
     it("should allow to claim tokens", async () => {

package/src/extensions/erc721/read/getNFTs.test.ts

@@ -189,7 +189,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("erc721.getNFTs", () => {
   });
 
   it("should throw error if totalSupply and nextTokenIdToMint are not supported", async () => {
-    await expect(() =>
+    await expect(
       getNFTs({ contract: UNISWAPV3_FACTORY_CONTRACT }),
     ).rejects.toThrowError(
       "Contract requires either `nextTokenIdToMint` or `totalSupply` function available to determine the next token ID to mint",

package/src/extensions/erc721/read/getOwnedTokenIds.test.ts

@@ -22,7 +22,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("erc721.getOwnedTokenIds", () => {
   it("should throw if tokenOfOwnerByIndex or tokensOfOwner not supported", async () => {
     // We know current Lens contract on Polygon doesn't have this.
     const contract = UNISWAPV3_FACTORY_CONTRACT;
-    await expect(() =>
+    await expect(
       getOwnedTokenIds({ contract, owner: TEST_ACCOUNT_B.address }),
     ).rejects.toThrowError(
       `The contract at ${contract.address} on chain ${contract.chain.id} does not support the tokenOfOwnerByIndex or tokensOfOwner interface`,

package/src/extensions/lens/read/resolveAddress.test.ts

@@ -14,7 +14,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("resolve lens address", () => {
   });
 
   it("should throw if passed an invalid lens handle", async () => {
-    await expect(() =>
+    await expect(
       resolveAddress({ client: TEST_CLIENT, name: "vitalik.eth" }),
     ).rejects.toThrowError(
       "Could not fetch the wallet address for lens handle: vitalik.eth",

package/src/extensions/prebuilts/deploy-vote.test.ts

@@ -9,7 +9,7 @@ const account = TEST_ACCOUNT_B;
 
 describe.runIf(process.env.TW_SECRET_KEY)("deploy-voteERC20 contract", () => {
   it("should throw if passed an non-integer-like value to minVoteQuorumRequiredPercent", async () => {
-    await expect(() =>
+    await expect(
       deployVoteContract({
         account,
         client: TEST_CLIENT,

package/src/extensions/unstoppable-domains/read/resolveAddress.test.ts

@@ -19,7 +19,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
     });
 
     it("should throw an error with a non-existent domain name", async () => {
-      await expect(() =>
+      await expect(
         resolveAddress({
           name: "thirdwebsdk.thissuredoesnotexist",
           client: TEST_CLIENT,

package/src/extensions/unstoppable-domains/read/resolveName.test.ts

@@ -18,7 +18,7 @@ describe.runIf(process.env.TW_SECRET_KEY)(
     });
 
     it("should throw error on addresses that dont own any UD", async () => {
-      await expect(() =>
+      await expect(
         resolveName({ client: TEST_CLIENT, address: TEST_ACCOUNT_D.address }),
       ).rejects.toThrowError(
         `Failed to retrieve domain for address: ${TEST_ACCOUNT_D.address}. Make sure you have set the Reverse Resolution address for your domain at https://unstoppabledomains.com/manage?page=reverseResolution&domain=your-domain`,

package/src/pay/convert/cryptoToFiat.test.ts

@@ -52,7 +52,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: crypto-to-fiat", () => {
   });
 
   it("should throw error for testnet chain (because testnets are not supported", async () => {
-    await expect(() =>
+    await expect(
       convertCryptoToFiat({
         chain: sepolia,
         fromTokenAddress: NATIVE_TOKEN_ADDRESS,
@@ -66,7 +66,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: crypto-to-fiat", () => {
   });
 
   it("should throw error if fromTokenAddress is set to an invalid EVM address", async () => {
-    await expect(() =>
+    await expect(
       convertCryptoToFiat({
         chain: ethereum,
         fromTokenAddress: "haha",
@@ -80,7 +80,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: crypto-to-fiat", () => {
   });
 
   it("should throw error if fromTokenAddress is set to a wallet address", async () => {
-    await expect(() =>
+    await expect(
       convertCryptoToFiat({
         chain: base,
         fromTokenAddress: TEST_ACCOUNT_A.address,
@@ -99,7 +99,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: crypto-to-fiat", () => {
       status: 400,
       statusText: "Bad Request",
     });
-    await expect(() =>
+    await expect(
       convertCryptoToFiat({
         chain: base,
         fromTokenAddress: NATIVE_TOKEN_ADDRESS,

package/src/pay/convert/fiatToCrypto.test.ts

@@ -53,7 +53,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: fiatToCrypto", () => {
   });
 
   it("should throw error for testnet chain (because testnets are not supported", async () => {
-    await expect(() =>
+    await expect(
       convertFiatToCrypto({
         chain: sepolia,
         to: NATIVE_TOKEN_ADDRESS,
@@ -67,7 +67,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: fiatToCrypto", () => {
   });
 
   it("should throw error if `to` is set to an invalid EVM address", async () => {
-    await expect(() =>
+    await expect(
       convertFiatToCrypto({
         chain: ethereum,
         to: "haha",
@@ -81,7 +81,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: fiatToCrypto", () => {
   });
 
   it("should throw error if `to` is set to a wallet address", async () => {
-    await expect(() =>
+    await expect(
       convertFiatToCrypto({
         chain: base,
         to: TEST_ACCOUNT_A.address,
@@ -100,7 +100,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("Pay: fiatToCrypto", () => {
       status: 400,
       statusText: "Bad Request",
     });
-    await expect(() =>
+    await expect(
       convertFiatToCrypto({
         chain: ethereum,
         to: NATIVE_TOKEN_ADDRESS,

package/src/react/core/hooks/wallets/useConnect.test.tsx

@@ -48,7 +48,7 @@ describe("useAddConnectedWallet", () => {
       },
     );
     const { result } = renderHook(() => useConnect(), { wrapper });
-    expect(statusResult.current).toEqual("disconnected");
+    expect(statusResult.current).toEqual("unknown");
     await result.current.connect(async () => wallet);
     expect(statusResult.current).toEqual("connected");
 
@@ -67,7 +67,7 @@ describe("useAddConnectedWallet", () => {
       },
     );
     const { result } = renderHook(() => useConnect(), { wrapper });
-    expect(statusResult.current).toEqual("disconnected");
+    expect(statusResult.current).toEqual("unknown");
     await result.current.connect(async () => wallet);
     expect(statusResult.current).toEqual("connected");
 
@@ -85,7 +85,7 @@ describe("useAddConnectedWallet", () => {
         wrapper,
       },
     );
-    expect(statusResult.current).toEqual("disconnected");
+    expect(statusResult.current).toEqual("unknown");
     const { result } = renderHook(() => useConnect(), { wrapper });
     await result.current.connect(async () => {
       throw new Error("test");

package/src/react/web/ui/prebuilt/Account/balance.test.tsx

@@ -72,14 +72,8 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
     expect(result.symbol).toBe("$");
   });
 
-  it("`loadAccountBalance` should throw if `chain` is not passed", async () => {
-    await expect(() =>
-      loadAccountBalance({ client: TEST_CLIENT, address: VITALIK_WALLET }),
-    ).rejects.toThrowError("chain is required");
-  });
-
   it("`loadAccountBalance` should throw if `tokenAddress` is mistakenly passed as native token", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         address: VITALIK_WALLET,
@@ -92,7 +86,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
   });
 
   it("`loadAccountBalance` should throw if `address` is not a valid evm address", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         // biome-ignore lint/suspicious/noExplicitAny: for the test
@@ -103,7 +97,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
   });
 
   it("`loadAccountBalance` should throw if `tokenAddress` is passed but is not a valid evm address", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         address: VITALIK_WALLET,
@@ -133,7 +127,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
   });
 
   it("`loadAccountBalance` should throw if failed to load tokenBalance (native token)", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         address: VITALIK_WALLET,
@@ -145,7 +139,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
   });
 
   it("`loadAccountBalance` should throw if failed to load tokenBalance (erc20 token)", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         address: VITALIK_WALLET,
@@ -158,7 +152,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
   });
 
   it("if fetching fiat value then it should throw if failed to resolve (native token)", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         address: VITALIK_WALLET,
@@ -171,7 +165,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("AccountBalance component", () => {
   });
 
   it("if fetching fiat value then it should throw if failed to resolve (erc20 token)", async () => {
-    await expect(() =>
+    await expect(
       loadAccountBalance({
         client: TEST_CLIENT,
         address: VITALIK_WALLET,

package/src/react/web/ui/prebuilt/Chain/icon.test.tsx

@@ -76,7 +76,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("ChainIcon", () => {
   });
 
   it("fetchChainIcon should throw error if failed to resolve chain icon", async () => {
-    await expect(() =>
+    await expect(
       fetchChainIcon({ chain: defineChain(-1), client }),
     ).rejects.toThrowError("Failed to resolve icon for chain");
   });

package/src/react/web/ui/prebuilt/NFT/description.test.tsx

@@ -53,7 +53,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("NFTDescription", () => {
   });
 
   it("fetchNftDescription should throw error if failed to resolve nft info", async () => {
-    await expect(() =>
+    await expect(
       fetchNftDescription({
         contract: UNISWAPV3_FACTORY_CONTRACT,
         tokenId: 0n,

package/src/react/web/ui/prebuilt/NFT/media.test.tsx

@@ -70,7 +70,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("NFTMedia", () => {
   });
 
   it("fetchNftMedia should throw error if failed to resolve nft info", async () => {
-    await expect(() =>
+    await expect(
       fetchNftMedia({
         contract: UNISWAPV3_FACTORY_CONTRACT,
         tokenId: 0n,

package/src/react/web/ui/prebuilt/NFT/name.test.tsx

@@ -54,7 +54,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("NFTName", () => {
   });
 
   it("fetchNftName should throw error if failed to resolve nft info", async () => {
-    await expect(() =>
+    await expect(
       fetchNftName({
         contract: UNISWAPV3_FACTORY_CONTRACT,
         tokenId: 0n,

package/src/react/web/ui/prebuilt/NFT/utils.test.ts

@@ -86,7 +86,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("getNFTInfo", () => {
   });
 
   it("should throw error if failed to load nft info", async () => {
-    await expect(() =>
+    await expect(
       getNFTInfo({ contract: UNISWAPV3_FACTORY_CONTRACT, tokenId: 0n }),
     ).rejects.toThrowError("Failed to load NFT metadata");
   });

package/src/react/web/ui/prebuilt/Token/name.test.tsx

@@ -73,7 +73,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("TokenName component", () => {
   });
 
   it("fetchTokenName should throw in the end where all fallback solutions failed to resolve to any name", async () => {
-    await expect(() =>
+    await expect(
       fetchTokenName({
         address: UNISWAPV3_FACTORY_CONTRACT.address,
         client,

package/src/react/web/ui/prebuilt/Token/symbol.test.tsx

@@ -73,7 +73,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("TokenSymbol component", () => {
   });
 
   it("fetchTokenSymbol should throw in the end where all fallback solutions failed to resolve to any symbol", async () => {
-    await expect(() =>
+    await expect(
       fetchTokenSymbol({
         address: UNISWAPV3_FACTORY_CONTRACT.address,
         client,

package/src/react/web/ui/prebuilt/Wallet/icon.test.tsx

@@ -11,7 +11,7 @@ describe("WalletIcon", () => {
   });
 
   it("should throw error if WalletId is not supported", async () => {
-    await expect(() =>
+    await expect(
       // @ts-ignore For test
       fetchWalletImage({ id: "__undefined__" }),
     ).rejects.toThrowError("Wallet with id __undefined__ not found");

package/src/react/web/ui/prebuilt/Wallet/name.test.tsx

@@ -16,7 +16,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("WalletName", () => {
 
   it("fetchWalletName should throw error if failed to get name", async () => {
     // @ts-ignore for test
-    await expect(() => fetchWalletName({ id: "test___" })).rejects.toThrowError(
+    await expect(fetchWalletName({ id: "test___" })).rejects.toThrowError(
       "Wallet with id test___ not found",
     );
   });

package/src/react/web/ui/prebuilt/thirdweb/ClaimButton/ClaimButton.test.tsx

@@ -113,7 +113,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("ClaimButton", () => {
       },
     });
     const contract = getContract({ address, chain, client });
-    await expect(() =>
+    await expect(
       getERC20ClaimTo({
         contract,
         account,

package/src/storage/download.test.ts

@@ -7,7 +7,7 @@ import { download } from "./download.js";
 
 const server = setupServer(...storageHandlers);
 
-describe("download", () => {
+describe.skip("download", () => {
   beforeAll(() => server.listen({ onUnhandledRequest: "error" }));
   afterAll(() => server.close());
   afterEach(() => server.resetHandlers());

package/src/storage/download.ts

@@ -1,6 +1,8 @@
 import { getClientFetch } from "../utils/fetch.js";
 import { type ResolveSchemeOptions, resolveScheme } from "../utils/ipfs.js";
+import { IS_TEST } from "../utils/process.js";
 import type { Prettify } from "../utils/type-utils.js";
+import { getFromMockStorage } from "./mock.js";
 
 export type DownloadOptions = Prettify<
   ResolveSchemeOptions & {
@@ -64,6 +66,21 @@ export type DownloadOptions = Prettify<
  * @storage
  */
 export async function download(options: DownloadOptions) {
+  if (IS_TEST) {
+    const hash = options.uri.split("://")[1];
+    if (!hash) {
+      throw new Error("Invalid hash");
+    }
+    const data = getFromMockStorage(hash);
+    if (data) {
+      return {
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve(data),
+      } as Response;
+    }
+  }
+
   let url: string;
   if (options.uri.startsWith("ar://")) {
     const { resolveArweaveScheme } = await import("../utils/arweave.js");

package/src/storage/mock.ts

@@ -0,0 +1,52 @@
+import { randomBytesHex } from "../utils/random.js";
+
+const mockStorage = new Map<string, unknown>();
+
+/**
+ * Extracts file contents from FormData and stores it as JSON
+ * @returns The storage key with filename if present
+ */
+export async function addToMockStorage(value: FormData): Promise<string[]> {
+  const key = randomBytesHex();
+
+  // Get the first file from FormData
+  const files = value.getAll("file") as File[];
+  if (!files) {
+    throw new Error("No file found in FormData");
+  }
+
+  // Read file contents
+  return Promise.all(
+    files.map(async (file) => {
+      const text = await file.text();
+      let data: unknown;
+
+      try {
+        // Parse the contents as JSON
+        data = JSON.parse(text);
+      } catch {
+        throw new Error("File contents must be valid JSON");
+      }
+
+      // If file has a name, return key/filename format
+      const filename =
+        "name" in file && file.name ? file.name.replace("files/", "") : "";
+
+      //   console.log("mockStorage upload", key, data, filename);
+
+      const hash = `${key}${filename ? `/${filename}` : ""}`;
+      mockStorage.set(hash, data);
+      return `ipfs://${hash}`;
+    }),
+  );
+}
+
+/**
+ * Retrieves parsed JSON data from storage
+ * @returns The parsed data object or undefined if not found
+ */
+export function getFromMockStorage(key: string): unknown {
+  const data = mockStorage.get(key);
+  //   console.log("mockStorage get", key, data);
+  return data;
+}

package/src/storage/upload/web-node.test.ts

@@ -8,7 +8,8 @@ import { uploadBatch } from "./web-node.js";
 
 const server = setupServer(...storageHandlers);
 
-describe("uploadBatch", () => {
+// skip this test for now, will need to be manually run
+describe.skip("uploadBatch", () => {
   beforeAll(() => server.listen({ onUnhandledRequest: "error" }));
   afterAll(() => server.close());
   afterEach(() => server.resetHandlers());

package/src/storage/upload/web-node.ts

@@ -1,6 +1,8 @@
 import type { ThirdwebClient } from "../../client/client.js";
 import { getThirdwebDomains } from "../../utils/domains.js";
 import { getClientFetch } from "../../utils/fetch.js";
+import { IS_TEST } from "../../utils/process.js";
+import { addToMockStorage } from "../mock.js";
 import type { UploadOptions, UploadableFile } from "./types.js";
 
 export async function uploadBatch<const TFiles extends UploadableFile[]>(
@@ -9,6 +11,10 @@ export async function uploadBatch<const TFiles extends UploadableFile[]>(
   fileNames: string[],
   options?: UploadOptions<TFiles>,
 ) {
+  if (IS_TEST) {
+    return addToMockStorage(form);
+  }
+
   const headers: HeadersInit = {};
 
   const res = await getClientFetch(client)(
@@ -17,7 +23,8 @@ export async function uploadBatch<const TFiles extends UploadableFile[]>(
       method: "POST",
       headers,
       body: form,
-      requestTimeoutMs: client.config?.storage?.fetch?.requestTimeoutMs,
+      requestTimeoutMs:
+        client.config?.storage?.fetch?.requestTimeoutMs || 120000,
     },
   );
 

package/src/transaction/actions/encode.test.ts

@@ -203,7 +203,7 @@ describe("transaction: encode", () => {
       // @ts-ignore Intentionally for the test purpose
       extraCallData: "I'm a cat",
     });
-    await expect(() => getExtraCallDataFromTx(tx)).rejects.toThrowError(
+    await expect(getExtraCallDataFromTx(tx)).rejects.toThrowError(
       "Invalid extra calldata - must be a hex string",
     );
   });

package/src/transaction/actions/estimate-gas-cost.ts

@@ -44,7 +44,7 @@ export async function estimateGasCost(
     );
   }
   let l1Fee: bigint;
-  if (isOpStackChain(transaction.chain)) {
+  if (await isOpStackChain(transaction.chain)) {
     const { estimateL1Fee } = await import("../../gas/estimate-l1-fee.js");
     l1Fee = await estimateL1Fee({
       transaction,

package/src/utils/nft/fetch-token-metadata.test.ts

@@ -32,6 +32,6 @@ describe("fetchTokenMetadata", () => {
       tokenId: 0n,
       tokenUri: invalidBase64Json,
     };
-    await expect(() => fetchTokenMetadata(options)).rejects.toThrowError();
+    await expect(fetchTokenMetadata(options)).rejects.toThrowError();
   });
 });

package/src/utils/process.ts

@@ -1,3 +1,7 @@
 export const IS_DEV =
   // biome-ignore lint/nursery/noProcessEnv: ok in this file
   process.env.NODE_ENV === "development" || process.env.NODE_ENV === "test";
+
+export const IS_TEST =
+  // biome-ignore lint/nursery/noProcessEnv: ok in this file
+  process.env.NODE_ENV === "test";

package/src/version.ts

@@ -1 +1 @@
-export const version = "5.89.1";
+export const version = "5.90.0";

package/src/wallets/manager/index.ts

@@ -15,7 +15,11 @@ import type { SmartWalletOptions } from "../smart/types.js";
 import type { WalletId } from "../wallet-types.js";
 
 type WalletIdToConnectedWalletMap = Map<string, Wallet>;
-export type ConnectionStatus = "connected" | "disconnected" | "connecting";
+export type ConnectionStatus =
+  | "connected"
+  | "disconnected"
+  | "connecting"
+  | "unknown";
 
 const CONNECTED_WALLET_IDS = "thirdweb:connected-wallet-ids";
 const LAST_ACTIVE_EOA_ID = "thirdweb:active-wallet-id";
@@ -47,7 +51,7 @@ export function createConnectionManager(storage: AsyncStorage) {
   const activeAccountStore = createStore<Account | undefined>(undefined);
   const activeWalletChainStore = createStore<Chain | undefined>(undefined);
   const activeWalletConnectionStatusStore =
-    createStore<ConnectionStatus>("disconnected");
+    createStore<ConnectionStatus>("unknown");
 
   const definedChainsStore = createStore<Map<number, Chain>>(new Map());
 

package/src/wallets/smart/index.ts

@@ -556,7 +556,7 @@ async function _sendUserOp(args: {
   }
 }
 
-async function getEntrypointFromFactory(
+export async function getEntrypointFromFactory(
   factoryAddress: string,
   client: ThirdwebClient,
   chain: Chain,