thinkpool-pair 0.7.274 → 0.7.275

package/account.mjs

@@ -501,12 +501,11 @@ export async function runAccount(SUPABASE_URL, SUPABASE_ANON) {
   acct.on('broadcast', { event: 'restart' }, () => {
     restarting = true
     // The dashboard "Restart bridge" button ALSO updates to the newest published version
-    // (Max, 2026-07-03). If an OS service manages this bridge, spawn a DETACHED updater
-    // that re-pins the service to @latest and reloads it (install-service resolves the
-    // newest version → rewrites the plist/unit → bootout+bootstrap). Detached → its own
-    // session, so it SURVIVES this process being booted out (the reload kills us); it
-    // inherits our env, whose PATH carries nvm's bin, so npx/node resolve — a bare launchd
-    // PATH would NOT (the 2026-07-03 gotcha that made a manual updater silently no-op).
+    // (Max, 2026-07-03). Use service.mjs's authoritative registry → immutable runtime →
+    // one-shot reload transaction directly. Spawning `npx install-service` here used a
+    // disposable cache that legacy services could delete underneath the updater. The
+    // service primitive arms an independent launchd handoff before this process is booted
+    // out, so the reload survives us without a second package execution tree.
     // The reload IS the bounce; sessions resume from disk on the new version. Best-effort:
     // if there's no service or npm is unreachable, we fall through to the plain bounce, so
     // the button is never dead — and even a failed update degrades to today's behaviour.
@@ -525,8 +524,7 @@ export async function runAccount(SUPABASE_URL, SUPABASE_ANON) {
       try {
         const svc = await import('./service.mjs')
         if (svc.serviceActive(null)) {
-          spawn('npx', ['-y', 'thinkpool-pair@latest', 'install-service'], { detached: true, stdio: 'ignore', env: process.env }).unref()
-          updating = true
+          updating = svc.updateService(null) !== false
         }
       } catch { /* no service / spawn failed → plain bounce below */ }
       process.stderr.write(updating

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "thinkpool-pair",
-  "version": "0.7.274",
+  "version": "0.7.275",
   "description": "Share a local coding-agent CLI (Claude Code, Codex, Gemini, Aider, …) into a ThinkPool Code room, live.",
   "type": "module",
   "bin": {

package/service.mjs

@@ -46,16 +46,12 @@ export function darwinServiceRunning(output) {
   const text = String(output || '')
   return /(^|\n)[ \t]*state = running[ \t]*($|\n)/.test(text) && /(^|\n)[ \t]*pid = \d+[ \t]*($|\n)/.test(text)
 }
-// Legacy auto-update services still use npx. Wipe its disposable execution project
-// before resolving the package so an @latest restart cannot re-serve a stale cache.
-// `home` is the platform-correct, runtime-expanded home token ("$HOME" on darwin under
-// /bin/bash; "$$HOME" inside a systemd unit so systemd emits a literal $HOME to bash).
-// npx caches the temporary execution project as a unit. Removing only the package can
-// leave its generated .bin/package-lock metadata behind, producing the contradictory
-// state where `npm view` sees a version but `npx` reports ETARGET or no executable.
-// The whole _npx directory is disposable; clear its children so the next launch is a
-// genuinely clean install.
-const cacheWipe = (home) => `rm -rf ${home}/.npm/_npx/* 2>/dev/null`
+// Legacy auto-update services still use npx. They MUST use a bridge-owned cache:
+// deleting ~/.npm/_npx corrupts unrelated interactive `npx thinkpool-pair` processes
+// (0.7.274 removed account.mjs underneath a live launcher). The service cache is
+// disposable and isolated, so clearing it cannot mutate a person's npm execution tree.
+const serviceNpmCache = () => path.join(os.homedir(), '.thinkpool-pair', 'npm-cache')
+const cacheWipe = (cacheRoot) => `rm -rf ${shq(path.join(cacheRoot, '_npx'))}/* 2>/dev/null`
 
 // The version installing the service. By DEFAULT the service is pinned to this exact
 // version (not @latest) so a future bad npm publish can't auto-roll to every machine's
@@ -130,6 +126,7 @@ export function buildArtifact(platform, { room = null, cmdArgs = [], autoUpdate
   const logDir = path.join(os.homedir(), '.thinkpool-pair')
   const log = path.join(logDir, `${id}.log`)
   const servicePath = sanitizeServicePath(process.env.PATH || '', platform)
+  const npmCache = serviceNpmCache()
   const tail = cmdArgs.length ? ['--', ...cmdArgs] : []
   const desc = room ? `bridge (${room})` : 'account bridge'
   // OS-supervised tiers (launchd KeepAlive / systemd Restart) don't need --supervise.
@@ -156,7 +153,7 @@ export function buildArtifact(platform, { room = null, cmdArgs = [], autoUpdate
     const args = runtimeEntry
       ? [process.execPath, runtimeEntry, ...(room ? [room] : []), ...tail]
       : staleProof
-      ? ['/bin/bash', '-lc', `${cacheWipe('"$HOME"')}; exec ${[npx, ...pkgArgs, ...tail].map(shq).join(' ')}`]
+      ? ['/bin/bash', '-lc', `${cacheWipe(npmCache)}; export NPM_CONFIG_CACHE=${shq(npmCache)}; exec ${[npx, ...pkgArgs, ...tail].map(shq).join(' ')}`]
       : [npx, ...pkgArgs, ...tail]
     const file = path.join(os.homedir(), 'Library', 'LaunchAgents', `${label(room)}.plist`)
     const content = `<?xml version="1.0" encoding="UTF-8"?>
@@ -175,7 +172,7 @@ export function buildArtifact(platform, { room = null, cmdArgs = [], autoUpdate
   <key>WorkingDirectory</key><string>${xml(cwd)}</string>
   <key>StandardOutPath</key><string>${xml(log)}</string>
   <key>StandardErrorPath</key><string>${xml(log)}</string>
-  <key>EnvironmentVariables</key><dict><key>PATH</key><string>${xml(servicePath)}</string>${autoUpdate ? '<key>THINKPOOL_PAIR_AUTOUPDATE</key><string>1</string>' : ''}</dict>
+  <key>EnvironmentVariables</key><dict><key>PATH</key><string>${xml(servicePath)}</string>${runtimeEntry ? '' : `<key>NPM_CONFIG_CACHE</key><string>${xml(npmCache)}</string>`}${autoUpdate ? '<key>THINKPOOL_PAIR_AUTOUPDATE</key><string>1</string>' : ''}</dict>
 </dict></plist>\n`
     // The destructive reload is intentionally NOT represented as an inline `post`
     // command. installService stages this plist and hands the transaction to an
@@ -193,7 +190,7 @@ export function buildArtifact(platform, { room = null, cmdArgs = [], autoUpdate
     const execStart = runtimeEntry
       ? args.map((a) => `'${a.replace(/'/g, "'\\''")}'`).join(' ')
       : staleProof
-      ? `/bin/bash -lc "${cacheWipe('$$HOME')}; exec ${[npx, ...pkgArgs, ...tail].join(' ')}"`
+      ? `/bin/bash -lc "${cacheWipe(npmCache)}; export NPM_CONFIG_CACHE=${shq(npmCache)}; exec ${[npx, ...pkgArgs, ...tail].join(' ')}"`
       : args.map((a) => `'${a.replace(/'/g, "'\\''")}'`).join(' ')
     const content = `[Unit]
 Description=ThinkPool Code ${desc}
@@ -211,7 +208,7 @@ RestartSec=2
 RestartPreventExitStatus=0
 WorkingDirectory=${cwd}
 Environment=PATH=${servicePath}
-${autoUpdate ? 'Environment=THINKPOOL_PAIR_AUTOUPDATE=1\n' : ''}StandardOutput=append:${log}
+${runtimeEntry ? '' : `Environment=NPM_CONFIG_CACHE=${npmCache}\n`}${autoUpdate ? 'Environment=THINKPOOL_PAIR_AUTOUPDATE=1\n' : ''}StandardOutput=append:${log}
 StandardError=append:${log}
 
 [Install]
@@ -232,7 +229,7 @@ WantedBy=default.target
       : room
       ? ['npx', '-y', ...onlineFlag, verSpec, room, '--supervise', ...tail].join(' ')
       : ['npx', '-y', ...onlineFlag, verSpec].join(' ')
-    const content = `@echo off\r\ntitle thinkpool-pair ${id}\r\n${inner}\r\n`
+    const content = `@echo off\r\ntitle thinkpool-pair ${id}\r\n${runtimeEntry ? '' : `set "NPM_CONFIG_CACHE=${npmCache}"\r\n`}${inner}\r\n`
     return { file, content, logDir, post: [], note: 'Installed to the Startup folder — runs at login' + (room ? ' with --supervise (auto-restart on crash).' : ' (account mode).') + ' Start it now without rebooting by double-clicking the .cmd, or run it from a terminal.' }
   }