thinkpool-pair 0.7.229 → 0.7.231

package/bridge.mjs

@@ -66,7 +66,7 @@ import { writeLaneArtifact, digestSlice, appendDigest, resumeLane } from './flow
 import { createFlowWorktree, worktreeSpec } from './flow-worktree.mjs'
 import { startPreview, stopAllPreviews, previews } from './flow-preview.mjs'
 import { ViewportManager, createViewportTools, sharedViewportBrowser } from './viewport.mjs'
-import { deleteDesignAssetDraft, designPrompt, materializeDesignAsset, resolveDesignSource, resolveManifestDesignSource, restoreDesignSources, syncRealtimeAuth, validateDesignBatchRequest } from './design-edit.mjs'
+import { deleteDesignAssetDraft, designPrompt, designTranscript, materializeDesignAsset, resolveDesignSource, resolveManifestDesignSource, restoreDesignSources, syncRealtimeAuth, validateDesignBatchRequest } from './design-edit.mjs'
 // FL-M9 — per-lane preview servers leak (one per done lane, never stopped until shutdown).
 // Lane previews are keyed `lane:<flowId>:<laneId>`; stop a whole flow's set when it assembles
 // (the assembled preview supersedes them) or when a lane is reverted.
@@ -1283,19 +1283,13 @@ function pumpDesign(term) {
   const active = { ...next, resultOk: false, proof: null, timer: null }
   designActive.set(term, active)
   designStatus({ previewId: next.record.previewId, requestId: next.request.cid, state: 'applying' })
-  // Safe transcript summary: never include host paths or the full locator packet.
-  const action = next.request.mode === 'text' ? 'replace text'
-    : next.request.mode === 'move' ? 'move element'
-      : next.request.mode === 'image' ? 'replace image'
-        : next.request.intent
-  const batchCount = next.request.mode === 'batch' ? next.request.edits.length : 0
+  // Complete room-visible instructions, without host paths or locator packets.
   const visible = {
     kind: 'you',
-    text: batchCount
-      ? `Design batch · ${batchCount} pooled edit${batchCount === 1 ? '' : 's'}`
-      : `Design edit · ${next.request.target.name || next.request.target.tag}: ${action}`,
+    text: designTranscript(next.request, { restore: !!next.restoreRecord }),
     cid: next.request.cid,
     by: next.by,
+    design: true,
   }
   stampEvent(visible); pushLog(lane, visible); bcast('code-event', { term, evt: visible })
   try { lane.session.sendTurn(designPrompt({ record: next.record, request: next.request, by: next.by, restore: !!next.restoreRecord, priorRecord: next.restoreRecord })) }
@@ -4038,7 +4032,8 @@ designChannel
       materializedDrafts.push(edit.asset.path)
     }
     await Promise.all(materializedDrafts.map((assetPath) => deleteDesignAssetDraft({ webBase: WEB_BASE, token: codeAuthToken, room, path: assetPath })))
-    queue.push({ ...verdict, by: 'A room member' })
+    const by = String(payload?.by || 'A room member').replace(/\0/g, '').trim().slice(0, 120) || 'A room member'
+    queue.push({ ...verdict, by })
     const batchCount = verdict.request.mode === 'batch' ? verdict.request.edits.length : 1
     designStatus({ previewId, requestId, state: 'queued', message: `${batchCount} edit${batchCount === 1 ? '' : 's'} pooled to the producing lane.` })
     pumpDesign(term)
@@ -4061,7 +4056,8 @@ designChannel
       designStatus({ previewId, requestId, state: 'failed', message: 'Too many Design edits are queued for this lane.' })
       return
     }
-    queue.push({ record, restoreRecord: restore.priorRecord, request: { previewId, revision: record.revision, mode: 'restore', intent: 'restore previous verified revision', target: restore.request.target || { selector: 'html', tag: 'artifact', name: `${restore.request.edits?.length || 1} pooled edits` }, cid: requestId }, by: 'A room member' })
+    const by = String(payload?.by || 'A room member').replace(/\0/g, '').trim().slice(0, 120) || 'A room member'
+    queue.push({ record, restoreRecord: restore.priorRecord, request: { previewId, revision: record.revision, mode: 'restore', intent: 'restore previous verified revision', target: restore.request.target || { selector: 'html', tag: 'artifact', name: `${restore.request.edits?.length || 1} pooled edits` }, cid: requestId }, by })
     designStatus({ previewId, requestId, state: 'queued', message: 'Restore queued in the producing lane.' })
     pumpDesign(record.term)
   })

package/codex-app-server.mjs

@@ -59,7 +59,14 @@ export function codexAppServerGate({ env = process.env, execFile = execFileSync
 export function buildCodexAppServerArgs({ providerConfig, mcpUrl, writableDirs = [] } = {}) {
   const args = ['app-server', '--stdio']
   if (providerConfig) args.push('-c', providerConfig)
-  if (mcpUrl) args.push('-c', `mcp_servers.thinkpool.url=${JSON.stringify(mcpUrl)}`)
+  if (mcpUrl) {
+    args.push('-c', `mcp_servers.thinkpool.url=${JSON.stringify(mcpUrl)}`)
+    // The room prompt promises spawn/read/close_terminal as native room tools.
+    // Fail startup instead of silently running a tool-less Codex turn when the
+    // private loopback MCP handshake is unavailable. Existing MCP approval
+    // policy still owns the room permission card for each call.
+    args.push('-c', 'mcp_servers.thinkpool.required=true')
+  }
   if (writableDirs.length) args.push('-c', `sandbox_workspace_write.writable_roots=${JSON.stringify(writableDirs)}`)
   return args
 }

package/codex-session.mjs

@@ -248,7 +248,13 @@ export function buildCodexExecArgs({ sessionId, model, effort, sandbox, approval
   // accept --add-dir itself. Supply these only when creating the thread.
   if (!sessionId) for (const dir of writableDirs) args.push('--add-dir', dir)
   // Per-lane override only: never mutate the person's global Codex config.
-  if (mcpUrl) args.push('-c', `mcp_servers.thinkpool.url=${JSON.stringify(mcpUrl)}`)
+  if (mcpUrl) {
+    args.push('-c', `mcp_servers.thinkpool.url=${JSON.stringify(mcpUrl)}`)
+    // Room tools are part of the ThinkPool execution contract, not optional
+    // enrichment. A failed handshake must abort this invocation so Codex
+    // cannot continue after spawn_terminal vanished from its callable set.
+    args.push('-c', 'mcp_servers.thinkpool.required=true')
+  }
   // Both fresh `exec` and `exec resume` accept repeatable --image flags. Only
   // bridge-derived absolute paths reach this layer; relative values are ignored
   // so a future caller cannot silently change the child's path interpretation.

package/design-edit.mjs

@@ -223,6 +223,32 @@ function designAction(request) {
   return `Apply this visual change to only the selected element unless the instruction explicitly requires its immediate context:\n${request.intent}`
 }
 
+const designModeLabel = (mode) => ({ text: 'Text', prompt: 'Prompt', move: 'Move', image: 'Image' })[mode] || 'Edit'
+
+function visibleDesignAction(request) {
+  if (request.mode === 'text') return `Replacement text:\n${clean(request.intent, MAX_TEXT)}`
+  if (request.mode === 'prompt') return `Instruction:\n${clean(request.intent, MAX_INTENT)}`
+  if (request.mode === 'move') return `Move from position ${request.movement.fromIndex + 1} to position ${request.movement.toIndex + 1}.`
+  if (request.mode === 'image') return `Replacement image: ${clean(request.asset?.name || 'uploaded image', 240)}`
+  return ''
+}
+
+// Complete, room-safe transcript text for the visible Design dispatch. Keep the
+// user instructions and order; omit host-only paths and locator packets.
+export function designTranscript(request, { restore = false } = {}) {
+  if (restore) return 'Thinkpool Design · restore the previous verified revision'
+  const edits = request?.mode === 'batch' ? request.edits : [request]
+  const valid = Array.isArray(edits) ? edits.filter(Boolean).slice(0, MAX_BATCH_EDITS) : []
+  const heading = request?.mode === 'batch'
+    ? `Thinkpool Design · ${valid.length} pooled edit${valid.length === 1 ? '' : 's'}`
+    : 'Thinkpool Design · 1 edit'
+  const details = valid.map((edit, index) => {
+    const target = clean(edit.target?.name || edit.target?.tag || 'element', 240)
+    return `${index + 1}. ${designModeLabel(edit.mode)} · ${target}\n${visibleDesignAction(edit)}`
+  })
+  return [heading, ...details].join('\n\n')
+}
+
 export function designPrompt({ record, request, by, restore = false, priorRecord = null }) {
   const batch = request.mode === 'batch' ? request.edits : null
   const work = restore

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "thinkpool-pair",
-  "version": "0.7.229",
+  "version": "0.7.231",
   "description": "Share a local coding-agent CLI (Claude Code, Codex, Gemini, Aider, …) into a ThinkPool Code room, live.",
   "type": "module",
   "bin": {