thinkpool-pair 0.7.177 → 0.7.178

package/account.mjs

@@ -16,7 +16,7 @@ import os from 'node:os'
 import { saveAuth, loadAuth, loadDirs, bindDir, loadServed, rememberServed, loadDefaultDir, saveDefaultDir, claudeRecentProjectDir } from './auth-store.mjs'
 import { isSafeToRestart } from './update-gate.mjs'
 import { makeThrottledTrack, presenceSelfEchoVerdict } from './presence.mjs'
-import { publicKeyB64, announceProviders, listProviders, addProvider, removeProvider, unseal } from './providers.mjs'
+import { publicKeyB64, announceProviders, listProviders, addProvider, addProviderModel, removeProvider, unseal } from './providers.mjs'
 import { supervisorServes } from './serve-consent.mjs'
 import { resolveServeDir } from './serve-dir.mjs'
 import { pairKeyFor, pairTopic, CROSSROOM_BUS } from './cross-terminal.mjs'
@@ -579,6 +579,17 @@ export async function runAccount(SUPABASE_URL, SUPABASE_ANON) {
     if (r.ok) { pushPresence(); process.stderr.write(`\n  ◆ provider added (${String(fields?.name || '').slice(0, 40)}) — re-announced.\n`) }
     provReply('provider-add-res', { nonce, ok: r.ok, error: r.ok ? undefined : r.error, id: r.ok ? r.id : undefined })
   })
+  // provider-add-model {id, model, name?, nonce, jwt} → clone the source row's
+  // baseUrl + key HOST-SIDE onto a new model, re-announce. Deliberately carries NO
+  // `sealed` envelope: the key never leaves the bridge for this op, so there is
+  // nothing to decrypt. Owner-authed exactly like its siblings.
+  acct.on('broadcast', { event: 'provider-add-model' }, async ({ payload }) => {
+    const nonce = payload?.nonce
+    if (!(await isOwner(payload?.jwt))) return provReply('provider-add-model-res', { nonce, ok: false, error: 'unauthorized' })
+    const r = addProviderModel({ id: payload?.id, model: payload?.model, name: payload?.name })
+    if (r.ok) { pushPresence(); process.stderr.write(`\n  ◆ model added to an existing provider (${String(payload?.model || '').slice(0, 40)}) — re-announced.\n`) }
+    provReply('provider-add-model-res', { nonce, ok: r.ok, error: r.ok ? undefined : r.error, id: r.ok ? r.id : undefined })
+  })
   // provider-remove {id, nonce, jwt} → remove (built-in refuses), re-announce.
   acct.on('broadcast', { event: 'provider-remove' }, async ({ payload }) => {
     const nonce = payload?.nonce

package/bridge.mjs

@@ -45,7 +45,7 @@ import { createPermNotifier, shouldNotifyTurnDone, permissionSummary, clipSummar
 // resolveProviderEnv(id) → {ANTHROPIC_BASE_URL,ANTHROPIC_AUTH_TOKEN,ANTHROPIC_MODEL} for a
 // registered custom provider, or null for the built-in/unknown (leave the default env intact).
 // Multi-provider BYOK slice 1: a lane spawned with a `provider` id runs on that endpoint.
-import { resolveProviderEnv, providerNameMap, publicKeyB64, announceProviders, listProviders, addProvider, removeProvider, unseal } from './providers.mjs'
+import { resolveProviderEnv, providerNameMap, publicKeyB64, announceProviders, listProviders, addProvider, removeProvider, unseal, effectiveLaneModel } from './providers.mjs'
 import { validateProviderSwitch, BUILTIN_PROVIDER } from './switch-provider.mjs'
 import { createSdkMcpServer, tool } from '@anthropic-ai/claude-agent-sdk'
 import { z } from 'zod'
@@ -1568,18 +1568,28 @@ function worktreeSnapshot(cwd) {
 // rolling log replays to joiners and survives bridge restarts (session-store).
 function openStructured({ id, model, resume, log, commands, mode, spawnedBy, rolePrompt, flowSessionId, flowTaskKey, cwd, reviewSliceRoots, openedAt, defer, provider, carryRecap }) {
   if (sessions.has(id)) return
+  // The lane's EFFECTIVE model — computed ONCE and used for BOTH the truthful display
+  // label (entry.model) and the SDK's `model` option below. These used to be computed
+  // separately: the label resolved the provider's configured model while the SDK got the
+  // RAW inherited `model`, which OVERRIDES ANTHROPIC_MODEL from resolveProviderEnv. A GLM
+  // lane opened while focused on Fable therefore showed `glm-4.6` and sent
+  // `claude-fable-5` → 400 [1211][Unknown Model]. One value, one truth.
+  // undefined → omit the SDK option entirely and let the provider env/endpoint default.
+  const laneModel = effectiveLaneModel({ provider, model, configuredModel: resolveProviderEnv(provider)?.ANTHROPIC_MODEL })
   // spawnedBy: set when this lane was Dispatched (spawn_terminal). Restored from the
   // session store so the Ensemble flag survives a bridge restart (else a respin
   // stripped it and the lane reverted to a plain tab — the t6 "no chip" bug).
   const entry = { cmd: 'claude', kind: 'structured', log: Array.isArray(log) ? log.slice(-STRUCTURED_LOG_MAX) : [], pending: new Map(), session: null, recovered: false, commands: Array.isArray(commands) ? commands : undefined, mode,
-    // model: truthful active-model label. When this lane runs on a custom (non-anthropic)
-    // registered provider the SDK id is impersonated (see the onEvent guard below), so seed
-    // from THAT provider's CONFIGURED model — glm-5.2, not a Claude label — before any turn.
-    // No configured model → the provider's name, never a false Claude id. Built-in Anthropic
-    // keeps the passed model. Keyed on the lane's own provider id, not the bridge default.
+    // model: truthful active-model label — now the SAME `laneModel` the SDK is given, so the
+    // chip cannot disagree with the wire. When this lane runs on a custom (non-anthropic)
+    // registered provider the SDK id is impersonated (see the onEvent guard below), so
+    // laneModel resolves from THAT provider's CONFIGURED model — glm-4.6, not a Claude label.
+    // No configured model → the provider's NAME, never a false Claude id (an inherited
+    // claudeish id was dropped upstream by effectiveLaneModel; it must not sneak back in as a
+    // label fallback here). Built-in Anthropic keeps the passed model.
     model: (!provider || provider === 'anthropic')
-      ? (model || null)
-      : (resolveProviderEnv(provider)?.ANTHROPIC_MODEL || providerNameMap()[provider] || model || provider),
+      ? (laneModel || null)
+      : (laneModel || providerNameMap()[provider] || provider),
     provider: provider || null, spawnedBy: spawnedBy || undefined, flowSessionId: flowSessionId || null, flowTaskKey: flowTaskKey || null, cwd: cwd || null,
     // Stable creation order — persisted so a bridge restart restores tabs in the SAME
     // order (not readdir/filesystem order). Legacy recs (no openedAt) derive it from the
@@ -2095,7 +2105,15 @@ function openStructured({ id, model, resume, log, commands, mode, spawnedBy, rol
   // is silently lost (the 2026-07-02 auto-resume bug). Empty string → nothing to carry.
   entry.pendingRecap = (typeof carryRecap === 'string' && carryRecap.trim()) ? carryRecap : null
   entry.session = startClaudeSession({
-    cwd: cwd || process.cwd(), model, resume, mode, rolePrompt,
+    // laneModel, NOT the raw `model` param: the SDK's `model` option OVERRIDES the
+    // ANTHROPIC_MODEL supplied by resolveProviderEnv() in `env` below, so an inherited
+    // Claude id here defeats the whole per-provider env. undefined → option omitted.
+    cwd: cwd || process.cwd(), model: laneModel, resume, mode, rolePrompt,
+    // Haiku composer-prefill is an Anthropic-subscription freebie. This lane's env carries a
+    // CUSTOM provider's base URL + auth token, so on a non-anthropic lane that call would bill
+    // the user's own BYOK key for a feature they didn't ask for (and 400 on strict providers).
+    // Same lane-provider key as the model-truth guard in onEvent below.
+    suggest: !provider || provider === 'anthropic',
     // Live ROOM NOW tail appended to every turn's <system-reminder>: sibling lanes
     // (same registries the read_terminal roster uses) + active git worktrees (only
     // when >1 — a solo checkout has nothing to coordinate about). Keeps every lane

package/claude-session.mjs

@@ -176,6 +176,8 @@ const simplifyBlocks = (blocks = []) => blocks.map((b) => {
  * @param {(req)=>Promise<'allow'|'deny'>} o.requestPermission
  *        called for EVERY tool call with { id, toolName, input, risk };
  *        resolve 'allow'/'deny'. (Caller implements any auto-allow policy.)
+ * @param {boolean=} o.suggest          allow the Haiku composer-prefill fallback.
+ *        MUST be false on a lane running a custom provider — see haikuSuggest.
  * @returns {{ sendTurn(text), abort(), end(), readonly sessionId }}
  */
 const MODES = new Set(['default', 'acceptEdits', 'plan', 'bypassPermissions'])
@@ -203,7 +205,7 @@ const TP_ROOM_REMINDER = [
   'Verify before claiming done — show runtime evidence you produced, not "should work, go test it".',
 ].join(' ')
 
-export function startClaudeSession({ cwd, model, resume, env, mode: initialMode = 'default', onEvent, requestPermission, mcpServers, crossPostGate, crossRoomPostGate, didSpawnTarget = null, rolePrompt, blockSubagents = false, onSubmitPlan = null, onLaneDone = null, onReviewVerdict = null, reviewGate = null, lazy = false, roomContext = null }) {
+export function startClaudeSession({ cwd, model, resume, env, mode: initialMode = 'default', onEvent, requestPermission, mcpServers, crossPostGate, crossRoomPostGate, didSpawnTarget = null, rolePrompt, blockSubagents = false, onSubmitPlan = null, onLaneDone = null, onReviewVerdict = null, reviewGate = null, lazy = false, roomContext = null, suggest = true }) {
   // Per-turn reminder + live ROOM NOW tail. roomContext (bridge-supplied) returns the
   // room's CURRENT state — sibling lanes, active git worktrees — or null. The static
   // rules keep the agent aware of the room's FEATURES; the live tail keeps it aware of
@@ -746,7 +748,16 @@ export function startClaudeSession({ cwd, model, resume, env, mode: initialMode
   // (opts.env carries the OAuth — no API key needed), but as a BARE model call: no
   // settingSources, no MCP, no tools — so it's a fast cold call, not a full session boot.
   // Fed only `lastAssistantText` (trimmed). Never blocks a turn; any failure is silent.
+  //
+  // BUILT-IN ANTHROPIC PATH ONLY (`suggest`). On a lane running a registered custom
+  // provider, opts.env carries that provider's ANTHROPIC_BASE_URL + ANTHROPIC_AUTH_TOKEN —
+  // so this hardcoded `claude-haiku-4-5` call would spend the USER'S OWN BYOK credit on a
+  // composer prefill they never asked for, at whatever (wrong, flagship) model the endpoint
+  // maps the unknown id to. z.ai silently serves glm for any `claude-*` id, which is exactly
+  // why this went unnoticed; a stricter provider 400s. This is an Anthropic-subscription
+  // freebie — it does not get a per-provider small model, it gets switched off.
   const haikuSuggest = async () => {
+    if (!suggest) return
     const seed = (lastAssistantText || '').trim().slice(-1500)
     if (!seed || closed) return
     const ac2 = new AbortController()

package/event-id.mjs

@@ -215,6 +215,14 @@ export function summarizeUsage(logEvents) {
   return { turns: results.length, per: [...per.values()], totalIn, totalOut, totalCost, haveCost }
 }
 
+// Does this model id name a Claude/Anthropic model? Used by two callers with the
+// same question and NO room for a second opinion:
+//   • usageReportLine — token/cost reporting is Claude-only.
+//   • providers.mjs/effectiveLaneModel — a lane on a CUSTOM (non-anthropic) provider
+//     must never be handed an inherited Claude id; the endpoint 400s on it.
+// Exported (not a local const) precisely so there is exactly one definition.
+export const claudeish = (m) => /claude|anthropic|opus|sonnet|haiku|fable/i.test(String(m || ''))
+
 // model id → friendly label for the /usage report: claude-opus-4-8 → "Opus 4.8".
 // Bridge-local twin of the web's prettyModel (structured.jsx); falls back to the raw id.
 export function prettyModelId (m) {
@@ -229,7 +237,6 @@ export function prettyModelId (m) {
 // handler is a thin wrapper: ctlLine(usageReportLine(s.model, s.log)). `sessionModel` is
 // the resolved model id the /model state tracks; `logEvents` the session's retained log.
 export function usageReportLine (sessionModel, logEvents) {
-  const claudeish = (m) => /claude|anthropic|opus|sonnet|haiku|fable/i.test(String(m || ''))
   const sum = summarizeUsage(logEvents)
   // Gate (Max's ask: "make /usage work if users bridge is on claude llms"). The Code bridge
   // runs the Claude Agent SDK, so a normal lane IS a Claude model — but a session pointed at a

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "thinkpool-pair",
-  "version": "0.7.177",
+  "version": "0.7.178",
   "description": "Share a local coding-agent CLI (Claude Code, Codex, Gemini, Aider, …) into a ThinkPool Code room, live.",
   "type": "module",
   "bin": {

package/providers.mjs

@@ -42,6 +42,7 @@ import os from 'node:os'
 import fs from 'node:fs'
 import path from 'node:path'
 import crypto from 'node:crypto'
+import { claudeish } from './event-id.mjs'
 
 const DIR       = path.join(os.homedir(), '.thinkpool-pair')
 const REG_FILE  = path.join(DIR, 'providers.json')
@@ -180,6 +181,59 @@ export function addProvider(fields) {
   return { ok: true, id }
 }
 
+/**
+ * Add ANOTHER model to an already-registered provider — without the user ever
+ * retyping the key (Max, 2026-07-09). The registry's unit is a {provider,model}
+ * pair, not a provider, and `buildSwitchMenu` already groups rows by brand
+ * ("Z.ai GLM 4.5" / "Z.ai GLM Air" collapse under one "z.ai" header) — so a new
+ * model is simply a CLONE of the source row with a fresh id and a new model.
+ * No schema change, no new menu shape.
+ *
+ * The clone copies `key` + `baseUrl` HOST-SIDE from the row that already holds
+ * them, so no key material crosses the wire for this operation — the caller's
+ * RPC carries no `sealed` envelope at all (see account.mjs `provider-add-model`).
+ *
+ * @param {{id:string, model:string, name?:string}} fields  id = the SOURCE provider
+ * @returns {{ok:true,id:string} | {ok:false,error:string}}
+ */
+export function addProviderModel({ id, model, name } = {}) {
+  if (!id || id === BUILTIN_ID) return { ok: false, error: 'the built-in Anthropic provider has no key to reuse' }
+  if (!model || typeof model !== 'string' || !model.trim()) return { ok: false, error: 'model is required' }
+  const arr = loadProviders()
+  const src = arr.find((p) => p.id === id)
+  if (!src) return { ok: false, error: 'no such provider' }
+
+  const nextModel = String(model).trim()
+  // An endpoint+model pair is the identity of a row — a second row for the same
+  // pair would render as a duplicate menu entry that switches to nothing new.
+  if (arr.some((p) => p.baseUrl === src.baseUrl && (p.model || '') === nextModel)) {
+    return { ok: false, error: `${nextModel} is already registered on this provider` }
+  }
+
+  const nextName = (name && String(name).trim()) || `${brandOf(src.name)} ${nextModel}`.trim()
+  const newId = crypto.randomUUID()
+  arr.push({
+    id: newId,
+    name: nextName,
+    baseUrl: src.baseUrl,   // copied host-side
+    model: nextModel,
+    key: src.key,           // copied host-side — never re-sent by the client
+    addedAt: Date.now(),
+  })
+  saveProviders(arr)
+  return { ok: true, id: newId }
+}
+
+/**
+ * First name token — the brand, matching code-constants.js `brandKey`. "Z.ai GLM
+ * 4.5" → "Z.ai". Used to derive a default name for a cloned row so the switch
+ * menu groups it under the SAME header as its source.
+ */
+function brandOf(name) {
+  const first = String(name || '').trim().split(/\s+/)[0]
+  return first || 'Provider'
+}
+
 /**
  * Remove a provider by id. The built-in `anthropic` refuses.
  * @returns {{ok:true} | {ok:false,error:string}}
@@ -244,3 +298,35 @@ export function resolveProviderEnv(id) {
   if (p.model) env.ANTHROPIC_MODEL = p.model
   return env
 }
+
+/**
+ * The ONE model id a lane actually runs on — used for BOTH the display label and the
+ * SDK's `model` option, which is the whole point: they drifted, and the SDK option
+ * silently OVERRIDES the ANTHROPIC_MODEL env resolveProviderEnv() supplies.
+ *
+ * The bug this closes: a new lane inherits the focused lane's model (client-side), so
+ * opening a GLM lane while on Fable sent `model: 'claude-fable-5'` to
+ * https://api.z.ai/api/anthropic → `API Error: 400 [1211][Unknown Model]`, while the
+ * chip truthfully read `glm-4.6`. Label and wire disagreed; the wire lost.
+ *
+ * Rules (custom = any registered, non-built-in provider):
+ *   • built-in anthropic / no provider → passthrough, unchanged. Default path is sacred.
+ *   • custom + model equals the configured model  → honour it.
+ *   • custom + model is a Claude id (claudeish)   → DROP it. It leaked across a provider
+ *       boundary and the endpoint cannot serve it. Fall back to the configured model, or
+ *       to undefined (no `model` option → the env / endpoint default decides).
+ *   • custom + explicit non-Claude model (glm-4.5, deepseek-…) → honour it. This is a
+ *       deliberate pick (/model, spawn_terminal({provider, model})), not an inheritance leak.
+ *
+ * NEVER returns an inherited Claude id on a custom provider — that is the invariant.
+ * Pure: `configuredModel` is passed in (not read from disk) so it is directly testable.
+ *
+ * @param {{provider?:string|null, model?:string|null, configuredModel?:string|null}} a
+ * @returns {string|undefined}  the model to send; undefined → omit the SDK `model` option
+ */
+export function effectiveLaneModel({ provider, model, configuredModel } = {}) {
+  if (!provider || provider === BUILTIN_ID) return model || undefined
+  if (model && model === configuredModel) return model
+  if (model && !claudeish(model)) return model
+  return configuredModel || undefined
+}