thincoder 0.12.59 → 0.12.60

package/src/agent/completion.mjs

@@ -7,6 +7,7 @@
 import { hasCodeMutations } from "../advisor/repos.mjs"
 import { pushReal } from "../context.mjs"
 import { MAX_ADVISOR_ROUNDS } from "../advisor/run.mjs"
+import { advisorReviewPending, effectiveAdvisorRound } from "../agent-tools/advisor-async.mjs"
 
 const MAX_VERIFY_PUSHBACKS = 2
 const MAX_VERIFY_RETRIES = 3
@@ -77,18 +78,20 @@ export function handleCompletion(agent, response, depth, turn, guardPushbacks, h
       pushReal(agent, { role: "assistant", content: response.content })
       agent.history.push({
         role: "user",
-        content: "[System reminder: you modified files in this run but have not verified the changes. Before finishing: call the verify tool to run syntax checks and tests. If verify reports failures, fix them and run verify again. If verification is genuinely impossible here, say so explicitly in your reply.]",
+        content: "[System reminder: you modified files in this run but have not verified the changes. Before finishing: run the project's verification yourself (per its AGENTS.md test method), then call verify declaring the outcome via verification.status. verify mechanically gates on your declaration. If verification is genuinely impossible here, say so explicitly in your reply.]",
       })
       callbacks.onTurnEnd?.(agent, turn)
       return { action: "continue", guardPushbacks, honestReminderInjected, advisorPushbacks }
     }
-    // Verified but still failing → pushback to fix (up to MAX_VERIFY_RETRIES)
+    // Verified but not passed → pushback to fix/complete (up to MAX_VERIFY_RETRIES).
+    // _verifyPassed === false means the declaration was failed, skipped without a
+    // reason, or not declared — not necessarily that a test failed.
     if (agent._verifiedThisRun && agent._verifyPassed === false && agent._verifyRetries < MAX_VERIFY_RETRIES) {
       agent._verifyRetries++
       pushReal(agent, { role: "assistant", content: response.content })
       agent.history.push({
         role: "user",
-        content: `[System reminder: verify reported test failures (retry ${agent._verifyRetries}/${MAX_VERIFY_RETRIES}). Review the failures, fix the issues, then run verify again. If you cannot fix after ${MAX_VERIFY_RETRIES} attempts, explain honestly what's blocking you.]`,
+        content: `[System reminder: (retry ${agent._verifyRetries}/${MAX_VERIFY_RETRIES}) verify was not passed — either your verification declared failed, was skipped without a reason, or was not declared. Fix or complete your verification, then call verify again declaring the outcome. If you cannot fix after ${MAX_VERIFY_RETRIES} attempts, explain honestly what's blocking you.]`,
       })
       callbacks.onTurnEnd?.(agent, turn)
       return { action: "continue", guardPushbacks, honestReminderInjected, advisorPushbacks }
@@ -103,7 +106,7 @@ export function handleCompletion(agent, response, depth, turn, guardPushbacks, h
       pushReal(agent, { role: "assistant", content: response.content })
       agent.history.push({
         role: "user",
-        content: `[System reminder: ${MAX_VERIFY_RETRIES} verify attempts exhausted and tests are still failing. In your response to the user, you MUST state explicitly: (1) what tests are still failing, (2) what you tried, (3) what you believe the root cause is. Do not present this as complete — the user needs to know the work is unfinished.]`,
+        content: `[System reminder: ${MAX_VERIFY_RETRIES} verify attempts exhausted. You have not passed verification. Either state explicitly that your verification could not be completed, or run verify again once it is. If your verification could not be completed, say so explicitly in your reply to the user — state what you tried and what you believe is blocking you, and do not present the work as complete; the user needs to know it is unfinished.]`,
       })
       callbacks.onTurnEnd?.(agent, turn)
       return { action: "continue", guardPushbacks, honestReminderInjected, advisorPushbacks }
@@ -117,18 +120,21 @@ export function handleCompletion(agent, response, depth, turn, guardPushbacks, h
   const cfg = agent.config?.advisor
   const advisorReview = cfg?.guard === true
   if (depth === 0 && advisorReview && !agent.config?.agent?.engineering) {
-    // Cap sync: beyond MAX_ADVISOR_ROUNDS the advisor tool refuses to review
-    // (run.mjs convergence cap) — pushing back further would loop forever
-    // (fix → pushback → cap-refused call → fix …). The cap message from the
-    // last accepted review stands; the user decides manually.
-    if (agent._mutatedThisRun && !agent._calledAdvisorThisRun && hasCodeMutations(agent)
+    // §24 D-24b (T-24b4 — guard timing): an async review that is still in flight
+    // (or queued in the advisor pool) means the review was launched — the guard
+    // does NOT push back while it is pending (未决不算未评审); once it settles
+    // non-stale it marks _calledAdvisorThisRun, and a STALE settle leaves the
+    // mark unset so the guard pushes back here again (fix #2 — no silent skip).
+    const pending = advisorReviewPending(agent)
+    const rounds = effectiveAdvisorRound(agent)
+    if (!pending && agent._mutatedThisRun && !agent._calledAdvisorThisRun && hasCodeMutations(agent)
         && advisorPushbacks < MAX_ADVISOR_PUSHBACKS
-        && (agent._advisorRound || 0) < MAX_ADVISOR_ROUNDS) {
+        && rounds < MAX_ADVISOR_ROUNDS) {
       advisorPushbacks++
       pushReal(agent, { role: "assistant", content: response.content })
       agent.history.push({
         role: "user",
-        content: `[System reminder: you changed code in this run and MUST get an advisor review before finishing (round ${agent._advisorRound + 1}). Call the \`advisor\` tool now. This is required, not optional — do not skip it even if you believe the changes are trivial — the review will be quick either way. After the review, produce a response table for every issue found (see discipline rules for format).]`,
+        content: `[System reminder: you changed code in this run and MUST get an advisor review before finishing (round ${rounds + 1}). Call the \`advisor\` tool now. This is required, not optional — do not skip it even if you believe the changes are trivial — the review will be quick either way. After the review, produce a response table for every issue found (see discipline rules for format).]`,
       })
       callbacks.onTurnEnd?.(agent, turn)
       return { action: "continue", guardPushbacks, honestReminderInjected, advisorPushbacks }

package/src/agent/dispatch.mjs

@@ -6,9 +6,18 @@ import { offloadToolResult, FILE_MUTATORS } from "./helpers.mjs"
 import { runHooks } from "../hooks.mjs"
 import { snapshotForUndo } from "../tui/cmd-undo.mjs"
 import { isDocFile } from "../advisor/repos.mjs"
+// R10 L3 (MULTI-INSTANCE-COLLAB §2a.5 D-L3b)：写工具钩子——peerCollabNote（执行前冲突
+// 检测——软提示不阻止）+ recordPeerWrites（成功后累积本回合写足迹——回合末 flush）。
+import { PEER_WRITE_TOOLS, peerCollabNote, recordPeerWrites } from "../peer-domains.mjs"
 import { writeFileSync, mkdirSync, existsSync } from "node:fs"
-import { join } from "node:path"
+import { join, resolve } from "node:path"
 import { homedir } from "node:os"
+// §29 fix A（AGENT-LOOP.md §29——2026-09-07）：FILE_MUTATORS 的 mutation-seq 记账从
+// 批后提交（record-results noteMutations）移到执行成功即刻——唯一记账点（取代批后段
+// + agent.mjs 中断分支记账——不双计）——同消息 [写 + async advisor launch] 时 launch 前
+// 完成的写在 launchSeq 之前落地 → settle 不再误判 stale（§29 症状根因）。
+import { noteMutations } from "../agent-tools/advisor-async.mjs"
+import { anyLiveDesignSlot } from "../token-ttl.mjs"
 
 const ERRORS_DIR = join(homedir(), ".thincoder", "tool-errors")
 
@@ -40,9 +49,9 @@ function logToolError(toolName, args, error) {
 
 /**
  * §19 action-level classification (AGENT-LOOP.md §19 D-M1): the merged subagent
- * tool expresses spawn (side effect) and check/status (read-only queries) through
+ * tool expresses spawn (side effect) and status (read-only query) through
  * its `action` parameter — the tool-level readonly flag can no longer express both.
- * dispatch Phase-1/Phase-2 classifies per action: check/status behave as readonly
+ * dispatch Phase-1/Phase-2 classifies per action: status behaves as readonly
  * (planMode pass / no permission ask / batchable), spawn keeps its non-readonly
  * gates, escalate runs non-readonly AND serially (the retired escalate tool had no
  * parallel flag — zero behavior change under the merged surface).
@@ -50,13 +59,13 @@ function logToolError(toolName, args, error) {
  * stops, never starts. isSubagentControlAction feeds the SAME two gate sites as
  * readonly (planMode pass / no permission ask — never joins a batch approval
  * group / no handler → not denied — digest 内 cancel 放行).
- * §19.6 panel (round1 #5): view 面归只读类（同 check/status——planMode 放行、免
+ * §19.6 panel (round1 #5): view 面归只读类（同 status——planMode 放行、免
  * 审批、可批并行）；freeze 面归控制类（同 cancel——planMode 放行、免权限审批、
  * 批审批不入组、digest 内放行）。freeze 存在（非空 key）即控制类——否则只读类。
  */
 function isSubagentReadonlyAction(toolName, args) {
   // §6 memory 工具面重构（MEMORY.md §6 D-M5）：memory search/list 是只读动作——与
-  // subagent check/status 同分类（planMode 放行/免审批——Phase-2 批并行只认工具级
+  // subagent status 同分类（planMode 放行/免审批——Phase-2 批并行只认工具级
   // readonly/parallel，memory 无 parallel → 按非只读串行，见 MEMORY.md §6.4 实现注）。
   // 动作级判定——不能按工具名（同一 memory 工具的 put/delete/clear 保持侧效门）。
   if (toolName === "memory") {
@@ -71,7 +80,10 @@ function isSubagentReadonlyAction(toolName, args) {
   }
   if (toolName !== "subagent" || !args || typeof args !== "object") return false
   const action = args.action
-  if (action === "check" || action === "status") return true
+  // §19.8: check 动作已删除——只读面仅剩 status（planMode 放行/免权限审批/可批并行）
+  if (action === "status") return true
+  // SUBAGENT-OBSERVE-SEND：observe = readonly 查询（同 status——digest/planMode 放行）
+  if (action === "observe") return true
   // §19.6 panel view 面（freeze 缺省/空 = 视图请求——readonly；非空 freeze 归控制类）
   if (action === "panel" && (args.freeze === undefined || args.freeze === null || String(args.freeze) === "")) return true
   return false
@@ -79,14 +91,44 @@ function isSubagentReadonlyAction(toolName, args) {
 function isSubagentControlAction(toolName, args) {
   if (toolName !== "subagent") return false
   if (args?.action === "cancel") return true
+  // SUBAGENT-OBSERVE-SEND：send = 控制类豁免（同 cancel——父回合内显式调用即授权——
+  // 写子输入队列属父对子轻量引导，非产品代码写——免审批、planMode 放行、digest 内放行）
+  if (args?.action === "send") return true
   // §19.6 panel freeze 面（D-P3 门控在 executor——只读/控制分类在此）
   if (args?.action === "panel" && args.freeze !== undefined && args.freeze !== null && String(args.freeze) !== "") return true
   return false
 }
+/**
+ * §2.6 token 链终消费制（2026-09-07——评审 #7d dispatch 分类）：consume-design =
+ * 非只读控制动作——planMode 拒绝（不入 readonly/control 豁免——与其他非只读动作同门）、
+ * 免权限审批、不入批审批分组（无文件写——控制类直行——只停既有状态不起新副作用）。
+ * 与 cancel 的不同：cancel 是控制类豁免（planMode 放行），consume-design 按设计
+ * planMode 拒绝——故不并入 isSubagentControlAction，单独谓词只接权限豁免位。
+ */
+function isSubagentConsumeDesignAction(toolName, args) {
+  return toolName === "subagent" && args?.action === "consume-design"
+}
 function isSubagentEscalateAction(toolName, args) {
   return toolName === "subagent" && args?.action === "escalate"
 }
 
+/**
+ * §29 fix A — 唯一记账点：FILE_MUTATORS 工具执行成功即刻记 mutation seq（abs 路径）。
+ * 取代 record-results 批后段 + agent.mjs 中断分支的 noteMutations（不双计——中断+同批
+ * launch 场景 seq 单计，AGENT-LOOP.md §29 T-A1i）。调用时机 = 写执行成功（非 Error 前缀
+ * 结果——recordPeerWrites 同款门）；routed（M2 ACP 客户端执行）成功同样记账。
+ */
+function noteExecutedMutation(agent, tool, args) { 
+  let paths
+  try {
+    paths = tool.touchedPaths ? tool.touchedPaths(args ?? {}) : [args?.path]
+  } catch { return }
+  const abs = (paths ?? [])
+    .filter((p) => typeof p === "string" && p)
+    .map((p) => resolve(agent.cwd, p))
+  if (abs.length > 0) noteMutations(agent, abs)
+}
+
 /**
  * Two-phase execution:
  * Phase 1 (serial): parse args one by one + planMode check + permission confirmation (side-effecting tools)
@@ -138,14 +180,18 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
     }
 
     // Engineering mode PARENT gate: the parent agent must not touch code files
-    // before the design review passed. Signaled by _engDesignToken — set on
-    // design-review approval, survives across turns (_engDesignReviewed is
-    // eng-coder-only and reset per run). Exemptions cover ONLY design artifacts
+    // before the design review passed. Signaled by a live design slot (design-review
+    // approval — persists in the session slot, survives across turns; _engDesignReviewed
+    // is eng-coder-only and reset per run). Exemptions cover ONLY design artifacts
     // (docs/** and root-level docs like METHODOLOGY.md/README.md/AGENTS.md/
     // LICENSE) — writing them IS the design/methodology step. Everything under
     // src/ (incl. src/prompts/*.md) is product code, not documentation, and
     // needs a design token. Mechanically blocks "talk then code".
-    if (agent.config?.agent?.engineering && depth === 0 && !agent._engDesignToken
+    // DESIGN-TOKEN-SETTLEMENT D3（2026-09-08）：资格判据 = 权威槽"任一活槽存在"
+    // （anyLiveDesignSlot——查内存 Map，miss 回读槽文件——单值镜像 `_engDesignToken`
+    // 已退役，门禁不再读镜像——AC4）。
+    if (agent.config?.agent?.engineering && depth === 0
+        && !anyLiveDesignSlot(agent)
         && FILE_MUTATORS.has(toolCall.name)) {
       const paths = tool.touchedPaths ? tool.touchedPaths(args) : [args.path]
       // Unknown/missing paths (non-string, e.g. no path argument) are treated
@@ -171,7 +217,7 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
     // — the exemption never widens what reaches this stage (round4 #3, T-E14).
     // PreToolUse hooks still run below. Non-eng-coder children keep the manual
     // parent ask (human in the loop).
-    if (tool.readonly || isSubagentReadonlyAction(toolCall.name, args) || isSubagentControlAction(toolCall.name, args) || agent.autoApprove || agent._engTaskAuthorized) {
+    if (tool.readonly || isSubagentReadonlyAction(toolCall.name, args) || isSubagentControlAction(toolCall.name, args) || isSubagentConsumeDesignAction(toolCall.name, args) || agent.autoApprove || agent._engTaskAuthorized) {
       if (!(await runHooks("PreToolUse", { agent, toolName: toolCall.name, toolArgs: args }))) {
         prepared.push({ toolCall, tool, denied: true, reason: "blocked by PreToolUse hook" })
         continue
@@ -267,6 +313,11 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
     const toolName = item.toolCall.name
     logEvent("tool:call", { tool: toolName, child: agent?._logId })
     try {
+      // R10 L3 (MULTI-INSTANCE-COLLAB §2a.5 D-L3b)：结构化写工具执行前查 conflicts
+      // （命中他实例 hot 域 → 结果附软提示——决策⑥ A 不阻止；一次目录 stat——N3 度量）；
+      // 足迹累积（D-L3a——"检测+记录一次完成"）延后到执行成功（实际写过的文件）。
+      const isPeerWriteTool = PEER_WRITE_TOOLS.has(toolName)
+      const peerNote = isPeerWriteTool ? peerCollabNote(agent.cwd, item.tool, item.args) : null
       // Snapshot for undo before side-effect tools (setupOutputPanel already fired in Phase 1)
       if (!item.tool?.readonly && item.args) {
         snapshotForUndo(agent, item.toolCall.name, item.args, agent.cwd)
@@ -276,9 +327,14 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
       if (callbacks.toolRouter) {
         const routed = await callbacks.toolRouter(item.toolCall.name, item.args)
         if (routed?.handled) {
-          callbacks.onToolResult?.(item.toolCall.name, routed.result, item.toolCall.id)
-          logEvent("tool:done", { tool: toolName, ms: Date.now() - toolT0, head: headText(routed.result, 200), child: agent?._logId })
-          return { ...item, result: routed.result, ok: true }
+          const routedOk = !String(routed.result).startsWith("Error:")
+          const routedResult = peerNote && routedOk ? `${routed.result}\n${peerNote}` : routed.result
+          if (isPeerWriteTool && routedOk) recordPeerWrites(agent, item.tool, item.args)
+          // §29 fix A：routed 写成功（客户端执行）同样执行期即刻记账（唯一记账点）
+          if (routedOk && FILE_MUTATORS.has(toolName)) noteExecutedMutation(agent, item.tool, item.args)
+          callbacks.onToolResult?.(item.toolCall.name, routedResult, item.toolCall.id)
+          logEvent("tool:done", { tool: toolName, ms: Date.now() - toolT0, head: headText(routedResult, 200), child: agent?._logId })
+          return { ...item, result: routedResult, ok: true }
         }
       }
       const origConsoleLog = console.log
@@ -296,18 +352,41 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
         depth,
         signal,
         callbacks,
+        // §24 D-24b: per-call id — the advisor tool marker-keys its launch so
+        // recordToolResults can split async-ack accounting from sync settles.
+        _toolCallId: item.toolCall.id,
         onOutput: (chunk) => callbacks.onToolOutput?.(item.toolCall.name, chunk, item.toolCall.id),
         onQuestion: callbacks.onQuestion,
         onPermissionRequest: callbacks.onPermissionRequest,
       }
       try {
-        rawResult = await item.tool.execute(item.args, toolCtx)
+        // SUBAGENT-OBSERVE-SEND D1（评审 #1）：in-flight 当前工具记账——工具执行期间在
+        // agent 上留 _inflightTools Set（子代理 observe 从 dispatch 状态读——卡在长工具
+        // 调用时 history 无新回合、恰需此信号）；finally 清除。批并行工具同入 Set（observe
+        // 如实返回多个在跑工具）。主会话同样记账——无害（无人读）。
+        const inflight = agent._inflightTools ?? (agent._inflightTools = new Set())
+        inflight.add(toolName)
+        try {
+          rawResult = await item.tool.execute(item.args, toolCtx)
+        } finally {
+          inflight.delete(toolName)
+        }
       } finally {
         console.log = origConsoleLog
         console.error = origConsoleErr
       }
       if (rawResult === undefined) throw new Error(`Tool "${item.toolCall.name}" returned undefined — all tools must return a string value`)
       const raw = String(rawResult)
+      // 写成功（非 "Error:" 字符串结果）→ 足迹计入本回合集合（flush 在 finalizeAgentTurn）
+      if (isPeerWriteTool && !raw.startsWith("Error:")) {
+        recordPeerWrites(agent, item.tool, item.args)
+      }
+      // §29 fix A：FILE_MUTATORS 执行成功即刻记账（唯一记账点——取代 record-results 批后
+      // 段 + agent.mjs 中断分支——不双计）——同批 launch 前的写在 launchSeq 之前落地 →
+      // async advisor settle 不误判 stale（同批 launch 后写仍保守 stale——T-A2/T-24b9）。
+      if (FILE_MUTATORS.has(toolName) && !raw.startsWith("Error:")) {
+        noteExecutedMutation(agent, item.tool, item.args)
+      }
       // Multimodal tools keep the raw result (base64 images ride the multimodal
     // channel); everything else offloads oversized text to disk. Flag-driven, not
     // name-driven (consult P3, 2026-08-30).
@@ -316,11 +395,15 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
       const resultWithConsole = capturedConsole.length > 0
         ? `${result}\n[console during ${item.toolCall.name}]\n${capturedConsole.join("\n")}`
         : result
-      callbacks.onToolResult?.(item.toolCall.name, resultWithConsole, item.toolCall.id, toolCtx._subagentKey)
+      // R10 L3：冲突软提示附在工具结果末尾（模型可见——不阻止写）
+      const resultForModel = peerNote && !raw.startsWith("Error:")
+        ? `${resultWithConsole}\n${peerNote}`
+        : resultWithConsole
+      callbacks.onToolResult?.(item.toolCall.name, resultForModel, item.toolCall.id, toolCtx._subagentKey)
       // PostToolUse hooks: fire-and-forget (result not awaited on hook failure)
       runHooks("PostToolUse", { agent, toolName: item.toolCall.name, toolArgs: item.args, result: raw }).catch(() => {})
-      logEvent("tool:done", { tool: toolName, ms: Date.now() - toolT0, head: headText(resultWithConsole, 200), child: agent?._logId })
-      return { ...item, result: resultWithConsole, ok: true }
+      logEvent("tool:done", { tool: toolName, ms: Date.now() - toolT0, head: headText(resultForModel, 200), child: agent?._logId })
+      return { ...item, result: resultForModel, ok: true }
     } catch (error) {
       // Persist to ~/.thincoder/tool-errors/ for post-mortem; only pass message to the model (stack traces confuse LLMs and may leak paths)
       logToolError(item.toolCall.name, item.args, error)
@@ -357,7 +440,7 @@ export async function executeToolCalls(agent, toolByName, toolCalls, callbacks,
   for (const item of prepared) {
     // escalate action keeps the retired escalate tool's serial placement (no
     // parallel flag): it flushes the batch and runs alone in call order (§19 —
-    // spawn stays parallel; check/status classify as readonly and batch freely).
+    // spawn stays parallel; status classifies as readonly and batch freely).
     if (item.tool && !item.tool.readonly
         && (!item.tool.parallel || isSubagentEscalateAction(item.tool.name, item.args))) {
       await flush()

package/src/agent/helpers.mjs

@@ -288,3 +288,39 @@ export async function loadProjectInstructions(cwd) {
     merged
   )
 }
+
+// Engineering mode reminders + auto-turn digest domain + mode injector
+// （2026-09-05 module-split：自 agent.mjs 迁入——agent.mjs 530 > 500 硬限——agent.mjs
+// re-export 保 import 面：eng.mjs / cmd-eng.mjs / 测试从 agent.mjs import）
+
+/** Engineering mode reminder — shared with eng.mjs tool. */
+export const ENG_ON_REMINDER =
+  "[System reminder: engineering mode is ON — design-before-code enforced. " +
+  "Workflow: Requirements doc → Design doc → advisor(type='design') → " +
+  "user approval → eng-coder implementation. Code changes go through eng-coder " +
+  "subagents only. Advisor calls are NOT per-turn-mandatory — call only at " +
+  "flow nodes or when the user asks.]"
+
+/** Engineering mode OFF reminder — shared with the eng tool and the injector. */
+export const ENG_OFF_REMINDER =
+  "[System reminder: engineering mode is now OFF — standard discipline applies. " +
+  "Changes go through the normal workflow: you may edit files directly, advisor/verify " +
+  "guards apply per config.]"
+
+/** Manual-tier auto-turn digest domain (AGENT-LOOP.md §17 D-S6): organize-only.
+ *  Injected per manual auto-turn run — writes/execute/spawns/questions are also
+ *  mechanically denied (no permission handler + spawn gate); this steers first. */
+export const AUTO_TURN_DIGEST_DOMAIN =
+  "[System reminder: auto-turn — background async subagents finished while there was no user message, and this turn runs automatically to digest their reports (the finished-report reminders above). No one is waiting for this reply, so organize only: 1) summarize each finished report's key points into this conversation for the user to read later; 2) update the task list with the task tool (allowed) to mark finished work done; 3) write decision points with a suggested next step as text — do not execute it. FORBIDDEN this turn (mechanically enforced): modifying files, bash/execute/verify, spawning subagents, asking questions — those need a real user message. End the turn once the summaries are written.]"
+
+/** Engineering-mode status injection — one reminder on EVERY transition (2026-08-25:
+ *  OFF is announced too — the model must know the gates lifted; silence after /eng-off
+ *  left it guessing. Covers TUI /eng, resume, and any path bypassing the eng tool.) */
+export function injectEngineeringReminder(agent) {
+  const eng = agent.config?.agent?.engineering ?? false
+  if (eng !== agent._lastEngState) {
+    agent.history.push({ role: "user", content: eng ? ENG_ON_REMINDER : ENG_OFF_REMINDER, transient: true })
+  }
+  agent._lastEngState = eng
+}
+

package/src/agent/record-results.mjs

@@ -22,7 +22,9 @@
 import { pushReal } from "../context.mjs"
 import { specForModel } from "../config.mjs"
 import { FILE_MUTATORS } from "./helpers.mjs"
-import { join } from "node:path"
+import { resolve } from "node:path"
+import { advisorRuns, stripApprovedSuffix } from "../agent-tools/advisor-async.mjs"
+import { looksLikeReviewOutput } from "../advisor/run.mjs"
 
 let _reindexFile = null
 
@@ -72,6 +74,9 @@ export async function recordToolResults(agent, toolByName, results) {
         // Direct file edit — code was changed. The prior advisor review and
         // verify are stale: a review that ran before the edit no longer
         // covers the current file state.
+        // §29 fix A（AGENT-LOOP.md §29——2026-09-07）：mutation-seq 记账已移到 dispatch
+        // runOne 执行成功即刻（唯一记账点——取代本批后段 + agent.mjs 中断分支——不双计）——
+        // 此处仅剩 guard 标志失效（顺序语义：批内同消息的 sync advisor 提交仍在其后置位）。
         agent._mutatedThisRun = true
         agent._calledAdvisorThisRun = false
         agent._verifiedThisRun = false
@@ -91,20 +96,51 @@ export async function recordToolResults(agent, toolByName, results) {
       }
       if (toolCall.name === "verify") agent._verifiedThisRun = true
       if (toolCall.name === "advisor") {
-        agent._calledAdvisorThisRun = true
-        // All advisor calls (code and design) share the 5-round convergence
-        // budget — each advances _advisorRound toward MAX_ADVISOR_ROUNDS.
-        // Always advance the round — the convergence protocol cares about
-        // how many reviews have run (round 1→2→3→4→5), not how many succeeded.
-        // A failed/interrupted review is still a review attempt and should use
-        // the next round's prompt on retry.
-        agent._advisorRound++
+        // §24 D-24b (settle accounting split — fix #2): an ASYNC launch returns an
+        // ack and settles later — the settle callback owns its called/round/token
+        // accounting. Only the SYNC path (depth>0 / explicit async:false) accounts
+        // here — per-review instance round++ (marker-keyed by tool call id) + the
+        // legacy mirror._advisorRound_ counter stays for display/back-compat.
+        // REFUSED launches (pool full / per-review cap) count as neither a call
+        // nor a completion: no called-mark (the guard must keep pushing until a
+        // review really runs), no round advance.
+        const refused = agent._advisorRefusals?.has(toolCall.id)
+        const asyncAck = agent._advisorAsyncAcks?.has(toolCall.id)
+        if (refused) {
+          agent._advisorRefusals.delete(toolCall.id)
+        } else if (asyncAck) {
+          agent._advisorAsyncAcks.delete(toolCall.id)
+        } else {
+          agent._calledAdvisorThisRun = true
+          const reviewId = agent._advisorSyncCalls?.get(toolCall.id)
+          if (reviewId !== undefined) {
+            const run = advisorRuns(agent).get(reviewId)
+            if (run) {
+              run.round++
+              agent._advisorRound = run.round
+              // Prior of round 2+ = the last REVIEW-LOOKING output (run.mjs parity).
+              // F2e (§29.1): the sync settle's engine-approved suffix (stored on the
+              // run by settleDesignReview) is stripped with exact truncation — the
+              // prior never carries the raw token / designId.
+              if (looksLikeReviewOutput(result)) {
+                run.priorOutput = stripApprovedSuffix(result, run.approvedSuffix)
+              }
+            } else {
+              agent._advisorRound++
+            }
+            agent._advisorSyncCalls.delete(toolCall.id)
+          } else {
+            // Direct/legacy callers without a resolution marker — plain mirror
+            // increment (the per-review registry never saw this call).
+            agent._advisorRound++
+          }
+        }
       }
       if (FILE_MUTATORS.has(toolCall.name)) {
         const args = JSON.parse(toolCall.arguments)
         const paths = tool.touchedPaths ? tool.touchedPaths(args) : [args.path]
         for (const p of paths) {
-          const abs = join(agent.cwd, p)
+          const abs = resolve(agent.cwd, p)
           if (!agent._touchedFiles.includes(abs)) agent._touchedFiles.push(abs)
           if (agent.memory) {
             // Fire-and-forget: don't block the agent loop on indexing.