theprogrammablemind_4wp 7.5.8-beta.77 → 7.5.8-beta.79

package/client.js

@@ -591,7 +591,7 @@ const loadInstance = (config, instance) => {
         config.addAssociations(instance.associations)
       }
       if (instance.learned_contextual_priorities && instance.learned_contextual_priorities.length > 0) {
-        config.addContextualPriorities(instance.learned_contextual_priorities)
+        config.addPriorities(instance.learned_contextual_priorities)
       }
     }
   }
@@ -1122,6 +1122,13 @@ const defaultInnerProcess = (config, errorHandler, responses) => {
   }
   console.log("KM's loaded", config.configs.map((c) => c.name))
   console.log('This is the global objects from running semantics:\n', config.objects)
+  if (!_.isEmpty(responses.learned_contextual_priorities)) {
+    console.log('\nThe learned contextual priorties are :\n')
+    for (const lcp of responses.learned_contextual_priorities) {
+      console.log(`  ${JSON.stringify(lcp)},\n`)
+    }
+    console.log("\n")
+  }
   if (responses.logs) {
     console.log('Logs')
     responses.logs.forEach((log) => console.log(`    ${log}`))
@@ -1433,6 +1440,7 @@ const knowledgeModule = async ({
     parser.add_argument('-tmn', '--testModuleName', { help: 'When running tests instead of using the current modules tests use the specified modules tests' })
     parser.add_argument('-t', '--test', { action: 'store_true', help: 'Run the tests. Create tests by running with the --query + --save flag' })
     parser.add_argument('-tv', '--testVerbose', { action: 'store_true', help: 'Run the tests in verbose mode. Create tests by running with the --query or --loop with the --save flag' })
+    // parser.add_argument('-ttr', '--testToRun', { help: 'Only the specified test will be run' })
     parser.add_argument('-tva', '--testAllVerbose', { action: 'store_true', help: 'Run the tests in verbose mode. All the tests will be run instead of stopping at first failure. Create tests by running with the --query or --loop with the --save flag' })
     parser.add_argument('-tnp', '--testNoParenthesized', { action: 'store_true', help: 'Don\' check parenthesized differences for the tests' })
     parser.add_argument('-n', '--count', { help: 'Number of times to run the tests. Default is one. Use this to check for flakey test. If possible the system will print out a message with the word "hint" suggesting how to fix the problem' })
@@ -1452,7 +1460,7 @@ const knowledgeModule = async ({
     parser.add_argument('-c', '--clean', { help: 'Remove data from the test files. a === association' })
     parser.add_argument('-od', '--objectDiff', { action: 'store_true', help: 'When showing the objects use a colour diff' })
     parser.add_argument('-daa', '--dontAddAssociations', { action: 'store_true', help: 'Do not add associations from the tests.' })
-    parser.add_argument('-p', '--print', { help: 'Print the specified elements c === config, w === words, b === bridges, o === operators d === objects (d for data), h === hierarchy, g === generators, s === semantics, l === load t=tests ordering p === priorities a == associations j == JSON sent to server x == contextual priorities. for example --print wb' })
+    parser.add_argument('-p', '--print', { help: 'Print the specified elements c === config, w === words, b === bridges, o === operators d === objects (d for data), h === hierarchy, g === generators, s === semantics, l === load t=tests ordering p === priorities a == associations j == JSON sent to server. for example --print wb' })
     parser.add_argument('-s', '--save', { action: 'store_true', help: 'When running with the --query flag this will save the current run to the test file. When running without the --query flag all tests will be run and resaved.' })
     parser.add_argument('-sd', '--saveDeveloper', { action: 'store_true', help: 'Same as -s but the query will not show up in the info command.' })
     parser.add_argument('-dl', '--debugLoops', { action: 'store_true', help: 'When running with the --debugLoops flag the logs calls to semantics and generators will be immediately written to the console '})
@@ -1629,11 +1637,6 @@ const knowledgeModule = async ({
             console.log(JSON.stringify(priority))
           }
         }
-        if (args.print.includes('x')) {
-          for (let contextual_priority of config.config.contextual_priorities) {
-            console.log(JSON.stringify(contextual_priority))
-          }
-        }
         if (args.print.includes('h')) {
           for (let edge of config.config.hierarchy) {
             console.log(JSON.stringify(edge))

package/package.json

@@ -64,6 +64,6 @@
     "json-stable-stringify": "^1.0.1",
     "node-fetch": "^2.6.1"
   },
-  "version": "7.5.8-beta.77",
+  "version": "7.5.8-beta.79",
   "license": "ISC"
 }

package/src/config.js

@@ -23,13 +23,6 @@ const indent = (string, indent) => {
 }
 
 const config_toServer = (config) => {
-  /*
-  if (config.contextual_priorities) {
-    config.contextual_priorities = config.contextual_priorities.map((cp) => {
-      return [cp.context, cp.choose]
-    })
-  }
-  */
 }
 
 const debugPriority = (priority) => {
@@ -48,14 +41,6 @@ const debugAssociation = (association) => {
   }
 }
 
-const debugContextualPriority = (contextual_priority) => {
-  if (global.entodictonDebugContextualPriority) {
-    if (helpers.safeEquals(entodictonDebugContextualPriority, contextual_priority)) {
-      debugger; // debug hierarchy hit
-    }
-  }
-}
-
 const debugHierarchy = (pair) => {
   if (global.entodictonDebugHierarchy) {
     if (helpers.safeEquals(global.entodictonDebugHierarchy, pair)) {
@@ -87,7 +72,6 @@ const debugConfigProps = (config) => {
   const checkProps = [
     { property: 'priorities', check: (v) => debugPriority(v) },
     { property: 'association', check: (v) => debugAssociation(v) },
-    { property: 'contextual_priorities', check: (v) => debugContextualPriority(v) },
     { property: 'hierarchy', check: (v) => debugHierarchy(v) },
     { property: 'operators', check: (v) => debugOperator(v) },
     { property: 'bridges', check: (v) => debugBridge(v) },
@@ -109,7 +93,6 @@ const validConfigProps = (config) => {
     'operators', 
     'words', 
     'priorities', 
-    'contextual_priorities', 
     'associations', 
     'name', 
     'version', 
@@ -188,20 +171,20 @@ const elist = (list, check, prefix) => {
     }
   }
 }
-const contextual_priorities_valid = (cps) => {
-  elist(cps, (cp) => contextual_priority_valid(cp),  (index, e) => `contextual_priorities has an invalid contextual priority at position ${index}. ${e}`)
+const priorities_valid = (cps) => {
+  elist(cps, (cp) => priority_valid(cp),  (index, e) => `priorities has an invalid priority at position ${index}. ${e}`)
 }
 
-const contextual_priority_valid = (cp) => {
+const priority_valid = (cp) => {
   if (!cp.context) {
-    throw new Error(`The contextual priority ${JSON.stringify(cp)} is missing the "context" property. That is a list of the operator keys that are to be prioritized differently.`)
+    throw new Error(`The priority ${JSON.stringify(cp)} is missing the "context" property. That is a list of the operator keys that are to be prioritized differently.`)
   }
   if (!_.isArray(cp.context)) {
-    throw new Error(`The contextual priority ${JSON.stringify(cp)} has an invalid "context" value. That is a list of the operator keys that are to be prioritized differently.`)
+    throw new Error(`The priority ${JSON.stringify(cp)} has an invalid "context" value. That is a list of the operator keys that are to be prioritized differently.`)
   }
-  elist(cp.context, (element) => operatorKey_valid(element), (index, e) => `The contextual priority ${JSON.stringify(cp)} has an invalid operator key at position ${index}. ${e}`)
+  elist(cp.context, (element) => operatorKey_valid(element), (index, e) => `The priority ${JSON.stringify(cp)} has an invalid operator key at position ${index}. ${e}`)
   if (!_.isArray(cp.choose)) {
-    throw new Error(`The contextual priority ${JSON.stringify(cp)} has an invalid "choose" value. The value should be a list of the operators in the context to consider for prioritization.`)
+    throw new Error(`The priority ${JSON.stringify(cp)} has an invalid "choose" value. The value should be a list of the operators in the context to consider for prioritization.`)
   }
   elist(cp.choose, 
       (element) => {
@@ -212,7 +195,7 @@ const contextual_priority_valid = (cp) => {
           throw new Error(`The value should be an index into the "context" property of the operator that is to be considered for prioritization. Valid values are between 0 and ${cp.context.length-1}.`)
         }
       }, 
-      (index, e) => `The choose property in the contextual priority ${JSON.stringify(cp)} has an invalid index at position ${index}. ${e}`
+      (index, e) => `The choose property in the priority ${JSON.stringify(cp)} has an invalid index at position ${index}. ${e}`
   )
 }
 
@@ -245,7 +228,7 @@ const handleBridgeProps = (config, bridge, addFirst) => {
           if (typeof after == 'string') {
             after = [after, 0]
           }
-          config.addPriorities({ "context": [[bridge.id, bridge.level], after], "choose": [0] })
+          config.addPriority({ context: [[bridge.id, bridge.level], after], choose: [0] })
         }
       }
       if (bridge.after) {
@@ -253,7 +236,7 @@ const handleBridgeProps = (config, bridge, addFirst) => {
           if (typeof before == 'string') {
             before = [before, 0]
           }
-          config.addPriorities({ "context": [before, [bridge.id, bridge.level]], "choose": [0] })
+          config.addPriority({ context: [before, [bridge.id, bridge.level]], choose: [0] })
         }
       }
       if (bridge.words) {
@@ -381,6 +364,11 @@ if (runtime.process.env.DEBUG_HIERARCHY) {
   global.entodictonDebugHierarchy = JSON.parse(runtime.process.env.DEBUG_HIERARCHY)
 }
 
+
+// i keep randomly doing one of the other so I will just make both work the same way
+if (runtime.process.env.DEBUG_PRIORITIES) {
+  global.entodictonDebugPriority = JSON.parse(runtime.process.env.DEBUG_PRIORITIES)
+}
 if (runtime.process.env.DEBUG_PRIORITY) {
   global.entodictonDebugPriority = JSON.parse(runtime.process.env.DEBUG_PRIORITY)
 }
@@ -739,10 +727,10 @@ class Config {
       addAssociation: (...args) => this.addAssociation(...args),
       addAssociations: (...args) => this.addAssociations(...args),
       addBridge: (...args) => this.addBridge(...args, uuid),
-      addContextualPriority: (...args) => this.addContextualPriority(...args),
       addGenerator: (...args) => this.addGenerator(...args, uuid, config.name),
       addHierarchy: (...args) => this.addHierarchy(...args),
       addOperator: (...args) => this.addOperator(...args, uuid),
+      addPriority: (...args) => this.addPriority(...args),
       addPriorities: (...args) => this.addPriorities(...args),
       addSemantic: (...args) => this.addSemantic(...args, uuid, config.name),
       removeSemantic: (...args) => this.removeSemantic(...args, uuid, config.name),
@@ -815,7 +803,6 @@ class Config {
       },
       eqClasses: [],
       priorities: [], // Done
-      contextual_priorities: [],
       version: '3',
       debug: false,
       associations: { // Done
@@ -854,7 +841,6 @@ class Config {
           'namespaces',
           'eqClasses',
           'priorities',
-          'contextual_priorities',
           'associations',
           'words',
           'floaters',
@@ -1053,16 +1039,6 @@ class Config {
     this.validifyTemplate(template)
     instance.template = template
     this.logs.push(`loading template for ${this.name}`)
-    /*
-    if (instance && (instance.associations || instance.learned_contextual_priorities) && !options.rebuild) {
-      if (instance.associations) {
-        this.addAssociations(instance.associations)
-      }
-      if (instance.learned_contextual_priorities && instance.learned_contextual_priorities.length > 0) {
-        this.addContextualPriorities(instance.learned_contextual_priorities)
-      }
-    }
-    */
     if (options.rebuild) {
       // TODO fix beforeQuery
       template = { fragments: [], queries: [], ...template }
@@ -1111,12 +1087,6 @@ class Config {
     }
   }
 
-  addContextualPriorities (cps) {
-    for (let cp of cps) {
-      this.addContextualPriority(cp)
-    }
-  }
-
   debugConfig() {
   }
 
@@ -1134,24 +1104,21 @@ class Config {
 
   // TODO add more error checking to these like addHierarchy has
   // TODO change name from priorities to priority
-  addPriorities (priorities) {
+  // [ context: <list of [id, level]>, choose: [<indexes of prioritized operator>], [ordered: [true|false]] ]
+  addPriority (priority) {
     if (!this.config.priorities) {
       this.config.priorities = []
     }
-    debugPriority(priorities)
-    this.config.priorities.push(priorities)
-    this._delta.json.priorities.push({ action: 'add', priorities })
+    debugPriority(priority)
+    priority_valid(priority)
+    this.config.priorities.push(priority)
+    this._delta.json.priorities.push({ action: 'add', priority })
   }
 
-  // [ operators: <list of [id, level]>, select: <index of prioritized operator> ]
-  addContextualPriority(contextual_priority) {
-    if (!this.config.contextual_priorities) {
-      this.config.contextual_priorities = []
+  addPriorities (priorities) {
+    for (let priority of priorities) {
+      this.addPriority(priority)
     }
-    debugContextualPriority(contextual_priority)
-    contextual_priority_valid(contextual_priority)
-    this.config.contextual_priorities.push(contextual_priority)
-    this._delta.json.contextual_priorities.push({ action: 'add', contextual_priority: contextual_priority })
   }
 
   addHierarchy (child, parent) {
@@ -1549,7 +1516,6 @@ class Config {
       config.hierarchy = config.hierarchy || []
       config.associations = config.associations || { negative: [], positive: [] }
       config.priorities = config.priorities || []
-      config.contextual_priorities = config.contextual_priorities || []
     }
 
     this.maxDepth = 20 // for generators and semantics
@@ -1603,8 +1569,8 @@ class Config {
       }
     }
 
-    if (config && config.contextual_priorities) {
-      contextual_priorities_valid(config.contextual_priorities)
+    if (config && config.priorities) {
+      priorities_valid(config.priorities)
     }
 
     normalizeConfig(config)
@@ -1692,7 +1658,6 @@ class Config {
         bridges: [],
         associations: [],
         priorities: [],
-        contextual_priorities: [],
         hierarchy: [],
       }
     }
@@ -2322,7 +2287,6 @@ class Config {
         bridges: this.config.bridges,
         hierarchy: this.config.hierarchy,
         priorities: this.config.priorities,
-        contextual_priorities: this.config.contextual_priorities,
         associations: this.config.associations,
         words: this.config.words
       }
@@ -2331,7 +2295,6 @@ class Config {
       this.config.bridges = []
       this.config.hierarchy = []
       this.config.priorities = []
-      this.config.contextual_priorities = []
       this.config.associations = { positive: [], negative: [] }
       this.config.words = {}
 
@@ -2540,25 +2503,20 @@ class Config {
 
     if (config.priorities) {
       let priorities = config.priorities
-      priorities = priorities.map((p) => {
-        return { ...p, context: p.context.map( (id) => [toNS(id[0]), id[1]] )}
-      })
-      config.priorities = priorities
-    }
-
-    if (config.contextual_priorities) {
-      let contextual_priorities = config.contextual_priorities
-      contextual_priorities = contextual_priorities.map((cp) => {
+      priorities = priorities.map((cp) => {
         const { context, choose, ordered } = cp
-        return {
+        const priority = {
           context: context.map((id) => {
             return [toNS(id[0]), id[1]]
           }),
           choose,
-          ordered
         }
+        if (ordered) {
+          priority.ordered = ordered
+        }
+        return priority
       })
-      config.contextual_priorities = contextual_priorities
+      config.priorities = priorities
     }
 
     for (const bag of bags) {