theprogrammablemind 8.9.1 → 9.0.0-beta.0

package/client.js

@@ -1,7 +1,7 @@
 const { Semantics, Semantic } = require('./src/semantics')
 const { Generators, Generator } = require('./src/generators')
 const { Config } = require('./src/config')
-const { loadInstance, ErrorReason, listable, setupArgs, gs, processContext, getObjects, setupProcessB, processContextsB  } = require('./src/configHelpers')
+const { loadInstance, ErrorReason, listable, setupArgs, gs, processContext, getObjects, setupProcessB, processContextsB } = require('./src/configHelpers')
 const DigraphInternal = require('./src/digraph_internal')
 const Digraph = require('./src/digraph')
 const { project } = require('./src/project')
@@ -12,7 +12,7 @@ const _ = require('lodash')
 const stringify = require('json-stable-stringify')
 const Lines = require('./lines')
 const flattens = require('./src/flatten')
-const { appendNoDups, InitCalls, updateQueries, safeNoDups, stableId, where } = require('./src/helpers')
+const { appendNoDups, InitCalls, updateQueries, safeNoDups, stableId, where, suggestAssociationsFix, suggestAssociationsFixFromSummaries } = require('./src/helpers')
 const runtime = require('./runtime')
 const sortJson = runtime.sortJson
 
@@ -23,7 +23,7 @@ const getConfig_getObjectsCheck = (config, testConfig) => {
   }
   const checks = (testConfig.checks && testConfig.checks.objects) || []
   if (Array.isArray(checks)) {
-    const kmToChecks = { [testConfigName]: checks.filter( (check) => !check.km ) }
+    const kmToChecks = { [testConfigName]: checks.filter((check) => !check.km) }
     for (const check of checks) {
       if (check.km) {
         kmToChecks[check.km] = config.km(check.km).testConfig.checks.objects
@@ -35,6 +35,16 @@ const getConfig_getObjectsCheck = (config, testConfig) => {
   }
 }
 
+const getSuggestion = (diff) => {
+  return diff.map((element) => {
+    return element.marker
+  })
+}
+
+const getSuggestionMessage = (suggestion) => {
+  return `Try adding this to the associations: { context: ${JSON.stringify(getSuggestion(suggestion))}, choose: <indexOfMainElement> },\n If that does not work look at the logs and check when the operators become wrong during an interation. Deduce the change based on the previous iteration and what operator was applied.`
+}
+
 const getConfig_getContextCheck = (testConfig) => {
   return (testConfig.checks && testConfig.checks.context) || []
 }
@@ -53,7 +63,7 @@ const pickObjects = (config, testConfig, getObjects) => {
   */
   const checks = getConfig_getObjectsCheck(config, testConfig)
   const projection = {}
-  for (let km in checks) {
+  for (const km in checks) {
     const objects = getObjects(km)
     if (!objects) {
       throw new Error(`In the checks for ${config.name} the KM ${km} does not exist`)
@@ -72,9 +82,9 @@ const sameJSON = (json1, json2) => {
 const vimdiff = (actualJSON, expectedJSON, title) => {
   const path = '.'
   const actual = sortJson(actualJSON, { depth: 25 })
-  runtime.fs.writeFileSync(`${path}/actual.json`, JSON.stringify({ title, actual}, 0, 2))
+  runtime.fs.writeFileSync(`${path}/actual.json`, JSON.stringify({ title, actual }, 0, 2))
   const expected = sortJson(expectedJSON, { depth: 25 })
-  runtime.fs.writeFileSync(`${path}/expected.json`, JSON.stringify({ title, expected}, 0, 2))
+  runtime.fs.writeFileSync(`${path}/expected.json`, JSON.stringify({ title, expected }, 0, 2))
   // console.log(`vimdiff ${path}/actual.json ${path}/expected.json`)
   {
     const editor = runtime.process.env.EDITOR || 'vimdiff'
@@ -148,7 +158,7 @@ const writeTestFile = (fn, tests) => {
   runtime.fs.writeFileSync(fn, stringify(tests, { space: 2 }), { encoding: 'utf8', flag: 'w+' })
 }
 
-const writeTest = (fn, query, objects, generated, paraphrases, responses, contexts, associations, metadata, config, saveDeveloper, paraphrasesParenthesized, generatedParenthesized) => {
+const writeTest = (fn, query, objects, generated, paraphrases, responses, contexts, associations, metadata, config, saveDeveloper, paraphrasesParenthesized, generatedParenthesized, summaries) => {
   let tests = []
   if (runtime.fs.existsSync(fn)) {
     tests = JSON.parse(runtime.fs.readFileSync(fn))
@@ -160,6 +170,7 @@ const writeTest = (fn, query, objects, generated, paraphrases, responses, contex
   // tests[query] = sortJson({ paraphrases, responses, contexts, objects: convertToStable(objects), associations, metadata, config, developerTest: saveDeveloper }, { depth: 25 })
   const results = sortJson({
     query,
+    summaries,
     paraphrases,
     responses,
     contexts,
@@ -276,7 +287,7 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
     data.errors_ignore_contextual_priorities_non_existant_ops = true
   }
   let queries = query.split('\\n')
-
+  const summaries = [] // for error
   try {
     const response = {
       hierarchy: [],
@@ -294,7 +305,8 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
       paraphrasesParenthesized: [],
       generatedParenthesized: [],
       responses: [],
-      associations: []
+      associations: [],
+      summaries: []
     }
 
     let startCounter = 0
@@ -326,7 +338,7 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
         }
       }
       json.contexts = json.results
-      startCounter= json.end_counter + 1
+      startCounter = json.end_counter + 1
       delete json.results
       if (json.status !== 200) {
         throw json
@@ -335,6 +347,8 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
         if (isTest) {
           start = runtime.performance.performance.now()
         }
+        const summary = { summaries: json.summaries, length: json.contexts.length }
+        summaries.push(summary)
         const { contextsPrime, generatedPrime, paraphrasesPrime, paraphrasesParenthesizedPrime, generatedParenthesizedPrime, responsesPrime } =
                                   await processContextsB({ isTest, rebuildingTemplate, config, hierarchy, json, commandLineArgs /*, generators, semantics */ })
         if (isTest) {
@@ -363,8 +377,8 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
         response.paraphrasesParenthesized = response.paraphrasesParenthesized.concat(paraphrasesParenthesizedPrime)
         response.generatedParenthesized = response.generatedParenthesized.concat(generatedParenthesizedPrime)
         response.responses = response.responses.concat(responsesPrime)
+        response.summaries.push(summary)
         queries = queries.slice(1)
-
       }
     }
 
@@ -375,11 +389,12 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
       for (const km of config.configs) {
         saveObjects.nameToUUID[km.name] = km.uuid
       }
-      writeTest(testsFN, query, saveObjects, response.generated, response.paraphrases, response.responses, response.contexts, response.associations, response.metadata, actual_config, saveDeveloper, response.paraphrasesParenthesized, response.generatedParenthesized)
+      writeTest(testsFN, query, saveObjects, response.generated, response.paraphrases, response.responses, response.contexts, response.associations, response.metadata, actual_config, saveDeveloper, response.paraphrasesParenthesized, response.generatedParenthesized, response.summaries)
     }
 
     return response
   } catch (error) {
+    error.summaries = summaries
     error.query = query
     errorHandler(error)
   }
@@ -397,7 +412,7 @@ const getConfigForTest = (config, testConfig) => {
       configForTest.words = {
         literals: {},
         patterns: [],
-        hierarchy: [],
+        hierarchy: []
       }
 
       const literals = config.config.words.literals
@@ -427,7 +442,7 @@ const getConfigForTest = (config, testConfig) => {
       if (Array.isArray(includes.operators)) {
         include = (operator) => includes.operators.includes(operator.pattern)
       }
-      configForTest.operators = config.config.operators.filter( include ).map((operator) => Object.assign({}, operator, { uuid: undefined }))
+      configForTest.operators = config.config.operators.filter(include).map((operator) => Object.assign({}, operator, { uuid: undefined }))
     } else if (key === 'bridges') {
       let include = (operator) => true
       if (Array.isArray(includes.bridges)) {
@@ -441,7 +456,7 @@ const getConfigForTest = (config, testConfig) => {
   return configForTest
 }
 
-const runTest = async (config, expected, { args, verbose, testConfig, debug, timings={ server: 0, client: 0 } }) => {
+const runTest = async (config, expected, { args, verbose, testConfig, debug, timings = { server: 0, client: 0 } }) => {
   const test = expected.query
   if (args.query && args.query != test) {
     // no run this
@@ -460,7 +475,7 @@ const runTest = async (config, expected, { args, verbose, testConfig, debug, tim
     defaultErrorHandler(error)
   }
 
-  let objects = getObjects(config.config.objects)(config.uuid)
+  const objects = getObjects(config.config.objects)(config.uuid)
   try {
     const result = await _process(config, test, { errorHandler, isTest: true })
     result.query = test
@@ -539,7 +554,8 @@ const runTest = async (config, expected, { args, verbose, testConfig, debug, tim
           checked: expected_checked,
           checkedContexts: pickedExpectedContexts,
           objects: expected_objects,
-          config: expected.config
+          config: expected.config,
+          summaries: expected.summaries
         },
         actual: {
           responses: result.responses,
@@ -550,7 +566,8 @@ const runTest = async (config, expected, { args, verbose, testConfig, debug, tim
           checked: actual_checked,
           checkedContexts: pickedResultContexts,
           objects: actual_objects,
-          config: actual_config
+          config: actual_config,
+          summaries: result.summaries
         }
       }
     }
@@ -609,7 +626,7 @@ const saveTest = async (testFile, config, test, expected, testConfig, saveDevelo
   for (const km of config.configs) {
     saveObjects.nameToUUID[km.name] = km.uuid
   }
-  writeTest(testFile, test, saveObjects, result.generated, result.paraphrases, result.responses, result.contexts, result.associations, result.metadata, actualConfig, saveDeveloper, result.paraphrasesParenthesized, result.generatedParenthesized)
+  writeTest(testFile, test, saveObjects, result.generated, result.paraphrases, result.responses, result.contexts, result.associations, result.metadata, actualConfig, saveDeveloper, result.paraphrasesParenthesized, result.generatedParenthesized, result.summaries)
 }
 
 const saveTestsHelper = async (testFile, config, tests, todo, testConfig, saveDeveloper) => {
@@ -768,13 +785,13 @@ const printContextualPrioritiesAmbiguities = (cpa) => {
     console.log(`  Counter ${counter}`)
     for (const choices of cpa[counter]) {
       console.log('     [')
-        for (const choice of choices) {
-          console.log('        [')
-          for (const element of choice) {
-            console.log(`          ${JSON.stringify(element)},`)
-          }
-          console.log('        ],')
+      for (const choice of choices) {
+        console.log('        [')
+        for (const element of choice) {
+          console.log(`          ${JSON.stringify(element)},`)
         }
+        console.log('        ],')
+      }
       console.log('     ],')
     }
   }
@@ -873,7 +890,7 @@ const defaultInnerProcess = (config, errorHandler, responses) => {
   console.log('')
   const screen_width = process.stdout.columns
   // || 0 for when running without a console
-  const widths = [70, 10, Math.max(80, screen_width-71 || 0)]
+  const widths = [70, 10, Math.max(80, screen_width - 71 || 0)]
   const lines = new Lines(widths)
   lines.setElement(0, 0, '--- The paraphrases are ----------')
   lines.setElement(0, 2, '--- The response strings are ----------')
@@ -904,12 +921,13 @@ const defaultProcess = ({ config, errorHandler }) => async (promise) => {
 }
 
 // builtTemplate saveInstance
-const rebuildTemplate = async ({ config, target, previousResultss, startOfChanges, template, errorHandler = defaultErrorHandler }) => {
+const rebuildTemplate = async ({ config, instance, target, previousResultss, rebuild, startOfChanges, template, errorHandler = defaultErrorHandler }) => {
   const accumulators = {
     resultss: [],
     fragments: [],
     semantics: [],
     associations: [],
+    summaries: [],
     learned_contextual_priorities: []
   }
   config.fragmentsBeingBuilt = []
@@ -922,7 +940,7 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
     // queries are strings or { query: "blah", development: true/false }
     if (typeof queryOrExtraConfig === 'string' || queryOrExtraConfig.query || queryOrExtraConfig.isFragment) {
       let query = queryOrExtraConfig
-      let isFragment = queryOrExtraConfig.isFragment
+      const isFragment = queryOrExtraConfig.isFragment
       if (typeof queryOrExtraConfig === 'string') {
         query = { query }
       }
@@ -943,12 +961,28 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
       try {
         let results
         let prMessage = ''
-        if (previousResults && previousResults.query == query.query) {
+        const suggestFix = (newSummaries) => {
+          if (!previousResults) {
+            return
+          }
+          const suggestion = suggestAssociationsFixFromSummaries(previousResults.summaries, newSummaries)
+          if (suggestion.length > 0) {
+            console.log(getSuggestionMessage(suggestion))
+          }
+        }
+        if (!rebuild && previousResults && previousResults.query == query.query) {
           results = previousResults
           prMessage = ' Using previous results. use -rtf for a hard rebuild of everything on the server side.'
           await loadInstance(config, { resultss: [results] })
         } else {
-          results = await _process(config, query.query, { initializer, rebuildingTemplate: true })
+          try {
+            results = await _process(config, query.query, { initializer, rebuildingTemplate: true })
+          } catch (e) {
+            if (e.summaries && e.summaries.length > 0) {
+              suggestFix(e.summaries)
+            }
+            throw e
+          }
         }
         if (config.config.debug) {
           // TODO pass in the error handler like the other ones
@@ -956,9 +990,11 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
         }
         if (results.contexts.length > 1) {
           console.log(`query "${query.query}". There is ${results.contexts.length} contexts in the results. Make sure its producing the results that you expect.`)
+          suggestFix(results.summaries)
           throw new Error(`query "${query.query}". There is ${results.contexts.length} contexts in the results. Make sure its producing the results that you expect.`)
         } else if (results.paraphrases[0].toLowerCase() !== query.query.toLowerCase()) {
           console.log(`query "${query.query}". The paraphrase is different from the query "${results.paraphrases[0]}".${prMessage}`)
+          // suggestFix(results.summaries)
         } else {
           console.log(`query ${isFragment ? 'fragment' : ''}"${query.query}".${prMessage}`)
         }
@@ -973,6 +1009,7 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
         if (isFragment) {
           config.fragmentsBeingBuilt.push({ query: query.query, contexts: results.contexts })
         }
+        accumulators.summaries = accumulators.summaries.concat(results.summaries)
         accumulators.associations = accumulators.associations.concat(results.associations)
         accumulators.learned_contextual_priorities = accumulators.learned_contextual_priorities.concat(results.learned_contextual_priorities)
         await looper(configs)
@@ -1065,16 +1102,31 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
   }
   let todo = []
   todo = todo.concat((template.initializers || []).map((query) => { return { initializer: true, property: 'resultss', query, skipSemantics: false || query.skipSemantics } }))
+  /*
   todo = todo.concat((template.configs || []).map((query, index) => {
     let pr
-    if (index < startOfChanges) {
+    if (index < startOfChanges || (!startOfChanges && index < previousResultss.length)) {
       pr = previousResultss[index]
     }
     return { property: 'resultss', query, previousResults: pr, skipSemantics: false || query.skipSemantics }
   }))
-  todo = todo.concat((template.fragments || []).map((query) => { return Object.assign({}, toProperties(query), { property: 'fragments', skipSemantics: false }) }))
-  todo = todo.concat((template.semantics || []).map((definition) => { return { property: 'semantics', query: `${definition.from}\n${definition.to}`, skipSemantics: true } }))
-  await looper(Object.assign([], todo))
+  */
+  if (template.configs) {
+    for (let configsIndex = 0; configsIndex < template.configs.length; ++configsIndex) {
+      const query = template.configs[configsIndex]
+      // account for things for example associations being added to the config while debugginer
+      const pr = previousResultss.find((pr) => pr.query == query)
+      todo.push({ property: 'resultss', query, previousResults: pr, skipSemantics: false || query.skipSemantics })
+    }
+  }
+  todo = todo.concat((template.fragments || []).map((query, index) => {
+    const pr = instance.fragments[index]
+    return Object.assign({}, toProperties(query), { property: 'fragments', previousResults: pr, skipSemantics: false })
+  }))
+  todo = todo.concat((template.semantics || []).map((definition) => {
+    return { property: 'semantics', query: `${definition.from}\n${definition.to}`, skipSemantics: true }
+  }))
+  await looper([...todo])
 }
 
 const checkTemplate = (template) => {
@@ -1096,14 +1148,14 @@ const checkTest = (testConfig) => {
   if (!testConfig.contents) {
     throw new Error("The 'test' property is missing the 'contents' property that contains contents of the '<km>.test.json' file")
   }
-  if (testConfig.checks?.context && typeof testConfig.checks.context == 'function') {
+  if (testConfig.checks?.context && typeof testConfig.checks.context === 'function') {
     throw new Error(`The 'test.check.context' property should not be a function for ${testConfig.name}. If you are using defaultContextCheck then do this defaultContextCheck().`)
   }
 }
 
 const knowledgeModuleImpl = async ({
   includes,
-  config : configStruct,
+  config: configStruct,
   api,
   initializer,
   terminator,
@@ -1248,7 +1300,7 @@ const knowledgeModuleImpl = async ({
       }
 
       config = await createConfig()
-      
+
       // dont debug the load of the KM's if rebuild template is on since we want to debug the template rebuild not the load
       if (args.rebuildTemplate) {
         global.pauseDebugging = true
@@ -1398,7 +1450,7 @@ const knowledgeModuleImpl = async ({
             // { literals: Object, patterns: Array(2), hierarchy: Array(97) }
             console.log('literals')
             for (const word in config.config.words.literals) {
-              console.log('  ' + word.concat(...config.config.words.literals[word].map((def, i) => ((i > 0) ? ' '.repeat(4+word.length) : '  ') + JSON.stringify(def) + '\n')))
+              console.log('  ' + word.concat(...config.config.words.literals[word].map((def, i) => ((i > 0) ? ' '.repeat(4 + word.length) : '  ') + JSON.stringify(def) + '\n')))
             }
             console.log('patterns')
             for (const pattern of config.config.words.patterns) {
@@ -1567,19 +1619,23 @@ const knowledgeModuleImpl = async ({
                   }
                 }
 
-                
                 console.log(`Total Server Time: ${timings.server.toFixed(2)}. Total Client Time: ${timings.client.toFixed(2)}`)
                 if (hasError) {
                   console.log('**************************** ERRORS ************************')
                   for (const result of results) {
                     console.log('Utterance: ', result.utterance)
-                    const show = (label, expected, actual) => {
+                    if (!result.hasError) {
+                      continue
+                    }
+                    const show = (label, expected, actual, { console_log = true } = {}) => {
                       if (JSON.stringify(expected) !== JSON.stringify(actual)) {
-                        if (!headerShown) {
-                          console.log('  Failure')
+                        if (console_log) {
+                          if (!headerShown) {
+                            console.log('  Failure')
+                          }
+                          console.log(`    expected ${label}`, expected)
+                          console.log(`    actual ${label}  `, actual)
                         }
-                        console.log(`    expected ${label}`, expected)
-                        console.log(`    actual ${label}  `, actual)
                         newError = true
                         headerShown = true
                         if (args.vimdiff) {
@@ -1588,6 +1644,44 @@ const knowledgeModuleImpl = async ({
                         result.hasError = true
                       }
                     }
+                    if (!deepEqual(result.expected.summaries, result.actual.summaries)) {
+                      /*
+                      const suggestion = suggestAssociationsFix(result.expected.summaries, result.actual.summaries)
+                      let suggestedFix
+                      if (suggestion) {
+                        suggestedFix = suggestion
+                        console.log(`Try adding this to the associations: { context: ${JSON.stringify(getSuggestion(suggestedFix))}, choose: <indexOfMainElement> }`)
+                      }
+                      */
+
+                      const checkForFix = () => {
+                        for (let iDiff = 0; iDiff < result.expected.paraphrases.length; ++iDiff) {
+                          if (result.expected.paraphrases[iDiff] !== result.actual.paraphrases[iDiff]) {
+                            // const context = result.expected.contexts[iDiff]
+                            let lengths = 0
+                            // just check where the results differ since earlier summaries can be different but dont matter if the result is the same
+                            for (let iSummaries = 0; iSummaries < result.expected.summaries.length; ++iSummaries) {
+                              const summary = result.expected.summaries[iSummaries]
+                              lengths += summary.length
+                              if (lengths > iDiff) {
+                                const suggestion = suggestAssociationsFix(result.expected.summaries[iSummaries].summaries, result.actual.summaries[iSummaries].summaries)
+                                if (suggestion) {
+                                  suggestedFix = suggestion
+                                  // console.log(`Try adding this to the associations: { context: ${JSON.stringify(getSuggestion(suggestedFix))}, choose: <indexOfMainElement> },`)
+                                  console.log(getSuggestionMessage(suggestedFix))
+                                  return
+                                }
+                              }
+                            }
+                          }
+                        }
+                      }
+                      checkForFix()
+
+                      // find the context where the different is
+                      // select the first diff that has a different operator in the range
+                      // show that
+                    }
                     show('paraphrases', result.expected.paraphrases, result.actual.paraphrases)
                     if (!args.testNoParenthesized) {
                       show('paraphrases parenthesized', result.expected.paraphrasesParenthesized, result.actual.paraphrasesParenthesized)
@@ -1723,7 +1817,7 @@ const knowledgeModuleImpl = async ({
         })
         f()
       } else if (args.query) {
-        let useTestConfig = testConfig
+        const useTestConfig = testConfig
         if (args.testModuleName) {
           config.testConfig.testModuleName = args.testModuleName
           config.testConfig.checks = config.getConfigs()[args.testModuleName].getTestConfig().checks
@@ -1751,7 +1845,6 @@ const knowledgeModuleImpl = async ({
     const initConfig = async (config) => {
       if (template) {
         if (config.needsRebuild(template.template, template.instance, { isModule: !isProcess }).needsRebuild) {
-          debugger
           config.needsRebuild(template.template, template.instance, { isModule: !isProcess })
           const error = `This module "${config.name}" cannot be used because the instance file needs rebuilding. Run on the command line with no arguments or the -rt argument to rebuild.`
           throw new Error(error)
@@ -1795,7 +1888,7 @@ const knowledgeModuleImpl = async ({
     // no cache 21 minutes + rebuild fails "node tester_rebuild -m colors"
     // cache okay
     createConfigExport = async () => {
-      if (false && createConfig.cached) {
+      if (createConfig.cached) {
         return createConfig.cached
       }
       const config = await createConfig()
@@ -1855,5 +1948,5 @@ module.exports = {
   gs,
   flattens,
   writeTest,
-  getConfigForTest,
+  getConfigForTest
 }

package/package.json

@@ -1,12 +1,14 @@
 {
   "devDependencies": {
+    "@eslint/js": "^9.21.0",
     "@typescript-eslint/eslint-plugin": "^4.28.4",
     "@typescript-eslint/parser": "^4.28.4",
-    "eslint": "^7.31.0",
+    "eslint": "^7.32.0",
     "eslint-config-standard": "^16.0.3",
     "eslint-plugin-import": "^2.23.4",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^5.1.0",
+    "globals": "^16.0.0",
     "jest": "^29.7.0"
   },
   "scripts": {
@@ -65,6 +67,6 @@
     "sort-json": "^2.0.0",
     "uuid": "^8.3.2"
   },
-  "version": "8.9.1",
+  "version": "9.0.0-beta.0",
   "license": "UNLICENSED"
 }

package/src/config.js

@@ -50,7 +50,8 @@ const debugPriority = (priority) => {
   }
   if (global.entodictonDebugPriority) {
     if (helpers.subPriority(entodictonDebugPriority, priority)) {
-      debugger // debug hierarchy hit
+      // debug hierarchy hit
+      debugger // eslint-disable-line no-debugger
     }
   }
 }
@@ -61,7 +62,8 @@ const debugAssociation = (association) => {
   }
   if (global.entodictonDebugAssociation) {
     if (helpers.safeEquals(global.entodictonDebugAssociation, association)) {
-      debugger // debug association hit
+      // debug association hit
+      debugger // eslint-disable-line no-debugger
     }
   }
 }
@@ -72,7 +74,8 @@ const debugWord = (word) => {
   }
   if (global.entodictonDebugWord) {
     if (helpers.safeEquals(global.entodictonDebugWord, word)) {
-      debugger // debug word hit
+      // debug word hit
+      debugger // eslint-disable-line no-debugger
     }
   }
 }
@@ -83,7 +86,8 @@ const debugHierarchy = (pair) => {
   }
   if (global.entodictonDebugHierarchy) {
     if (helpers.safeEquals(global.entodictonDebugHierarchy, pair)) {
-      debugger // debug hierarchy hit
+      // debug hierarchy hit
+      debugger // eslint-disable-line no-debugger
     }
   }
 }
@@ -94,7 +98,8 @@ const debugBridge = (bridge) => {
   }
   if (global.entodictonDebugBridge) {
     if (global.entodictonDebugBridge == bridge.id) {
-      debugger // debug hierarchy hit
+      // debug hierarchy hit
+      debugger // eslint-disable-line no-debugger
     }
   }
 }
@@ -105,7 +110,8 @@ const debugOperator = (operator) => {
   }
   if (global.entodictonDebugOperator) {
     if ((operator.pattern || operator) === global.entodictonDebugOperator) {
-      debugger // debug operator hit
+      // debug operator hit
+      debugger // eslint-disable-line no-debugger
     }
   }
 }
@@ -119,21 +125,36 @@ const debugConfigProps = (config) => {
   }
   const checkProps = [
     { property: 'priorities', check: (v) => debugPriority(v) },
-    { property: 'association', check: (v) => debugAssociation(v) },
-    { property: 'words', check: (v) => debugAssociation(v) },
+    { property: 'associations', check: (v) => debugAssociation(v) },
+    // TODO implement debugWords
+    { property: 'words', check: (v) => debugWords(v) },
     { property: 'hierarchy', check: (v) => debugHierarchy(v) },
     { property: 'operators', check: (v) => debugOperator(v) },
     { property: 'bridges', check: (v) => debugBridge(v) }
   ]
   for (const { property, check } of checkProps) {
-    if (property == 'words') {
+    if (property == 'associations') {
+      if (config[property]) {
+        if (config[property].negative) {
+          for (const value of config[property].negative) {
+            check(value)
+          }
+        }
+        if (config[property].positive) {
+          for (const value of config[property].positive) {
+            check(value)
+          }
+        }
+      }
+    } else if (property == 'words') {
+      /*
       if (config[property]) {
-        for (const value in config[property].literals) {
+        for (const value of config[property].literals) {
           check(value)
         }
       }
-    }
-    else if (config[property]) {
+      */
+    } else if (config[property]) {
       for (const value of config[property]) {
         check(value)
       }
@@ -174,6 +195,13 @@ const validConfigProps = (config) => {
     'eqClasses'
   ]
   helpers.validProps(valid, config, 'config')
+
+  // TODO add more type checks
+  if (config.associations) {
+    if (!config.associations.positive && !config.associations.negative) {
+      throw new Error('Expected the \'associations\' property to be a hash with \'positive\' and or \'negative\' properties')
+    }
+  }
 }
 
 const setupInitializerFNArgs = (config, args) => {
@@ -262,7 +290,7 @@ const handleBridgeProps = (config, bridge, { addFirst, uuid } = {}) => {
       if (bridge.development && config.isModule) {
         return
       }
-      if (!bridge.bridge) {
+      if (false && !bridge.bridge) {
         bridge.bridge = '{ ...next(operator) }'
       }
       if (!bridge.level) {
@@ -400,7 +428,7 @@ const handleBridgeProps = (config, bridge, { addFirst, uuid } = {}) => {
           match: (args) => bridge.id == args.context.marker && !!args.context.evaluate == evaluate && match(args),
           apply: (args) => apply(args),
           applyWrapped: semantic,
-          property: evaluate ? 'evaluator':'semantic',
+          property: evaluate ? 'evaluator' : 'semantic'
         }
         if (addFirst) {
           config.config.semantics.unshift(addUUID(semanticDef))
@@ -444,7 +472,7 @@ const handleCalculatedProps = (baseConfig, moreConfig, { addFirst, uuid } = {})
   if (moreConfig.bridges) {
     moreConfig.bridges = moreConfig.bridges.map((bridge) => {
       bridge = { ...bridge }
-      const valid = ['after', 'before', 'bridge', 'development', 'evaluator', 'evaluators', 'generatorp', 'generatorr', 'generatorpr', 'generators', 'operator', 'id', 'convolution', 'inverted', 'isA', 'children', 'parents',
+      const valid = ['after', 'before', 'bridge', 'development', 'return_type_selector', 'evaluator', 'evaluators', 'generatorp', 'generatorr', 'generatorpr', 'generators', 'operator', 'id', 'convolution', 'inverted', 'isA', 'children', 'parents',
         'level', 'optional', 'selector', 'semantic', 'semantics', 'words', /Bridge$/, 'localHierarchy', 'levelSpecificHierarchy', 'where', 'uuid']
       helpers.validProps(valid, bridge, 'bridge')
       handleBridgeProps(baseConfig, bridge, { addFirst, uuid })
@@ -531,7 +559,7 @@ const addWord = (config, uuid) => ({ word, id, initial }) => {
     config.words = {
       literals: {},
       patterns: [],
-      hierarchy: [],
+      hierarchy: []
     }
   }
   const literals = config.words.literals
@@ -562,7 +590,7 @@ const normalizeConfig = (config) => {
         if (!bridge.level) {
           bridge.level = 0
         }
-        if (!bridge.bridge) {
+        if (false && !bridge.bridge) {
           bridge.bridge = '{ ...next(operator) }'
         }
       }
@@ -610,7 +638,7 @@ function setWordsUUIDs (words, uuid) {
   }
   const hierarchy = words.hierarchy
   for (const pair of hierarchy) {
-    pair.uuid = uuid 
+    pair.uuid = uuid
   }
 }
 
@@ -938,7 +966,7 @@ class Config {
       words: {
         literals: {},
         patterns: [],
-        hierarchy: [],
+        hierarchy: []
       }, // Done
       floaters: [],
       implicits: [],
@@ -998,7 +1026,7 @@ class Config {
     }
   }
 
-  get semantics() {
+  get semantics () {
     return [...this.config.semantics]
   }
 
@@ -1044,7 +1072,7 @@ class Config {
         // const todo = [...instantiated]
         // const todo = [...instantiated]
         const todo = _.clone(instantiated)
-        args = {...args}
+        args = { ...args }
         while (todo.length > 0) {
           const context = todo.pop()
           args.context = context
@@ -1125,18 +1153,18 @@ class Config {
         delete config.where
 
         if (config.words && config.words.hierarchy) {
-          config.words.hierarchy = config.words.hierarchy.map( (value) => {
-            value = {...value}
+          config.words.hierarchy = config.words.hierarchy.map((value) => {
+            value = { ...value }
             delete value.uuid
             return value
           })
         }
 
         if (config.words && config.words.patterns) {
-          config.words.patterns = config.words.patterns.map( (value) => {
-            value = {...value}
-            value.defs = value.defs.map( (value) => {
-              value = {...value}
+          config.words.patterns = config.words.patterns.map((value) => {
+            value = { ...value }
+            value.defs = value.defs.map((value) => {
+              value = { ...value }
               delete value.uuid
               return value
             })
@@ -1173,8 +1201,8 @@ class Config {
             delete bridge.evaluators
             delete bridge.semantic
             delete bridge.semantics
-            if (!bridge.bridge) {
-              bridge.bridge = "{ ...next(operator) }"
+            if (false && !bridge.bridge) {
+              bridge.bridge = '{ ...next(operator) }'
             }
             return bridge
           })
@@ -1237,7 +1265,7 @@ class Config {
           let hasQueryOrFragment = false
           for (let rest = iq; rest < templateQueries.length; ++rest) {
             const value = templateQueries[rest]
-            if (typeof value == 'string' || (value.query && value.isFragment)) {
+            if (typeof value === 'string' || (value.query && value.isFragment)) {
               hasQueryOrFragment = true
               break
             }
@@ -1247,7 +1275,7 @@ class Config {
             startOfChanges = iq
           }
         }
-        break;
+        break
       }
     }
 
@@ -1306,7 +1334,7 @@ class Config {
       // TODO fix beforeQuery
       template = { fragments: [], configs: [], ...template }
       template.fragments = template.fragments.concat(this.dynamicFragments)
-      await rebuildTemplate({ config: this, target: this.name, previousResultss: options.previousResultss, startOfChanges: options.startOfChanges, beforeQuery: () => {}, template, ...options })
+      await rebuildTemplate({ config: this, instance, target: this.name, startOfChanges: options.startOfChanges, beforeQuery: () => {}, template, ...options, previousResultss: options.previousResultss || instance.resultss })
     } else {
       // no change
       // this.initInstances.push({ ...instance, name: config.name })
@@ -1396,7 +1424,7 @@ class Config {
 
   addHierarchyInternal (edge) {
     debugHierarchy([edge[0], edge[1]])
-    // because this is called from the semantics and internally. in the semantics the config can be a pseudo config 
+    // because this is called from the semantics and internally. in the semantics the config can be a pseudo config
     // where hierarchy and config.hierarchy do not match
     if (this.hierarchy) {
       this.hierarchy.addEdge(edge)
@@ -1588,7 +1616,7 @@ class Config {
       this.config.words = {
         literals: {},
         patterns: [],
-        hierarchy: [],
+        hierarchy: []
       }
     }
     debugWord(word)
@@ -1611,7 +1639,7 @@ class Config {
       this.config.words = {
         literals: {},
         patterns: [],
-        hierarchy: [],
+        hierarchy: []
       }
     }
 
@@ -1834,7 +1862,7 @@ class Config {
       let defs = pattern.defs || []
       defs = defs.filter((def) => !def.development)
       if (defs.length !== 0) {
-        patternsPrime.push({...pattern, defs})
+        patternsPrime.push({ ...pattern, defs })
       }
     }
     config.words.patterns = patternsPrime
@@ -1849,7 +1877,7 @@ class Config {
     config.words.hierarchy = hierarchyPrime
   }
 
-  terminate() {
+  terminate () {
     this.configs.forEach((km) => {
       const config = km.config
       if (!config.terminatorFn) {
@@ -1860,7 +1888,7 @@ class Config {
     })
   }
 
-  setTerminator(terminatorFn) {
+  setTerminator (terminatorFn) {
     if (terminatorFn) {
       this.terminatorFn = terminatorFn
     }
@@ -1968,11 +1996,11 @@ class Config {
     this.addedArgss.push(moreArgs)
   }
 
-  stop_auto_rebuild() {
+  stop_auto_rebuild () {
     this._stop_auto_rebuild = true
   }
 
-  async restart_auto_rebuild() {
+  async restart_auto_rebuild () {
     this._stop_auto_rebuild = false
     await this.rebuild()
   }
@@ -1985,9 +2013,6 @@ class Config {
       Object.assign(args, addedArgs)
       if (getUUIDScoped) {
         const currentGetUUIDScoped = args.getUUIDScoped
-        if (!currentGetUUIDScoped) {
-          debugger
-        }
         args.getUUIDScoped = (uuid) => Object.assign(currentGetUUIDScoped(uuid), getUUIDScoped(uuid))
       }
     }
@@ -2115,7 +2140,6 @@ class Config {
   // TODO add more details
   equal (config) {
     if (JSON.stringify(this.config) != JSON.stringify(config.config)) {
-      debugger
       return false
     }
     return true
@@ -2172,9 +2196,6 @@ class Config {
     }
     cp.mapUUIDs(map)
 
-    if (cp._uuid == 'concept2') {
-      // debugger
-    }
     if (options.callInitializers) {
       await cp.rebuild(options) // in copy
     } else {
@@ -2580,8 +2601,6 @@ class Config {
         args.currentConfig.wasInitialized = true
       }
       */
-      // debugger
-      // greg55
       config.initializerFn(args, { dontCallFn: true })
       initAfterApis.unshift({ config, args })
       if (config._api) {
@@ -2802,6 +2821,7 @@ class Config {
       config.name = toNS(config.name)
     }
     */
+    /*
     if (config.associations) {
       const map = (associations) => {
         return associations.map((association) => {
@@ -2816,6 +2836,7 @@ class Config {
         associations.negative = map(associations.negative)
       }
     }
+    */
 
     if (config.words) {
       const literals = {}
@@ -2975,7 +2996,7 @@ class Config {
   async add (...createConfigs) {
     createConfigs.forEach((createConfig, index) => {
       if (typeof createConfig !== 'function') {
-        throw new Error(`Expected add argument number ${index+1} to be a function that constructs the config.`)
+        throw new Error(`Expected add argument number ${index + 1} to be a function that constructs the config. This can happen if you have a loop in your includes. Sorry I am too tired to add a good error message. Good luck! I know you can figure it out. I have confidence in you.`)
       }
     })
 
@@ -3330,5 +3351,5 @@ module.exports = {
   Config,
   config_toServer,
   operatorKey_valid,
-  handleBridgeProps,
+  handleBridgeProps
 }

package/src/configHelpers.js

@@ -29,7 +29,7 @@ const gs = (g) => async (contexts, separator, lastSeparator) => {
   return s
 }
 
-const isA = (hierarchy) => (child, parent, { strict=false } = {}) => {
+const isA = (hierarchy) => (child, parent, { strict = false } = {}) => {
   if (!child || !parent) {
     return false
   }
@@ -81,7 +81,6 @@ const cleanAssign = (dest, ...srcs) => {
 }
 
 const setupArgs = (args, config, logs, hierarchy, uuidForScoping) => {
-
   // callId
   args.calls = new InitCalls(args.isInstance ? `${args.isInstance}#${config.name}` : config.name)
   if (global.theprogrammablemind && global.theprogrammablemind.loadForTesting) {
@@ -251,6 +250,13 @@ const setupContexts = (rawContexts) => {
     contexts.push(context)
   }
   contexts.push({ marker: 'controlEnd', controlRemove: true })
+
+  let _index = 0
+  const id = (context) => {
+    context.context_index = _index
+    ++_index
+  }
+  contexts.forEach(id)
   return contexts
 }
 
@@ -440,5 +446,5 @@ module.exports = {
   gs,
   processContextsB,
   loadInstance,
-  isA,
+  isA
 }

package/src/digraph.js

@@ -17,7 +17,6 @@ class Digraph {
 
   // BFS
   path (from, to) {
-    debugger
     const frontier = { [from]: [[]] }
     const done = new Set()
     while (Object.keys(frontier).length > 0) {
@@ -132,7 +131,7 @@ class Digraph {
     for (const node of nodes) {
       nodeToDescendants[node] = this.descendants(node)
     }
-    let minima = new Set()
+    const minima = new Set()
     for (const node of nodes) {
       let okay = true
       for (const key of nodeToDescendants[node]) {
@@ -155,18 +154,17 @@ class Digraph {
     if (nodes.length === 0) {
       return new Set([])
     }
-    debugger
-    nodes = Array.from(nodes);
+    nodes = Array.from(nodes)
     let common = this.ancestors(nodes[0], { includeSelf: true })
 
     for (let i = 1; i < nodes.length; i++) {
       const ancestors = this.ancestors(nodes[i], { includeSelf: true })
       common = new Set([...common].filter(x => ancestors.has(x)))
       if (common.size === 0) {
-        break;
+        break
       }
     }
-    return this.minima(common);
+    return this.minima(common)
   }
 
   /*
@@ -185,13 +183,13 @@ class Digraph {
     this._edges.push([child, parent])
   }
 
-  exists(child, parent) {
+  exists (child, parent) {
     return this._edges.find((edge) => edge[0] == child && edge[1] == parent)
   }
 
   addList (l) {
     for (let i = 1; i < l.length; ++i) {
-      if (!this.exists(l[i-1], l[i])) {
+      if (!this.exists(l[i - 1], l[i])) {
         this._edges.push([l[i - 1], l[i]])
       }
     }

package/src/digraph_internal.js

@@ -1,4 +1,4 @@
-const _ = require('lodash') 
+const _ = require('lodash')
 
 const toA = (edge) => {
   if (Array.isArray(edge)) {
@@ -92,7 +92,6 @@ class DigraphInternal {
       ancestors.add(s)
     }
     return ancestors
-
   }
 
   minima (nodes) {
@@ -101,7 +100,7 @@ class DigraphInternal {
     for (const node of nodes) {
       nodeToDescendants[node] = this.descendants(node)
     }
-    let minima = new Set()
+    const minima = new Set()
     for (const node of nodes) {
       let okay = true
       for (const key of nodeToDescendants[node]) {
@@ -124,17 +123,17 @@ class DigraphInternal {
     if (nodes.length === 0) {
       return new Set([])
     }
-    nodes = Array.from(nodes);
+    nodes = Array.from(nodes)
     let common = this.ancestors(nodes[0], { includeSelf: true })
 
     for (let i = 1; i < nodes.length; i++) {
       const ancestors = this.ancestors(nodes[i], { includeSelf: true })
       common = new Set([...common].filter(x => ancestors.has(x)))
       if (common.size === 0) {
-        break;
+        break
       }
     }
-    return this.minima(common);
+    return this.minima(common)
   }
 
   /*
@@ -153,13 +152,13 @@ class DigraphInternal {
     this._edges.push([child, parent])
   }
 
-  exists(child, parent) {
+  exists (child, parent) {
     return this._edges.findIndex((edge) => edge[0] == child && edge[1] == parent) != -1
   }
 
   addList (l) {
     for (let i = 1; i < l.length; ++i) {
-      if (!this.exists(l[i-1], l[i])) {
+      if (!this.exists(l[i - 1], l[i])) {
         this._edges.push([l[i - 1], l[i]])
       }
     }

package/src/generators.js

@@ -66,7 +66,8 @@ class Generator {
     const matches = await this.match(args)
     if ((matches && (options.debug || {}).match) ||
         callId == this.callId) {
-      debugger // next line is the matcher
+      // next line is the matcher
+      debugger // eslint-disable-line no-debugger
       await this.match(args)
     }
     return matches
@@ -118,16 +119,9 @@ class Generator {
     if (this.property == 'generatorp') {
       args.g = args.gp
     }
-    // if (this.callId) {
-    // greg
-    /*
-    if (callId == 'call11' && this.callId) {
-      debugger;
-    }
-    */
     if ((options.debug || {}).apply ||
         callId == this.callId) {
-      debugger
+      debugger // eslint-disable-line no-debugger
     }
     return await this._apply(args)
   }

package/src/helpers.js

@@ -27,6 +27,28 @@ function where (goUp = 2) {
   }
 }
 
+function suggestAssociationsFix (esummary, asummary) {
+  for (let isummary = 0; isummary < esummary.length; ++isummary) {
+    if (!deepEqual(esummary[isummary], asummary[isummary])) {
+      return esummary[isummary].operators
+    }
+  }
+  return []
+}
+
+function suggestAssociationsFixFromSummaries (esummaries, asummaries) {
+  for (let isummaries = 0; isummaries < esummaries.length; ++isummaries) {
+    const esummary = esummaries[isummaries].summaries
+    const asummary = asummaries[isummaries].summaries
+    for (let isummary = 0; isummary < esummary.length; ++isummary) {
+      if (!deepEqual(esummary[isummary], asummary[isummary])) {
+        return esummary[isummary].operators
+      }
+    }
+  }
+  return []
+}
+
 function w (func) {
   func.where = where(3)
   return func
@@ -438,4 +460,6 @@ module.exports = {
   subPriority,
   where,
   w,
+  suggestAssociationsFix,
+  suggestAssociationsFixFromSummaries
 }

package/src/semantics.js

@@ -73,7 +73,8 @@ class Semantic {
     this.fixUpArgs(args, context)
     const matches = await this.matcher(args)
     if (matches && (options.debug || {}).match || args.callId == this.callId) {
-      debugger // next line is the matcher
+      // next line is the matcher
+      debugger // eslint-disable-line no-debugger
       await this.matcher(args)
     }
     return matches
@@ -92,10 +93,10 @@ class Semantic {
     this.fixUpArgs(args, contextPrime)
 
     if ((options.debug || {}).apply || args.callId == this.callId) {
-      debugger
+      debugger // eslint-disable-line no-debugger
     }
     if (args.breakOnSemantics) {
-      debugger
+      debugger // eslint-disable-line no-debugger
     }
     await this._apply(args)
     return contextPrime
@@ -166,9 +167,6 @@ class Semantics {
     args.log = (message) => { this.logs.push(message) }
     for (const isemantic in this.semantics) {
       const semantic = this.semantics[isemantic]
-      if (!semantic) {
-        debugger
-      }
       // only one question at a time
       if (semantic.isQuestion && seenQuestion) {
         continue
@@ -182,7 +180,7 @@ class Semantics {
           let deferWasCalled = false
           const defer = (listener) => {
             deferred.push({ semantic, listener })
-            deferWasCalled = true 
+            deferWasCalled = true
           }
           args.defer = defer
           contextPrime = await semantic.apply(args, context, s, options)