theprogrammablemind 8.9.1-beta.26 → 8.9.1-beta.28

package/client.js

@@ -12,7 +12,7 @@ const _ = require('lodash')
 const stringify = require('json-stable-stringify')
 const Lines = require('./lines')
 const flattens = require('./src/flatten')
-const { appendNoDups, InitCalls, updateQueries, safeNoDups, stableId, where } = require('./src/helpers')
+const { appendNoDups, InitCalls, updateQueries, safeNoDups, stableId, where, suggestAssociationsFix, suggestAssociationsFixFromSummaries } = require('./src/helpers')
 const runtime = require('./runtime')
 const sortJson = runtime.sortJson
 
@@ -35,6 +35,16 @@ const getConfig_getObjectsCheck = (config, testConfig) => {
   }
 }
 
+const getSuggestion = (diff) => {
+  return diff.map( (element) => {
+    return element.marker
+  })
+}
+
+const getSuggestionMessage = (suggestion) => {
+  return `Try adding this to the associations: { context: ${JSON.stringify(getSuggestion(suggestion))}, choose: <indexOfMainElement> },\n If that does not work look at the logs and check when the operators become wrong during an interation. Deduce the change based on the previous iteration and what operator was applied.`
+}
+
 const getConfig_getContextCheck = (testConfig) => {
   return (testConfig.checks && testConfig.checks.context) || []
 }
@@ -148,7 +158,7 @@ const writeTestFile = (fn, tests) => {
   runtime.fs.writeFileSync(fn, stringify(tests, { space: 2 }), { encoding: 'utf8', flag: 'w+' })
 }
 
-const writeTest = (fn, query, objects, generated, paraphrases, responses, contexts, associations, metadata, config, saveDeveloper, paraphrasesParenthesized, generatedParenthesized) => {
+const writeTest = (fn, query, objects, generated, paraphrases, responses, contexts, associations, metadata, config, saveDeveloper, paraphrasesParenthesized, generatedParenthesized, summaries) => {
   let tests = []
   if (runtime.fs.existsSync(fn)) {
     tests = JSON.parse(runtime.fs.readFileSync(fn))
@@ -160,6 +170,7 @@ const writeTest = (fn, query, objects, generated, paraphrases, responses, contex
   // tests[query] = sortJson({ paraphrases, responses, contexts, objects: convertToStable(objects), associations, metadata, config, developerTest: saveDeveloper }, { depth: 25 })
   const results = sortJson({
     query,
+    summaries,
     paraphrases,
     responses,
     contexts,
@@ -276,7 +287,7 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
     data.errors_ignore_contextual_priorities_non_existant_ops = true
   }
   let queries = query.split('\\n')
-
+  let summaries = [] // for error
   try {
     const response = {
       hierarchy: [],
@@ -294,7 +305,8 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
       paraphrasesParenthesized: [],
       generatedParenthesized: [],
       responses: [],
-      associations: []
+      associations: [],
+      summaries: []
     }
 
     let startCounter = 0
@@ -335,6 +347,8 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
         if (isTest) {
           start = runtime.performance.performance.now()
         }
+        const summary = { summaries: json.summaries, length: json.contexts.length }
+        summaries.push(summary)
         const { contextsPrime, generatedPrime, paraphrasesPrime, paraphrasesParenthesizedPrime, generatedParenthesizedPrime, responsesPrime } =
                                   await processContextsB({ isTest, rebuildingTemplate, config, hierarchy, json, commandLineArgs /*, generators, semantics */ })
         if (isTest) {
@@ -363,6 +377,7 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
         response.paraphrasesParenthesized = response.paraphrasesParenthesized.concat(paraphrasesParenthesizedPrime)
         response.generatedParenthesized = response.generatedParenthesized.concat(generatedParenthesizedPrime)
         response.responses = response.responses.concat(responsesPrime)
+        response.summaries.push(summary)
         queries = queries.slice(1)
       }
     }
@@ -374,11 +389,12 @@ const _process = async (config, query, { initializer, commandLineArgs, credentia
       for (const km of config.configs) {
         saveObjects.nameToUUID[km.name] = km.uuid
       }
-      writeTest(testsFN, query, saveObjects, response.generated, response.paraphrases, response.responses, response.contexts, response.associations, response.metadata, actual_config, saveDeveloper, response.paraphrasesParenthesized, response.generatedParenthesized)
+      writeTest(testsFN, query, saveObjects, response.generated, response.paraphrases, response.responses, response.contexts, response.associations, response.metadata, actual_config, saveDeveloper, response.paraphrasesParenthesized, response.generatedParenthesized, response.summaries)
     }
 
     return response
   } catch (error) {
+    error.summaries = summaries
     error.query = query
     errorHandler(error)
   }
@@ -538,7 +554,8 @@ const runTest = async (config, expected, { args, verbose, testConfig, debug, tim
           checked: expected_checked,
           checkedContexts: pickedExpectedContexts,
           objects: expected_objects,
-          config: expected.config
+          config: expected.config,
+          summaries: expected.summaries,
         },
         actual: {
           responses: result.responses,
@@ -549,7 +566,8 @@ const runTest = async (config, expected, { args, verbose, testConfig, debug, tim
           checked: actual_checked,
           checkedContexts: pickedResultContexts,
           objects: actual_objects,
-          config: actual_config
+          config: actual_config,
+          summaries: result.summaries,
         }
       }
     }
@@ -608,7 +626,7 @@ const saveTest = async (testFile, config, test, expected, testConfig, saveDevelo
   for (const km of config.configs) {
     saveObjects.nameToUUID[km.name] = km.uuid
   }
-  writeTest(testFile, test, saveObjects, result.generated, result.paraphrases, result.responses, result.contexts, result.associations, result.metadata, actualConfig, saveDeveloper, result.paraphrasesParenthesized, result.generatedParenthesized)
+  writeTest(testFile, test, saveObjects, result.generated, result.paraphrases, result.responses, result.contexts, result.associations, result.metadata, actualConfig, saveDeveloper, result.paraphrasesParenthesized, result.generatedParenthesized, result.summaries)
 }
 
 const saveTestsHelper = async (testFile, config, tests, todo, testConfig, saveDeveloper) => {
@@ -903,12 +921,13 @@ const defaultProcess = ({ config, errorHandler }) => async (promise) => {
 }
 
 // builtTemplate saveInstance
-const rebuildTemplate = async ({ config, target, previousResultss, startOfChanges, template, errorHandler = defaultErrorHandler }) => {
+const rebuildTemplate = async ({ config, instance, target, previousResultss, rebuild, startOfChanges, template, errorHandler = defaultErrorHandler }) => {
   const accumulators = {
     resultss: [],
     fragments: [],
     semantics: [],
     associations: [],
+    summaries: [],
     learned_contextual_priorities: []
   }
   config.fragmentsBeingBuilt = []
@@ -942,12 +961,29 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
       try {
         let results
         let prMessage = ''
-        if (previousResults && previousResults.query == query.query) {
+        const suggestFix = (newSummaries) => {
+          if (!previousResults) {
+            return
+          }
+          const suggestion = suggestAssociationsFixFromSummaries(previousResults.summaries, newSummaries)
+          if (suggestion.length > 0) {
+            console.log(getSuggestionMessage(suggestion))
+          }
+        }
+        if (!rebuild && previousResults && previousResults.query == query.query) {
           results = previousResults
           prMessage = ' Using previous results. use -rtf for a hard rebuild of everything on the server side.'
           await loadInstance(config, { resultss: [results] })
         } else {
-          results = await _process(config, query.query, { initializer, rebuildingTemplate: true })
+          try {
+            results = await _process(config, query.query, { initializer, rebuildingTemplate: true })
+          } catch (e) {
+            debugger
+            if (e.summaries && e.summaries.length > 0) {
+              suggestFix(e.summaries)
+            }
+            throw e
+          }
         }
         if (config.config.debug) {
           // TODO pass in the error handler like the other ones
@@ -955,9 +991,11 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
         }
         if (results.contexts.length > 1) {
           console.log(`query "${query.query}". There is ${results.contexts.length} contexts in the results. Make sure its producing the results that you expect.`)
+          suggestFix(results.summaries)
           throw new Error(`query "${query.query}". There is ${results.contexts.length} contexts in the results. Make sure its producing the results that you expect.`)
         } else if (results.paraphrases[0].toLowerCase() !== query.query.toLowerCase()) {
           console.log(`query "${query.query}". The paraphrase is different from the query "${results.paraphrases[0]}".${prMessage}`)
+          // suggestFix(results.summaries)
         } else {
           console.log(`query ${isFragment ? 'fragment' : ''}"${query.query}".${prMessage}`)
         }
@@ -972,6 +1010,7 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
         if (isFragment) {
           config.fragmentsBeingBuilt.push({ query: query.query, contexts: results.contexts })
         }
+        accumulators.summaries = accumulators.summaries.concat(results.summaries)
         accumulators.associations = accumulators.associations.concat(results.associations)
         accumulators.learned_contextual_priorities = accumulators.learned_contextual_priorities.concat(results.learned_contextual_priorities)
         await looper(configs)
@@ -1064,16 +1103,31 @@ const rebuildTemplate = async ({ config, target, previousResultss, startOfChange
   }
   let todo = []
   todo = todo.concat((template.initializers || []).map((query) => { return { initializer: true, property: 'resultss', query, skipSemantics: false || query.skipSemantics } }))
+  /*
   todo = todo.concat((template.configs || []).map((query, index) => {
     let pr
-    if (index < startOfChanges) {
+    if (index < startOfChanges || (!startOfChanges && index < previousResultss.length)) {
       pr = previousResultss[index]
     }
     return { property: 'resultss', query, previousResults: pr, skipSemantics: false || query.skipSemantics }
   }))
-  todo = todo.concat((template.fragments || []).map((query) => { return Object.assign({}, toProperties(query), { property: 'fragments', skipSemantics: false }) }))
-  todo = todo.concat((template.semantics || []).map((definition) => { return { property: 'semantics', query: `${definition.from}\n${definition.to}`, skipSemantics: true } }))
-  await looper(Object.assign([], todo))
+  */
+  if (template.configs) {
+    for (let configsIndex = 0; configsIndex < template.configs.length; ++configsIndex) {
+      const query = template.configs[configsIndex]
+      // account for things for example associations being added to the config while debugginer
+      const pr = previousResultss.find((pr) => pr.query == query)
+      todo.push({ property: 'resultss', query, previousResults: pr, skipSemantics: false || query.skipSemantics })
+    }
+  }
+  todo = todo.concat((template.fragments || []).map((query, index) => { 
+    const pr = instance.fragments[index]
+    return Object.assign({}, toProperties(query), { property: 'fragments', previousResults: pr, skipSemantics: false }) 
+  }))
+  todo = todo.concat((template.semantics || []).map((definition) => { 
+    return { property: 'semantics', query: `${definition.from}\n${definition.to}`, skipSemantics: true } 
+  }))
+  await looper([...todo])
 }
 
 const checkTemplate = (template) => {
@@ -1571,13 +1625,18 @@ const knowledgeModuleImpl = async ({
                   console.log('**************************** ERRORS ************************')
                   for (const result of results) {
                     console.log('Utterance: ', result.utterance)
-                    const show = (label, expected, actual) => {
+                    if (!result.hasError) {
+                      continue
+                    }
+                    const show = (label, expected, actual, { console_log=true } = {}) => {
                       if (JSON.stringify(expected) !== JSON.stringify(actual)) {
-                        if (!headerShown) {
-                          console.log('  Failure')
+                        if (console_log) {
+                          if (!headerShown) {
+                            console.log('  Failure')
+                          }
+                          console.log(`    expected ${label}`, expected)
+                          console.log(`    actual ${label}  `, actual)
                         }
-                        console.log(`    expected ${label}`, expected)
-                        console.log(`    actual ${label}  `, actual)
                         newError = true
                         headerShown = true
                         if (args.vimdiff) {
@@ -1586,6 +1645,44 @@ const knowledgeModuleImpl = async ({
                         result.hasError = true
                       }
                     }
+                    if (!deepEqual(result.expected.summaries, result.actual.summaries)) {
+                      /*
+                      const suggestion = suggestAssociationsFix(result.expected.summaries, result.actual.summaries)
+                      let suggestedFix
+                      if (suggestion) {
+                        suggestedFix = suggestion
+                        console.log(`Try adding this to the associations: { context: ${JSON.stringify(getSuggestion(suggestedFix))}, choose: <indexOfMainElement> }`)
+                      }
+                      */
+
+                      const checkForFix = () => {
+                        for (let iDiff = 0; iDiff < result.expected.paraphrases.length; ++iDiff) {
+                          if (result.expected.paraphrases[iDiff] !== result.actual.paraphrases[iDiff]) {
+                            // const context = result.expected.contexts[iDiff]
+                            let lengths = 0
+                            // just check where the results differ since earlier summaries can be different but dont matter if the result is the same
+                            for (let iSummaries = 0; iSummaries < result.expected.summaries.length; ++iSummaries) {
+                              const summary = result.expected.summaries[iSummaries]
+                              lengths += summary.length
+                              if (lengths > iDiff) {
+                                const suggestion = suggestAssociationsFix(result.expected.summaries[iSummaries].summaries, result.actual.summaries[iSummaries].summaries)
+                                if (suggestion) {
+                                  suggestedFix = suggestion
+                                  // console.log(`Try adding this to the associations: { context: ${JSON.stringify(getSuggestion(suggestedFix))}, choose: <indexOfMainElement> },`)
+                                  console.log(getSuggestionMessage(suggestedFix))
+                                  return
+                                }
+                              }
+                            }
+                          }
+                        }
+                      }
+                      checkForFix()
+
+                      // find the context where the different is
+                      // select the first diff that has a different operator in the range
+                      // show that
+                    }
                     show('paraphrases', result.expected.paraphrases, result.actual.paraphrases)
                     if (!args.testNoParenthesized) {
                       show('paraphrases parenthesized', result.expected.paraphrasesParenthesized, result.actual.paraphrasesParenthesized)
@@ -1749,7 +1846,6 @@ const knowledgeModuleImpl = async ({
     const initConfig = async (config) => {
       if (template) {
         if (config.needsRebuild(template.template, template.instance, { isModule: !isProcess }).needsRebuild) {
-          debugger
           config.needsRebuild(template.template, template.instance, { isModule: !isProcess })
           const error = `This module "${config.name}" cannot be used because the instance file needs rebuilding. Run on the command line with no arguments or the -rt argument to rebuild.`
           throw new Error(error)

package/package.json

@@ -67,6 +67,6 @@
     "sort-json": "^2.0.0",
     "uuid": "^8.3.2"
   },
-  "version": "8.9.1-beta.26",
+  "version": "8.9.1-beta.28",
   "license": "UNLICENSED"
 }

package/src/config.js

@@ -119,19 +119,35 @@ const debugConfigProps = (config) => {
   }
   const checkProps = [
     { property: 'priorities', check: (v) => debugPriority(v) },
-    { property: 'association', check: (v) => debugAssociation(v) },
-    { property: 'words', check: (v) => debugAssociation(v) },
+    { property: 'associations', check: (v) => debugAssociation(v) },
+    // TODO implement debugWords
+    { property: 'words', check: (v) => debugWords(v) },
     { property: 'hierarchy', check: (v) => debugHierarchy(v) },
     { property: 'operators', check: (v) => debugOperator(v) },
     { property: 'bridges', check: (v) => debugBridge(v) }
   ]
   for (const { property, check } of checkProps) {
-    if (property == 'words') {
+    if (property == 'associations') {
+      if (config[property]) {
+        if (config[property].negative) {
+          for (const value of config[property].negative) {
+            check(value)
+          }
+        }
+        if (config[property].positive) {
+          for (const value of config[property].positive) {
+            check(value)
+          }
+        }
+      }
+    } else if (property == 'words') {
+      /*
       if (config[property]) {
-        for (const value in config[property].literals) {
+        for (const value of config[property].literals) {
           check(value)
         }
       }
+      */
     } else if (config[property]) {
       for (const value of config[property]) {
         check(value)
@@ -173,6 +189,13 @@ const validConfigProps = (config) => {
     'eqClasses'
   ]
   helpers.validProps(valid, config, 'config')
+
+  // TODO add more type checks
+  if (config.associations) {
+    if (!config.associations.positive && !config.associations.negative) {
+      throw new Error(`Expected the 'associations' property to be a hash with 'positive' and or 'negative' properties`)
+    }
+  }
 }
 
 const setupInitializerFNArgs = (config, args) => {
@@ -261,7 +284,7 @@ const handleBridgeProps = (config, bridge, { addFirst, uuid } = {}) => {
       if (bridge.development && config.isModule) {
         return
       }
-      if (!bridge.bridge) {
+      if (false && !bridge.bridge) {
         bridge.bridge = '{ ...next(operator) }'
       }
       if (!bridge.level) {
@@ -561,7 +584,7 @@ const normalizeConfig = (config) => {
         if (!bridge.level) {
           bridge.level = 0
         }
-        if (!bridge.bridge) {
+        if (false && !bridge.bridge) {
           bridge.bridge = '{ ...next(operator) }'
         }
       }
@@ -1172,7 +1195,7 @@ class Config {
             delete bridge.evaluators
             delete bridge.semantic
             delete bridge.semantics
-            if (!bridge.bridge) {
+            if (false && !bridge.bridge) {
               bridge.bridge = '{ ...next(operator) }'
             }
             return bridge
@@ -1305,7 +1328,7 @@ class Config {
       // TODO fix beforeQuery
       template = { fragments: [], configs: [], ...template }
       template.fragments = template.fragments.concat(this.dynamicFragments)
-      await rebuildTemplate({ config: this, target: this.name, previousResultss: options.previousResultss, startOfChanges: options.startOfChanges, beforeQuery: () => {}, template, ...options })
+      await rebuildTemplate({ config: this, instance, target: this.name, startOfChanges: options.startOfChanges, beforeQuery: () => {}, template, ...options, previousResultss: options.previousResultss || instance.resultss })
     } else {
       // no change
       // this.initInstances.push({ ...instance, name: config.name })

package/src/helpers.js

@@ -27,6 +27,28 @@ function where (goUp = 2) {
   }
 }
 
+function suggestAssociationsFix(esummary, asummary) {
+  for (let isummary = 0; isummary < esummary.length; ++isummary) {
+    if (!deepEqual(esummary[isummary], asummary[isummary])) {
+      return esummary[isummary].operators
+    }
+  }
+  return []
+}
+
+function suggestAssociationsFixFromSummaries(esummaries, asummaries) {
+  for (let isummaries = 0; isummaries < esummaries.length; ++isummaries) {
+    const esummary = esummaries[isummaries].summaries
+    const asummary = asummaries[isummaries].summaries
+    for (let isummary = 0; isummary < esummary.length; ++isummary) {
+      if (!deepEqual(esummary[isummary], asummary[isummary])) {
+        return esummary[isummary].operators
+      }
+    }
+  }
+  return []
+}
+
 function w (func) {
   func.where = where(3)
   return func
@@ -437,5 +459,7 @@ module.exports = {
   sortJson,
   subPriority,
   where,
-  w
+  w,
+  suggestAssociationsFix,
+  suggestAssociationsFixFromSummaries,
 }