npm - thatcher - Versions diffs - 1.0.7 → 1.0.34 - Mend

thatcher 1.0.7 → 1.0.34

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (174) hide show

package/README.md +4 -16
package/package.json +12 -18
package/src/adapters/google-auth.js +4 -43
package/src/adapters/google-drive.js +12 -67
package/src/app/api/audit/dashboard/route.js +14 -11
package/src/app/api/audit/logs/route.js +2 -2
package/src/app/api/audit/permissions/[id]/route.js +6 -3
package/src/app/api/audit/permissions/route.js +10 -7
package/src/app/api/audit/permissions/stats/route.js +8 -5
package/src/app/api/audit/route.js +4 -4
package/src/app/api/audit/stats/route.js +1 -1
package/src/app/api/auth/google/callback/route.js +5 -2
package/src/app/api/auth/google/route.js +4 -1
package/src/app/api/auth/login/route.js +5 -2
package/src/app/api/auth/mwr-bridge/route.js +11 -21
package/src/app/api/auth/password-reset/route.js +15 -14
package/src/app/api/cron/trigger/route.js +4 -1
package/src/app/api/debug/[[...path]]/route.js +6 -5
package/src/app/api/debug/sqlite/route.js +7 -12
package/src/app/api/debug/sync/route.js +5 -5
package/src/app/api/domains/route.js +4 -1
package/src/app/api/email/allocate/batch/route.js +19 -29
package/src/app/api/email/allocate/route.js +16 -17
package/src/app/api/email/receive/route.js +31 -42
package/src/app/api/email/send/route.js +28 -16
package/src/app/api/email/unallocated/route.js +10 -13
package/src/app/api/files/[id]/route.js +4 -1
package/src/app/api/formula/[[...path]]/route.js +0 -4
package/src/app/api/health/route.js +10 -9
package/src/app/api/metrics/route.js +1 -1
package/src/cli.js +4 -4
package/src/config/config-loader.js +1 -21
package/src/config/constants.js +0 -35
package/src/config/env.js +0 -30
package/src/config/spec-helpers.js +6 -95
package/src/engine.js +23 -0
package/src/engine.server.js +8 -78
package/src/index.js +42 -67
package/src/lib/alert-manager.js +7 -3
package/src/lib/api-helpers.js +4 -3
package/src/lib/api.js +10 -10
package/src/lib/audit-logger-enhanced.js +77 -83
package/src/lib/auth-middleware.js +1 -32
package/src/lib/auth-route-helpers.js +5 -0
package/src/lib/busybase-adapter.js +0 -5
package/src/lib/busybase-audit-reads.js +142 -0
package/src/lib/busybase-audit.js +41 -0
package/src/lib/busybase-lucia-adapter.js +72 -0
package/src/lib/busybase-store.js +338 -0
package/src/lib/config-field-helpers.js +0 -17
package/src/lib/config-generator-engine.js +19 -36
package/src/lib/config-helpers.js +0 -21
package/src/lib/crud-action-helpers.js +2 -2
package/src/lib/crud-factory.js +1 -16
package/src/lib/crud-handlers.js +17 -52
package/src/lib/csrf-protection.js +5 -2
package/src/lib/date-utils.js +3 -127
package/src/lib/debug-registry.js +0 -5
package/src/lib/domain-loader.js +4 -1
package/src/lib/email-sender.js +25 -23
package/src/lib/error-handler.js +5 -41
package/src/lib/error-recovery.js +10 -7
package/src/lib/error-resilience.js +7 -5
package/src/lib/events-engine.js +9 -6
package/src/lib/export-sink.js +0 -5
package/src/lib/field-iterator.js +7 -76
package/src/lib/field-registry.js +0 -22
package/src/lib/generic-crud-handler.js +0 -16
package/src/lib/hook-engine.js +5 -53
package/src/lib/hot-reload/checkpoint.js +5 -2
package/src/lib/hot-reload/promise-container.js +7 -3
package/src/lib/hot-reload/route-wrapper.js +4 -1
package/src/lib/hot-reload/supervisor.js +6 -3
package/src/lib/hyperformula-service.js +0 -5
package/src/lib/id-helpers.js +10 -0
package/src/lib/index.js +4 -7
package/src/lib/log-aggregator.js +0 -1
package/src/lib/logger.js +0 -15
package/src/lib/metrics-collector.js +2 -46
package/src/lib/next-compat.js +15 -1
package/src/lib/observability-bootstrap.js +0 -5
package/src/lib/perf-monitor.js +4 -1
package/src/lib/perf-profiler.js +0 -5
package/src/lib/query-string-adapter.js +5 -47
package/src/lib/realtime-server.js +4 -26
package/src/lib/request-tracing.js +0 -5
package/src/lib/resource-monitor.js +4 -1
package/src/lib/response-formatter.js +0 -38
package/src/lib/route-helpers.js +3 -1
package/src/lib/safe-json.js +5 -1
package/src/lib/server-bootstrap.js +10 -9
package/src/lib/stage-pipeline.js +2 -2
package/src/lib/state-transport-client.js +4 -1
package/src/lib/static-server.js +2 -2
package/src/lib/status-helpers.js +2 -51
package/src/lib/tracing.js +0 -5
package/src/lib/utils.js +6 -67
package/src/lib/validate.js +5 -88
package/src/lib/validators.js +0 -38
package/src/lib/with-audit-logging.js +1 -1
package/src/lib/workflow-engine.js +10 -77
package/src/lib/xstate-workflow-engine.js +3 -9
package/src/plugins/index.js +5 -3
package/src/server/server.js +26 -27
package/src/services/collaborator-role.service.js +21 -77
package/src/services/email-sender.js +7 -34
package/src/services/notification-engine.js +12 -33
package/src/services/permission.service.js +10 -73
package/src/ui/advanced-search-renderer.js +3 -2
package/src/ui/advanced-widgets.js +1 -1
package/src/ui/auth-pages.js +10 -9
package/src/ui/auth-styles.js +1 -1
package/src/ui/client.js +1 -1
package/src/ui/component-engine.js +1 -1
package/src/ui/dashboard-renderer.js +5 -5
package/src/ui/dialog-engine.js +6 -9
package/src/ui/dialog-factory.js +2 -2
package/src/ui/engagement-cards.js +7 -7
package/src/ui/engagement-dialogs.js +2 -3
package/src/ui/engagement-grid-renderer.js +20 -19
package/src/ui/entity-renderer.js +56 -42
package/src/ui/file-dialogs.js +25 -9
package/src/ui/flexup-report-renderer.js +21 -18
package/src/ui/format-helpers.js +27 -28
package/src/ui/highlight-threading-renderer.js +9 -9
package/src/ui/job-management-renderer.js +18 -16
package/src/ui/layout.js +51 -25
package/src/ui/ml-console-renderer.js +15 -16
package/src/ui/monitoring-dashboard-client.js +9 -8
package/src/ui/notifications-renderer.js +11 -10
package/src/ui/page-handler-admin.js +32 -23
package/src/ui/page-handler-helpers.js +27 -23
package/src/ui/page-handler-reviews.js +71 -35
package/src/ui/page-handler-rfi.js +28 -14
package/src/ui/page-handler.js +65 -48
package/src/ui/picker-dialogs.js +26 -19
package/src/ui/render-helpers.js +84 -46
package/src/ui/review-comparison-renderer.js +8 -7
package/src/ui/review-detail-panels.js +8 -9
package/src/ui/review-detail-renderer.js +3 -3
package/src/ui/review-detail-script.js +13 -12
package/src/ui/review-mwr-renderer.js +6 -5
package/src/ui/review-renderer.js +7 -6
package/src/ui/review-widgets.js +3 -3
package/src/ui/rfi-detail-renderer.js +37 -20
package/src/ui/rfi-report-renderer.js +14 -9
package/src/ui/settings-renderer-advanced.js +21 -18
package/src/ui/settings-renderer-advanced2.js +20 -19
package/src/ui/settings-renderer-teams.js +4 -4
package/src/ui/settings-renderer.js +4 -4
package/src/ui/spacing-system.js +5 -2
package/src/ui/standalone-login.js +2 -2
package/src/ui/styles.css +2 -1
package/src/ui/styles2.css +75 -5
package/src/ui/test-page.js +4 -4
package/src/ui/widgets.js +20 -15
package/src/lib/audit-logger.js +0 -193
package/src/lib/database-core.js +0 -255
package/src/lib/database-migrations.js +0 -350
package/src/lib/db-backup.js +0 -97
package/src/lib/error-boundary.js +0 -134
package/src/lib/errors.js +0 -69
package/src/lib/health-monitor.js +0 -134
package/src/lib/index-optimizer.js +0 -96
package/src/lib/query-engine-write.js +0 -221
package/src/lib/query-engine.js +0 -446
package/src/ui/collaboration-dialogs.js +0 -31
package/src/ui/global-tags.js +0 -144
package/src/ui/idle-logout.js +0 -156
package/src/ui/letter-dialogs.js +0 -37
package/src/ui/password-reset-page.js +0 -146
package/src/ui/perf-renderer.js +0 -71
package/src/ui/rfi-renderer.js +0 -194
package/src/ui/validation-ui.js +0 -147

package/src/lib/static-server.js CHANGED Viewed

@@ -18,7 +18,7 @@ export function serveStatic(pathname, req, res, compress, getCacheHeaders, loadM
   }
   if (pathname === '/manifest.json') {
-    const manifest = JSON.stringify({ name: 'MOONLANDING', short_name: 'Moonlanding', start_url: '/', display: 'standalone', background_color: '#f1f5f9', theme_color: '#04141f' });
+    const manifest = JSON.stringify({ name: 'Thatcher', short_name: 'Thatcher', start_url: '/', display: 'standalone', background_color: '#f1f5f9', theme_color: '#04141f' });
     res.setHeader('Content-Type', 'application/json');
     res.setHeader('Cache-Control', 'public, max-age=86400');
     res.setHeader('Content-Length', Buffer.byteLength(manifest, 'utf-8'));
@@ -93,5 +93,5 @@ export function serveStatic(pathname, req, res, compress, getCacheHeaders, loadM
 }
 export function html404() {
-  return `<!DOCTYPE html><html lang="en" data-theme="light"><head><meta charset="UTF-8"><meta name="viewport" content="width=device-width,initial-scale=1"><title>404 - Page Not Found | MOONLANDING</title><link href="/ui/rippleui.css" rel="stylesheet"><link href="/ui/styles2.css" rel="stylesheet"><style>body{margin:0;background:var(--color-bg,#f1f5f9);font-family:system-ui,sans-serif}.nav-shell{background:#04141f;padding:0 2rem;height:56px;display:flex;align-items:center}a.logo-link{color:#fff;text-decoration:none;font-weight:700;font-size:1.1rem}.error-shell{min-height:calc(100vh - 56px);display:flex;align-items:center;justify-content:center}.error-card{background:#fff;border-radius:12px;padding:3rem 4rem;text-align:center;box-shadow:0 1px 3px rgba(0,0,0,.1)}.error-code{font-size:4rem;font-weight:900;color:#04141f;line-height:1}.error-msg{font-size:1.2rem;color:#64748b;margin:0.5rem 0 2rem}.home-btn{display:inline-block;padding:0.75rem 2rem;background:#04141f;color:#fff;border-radius:8px;text-decoration:none;font-weight:600;font-size:0.95rem}</style></head><body><nav class="nav-shell"><a href="/" class="logo-link">MOONLANDING</a></nav><div class="error-shell"><div class="error-card"><div class="error-code">404</div><p class="error-msg">Page not found</p><a href="/" class="home-btn">Go to Dashboard</a></div></div></body></html>`;
+  return `<!DOCTYPE html><html lang="en"><head><meta charset="UTF-8"><script>(function(){try{var t=localStorage.getItem('thatcher-theme')||((window.matchMedia&&window.matchMedia('(prefers-color-scheme: dark)').matches)?'dark':'light');document.documentElement.setAttribute('data-theme',t)}catch(e){document.documentElement.setAttribute('data-theme','light')}})();</script><meta name="viewport" content="width=device-width,initial-scale=1"><title>404 - Page Not Found | Thatcher</title><link href="/ui/rippleui.css" rel="stylesheet"><link href="/ui/styles2.css" rel="stylesheet"><style>body{margin:0;background:var(--color-bg,#f1f5f9);font-family:system-ui,sans-serif}.nav-shell{background:#04141f;padding:0 2rem;height:56px;display:flex;align-items:center}a.logo-link{color:#fff;text-decoration:none;font-weight:700;font-size:1.1rem}.error-shell{min-height:calc(100vh - 56px);display:flex;align-items:center;justify-content:center}.error-card{background:#fff;border-radius:12px;padding:3rem 4rem;text-align:center;box-shadow:0 1px 3px rgba(0,0,0,.1)}.error-code{font-size:4rem;font-weight:900;color:#04141f;line-height:1}.error-msg{font-size:1.2rem;color:#64748b;margin:0.5rem 0 2rem}.home-btn{display:inline-block;padding:0.75rem 2rem;background:#04141f;color:#fff;border-radius:8px;text-decoration:none;font-weight:600;font-size:0.95rem}</style></head><body><nav class="nav-shell"><a href="/" class="logo-link">Thatcher</a></nav><div class="error-shell"><div class="error-card"><div class="error-code">404</div><p class="error-msg">Page not found</p><a href="/" class="home-btn">Go to Dashboard</a></div></div></body></html>`;
 }

package/src/lib/status-helpers.js CHANGED Viewed

@@ -1,8 +1,3 @@
-/**
- * Status Helpers - Status enumerations and transition maps
- * These are the standard status values used by moonlanding parity entities
- */
 import { getConfigEngineSync } from './config-generator-engine.js';
 // Engagement statuses
@@ -73,20 +68,10 @@ export const STAGE_TRANSITIONS = {
   closeout: 'closed',
 };
-/**
- * Get next stage in standard lifecycle
- * @param {string} currentStage
- * @returns {string|null}
- */
 export function getNextStage(currentStage) {
   return STAGE_TRANSITIONS[currentStage] || null;
 }
-/**
- * Get all valid transitions for an engagement
- * @param {string} currentStage
- * @returns {Array<string>}
- */
 export function getValidTransitions(currentStage) {
   const transitions = [];
   for (const [from, to] of Object.entries(STAGE_TRANSITIONS)) {
@@ -131,14 +116,11 @@ function buildEnumFromWorkflow(workflowName) {
   return result;
 }
-/**
- * Human-readable labels for status/stage values.
- * Built from thatcher's own enums so labels track thatcher's enum model.
- */
 function titleCase(v) {
   return String(v).replace(/_/g, ' ').replace(/\b\w/g, (c) => c.toUpperCase());
 }
+// Built from thatcher's own enums so labels track thatcher's enum model.
 export const STATUS_LABELS = {
   ...Object.fromEntries(Object.values(ENGAGEMENT_STATUS).map((v) => [v, titleCase(v)])),
   ...Object.fromEntries(Object.values(ENGAGEMENT_STAGE).map((v) => [v, titleCase(v)])),
@@ -149,44 +131,22 @@ export const STATUS_LABELS = {
   ...Object.fromEntries(Object.values(HIGHLIGHT_STATUS).map((v) => [v, titleCase(v)])),
 };
-/**
- * Get the display label for a status/stage value.
- * @param {string} value
- * @returns {string}
- */
 export function getStatusLabel(value) {
   return STATUS_LABELS[value] || value;
 }
-/**
- * Resolve engagement stages from config workflow, falling back to ENGAGEMENT_STAGE.
- * @returns {Object}
- */
 export function getEngagementStages() {
   return buildEnumFromWorkflow('engagement_lifecycle') || ENGAGEMENT_STAGE;
 }
-/**
- * Resolve RFI states from config workflow, falling back to RFI_STATUS.
- * @returns {Object}
- */
 export function getRfiStates() {
   return buildEnumFromWorkflow('rfi_type_standard') || RFI_STATUS;
 }
-/**
- * Resolve review stages from config workflow, falling back to REVIEW_STATUS.
- * @returns {Object}
- */
 export function getReviewStages() {
   return buildEnumFromWorkflow('review_lifecycle') || REVIEW_STATUS;
 }
-/**
- * Resolve the engagement stage transition map from config, falling back to
- * thatcher's static STAGE_TRANSITIONS.
- * @returns {Object<string,string>}
- */
 export function getStageTransitions() {
   const stages = getCachedConfig()?.workflows?.engagement_lifecycle?.stages;
   if (!stages) return STAGE_TRANSITIONS;
@@ -199,13 +159,6 @@ export function getStageTransitions() {
   return result;
 }
-/**
- * Check whether a transition between two states is valid for an entity type.
- * @param {string} entityType
- * @param {string} from
- * @param {string} to
- * @returns {boolean}
- */
 export function isValidTransition(entityType, from, to) {
   if (entityType === 'engagement') {
     const transitions = getStageTransitions();
@@ -218,9 +171,7 @@ export function isValidTransition(entityType, from, to) {
   return false;
 }
-/**
- * Clear the cached config snapshot (call after a config hot-reload).
- */
+// Call after a config hot-reload to force re-read.
 export function clearCachedConfig() {
   _cachedConfig = null;
 }

package/src/lib/tracing.js CHANGED Viewed

@@ -1,8 +1,3 @@
-/**
- * Observability Tracing Core - OpenTelemetry-style distributed tracing for Thatcher
- * Provides trace/span lifecycle, async context propagation, and trace export
- */
 import { AsyncLocalStorage } from 'async_hooks';
 import { createLogger } from './logger.js';

package/src/lib/utils.js CHANGED Viewed

@@ -1,24 +1,13 @@
-/**
- * Utility Functions - Common helpers
- */
-import { list } from './query-engine.js';
+import { list } from './busybase-store.js';
 import { getSpec } from '../config/spec-helpers.js';
-/**
- * Load ref-field options for a spec's form (ported from moonlanding).
- * For each `ref` field, fetch the referenced entity's rows and build
- * `{ value, label }` option lists. `engagement` refs get a richer label
- * and skip archived rows. Failures degrade to an empty option list.
- * @param {object} spec - Entity spec with a `fields` map
- * @returns {Promise<Record<string, Array<{value:any,label:string}>>>}
- */
+// Ported from moonlanding. engagement refs get a richer label and skip archived rows; failures degrade to [].
 export async function loadFormOptions(spec) {
   const options = {};
   for (const [key, field] of Object.entries(spec.fields || {})) {
     if (field.type === 'ref' && field.ref) {
       try {
-        const data = list(field.ref);
+        const data = await list(field.ref);
         if (field.ref === 'engagement') {
           options[key] = data
             .filter(r => r.status !== 'archived')
@@ -40,9 +29,7 @@ export async function loadFormOptions(spec) {
   return options;
 }
-/**
- * Error thrown when an entity spec cannot be resolved (ported from moonlanding).
- */
+// Ported from moonlanding.
 export class SpecError extends Error {
   constructor(entity) {
     super(`Unknown entity: ${entity}`);
@@ -51,12 +38,7 @@ export class SpecError extends Error {
   }
 }
-/**
- * Resolve an entity spec, throwing a typed SpecError on failure (ported from
- * moonlanding). Uses thatcher's single-arg getSpec convention.
- * @param {string} entity
- * @returns {Promise<object>}
- */
+// Ported from moonlanding. Uses thatcher's single-arg getSpec convention.
 export async function resolveSpec(entity) {
   try {
     const spec = getSpec(entity);
@@ -68,21 +50,11 @@ export async function resolveSpec(entity) {
   }
 }
-/**
- * Get display name for user
- * @param {object} user - User with name or email
- * @returns {string}
- */
 export function getDisplayName(user) {
   if (!user) return 'Unknown';
   return user.name || user.email || user.id || 'Unknown';
 }
-/**
- * Get initials from name or email
- * @param {string|object} userOrName
- * @returns {string}
- */
 export function getInitials(userOrName) {
   let name = typeof userOrName === 'string' ? userOrName : getDisplayName(userOrName);
   const parts = name.trim().split(/\s+/);
@@ -92,20 +64,10 @@ export function getInitials(userOrName) {
   return (parts[0].charAt(0) + parts[parts.length - 1].charAt(0)).toUpperCase();
 }
-/**
- * Get user role
- * @param {object} user
- * @returns {string}
- */
 export function getUserRole(user) {
   return user?.role || 'user';
 }
-/**
- * Slugify string (URL-safe)
- * @param {string} str
- * @returns {string}
- */
 export function slugify(str) {
   return str
     .toLowerCase()
@@ -115,25 +77,12 @@ export function slugify(str) {
     .replace(/^-+|-+$/g, '');
 }
-/**
- * Truncate text
- * @param {string} text
- * @param {number} maxLength
- * @param {string} suffix
- * @returns {string}
- */
 export function truncate(text, maxLength = 50, suffix = '...') {
   if (!text) return '';
   if (text.length <= maxLength) return text;
   return text.slice(0, maxLength - suffix.length) + suffix;
 }
-/**
- * Deep merge objects
- * @param {object} target
- * @param {object} source
- * @returns {object}
- */
 export function deepMerge(target, source) {
   const output = { ...target };
   for (const key of Object.keys(source)) {
@@ -146,10 +95,6 @@ export function deepMerge(target, source) {
   return output;
 }
-/**
- * Generate a random color
- * @returns {string} Hex color
- */
 export function randomColor() {
   const colors = [
     '#228be6', '#40c057', '#fab005', '#fa5252', '#15aabf',
@@ -158,13 +103,7 @@ export function randomColor() {
   return colors[Math.floor(Math.random() * colors.length)];
 }
-/**
- * Determine whether a user record is active (ported from moonlanding).
- * Treats explicit inactive/disabled/suspended status, falsy `is_active`,
- * or a set `deleted_at` as inactive.
- * @param {object} user
- * @returns {boolean}
- */
+// Ported from moonlanding. inactive/disabled/suspended status, falsy is_active, or set deleted_at all count as inactive.
 export function isUserActive(user) {
   if (!user) return false;
   if (user.is_active === false || user.is_active === 0) return false;

package/src/lib/validate.js CHANGED Viewed

@@ -1,7 +1,4 @@
-/**
- * Validation System - Field and entity validation
- * Adapted from moonlanding/src/lib/validate.js
- */
+// Adapted from moonlanding/src/lib/validate.js
 import { getSpec } from '../config/spec-helpers.js';
 import { isValidEmail as checkEmailFormat, isValidEmail } from './validators.js';
@@ -13,22 +10,10 @@ export { isValidEmail };
 const HTML_ESC = { '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' };
-/**
- * Sanitize HTML
- * @param {string} str
- * @returns {string}
- */
 function sanitizeHtml(str) {
   return typeof str === 'string' ? str.replace(/[&<>"']/g, c => HTML_ESC[c]) : str;
 }
-/**
- * Validate a single field
- * @param {object} fieldDef
- * @param {any} value
- * @param {object} options
- * @returns {Promise<{valid: boolean, error?: string}>}
- */
 export async function validateField(fieldDef, value, options = {}) {
   const { fieldName, entityName, existingValue } = options;
@@ -65,9 +50,9 @@ export async function validateField(fieldDef, value, options = {}) {
       return { valid: true };
     }
     try {
-      const { get } = await import('./query-engine.js');
+      const { getBy } = await import('./busybase-store.js');
       const refTable = fieldDef.ref === 'user' ? 'users' : fieldDef.ref;
-      if (!get(refTable, value)) {
+      if (!(await getBy(refTable, 'id', value))) {
         return {
           valid: false,
           error: `${fieldDef.ref.charAt(0).toUpperCase() + fieldDef.ref.slice(1)} with id '${value}' not found`,
@@ -81,13 +66,6 @@ export async function validateField(fieldDef, value, options = {}) {
   return { valid: true };
 }
-/**
- * Validate type of value
- * @param {object} fieldDef
- * @param {any} value
- * @param {string} fieldName
- * @returns {string|null}
- */
 function validateType(fieldDef, value, fieldName) {
   const { type, min, max } = fieldDef;
@@ -112,12 +90,6 @@ function validateType(fieldDef, value, fieldName) {
   return null;
 }
-/**
- * Resolve enum options from field definition
- * @param {object} fieldDef
- * @param {string} entityName
- * @returns {Array<string>}
- */
 function resolveEnumOptions(fieldDef, entityName) {
   if (Array.isArray(fieldDef.options)) {
     return fieldDef.options.map(o => typeof o === 'object' ? o.value : o);
@@ -136,13 +108,6 @@ function resolveEnumOptions(fieldDef, entityName) {
   return [];
 }
-/**
- * Validate all fields for an entity
- * @param {string} entityName
- * @param {object} data
- * @param {object} existingRecord
- * @returns {Promise<object>} Errors object keyed by field name
- */
 export async function validateEntity(entityName, data, existingRecord = null) {
   const spec = getSpec(entityName);
   const errors = {};
@@ -170,23 +135,15 @@ export async function validateEntity(entityName, data, existingRecord = null) {
   return errors;
 }
-/**
- * Enforce a field's `unique` constraint against the datastore.
- * Returns an error string if a duplicate exists, otherwise null.
- * @param {object} fieldDef
- * @param {any} value
- * @param {object} options - { fieldName, entityName, existingRecord }
- * @returns {Promise<string|null>}
- */
 async function checkUnique(fieldDef, value, { fieldName, entityName, existingRecord }) {
   if (!fieldDef.unique) return null;
   if (value == null || value === '') return null;
   const existingValue = existingRecord?.[fieldName];
   if (value === existingValue) return null;
   try {
-    const { get } = await import('./query-engine.js');
+    const { getBy } = await import('./busybase-store.js');
     const table = entityName === 'user' ? 'users' : entityName;
-    const dup = get(table, undefined, { [fieldName]: value });
+    const dup = await getBy(table, fieldName, value);
     if (dup && (!existingRecord || dup.id !== existingRecord.id)) {
       return `Field '${fieldName}' must be unique`;
     }
@@ -196,13 +153,6 @@ async function checkUnique(fieldDef, value, { fieldName, entityName, existingRec
   return null;
 }
-/**
- * Validate update (only changed fields)
- * @param {string} entityName
- * @param {object} changes
- * @param {object} existingRecord
- * @returns {Promise<object>}
- */
 export async function validateUpdate(entityName, changes, existingRecord) {
   const spec = getSpec(entityName);
   const errors = {};
@@ -232,23 +182,10 @@ export async function validateUpdate(entityName, changes, existingRecord) {
   return errors;
 }
-/**
- * Check if errors object has any errors
- * @param {object} errors
- * @returns {boolean}
- */
 export function hasErrors(errors) {
   return errors && Object.keys(errors).length > 0;
 }
-/**
- * Validate a status/stage transition is permitted.
- * Uses thatcher's STAGE_TRANSITIONS graph via getValidTransitions.
- * @param {string} entityType
- * @param {string} currentStatus
- * @param {string} newStatus
- * @returns {{valid: boolean, reason?: string}}
- */
 export function validateStatusTransition(entityType, currentStatus, newStatus) {
   if (!currentStatus || !newStatus) {
     return { valid: false, reason: 'Status values required' };
@@ -264,13 +201,6 @@ export function validateStatusTransition(entityType, currentStatus, newStatus) {
   return { valid: true };
 }
-/**
- * Validate that an end date is not before a start date.
- * @param {number} startSeconds - Unix timestamp (seconds)
- * @param {number} endSeconds - Unix timestamp (seconds)
- * @param {string} label
- * @returns {{valid: boolean, reason?: string}}
- */
 export function validateDateRange(startSeconds, endSeconds, label = 'date') {
   if (!startSeconds || !endSeconds) return { valid: true };
   if (isBeforeDate(endSeconds, startSeconds)) {
@@ -279,13 +209,6 @@ export function validateDateRange(startSeconds, endSeconds, label = 'date') {
   return { valid: true };
 }
-/**
- * Validate a deadline: required, not before a reference date, within maxYears.
- * @param {number} deadlineSeconds - Unix timestamp (seconds)
- * @param {number} [referenceSeconds] - Unix timestamp (seconds)
- * @param {number} [maxYears=2]
- * @returns {{valid: boolean, reason?: string}}
- */
 export function validateDeadline(deadlineSeconds, referenceSeconds, maxYears = 2) {
   if (!deadlineSeconds) return { valid: false, reason: 'Deadline is required' };
   if (referenceSeconds && isBeforeDate(deadlineSeconds, referenceSeconds)) {
@@ -302,12 +225,6 @@ export function validateDeadline(deadlineSeconds, referenceSeconds, maxYears = 2
   return { valid: true };
 }
-/**
- * Sanitize string/text fields of a record using the entity spec.
- * @param {object} data
- * @param {object} spec
- * @returns {object} Sanitized shallow copy
- */
 export function sanitizeData(data, spec) {
   const sanitized = { ...data };
   for (const [fieldName, value] of Object.entries(sanitized)) {

package/src/lib/validators.js CHANGED Viewed

@@ -1,12 +1,3 @@
-/**
- * Validation Utilities - Reusable validation functions
- */
-/**
- * Validate email address
- * @param {string} email
- * @returns {{valid: boolean, email?: string, domain?: string, reason?: string}}
- */
 export function isValidEmail(email) {
   if (!email || typeof email !== 'string') {
     return { valid: false, reason: 'Email is required' };
@@ -37,11 +28,6 @@ export function isValidEmail(email) {
   return { valid: true, email: trimmed, domain };
 }
-/**
- * Validate URL
- * @param {string} url
- * @returns {boolean}
- */
 export function isValidUrl(url) {
   try {
     new URL(url);
@@ -51,13 +37,6 @@ export function isValidUrl(url) {
   }
 }
-/**
- * Validate date is within range
- * @param {number} timestamp - Unix timestamp (seconds)
- * @param {number} minYearsAgo
- * @param {number} maxYearsAhead
- * @returns {boolean}
- */
 export function isWithinYears(timestamp, minYearsAgo = 10, maxYearsAhead = 5) {
   const now = Date.now() / 1000;
   const secondsInYear = 365.25 * 24 * 60 * 60;
@@ -67,21 +46,10 @@ export function isWithinYears(timestamp, minYearsAgo = 10, maxYearsAhead = 5) {
   );
 }
-/**
- * Check if date1 is before date2
- * @param {number} date1 - Unix timestamp
- * @param {number} date2 - Unix timestamp
- * @returns {boolean}
- */
 export function isBeforeDate(date1, date2) {
   return date1 < date2;
 }
-/**
- * Slugify string
- * @param {string} str
- * @returns {string}
- */
 export function slugify(str) {
   return str
     .toLowerCase()
@@ -91,12 +59,6 @@ export function slugify(str) {
     .replace(/^-+|-+$/g, '');
 }
-/**
- * Validate required fields object
- * @param {object} data
- * @param {Array<string>} requiredFields
- * @returns {Array<string>} Missing field names
- */
 export function getMissingFields(data, requiredFields) {
   return requiredFields.filter(field => {
     const val = data[field];

package/src/lib/with-audit-logging.js CHANGED Viewed

@@ -4,7 +4,7 @@ const extractEntityInfo = (request, params = {}) => {
   const url = new URL(request.url);
   const parts = url.pathname.split('/').filter(Boolean);
   const entityType = parts[parts.length - 2] || 'unknown';
-  const entityId = params.id || params.engagementId || params.reviewId || params.highlightId || params.permissionId || parts[parts.length - 1];
+  const entityId = params.id || parts[parts.length - 1];
   return { entityType, entityId };
 };