thachvd-kit 1.0.35 → 1.0.37

package/bin/matt-skills.js

@@ -1,191 +1,192 @@
-const fs = require('fs');
-const path = require('path');
-const { spawnSync } = require('child_process');
-
-// Source repository for Matt Pocock's promoted skills, installed via the
-// upstream `skills` CLI (npx skills@latest add <source>).
-const MATT_SKILLS_SOURCE = 'mattpocock/skills';
-
-// This list mirrors upstream's promoted daily-driver catalog:
-// https://github.com/mattpocock/skills -> skills/engineering/ + skills/productivity/
-// Do NOT add anything from skills/in-progress, skills/misc, or skills/deprecated —
-// those are explicitly not part of the supported set. Update this list by hand
-// when upstream promotes a new skill or retires one; there is no reliable
-// upstream "promoted only" filter, so this manifest is the source of truth.
-const PROMOTED_SKILLS = [
-    // skills/engineering
-    'ask-matt',
-    'code-review',
-    'codebase-design',
-    'diagnosing-bugs',
-    'domain-modeling',
-    'grill-with-docs',
-    'implement',
-    'improve-codebase-architecture',
-    'prototype',
-    'research',
-    'resolving-merge-conflicts',
-    'setup-matt-pocock-skills',
-    'tdd',
-    'to-spec',
-    'to-tickets',
-    'triage',
-    'wayfinder',
-    'wizard',
-    // skills/productivity
-    'grill-me',
-    'grilling',
-    'handoff',
-    'teach',
-    'to-questionnaire',
-    'wait-what',
-    'writing-for-agents'
-];
-
-// Agent identifiers as understood by the upstream `skills` CLI (verified
-// against its installed agent registry). Both currently resolve to the same
-// project-local skills directory below.
-const SUPPORTED_AGENTS = ['codex', 'antigravity'];
-
-// Project-local install target. Skills are intentionally not installed
-// globally (see AGENTS.md / .agent/docs/tooling.md for the reasoning).
-const SKILLS_RELATIVE_DIR = path.join('.agents', 'skills');
-
-const SETUP_SKILL_NAME = 'setup-matt-pocock-skills';
-
-function npxCommand() {
-    return process.platform === 'win32' ? 'npx.cmd' : 'npx';
-}
-
-function skillsDirFor(targetDir) {
-    return path.join(targetDir, SKILLS_RELATIVE_DIR);
-}
-
-function isSkillInstalled(targetDir, name) {
-    return fs.existsSync(path.join(skillsDirFor(targetDir), name, 'SKILL.md'));
-}
-
-// Read-only: never spawns a process. Safe to call from `doctor` and
-// `skills check`.
-function checkSkills(targetDir) {
-    const installed = [];
-    const missing = [];
-    for (const name of PROMOTED_SKILLS) {
-        (isSkillInstalled(targetDir, name) ? installed : missing).push(name);
-    }
-    return { installed, missing, total: PROMOTED_SKILLS.length };
-}
-
-// Builds the argv for `npx skills@latest add <source> ...`. Always passes
-// `--skill <name>` as separate argv entries (never `--skill=<name>`): current
-// `skills` CLI versions have a parsing bug where the `--skill=<name>` form is
-// silently ignored and installs every skill in the source repository,
-// including skills/in-progress, skills/misc, and skills/deprecated.
-function buildAddArgs(skillNames) {
-    return [
-        '-y', // npx: auto-confirm installing the `skills` package itself
-        'skills@latest',
-        'add',
-        MATT_SKILLS_SOURCE,
-        '--skill', ...skillNames,
-        '--agent', ...SUPPORTED_AGENTS,
-        '-y' // skills CLI: skip its own confirmation prompts
-    ];
-}
-
-function formatCommand(args) {
-    return `${npxCommand()} ${args.join(' ')}`;
-}
-
-function runNpx(args, options = {}) {
-    return spawnSync(npxCommand(), args, {
-        cwd: options.cwd,
-        encoding: 'utf8',
-        stdio: options.stdio || 'pipe',
-        shell: process.platform === 'win32'
-    });
-}
-
-// Installs the full promoted set in a single `add` call (one clone, one
-// filtered install). Never uses `--all`, which would also install
-// in-progress/misc/deprecated skills.
-function installSkills(targetDir, options = {}) {
-    const dryRun = options.dryRun === true;
-    const args = buildAddArgs(PROMOTED_SKILLS);
-    const command = formatCommand(args);
-
-    if (dryRun) {
-        return { ok: true, dryRun: true, command, message: `Dry run: would run ${command}` };
-    }
-
-    const result = runNpx(args, { cwd: targetDir, stdio: 'inherit' });
-    if (result.error || result.status !== 0) {
-        return { ok: false, dryRun: false, command, message: `failed to install promoted skills; run manually: ${command}` };
-    }
-    return {
-        ok: true,
-        dryRun: false,
-        command,
-        message: `installed ${PROMOTED_SKILLS.length} promoted Matt Pocock skills to ${SKILLS_RELATIVE_DIR}`
-    };
-}
-
-// Updates each promoted skill by re-adding it individually and idempotently.
-// This is deliberately NOT `npx skills update`: upstream has a known issue
-// where updating one project skill can reinstall every skill from the
-// source. Re-adding by explicit single-skill name only ever touches that
-// skill's directory (verified manually against the upstream CLI).
-// Trade-off: this does one network clone of the source repo per promoted
-// skill (~PROMOTED_SKILLS.length calls), so it is noticeably slower than
-// `installSkills`'s single batched call. That cost is accepted deliberately
-// for the safety guarantee above; revisit only if upstream ships a scoped,
-// non-destructive `update`.
-function updateSkills(targetDir, options = {}) {
-    const dryRun = options.dryRun === true;
-    const results = [];
-
-    for (const name of PROMOTED_SKILLS) {
-        const args = buildAddArgs([name]);
-        const command = formatCommand(args);
-
-        if (dryRun) {
-            results.push({ name, ok: true, dryRun: true, command });
-            continue;
-        }
-
-        const result = runNpx(args, { cwd: targetDir, stdio: 'pipe' });
-        const ok = !result.error && result.status === 0;
-        results.push({
-            name,
-            ok,
-            dryRun: false,
-            command,
-            error: ok ? null : (result.stderr || result.stdout || `exit ${result.status}`)
-        });
-    }
-
-    const failed = results.filter(r => !r.ok);
-    const message = dryRun
-        ? `Dry run: would update ${PROMOTED_SKILLS.length} promoted skills one by one`
-        : failed.length === 0
-            ? `updated ${PROMOTED_SKILLS.length} promoted Matt Pocock skills`
-            : `updated ${results.length - failed.length}/${PROMOTED_SKILLS.length} promoted skills; failed: ${failed.map(f => f.name).join(', ')}`;
-
-    return { ok: failed.length === 0, dryRun, results, message };
-}
-
-module.exports = {
-    MATT_SKILLS_SOURCE,
-    PROMOTED_SKILLS,
-    SUPPORTED_AGENTS,
-    SKILLS_RELATIVE_DIR,
-    SETUP_SKILL_NAME,
-    npxCommand,
-    skillsDirFor,
-    isSkillInstalled,
-    checkSkills,
-    buildAddArgs,
-    formatCommand,
-    installSkills,
-    updateSkills
-};
+const fs = require('fs');
+const path = require('path');
+const { spawnSync } = require('child_process');
+
+// Source repository for Matt Pocock's promoted skills, installed via the
+// upstream `skills` CLI (npx skills@latest add <source>).
+const MATT_SKILLS_SOURCE = 'mattpocock/skills';
+
+// This list mirrors upstream's promoted daily-driver catalog:
+// https://github.com/mattpocock/skills -> skills/engineering/ + skills/productivity/
+// Do NOT add anything from skills/in-progress, skills/misc, or skills/deprecated —
+// those are explicitly not part of the supported set. Update this list by hand
+// when upstream promotes a new skill or retires one; there is no reliable
+// upstream "promoted only" filter, so this manifest is the source of truth.
+const PROMOTED_SKILLS = [
+    // skills/engineering
+    'ask-matt',
+    'code-review',
+    'codebase-design',
+    'diagnosing-bugs',
+    'domain-modeling',
+    'grill-with-docs',
+    'implement',
+    'improve-codebase-architecture',
+    'prototype',
+    'research',
+    'resolving-merge-conflicts',
+    'setup-matt-pocock-skills',
+    'tdd',
+    'to-spec',
+    'to-tickets',
+    'triage',
+    'wayfinder',
+    'wizard',
+    // skills/productivity
+    'grill-me',
+    'grilling',
+    'handoff',
+    'teach',
+    'to-questionnaire',
+    'wait-what',
+    'writing-for-agents'
+];
+
+// Agent identifiers as understood by the upstream `skills` CLI. Codex and
+// Antigravity share the project-local .agents/skills directory; Claude Code
+// also receives its native .claude/skills integration so skills are exposed
+// as slash commands such as /ask-matt and /implement.
+const SUPPORTED_AGENTS = ['codex', 'antigravity', 'claude-code'];
+
+// Project-local install target. Skills are intentionally not installed
+// globally (see AGENTS.md / .agent/docs/tooling.md for the reasoning).
+const SKILLS_RELATIVE_DIR = path.join('.agents', 'skills');
+
+const SETUP_SKILL_NAME = 'setup-matt-pocock-skills';
+
+function npxCommand() {
+    return process.platform === 'win32' ? 'npx.cmd' : 'npx';
+}
+
+function skillsDirFor(targetDir) {
+    return path.join(targetDir, SKILLS_RELATIVE_DIR);
+}
+
+function isSkillInstalled(targetDir, name) {
+    return fs.existsSync(path.join(skillsDirFor(targetDir), name, 'SKILL.md'));
+}
+
+// Read-only: never spawns a process. Safe to call from `doctor` and
+// `skills check`.
+function checkSkills(targetDir) {
+    const installed = [];
+    const missing = [];
+    for (const name of PROMOTED_SKILLS) {
+        (isSkillInstalled(targetDir, name) ? installed : missing).push(name);
+    }
+    return { installed, missing, total: PROMOTED_SKILLS.length };
+}
+
+// Builds the argv for `npx skills@latest add <source> ...`. Always passes
+// `--skill <name>` as separate argv entries (never `--skill=<name>`): current
+// `skills` CLI versions have a parsing bug where the `--skill=<name>` form is
+// silently ignored and installs every skill in the source repository,
+// including skills/in-progress, skills/misc, and skills/deprecated.
+function buildAddArgs(skillNames) {
+    return [
+        '-y', // npx: auto-confirm installing the `skills` package itself
+        'skills@latest',
+        'add',
+        MATT_SKILLS_SOURCE,
+        '--skill', ...skillNames,
+        '--agent', ...SUPPORTED_AGENTS,
+        '-y' // skills CLI: skip its own confirmation prompts
+    ];
+}
+
+function formatCommand(args) {
+    return `${npxCommand()} ${args.join(' ')}`;
+}
+
+function runNpx(args, options = {}) {
+    return spawnSync(npxCommand(), args, {
+        cwd: options.cwd,
+        encoding: 'utf8',
+        stdio: options.stdio || 'pipe',
+        shell: process.platform === 'win32'
+    });
+}
+
+// Installs the full promoted set in a single `add` call (one clone, one
+// filtered install). Never uses `--all`, which would also install
+// in-progress/misc/deprecated skills.
+function installSkills(targetDir, options = {}) {
+    const dryRun = options.dryRun === true;
+    const args = buildAddArgs(PROMOTED_SKILLS);
+    const command = formatCommand(args);
+
+    if (dryRun) {
+        return { ok: true, dryRun: true, command, message: `Dry run: would run ${command}` };
+    }
+
+    const result = runNpx(args, { cwd: targetDir, stdio: 'inherit' });
+    if (result.error || result.status !== 0) {
+        return { ok: false, dryRun: false, command, message: `failed to install promoted skills; run manually: ${command}` };
+    }
+    return {
+        ok: true,
+        dryRun: false,
+        command,
+        message: `installed ${PROMOTED_SKILLS.length} promoted Matt Pocock skills to ${SKILLS_RELATIVE_DIR}`
+    };
+}
+
+// Updates each promoted skill by re-adding it individually and idempotently.
+// This is deliberately NOT `npx skills update`: upstream has a known issue
+// where updating one project skill can reinstall every skill from the
+// source. Re-adding by explicit single-skill name only ever touches that
+// skill's directory (verified manually against the upstream CLI).
+// Trade-off: this does one network clone of the source repo per promoted
+// skill (~PROMOTED_SKILLS.length calls), so it is noticeably slower than
+// `installSkills`'s single batched call. That cost is accepted deliberately
+// for the safety guarantee above; revisit only if upstream ships a scoped,
+// non-destructive `update`.
+function updateSkills(targetDir, options = {}) {
+    const dryRun = options.dryRun === true;
+    const results = [];
+
+    for (const name of PROMOTED_SKILLS) {
+        const args = buildAddArgs([name]);
+        const command = formatCommand(args);
+
+        if (dryRun) {
+            results.push({ name, ok: true, dryRun: true, command });
+            continue;
+        }
+
+        const result = runNpx(args, { cwd: targetDir, stdio: 'pipe' });
+        const ok = !result.error && result.status === 0;
+        results.push({
+            name,
+            ok,
+            dryRun: false,
+            command,
+            error: ok ? null : (result.stderr || result.stdout || `exit ${result.status}`)
+        });
+    }
+
+    const failed = results.filter(r => !r.ok);
+    const message = dryRun
+        ? `Dry run: would update ${PROMOTED_SKILLS.length} promoted skills one by one`
+        : failed.length === 0
+            ? `updated ${PROMOTED_SKILLS.length} promoted Matt Pocock skills`
+            : `updated ${results.length - failed.length}/${PROMOTED_SKILLS.length} promoted skills; failed: ${failed.map(f => f.name).join(', ')}`;
+
+    return { ok: failed.length === 0, dryRun, results, message };
+}
+
+module.exports = {
+    MATT_SKILLS_SOURCE,
+    PROMOTED_SKILLS,
+    SUPPORTED_AGENTS,
+    SKILLS_RELATIVE_DIR,
+    SETUP_SKILL_NAME,
+    npxCommand,
+    skillsDirFor,
+    isSkillInstalled,
+    checkSkills,
+    buildAddArgs,
+    formatCommand,
+    installSkills,
+    updateSkills
+};

package/bin/native-skills.js

@@ -0,0 +1,149 @@
+const fs = require('fs');
+const path = require('path');
+
+const NATIVE_SKILLS = [
+    'using-git-worktrees',
+    'subagent-driven-development',
+    'finishing-a-development-branch'
+];
+
+const NATIVE_SUPPORT_FILES = [
+    path.join('requesting-code-review', 'code-reviewer.md')
+];
+
+const NATIVE_SKILL_SURFACES = [
+    { id: 'agents', relativeDir: path.join('.agents', 'skills') },
+    { id: 'claude', relativeDir: path.join('.claude', 'skills') }
+];
+
+const nativeSkillsSourceDir = path.resolve(__dirname, '..', 'skills');
+
+function sourcePath(relativePath) {
+    return path.join(nativeSkillsSourceDir, relativePath);
+}
+
+function skillSourceDir(name) {
+    return sourcePath(name);
+}
+
+function collectFiles(directory, relative = '') {
+    const files = [];
+    for (const entry of fs.readdirSync(directory, { withFileTypes: true })) {
+        const entryRelative = path.join(relative, entry.name);
+        const entryPath = path.join(directory, entry.name);
+        if (entry.isDirectory()) files.push(...collectFiles(entryPath, entryRelative));
+        else if (entry.isFile()) files.push(entryRelative);
+    }
+    return files;
+}
+
+function ownedFiles() {
+    return [
+        ...NATIVE_SKILLS.flatMap(name => collectFiles(skillSourceDir(name), name)),
+        ...NATIVE_SUPPORT_FILES
+    ];
+}
+
+function ownedSkillFiles(name) {
+    return collectFiles(skillSourceDir(name), name);
+}
+
+function targetPath(targetDir, surface, relativePath) {
+    return path.join(targetDir, surface.relativeDir, relativePath);
+}
+
+function checkNativeSkills(targetDir) {
+    const surfaces = {};
+    const skills = {};
+
+    for (const surface of NATIVE_SKILL_SURFACES) {
+        const missingFiles = ownedFiles().filter(relativePath => !fs.existsSync(targetPath(targetDir, surface, relativePath)));
+        const installed = [];
+        const missing = [];
+        for (const name of NATIVE_SKILLS) {
+            (ownedSkillFiles(name).every(relativePath => fs.existsSync(targetPath(targetDir, surface, relativePath)))
+                ? installed
+                : missing).push(name);
+        }
+        const supportInstalled = NATIVE_SUPPORT_FILES.filter(relativePath => !missingFiles.includes(relativePath));
+        const supportMissing = NATIVE_SUPPORT_FILES.filter(relativePath => missingFiles.includes(relativePath));
+        surfaces[surface.id] = {
+            installed,
+            missing,
+            total: NATIVE_SKILLS.length,
+            missingFiles,
+            support: {
+                installed: supportInstalled,
+                missing: supportMissing,
+                total: NATIVE_SUPPORT_FILES.length
+            }
+        };
+    }
+
+    for (const name of NATIVE_SKILLS) {
+        skills[name] = {};
+        for (const surface of NATIVE_SKILL_SURFACES) {
+            skills[name][surface.id] = ownedSkillFiles(name).every(relativePath => fs.existsSync(targetPath(targetDir, surface, relativePath)));
+        }
+    }
+
+    const installed = NATIVE_SKILLS.filter(name => NATIVE_SKILL_SURFACES.every(surface => skills[name][surface.id]));
+    const missing = NATIVE_SKILLS.filter(name => !installed.includes(name));
+    const missingFiles = Object.fromEntries(NATIVE_SKILL_SURFACES.map(surface => [surface.id, surfaces[surface.id].missingFiles]));
+    return {
+        installed,
+        missing,
+        total: NATIVE_SKILLS.length,
+        allInstalled: missingFiles.agents.length === 0 && missingFiles.claude.length === 0,
+        surfaces,
+        skills,
+        missingFiles
+    };
+}
+
+function copyFile(source, destination) {
+    fs.mkdirSync(path.dirname(destination), { recursive: true });
+    fs.copyFileSync(source, destination);
+}
+
+function installNativeSkills(targetDir, options = {}) {
+    const dryRun = options.dryRun === true;
+    const operations = [];
+    for (const surface of NATIVE_SKILL_SURFACES) {
+        for (const relativePath of ownedFiles()) {
+            const source = sourcePath(relativePath);
+            const destination = targetPath(targetDir, surface, relativePath);
+            operations.push({ surface: surface.id, relativePath, source, destination });
+            if (!dryRun) copyFile(source, destination);
+        }
+    }
+    return {
+        ok: true,
+        dryRun,
+        operations,
+        results: NATIVE_SKILLS.map(name => ({ name, ok: true, dryRun })),
+        message: dryRun
+            ? `Dry run: would copy ${NATIVE_SKILLS.length} native skills to .agents/skills and .claude/skills`
+            : `installed ${NATIVE_SKILLS.length} thachvd-kit native skills to .agents/skills and .claude/skills`
+    };
+}
+
+function updateNativeSkills(targetDir, options = {}) {
+    const result = installNativeSkills(targetDir, options);
+    return {
+        ...result,
+        message: result.dryRun
+            ? `Dry run: would refresh ${NATIVE_SKILLS.length} native skills from bundled copies`
+            : `updated ${NATIVE_SKILLS.length} thachvd-kit native skills from bundled copies`
+    };
+}
+
+module.exports = {
+    NATIVE_SKILLS,
+    NATIVE_SUPPORT_FILES,
+    NATIVE_SKILL_SURFACES,
+    nativeSkillsSourceDir,
+    checkNativeSkills,
+    installNativeSkills,
+    updateNativeSkills
+};