th-memory-mcp 2.2.8 → 2.3.0

package/dist/tools/forget.js

@@ -7,7 +7,7 @@ export const forgetInput = {
         .positive()
         .describe("Row id to delete (id returned by remember/save_lesson)"),
     type: z
-        .enum(["preference", "lesson", "interaction"])
+        .enum(["memory", "preference", "lesson", "interaction"])
         .optional()
         .describe("Which table the id belongs to. Recommended whenever known, because numeric ids can coincide across tables."),
 };
@@ -15,10 +15,14 @@ const indexTables = db.prepare("SELECT DISTINCT ref_table FROM search_index WHER
 const existsPreference = db.prepare("SELECT id FROM preferences WHERE id = ?");
 const existsLesson = db.prepare("SELECT id FROM lessons WHERE id = ?");
 const existsInteraction = db.prepare("SELECT id FROM interactions WHERE id = ?");
+const existsMemory = db.prepare("SELECT id FROM memories WHERE id = ? AND status <> 'deleted'");
 const delPreference = db.prepare("DELETE FROM preferences WHERE id = ?");
 const delLesson = db.prepare("DELETE FROM lessons WHERE id = ?");
 const delInteraction = db.prepare("DELETE FROM interactions WHERE id = ?");
+const delMemoryLinks = db.prepare("DELETE FROM memory_links WHERE source_memory_id = ? OR target_memory_id = ?");
 function existsIn(kind, id) {
+    if (kind === "memories")
+        return !!existsMemory.get(id);
     if (kind === "preferences") {
         return !!existsPreference.get(id);
     }
@@ -31,6 +35,7 @@ export async function forgetHandler(args) {
     try {
         const id = args.target_id;
         const kindOf = {
+            memory: "memories",
             preference: "preferences",
             lesson: "lessons",
             interaction: "interactions",
@@ -44,21 +49,43 @@ export async function forgetHandler(args) {
             const indexed = indexTables.all(id);
             const evidence = indexed
                 .map((r) => r.ref_table)
-                .filter((t) => t === "preferences" || t === "lessons" || t === "interactions");
+                .filter((t) => t === "memories" || t === "preferences" || t === "lessons" || t === "interactions");
             const candidates = evidence.length > 0
                 ? evidence
-                : ["preferences", "lessons", "interactions"];
+                : ["memories", "preferences", "lessons", "interactions"];
             targets = candidates.filter((k) => existsIn(k, id));
         }
         if (targets.length === 0) {
             return ok(`nothing found with id=${id}`);
         }
+        // Batch A-1: never silently delete across tables. Without an explicit
+        // type, a numeric id can coincide in several tables (each AUTOINCREMENTs
+        // from 1). If it matches >1 table, fail closed and ask for `type`.
+        if (!typedKind && targets.length > 1) {
+            return err(`ambiguous id=${id}: found in ${targets.join(", ")}. Specify type explicitly (one of memory, preference, lesson, interaction)`);
+        }
         const removed = [];
+        let linksRemoved = 0;
         db.transaction(() => {
             for (const kind of targets) {
                 if (!existsIn(kind, id))
                     continue;
-                if (kind === "preferences") {
+                if (kind === "memories") {
+                    db.prepare("UPDATE memories SET status = 'deleted' WHERE id = ?").run(id);
+                    removeSearchIndex("memories", id);
+                    removeEmbedding("memories", id);
+                    // Batch A: cascade-delete memory_links referencing this id on BOTH sides
+                    // in the same transaction so forget never leaves dangling graph edges.
+                    // NOTE: entities/relations are intentionally NOT deleted here — they are
+                    // shared graph nodes that may still be referenced by other memories;
+                    // deleting them would corrupt the graph. Orphaned rows stay harmless
+                    // and can be reclaimed by consolidate/GC later.
+                    const info = delMemoryLinks.run(id, id);
+                    const n = Number(info.changes ?? 0);
+                    linksRemoved += n;
+                    removed.push(`memory #${id} (${n} link(s) removed)`);
+                }
+                else if (kind === "preferences") {
                     delPreference.run(id);
                     removeSearchIndex("preferences", id);
                     removeEmbedding("preferences", id);