tewip-ai 0.57.0 → 0.58.0

package/dist/engine/schema/dialect-rules.js

@@ -46,11 +46,16 @@ const DJANGO = [
         instead: 'for a large table, work in batches with atomic = False on the migration and make it resumable. For a small one this is fine - Tewip cannot see how many rows there are',
     },
     {
-        find: /AddIndex\(|AddConstraint\(/i,
+        // The model is named, for two reasons. A finding that says "adds an index or constraint" without
+        // saying to what is most of the way to useless, and `createdHere` - which stops an index on a
+        // table created moments earlier from counting as a lock - matches on the table name, so with no
+        // name it could never suppress anything here. Django writes it `AddIndex(model_name="order", ...)`.
+        find: /(?:AddIndex|AddConstraint)\s*\([\s\S]{0,120}?model_name\s*=\s*["']([\w]+)["']/i,
         unless: /AddIndexConcurrently|AddConstraintNotValid|atomic\s*=\s*False/,
         risk: 'locks-writes',
-        what: () => 'adds an index or constraint, which Django builds with a lock unless told otherwise',
+        what: (m) => `adds an index or constraint to ${m[1]}, which Django builds with a lock unless told otherwise`,
         instead: 'AddIndexConcurrently / AddConstraintNotValid from django.contrib.postgres.operations, with atomic = False on the migration',
+        table: (m) => m[1],
     },
 ];
 /** Rails migrations. */

package/dist/engine/schema/migration-files.js

@@ -4,7 +4,8 @@
 // across a whole checkout rather than across a diff and that file went past the 300-line rule.
 // Keeping it in one place is the point: the alternative was a copy of these patterns in a script,
 // and two definitions of "is this a migration" drift the moment one of them is fixed.
-import { readdirSync, statSync } from 'node:fs';
+import { readFileSync, readdirSync, statSync } from 'node:fs';
+import { dialectOf } from './frameworks.js';
 import { join, relative } from 'node:path';
 // A directory called `migration/` says what is probably in it, not what every file in it is. This
 // matched *anything* underneath one, so Keycloak's `docs/guides/migration/index.adoc` and its 113
@@ -70,8 +71,29 @@ export function migrationsUnder(root, limit = 20_000) {
                 continue;
             }
             const rel = relative(root, full).replaceAll(String.fromCharCode(92), '/');
-            if (SCHEMA_FILE.test(rel) || MIGRATION.test(rel) || NAMED_MIGRATION.test(rel))
-                found.push(rel);
+            if (!SCHEMA_FILE.test(rel) && !MIGRATION.test(rel) && !NAMED_MIGRATION.test(rel))
+                continue;
+            // And it has to look like one inside. Phase 44 stopped a directory called `migration/` from
+            // claiming every file under it by extension; discourse shows that was not enough. `lib/migration/
+            // helpers.rb` is a library module, `table_dropper.rb` is a class, and
+            // `migrations/converters/config/locales/migrations.en.yml` is a locale file - all three were
+            // selected, none could be read, and all three were reported as migrations Tewip could not read.
+            // 550 of discourse's 3,095, which is a "could not read" list that is mostly library code.
+            //
+            // `dialectOf` is the one definition of what a migration is written in, so it decides here too:
+            // a file whose dialect is unknown is not an unreadable migration, it is not a migration.
+            if (info.size > 2_000_000)
+                continue;
+            let text = '';
+            try {
+                text = readFileSync(full, 'utf8');
+            }
+            catch {
+                continue;
+            }
+            if (dialectOf(rel, text) === 'unknown')
+                continue;
+            found.push(rel);
         }
     };
     walk(root, 0);

package/dist/engine/schema/schema-command.js

@@ -46,6 +46,11 @@ function createdHere(text) {
     // EF Core puts the name on the line after the call, so these have to reach across a newline.
     const FRAMEWORK_CREATES = [
         /migrationBuilder\s*\.\s*CreateTable\s*\([\s\S]{0,80}?name\s*:\s*["']([\w$.]+)["']/gi,
+        // Django names the model rather than the table, and so does its AddIndex, so the two match each
+        // other. Saleor never exercises this - Django convention puts CreateModel and AddIndex in
+        // separate migrations - but every other dialect here has its create form registered and this
+        // one did not, which is the kind of gap that waits for a project with different habits.
+        /migrations\s*\.\s*CreateModel\s*\([\s\S]{0,60}?name\s*=\s*["']([\w]+)["']/gi,
         /queryInterface\s*\.\s*createTable\s*\(\s*["']([\w$.]+)["']/gi,
         /knex\s*\.\s*schema\s*\.\s*createTable\s*\(\s*["']([\w$.]+)["']/gi,
         /Schema\s*::\s*create\s*\(\s*["']([\w$.]+)["']/gi,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tewip-ai",
-  "version": "0.57.0",
+  "version": "0.58.0",
   "mcpName": "io.github.hmamut39/tewip",
   "description": "Tewip finds why each failing test failed - real bug, flaky test, environment, test data or changed selector - for any stack, from the command line, CI, or your editor.",
   "keywords": [