tewip-ai 0.18.3 → 0.18.4

package/dist/engine/secure/deps.js

@@ -34,6 +34,8 @@ export function npmAudit(root) {
             id: String(via?.url?.split('/').pop() ?? via?.source ?? ''),
             title: String(via?.title ?? `${name} has a known vulnerability`),
             fixedIn: entry.fixAvailable && typeof entry.fixAvailable === 'object' ? String(entry.fixAvailable.version ?? '') : '',
+            fixExists: entry.fixAvailable === true || (entry.fixAvailable && typeof entry.fixAvailable === 'object'),
+            direct: entry.isDirect === true,
             source: 'npm audit',
             dev: Boolean(entry.isDirect === false ? false : entry.dev ?? false) || Boolean(entry.effects?.length === 0 && entry.dev),
         });
@@ -82,6 +84,10 @@ export function osvScan(root) {
                         id: String(v.id ?? ''),
                         title: String(v.summary ?? '').slice(0, 200),
                         fixedIn: '',
+                        // osv-scanner's output says neither which version fixes it nor whether the project
+                        // declares the package, so neither is claimed.
+                        fixExists: false,
+                        direct: false,
                         source: 'osv-scanner',
                         dev: false,
                     });

package/dist/engine/secure/triage.js

@@ -116,7 +116,15 @@ export function triageDependency(finding, root, sources, accepted) {
         where,
         source: finding.source,
     };
-    const upgrade = finding.fixedIn ? `upgrade ${finding.package} to ${finding.fixedIn}` : `no fixed version is published yet: watch ${finding.id || 'the advisory'} and consider replacing the package`;
+    // npm answers `fixAvailable: true` when `npm audit fix` can resolve something without naming a
+    // version. Reading only the version form made Tewip say "no fixed version is published yet,
+    // consider replacing the package" about three packages npm could have fixed in one command -
+    // found by running this against real advisories for lodash, minimist and marked.
+    const upgrade = finding.fixedIn
+        ? `upgrade ${finding.package} to ${finding.fixedIn}`
+        : finding.fixExists
+            ? `a fix is available: run \`npm audit fix\` (the scanner did not name a version)`
+            : `no fixed version is published yet: watch ${finding.id || 'the advisory'} and consider replacing the package`;
     if (accepted.has(`dependency ${finding.package}`) || accepted.has(`dependency ${where}`)) {
         return { ...base, verdict: 'accepted', why: 'a person marked this one accepted in .tewip/security-accepted.txt', next: 'nothing: it was reviewed' };
     }
@@ -134,8 +142,12 @@ export function triageDependency(finding, root, sources, accepted) {
             ...base,
             verdict: 'not-reachable',
             severity: base.severity === 'critical' ? 'medium' : 'low',
-            why: `nothing in this project imports ${finding.package}: it is pulled in by another package, so the vulnerable code may never run here`,
-            next: `${upgrade}, or check which dependency requires it (npm why ${finding.package}) before spending time on it`,
+            why: finding.direct
+                ? `this project declares ${finding.package} but no file imports it, so the vulnerable code may never run here`
+                : `nothing in this project imports ${finding.package}: it is pulled in by another package, so the vulnerable code may never run here`,
+            next: finding.direct
+                ? `${upgrade}, or remove ${finding.package} from the project if nothing uses it any more`
+                : `${upgrade}, or check which dependency requires it (npm why ${finding.package}) before spending time on it`,
         };
     }
     return { ...base, verdict: 'real-risk', why: `this project imports ${finding.package} directly, and the advisory applies to the installed version`, next: upgrade };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tewip-ai",
-  "version": "0.18.3",
+  "version": "0.18.4",
   "description": "Tewip finds why each failing test failed - real bug, flaky test, environment, test data or changed selector - for any stack, from the command line, CI, or your editor.",
   "keywords": [
     "test-failures",