tewip-ai 0.18.2 → 0.18.4

package/dist/engine/secure/deps.js

@@ -34,6 +34,8 @@ export function npmAudit(root) {
             id: String(via?.url?.split('/').pop() ?? via?.source ?? ''),
             title: String(via?.title ?? `${name} has a known vulnerability`),
             fixedIn: entry.fixAvailable && typeof entry.fixAvailable === 'object' ? String(entry.fixAvailable.version ?? '') : '',
+            fixExists: entry.fixAvailable === true || (entry.fixAvailable && typeof entry.fixAvailable === 'object'),
+            direct: entry.isDirect === true,
             source: 'npm audit',
             dev: Boolean(entry.isDirect === false ? false : entry.dev ?? false) || Boolean(entry.effects?.length === 0 && entry.dev),
         });
@@ -82,6 +84,10 @@ export function osvScan(root) {
                         id: String(v.id ?? ''),
                         title: String(v.summary ?? '').slice(0, 200),
                         fixedIn: '',
+                        // osv-scanner's output says neither which version fixes it nor whether the project
+                        // declares the package, so neither is claimed.
+                        fixExists: false,
+                        direct: false,
                         source: 'osv-scanner',
                         dev: false,
                     });

package/dist/engine/secure/secrets.js

@@ -54,18 +54,26 @@ export function entropyOf(value) {
 const PLACEHOLDER_WORDS = /example|placeholder|dummy|sample|changeme|your[-_ ]?(?:key|token|secret|api)|xxxx|redacted|fake|notreal|test[-_]?key|<[^>]+>|\$\{|\{\{/i;
 /** Files whose whole purpose is to show the shape of a secret, not to hold one. */
 const DOC_FILE = /(?:^|[\\/])(?:\.env\.example|\.env\.sample|\.env\.template|[^\\/]*\.(?:md|rst|txt|adoc)|[^\\/]*example[^\\/]*|[^\\/]*sample[^\\/]*)$/i;
-/** Why this match is probably not a live credential, or null when nothing says so. */
+/**
+ * Why this match is probably not a live credential, or null when nothing says so.
+ *
+ * The file's name is deliberately not enough on its own any more. A realistic AWS key placed in
+ * `src/config-sample.js` was dismissed as noise - "nothing: this is not a credential" - while the
+ * identical key in `src/settings.js` was reported as critical. A filename is the weakest evidence
+ * there is, and a key pasted into an example file by accident is one of the commonest ways
+ * credentials leak. That case is now shown as a template finding instead of being dismissed.
+ */
 export function looksPlanted(value, line, file) {
     if (PLACEHOLDER_WORDS.test(value))
         return 'the value itself says it is an example';
     if (PLACEHOLDER_WORDS.test(line))
         return 'the line around it says it is an example';
-    if (DOC_FILE.test(file))
-        return 'it is in a documentation or example file';
     if (/(.)\1{5,}/.test(value))
         return 'the value repeats one character, so it is a stand-in';
     return null;
 }
+/** True when only the file's name suggests a template, whatever the value itself looks like. */
+export const inATemplate = (file) => DOC_FILE.test(file);
 const SKIP_DIR = new Set(['node_modules', '.git', 'dist', 'build', 'out', 'coverage', 'target', 'vendor', '__pycache__', '.venv', 'venv', '.tewip', '.next', '.cache']);
 const BINARY = /\.(?:png|jpe?g|gif|webp|ico|svg|pdf|zip|gz|tar|exe|dll|so|dylib|woff2?|ttf|eot|mp4|mp3|wav|class|jar|pyc|lock)$/i;
 const MAX_FILE_BYTES = 2 * 1024 * 1024;
@@ -150,6 +158,7 @@ export function scanSecrets(root, files = sourceFiles(root)) {
                     evidence: redact(lines[line - 1] ?? '', value),
                     entropy: Number(entropy.toFixed(2)),
                     placeholder: looksPlanted(value, lines[line - 1] ?? '', rel),
+                    template: inATemplate(rel),
                 });
             }
         }

package/dist/engine/secure/triage.js

@@ -60,6 +60,18 @@ export function triageSecret(finding, root, accepted) {
     if (finding.placeholder) {
         return { ...base, verdict: 'noise', severity: 'low', why: `${finding.placeholder}: ${finding.evidence}`, next: 'nothing: this is not a credential' };
     }
+    if (finding.template) {
+        // Only the file's name says this is a template; the value itself looks like a real credential.
+        // Dismissing it would hide the commonest accident there is - a working key pasted into an
+        // example file - so it is shown, below the ones that need acting on now.
+        return {
+            ...base,
+            verdict: 'not-reachable',
+            severity: 'medium',
+            why: `${finding.evidence} - the file is a template or documentation, but the value itself does not say it is an example`,
+            next: 'check whether this was ever a working credential; if it was, rotate it and replace it here with an obvious placeholder',
+        };
+    }
     const tracked = isTracked(root, finding.file);
     if (!tracked) {
         return {
@@ -104,7 +116,15 @@ export function triageDependency(finding, root, sources, accepted) {
         where,
         source: finding.source,
     };
-    const upgrade = finding.fixedIn ? `upgrade ${finding.package} to ${finding.fixedIn}` : `no fixed version is published yet: watch ${finding.id || 'the advisory'} and consider replacing the package`;
+    // npm answers `fixAvailable: true` when `npm audit fix` can resolve something without naming a
+    // version. Reading only the version form made Tewip say "no fixed version is published yet,
+    // consider replacing the package" about three packages npm could have fixed in one command -
+    // found by running this against real advisories for lodash, minimist and marked.
+    const upgrade = finding.fixedIn
+        ? `upgrade ${finding.package} to ${finding.fixedIn}`
+        : finding.fixExists
+            ? `a fix is available: run \`npm audit fix\` (the scanner did not name a version)`
+            : `no fixed version is published yet: watch ${finding.id || 'the advisory'} and consider replacing the package`;
     if (accepted.has(`dependency ${finding.package}`) || accepted.has(`dependency ${where}`)) {
         return { ...base, verdict: 'accepted', why: 'a person marked this one accepted in .tewip/security-accepted.txt', next: 'nothing: it was reviewed' };
     }
@@ -122,8 +142,12 @@ export function triageDependency(finding, root, sources, accepted) {
             ...base,
             verdict: 'not-reachable',
             severity: base.severity === 'critical' ? 'medium' : 'low',
-            why: `nothing in this project imports ${finding.package}: it is pulled in by another package, so the vulnerable code may never run here`,
-            next: `${upgrade}, or check which dependency requires it (npm why ${finding.package}) before spending time on it`,
+            why: finding.direct
+                ? `this project declares ${finding.package} but no file imports it, so the vulnerable code may never run here`
+                : `nothing in this project imports ${finding.package}: it is pulled in by another package, so the vulnerable code may never run here`,
+            next: finding.direct
+                ? `${upgrade}, or remove ${finding.package} from the project if nothing uses it any more`
+                : `${upgrade}, or check which dependency requires it (npm why ${finding.package}) before spending time on it`,
         };
     }
     return { ...base, verdict: 'real-risk', why: `this project imports ${finding.package} directly, and the advisory applies to the installed version`, next: upgrade };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tewip-ai",
-  "version": "0.18.2",
+  "version": "0.18.4",
   "description": "Tewip finds why each failing test failed - real bug, flaky test, environment, test data or changed selector - for any stack, from the command line, CI, or your editor.",
   "keywords": [
     "test-failures",