testronaut 2.0.1 → 2.0.2

package/.github/workflows/unit-tests.yml

@@ -0,0 +1,34 @@
+name: Unit Tests
+
+on:
+  pull_request:
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+concurrency:
+  group: unit-tests-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Unit Tests
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 24
+          cache: npm
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run unit tests
+        run: npm test

package/TODO.md

@@ -11,7 +11,7 @@
 
 ## Browser Automation Follow-Ups
 
-- [ ] Fix `click_text` so it prioritizes exact-text actionable elements (`button`, `a`, and elements with interactive roles) instead of clicking the first container whose descendant text includes the target. Define an explicit fallback for partial matches and add regression tests covering nested containers, duplicate labels, hidden elements, and the Add, Logout, and Report failures observed in the examples run.
+- [x] Make `click_text` match exact text, prefer the innermost visible element, and fail quickly instead of clicking an ancestor or partial match.
 
 ## Session and Reporting Follow-Ups
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testronaut",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "main": "./runner/testronaut.js",
   "bin": {
     "testronaut": "bin/cli.js"

package/tests/toolsTests/chromeBrowserClickText.test.js

@@ -0,0 +1,44 @@
+import { describe, expect, it, vi } from 'vitest';
+import { ChromeBrowser } from '../../tools/chromeBrowser.js';
+
+describe('ChromeBrowser.click_text', () => {
+  it('clicks the first visible innermost exact-text match with a short timeout', async () => {
+    const hidden = {
+      isVisible: vi.fn().mockResolvedValue(false),
+    };
+    const visible = {
+      isVisible: vi.fn().mockResolvedValue(true),
+      scrollIntoViewIfNeeded: vi.fn().mockResolvedValue(undefined),
+      click: vi.fn().mockResolvedValue(undefined),
+    };
+    const matches = {
+      count: vi.fn().mockResolvedValue(2),
+      nth: vi.fn(index => [hidden, visible][index]),
+    };
+    const browser = Object.create(ChromeBrowser.prototype);
+    browser.page = {
+      getByText: vi.fn().mockReturnValue(matches),
+      waitForTimeout: vi.fn().mockResolvedValue(undefined),
+    };
+
+    await expect(browser.click_text({ text: 'Report' })).resolves.toBe('clicked text "Report"');
+    expect(browser.page.getByText).toHaveBeenCalledWith('Report', { exact: true });
+    expect(visible.click).toHaveBeenCalledWith({ timeout: 3000 });
+    expect(browser.page.waitForTimeout).toHaveBeenCalledWith(500);
+  });
+
+  it('does not fall back to a partial or hidden match', async () => {
+    const matches = {
+      count: vi.fn().mockResolvedValue(1),
+      nth: vi.fn().mockReturnValue({ isVisible: vi.fn().mockResolvedValue(false) }),
+    };
+    const browser = Object.create(ChromeBrowser.prototype);
+    browser.page = {
+      getByText: vi.fn().mockReturnValue(matches),
+      waitForTimeout: vi.fn(),
+    };
+
+    await expect(browser.click_text({ text: 'Add' })).rejects.toThrow('Exact visible text "Add" not found');
+    expect(browser.page.getByText).toHaveBeenCalledWith('Add', { exact: true });
+  });
+});

package/tests/toolsTests/domControl.test.js

@@ -35,12 +35,13 @@ describe('domControl helpers', () => {
           </head>
           <body data-theme="dark">
             <!-- comment -->
-            <div id="main" data-testid="main" onclick="alert('x')">
+            <div id="main" data-testid="main" role="region" data-state="open"
+                 aria-expanded="true" aria-selected="false" onclick="alert('x')">
               <iframe src="frame.html"></iframe>
               <canvas></canvas>
               <svg></svg>
               <a href="/home" rel="noopener" target="_blank">Home</a>
-              <input id="email" name="email" type="email" data-tracking="abc" />
+              <input id="email" name="email" type="email" disabled data-tracking="abc" />
             </div>
           </body>
         </html>
@@ -66,13 +67,18 @@ describe('domControl helpers', () => {
       // Whitelisted attrs preserved
       const main = $('#main');
       expect(main.attr('id')).toBe('main');
-      expect(main.attr('data-testid')).toBeUndefined();
+      expect(main.attr('data-testid')).toBe('main');
+      expect(main.attr('role')).toBe('region');
+      expect(main.attr('data-state')).toBe('open');
+      expect(main.attr('aria-expanded')).toBe('true');
+      expect(main.attr('aria-selected')).toBe('false');
       expect(main.attr('onclick')).toBeUndefined();
 
       const input = $('#email');
       expect(input.attr('id')).toBe('email');
       expect(input.attr('name')).toBe('email');
       expect(input.attr('type')).toBe('email');
+      expect(input.attr('disabled')).toBeDefined();
       expect(input.attr('data-tracking')).toBeUndefined();
 
       const link = $('a[href="/home"]');

package/tools/chromeBrowser.js

@@ -1025,9 +1025,8 @@ export class ChromeBrowser {
       $ = await removeNonContentTags($);
       $ = await reduceRepeatedDivs($, listLimit);
       reduceTableRows($, listLimit);
-      // If you later re-enable:
-      // $ = await removeObfuscatedClassNames($);
-      // $ = await removeAutoGeneratedClasses($);
+      $ = removeObfuscatedClassNames($);
+      $ = removeAutoGeneratedClasses($);
     }
 
     // Minify whitespace *after* structural cleanup
@@ -1140,21 +1139,24 @@ export class ChromeBrowser {
     return html.includes(text) ? `FOUND: ${text}` : `NOT FOUND: ${text}`;
   }
 
-  async click_text({ text }) {
+  async click_text({ text, timeout = 3000 }) {
     console.log("attempting to click text with normal click:", text);
 
-    const elements = await this.page.$$('button, a, span, div, li, p'); // expand as needed
-    for (const el of elements) {
-      const innerText = await el.innerText().catch(() => '');
-      if (innerText.includes(text)) {
-        await el.scrollIntoViewIfNeeded().catch(() => {});
-        await el.click();
-        await this.page.waitForTimeout(5000);
-        return `clicked text "${text}"`;
-        
-      }
+    // Playwright's exact text engine normalizes whitespace and resolves to the
+    // innermost matching elements, avoiding ancestor containers that merely
+    // contain the requested label.
+    const matches = this.page.getByText(text, { exact: true });
+    const count = await matches.count();
+    for (let index = 0; index < count; index++) {
+      const match = matches.nth(index);
+      if (!await match.isVisible().catch(() => false)) continue;
+
+      await match.scrollIntoViewIfNeeded().catch(() => {});
+      await match.click({ timeout });
+      await this.page.waitForTimeout(500);
+      return `clicked text "${text}"`;
     }
-    throw new Error(`Element with text "${text}" not found`);
+    throw new Error(`Exact visible text "${text}" not found`);
   }
 
   async click_text_xpath({ text, delayMs = 1000 }) {

package/tools/domControl.js

@@ -37,7 +37,8 @@ export const removeNonContentTags = async ($) => {
     const $el = $(el);
     const allowedAttrs = [
       'href', 'src', 'type', 'alt', 'title',
-      'placeholder', 'name', 'id', 'class', 'aria-label', 'value',
+      'placeholder', 'name', 'id', 'class', 'value',
+      'data-testid', 'disabled', 'role', 'data-state',
       // keep key data-* attributes that help identify rows/items without bloating too much
       'data-type', 'data-id', 'data-title', 'data-parentid', 'data-order'
     ];
@@ -51,7 +52,7 @@ export const removeNonContentTags = async ($) => {
     // }
 
     for (const attr in attrs) {
-      if (!allowedAttrs.includes(attr)) {
+      if (!allowedAttrs.includes(attr) && !attr.startsWith('aria-')) {
         $el.removeAttr(attr);
       }
     }