testomatio-editor-blocks 0.4.35 → 0.4.36

package/package/editor/blocks/step.js

@@ -193,31 +193,6 @@ export const stepBlock = createReactBlockSpec({
             }
             return count;
         }, [block.id, documentVersion, editor.document]);
-        // Check if there is a preceding "Steps" heading
-        const hasStepsHeading = useMemo(() => {
-            const allBlocks = editor.document;
-            const blockIndex = allBlocks.findIndex((b) => b.id === block.id);
-            if (blockIndex < 0)
-                return false;
-            for (let i = blockIndex - 1; i >= 0; i--) {
-                const b = allBlocks[i];
-                if (b.type === "testStep" || b.type === "snippet" || isEmptyParagraph(b)) {
-                    continue;
-                }
-                if (b.type === "heading") {
-                    const text = (Array.isArray(b.content) ? b.content : [])
-                        .filter((n) => n.type === "text")
-                        .map((n) => { var _a; return (_a = n.text) !== null && _a !== void 0 ? _a : ""; })
-                        .join("")
-                        .trim()
-                        .toLowerCase()
-                        .replace(/[:\-–—]$/, "");
-                    return isStepsHeading(text);
-                }
-                return false;
-            }
-            return false;
-        }, [block.id, documentVersion, editor.document]);
         useEditorChange(() => {
             setDocumentVersion((version) => version + 1);
         }, editor);
@@ -362,10 +337,6 @@ export const stepBlock = createReactBlockSpec({
         }, [expectedHasContent, isExpectedVisible]);
         const canToggleData = !dataHasContent;
         const canToggleExpected = !expectedHasContent;
-        // Render as plain text when not under a "Steps" heading
-        if (!hasStepsHeading) {
-            return (_jsxs("div", { className: "bn-teststep-plain", "data-block-id": block.id, children: [_jsx("span", { children: stepTitle || "(empty step)" }), stepData ? _jsx("span", { className: "bn-teststep-plain__data", children: stepData }) : null, expectedResult ? _jsx("span", { className: "bn-teststep-plain__expected", children: expectedResult }) : null] }));
-        }
         if (viewMode === "horizontal") {
             return (_jsx(StepHorizontalView, { blockId: block.id, stepNumber: stepNumber, stepValue: combinedStepValue, expectedResult: expectedResult, onStepChange: handleCombinedStepChange, onExpectedChange: handleExpectedChange, onInsertNextStep: handleInsertNextStep, onFieldFocus: handleFieldFocus, viewToggle: _jsx("button", { type: "button", className: "bn-teststep__view-toggle bn-teststep__view-toggle--horizontal", "data-tooltip": "Switch step view", "aria-label": "Switch step view", onClick: handleToggleView, children: _jsxs("svg", { width: "16", height: "16", viewBox: "0 0 16 16", fill: "none", "aria-hidden": "true", children: [_jsx("mask", { id: "mask-toggle", style: { maskType: "alpha" }, maskUnits: "userSpaceOnUse", x: "0", y: "0", width: "16", height: "16", children: _jsx("rect", { width: "16", height: "16", fill: "#D9D9D9" }) }), _jsx("g", { mask: "url(#mask-toggle)", children: _jsx("path", { d: "M12.6667 2C13.0333 2 13.3472 2.13056 13.6083 2.39167C13.8694 2.65278 14 2.96667 14 3.33333L14 12.6667C14 13.0333 13.8694 13.3472 13.6083 13.6083C13.3472 13.8694 13.0333 14 12.6667 14L10 14C9.63333 14 9.31944 13.8694 9.05833 13.6083C8.79722 13.3472 8.66667 13.0333 8.66667 12.6667L8.66667 3.33333C8.66667 2.96667 8.79722 2.65278 9.05833 2.39167C9.31945 2.13055 9.63333 2 10 2L12.6667 2ZM6 2C6.36667 2 6.68056 2.13055 6.94167 2.39167C7.20278 2.65278 7.33333 2.96667 7.33333 3.33333L7.33333 12.6667C7.33333 13.0333 7.20278 13.3472 6.94167 13.6083C6.68055 13.8694 6.36667 14 6 14L3.33333 14C2.96667 14 2.65278 13.8694 2.39167 13.6083C2.13056 13.3472 2 13.0333 2 12.6667L2 3.33333C2 2.96667 2.13056 2.65278 2.39167 2.39167C2.65278 2.13055 2.96667 2 3.33333 2L6 2ZM3.33333 12.6667L6 12.6667L6 3.33333L3.33333 3.33333L3.33333 12.6667Z", fill: "currentColor" }) })] }) }) }));
         }

package/package/editor/customMarkdownConverter.js

@@ -80,7 +80,6 @@ function unescapeMarkdown(text) {
     return stripHtmlWrappers(text).replace(/\\([*_`~\[\]()<>\\])/g, "$1");
 }
 function applyTextStyles(text, styles) {
-    var _a;
     if (!styles) {
         return text;
     }
@@ -116,11 +115,22 @@ function applyTextStyles(text, styles) {
             suffix: "</span>",
         });
     }
-    for (const wrapper of wrappers) {
-        const suffix = (_a = wrapper.suffix) !== null && _a !== void 0 ? _a : wrapper.prefix;
-        result = `${wrapper.prefix}${result}${suffix}`;
-    }
-    return result;
+    // Split on newlines so that style markers wrap each line individually.
+    // This prevents <br/> (inserted by table cell formatting) from being
+    // trapped inside markers like **bold<br/>text**.
+    const segments = result.split("\n");
+    const wrapped = segments.map((segment) => {
+        var _a;
+        if (!segment)
+            return segment;
+        let s = segment;
+        for (const wrapper of wrappers) {
+            const suffix = (_a = wrapper.suffix) !== null && _a !== void 0 ? _a : wrapper.prefix;
+            s = `${wrapper.prefix}${s}${suffix}`;
+        }
+        return s;
+    });
+    return wrapped.join("\n");
 }
 function inlineToMarkdown(content) {
     if (!content || !Array.isArray(content)) {
@@ -309,17 +319,17 @@ function serializeBlock(block, ctx, orderedIndex, stepIndex) {
                 }
                 return flattenWithBlankLine(lines, true);
             }
-            if (stepTitle.length > 0) {
-                const normalizedTitle = stepTitle
-                    .split(/\r?\n/)
-                    .map((segment) => segment.trim())
-                    .filter((segment) => segment.length > 0)
-                    .join(" ");
-                if (normalizedTitle.length > 0) {
-                    const listStyle = (_m = block.props.listStyle) !== null && _m !== void 0 ? _m : "bullet";
-                    const prefix = listStyle === "ordered" ? `${(stepIndex !== null && stepIndex !== void 0 ? stepIndex : 0) + 1}.` : "*";
-                    lines.push(`${prefix} ${normalizedTitle}`);
-                }
+            const normalizedTitle = stepTitle
+                .split(/\r?\n/)
+                .map((segment) => segment.trim())
+                .filter((segment) => segment.length > 0)
+                .join(" ");
+            const normalizedExpectedForCheck = stripExpectedPrefix(expectedResult).trim();
+            const hasContent = stepData.length > 0 || normalizedExpectedForCheck.length > 0;
+            if (normalizedTitle.length > 0 || hasContent) {
+                const listStyle = (_m = block.props.listStyle) !== null && _m !== void 0 ? _m : "bullet";
+                const prefix = listStyle === "ordered" ? `${(stepIndex !== null && stepIndex !== void 0 ? stepIndex : 0) + 1}.` : "*";
+                lines.push(normalizedTitle.length > 0 ? `${prefix} ${normalizedTitle}` : `${prefix} `);
             }
             if (stepData.length > 0) {
                 const dataLines = stepData.split(/\r?\n/);
@@ -606,7 +616,7 @@ function detectListType(trimmed) {
     if (/^\d+[.)]\s+/.test(trimmed)) {
         return "numbered";
     }
-    if (/^[-*+]\s+/.test(trimmed)) {
+    if (/^[-*+](\s+|$)/.test(trimmed)) {
         return "bullet";
     }
     return null;
@@ -695,7 +705,7 @@ function parseList(lines, startIndex, listType, indentLevel, allowEmptySteps = f
         }
         else {
             const bulletMatch = trimmed.match(/^[-*+]\s+(.*)$/);
-            const text = (_d = bulletMatch === null || bulletMatch === void 0 ? void 0 : bulletMatch[1]) !== null && _d !== void 0 ? _d : trimmed.slice(2);
+            const text = (_d = bulletMatch === null || bulletMatch === void 0 ? void 0 : bulletMatch[1]) !== null && _d !== void 0 ? _d : (trimmed.length <= 1 ? "" : trimmed.slice(2));
             items.push({
                 type: "bulletListItem",
                 props: cloneBaseProps(),
@@ -721,7 +731,7 @@ function isLikelyStep(lines, index) {
         if (hasIndent)
             return true;
         // Stop at new list items, headings, or other block-level elements (only if not indented)
-        if (/^[-*+]\s/.test(trimmed) || /^\d+[.)]\s/.test(trimmed))
+        if (/^[-*+](\s|$)/.test(trimmed) || /^\d+[.)]\s/.test(trimmed))
             break;
         if (trimmed.startsWith("#") || trimmed.startsWith(">") || trimmed.startsWith("|") || trimmed.startsWith("```") || trimmed.startsWith(":::"))
             break;
@@ -736,7 +746,7 @@ function isLikelyStep(lines, index) {
 function parseTestStep(lines, index, allowEmpty = false, snippetId) {
     const current = lines[index];
     const trimmed = current.trim();
-    const isBullet = trimmed.startsWith("* ") || trimmed.startsWith("- ");
+    const isBullet = trimmed.startsWith("* ") || trimmed.startsWith("- ") || trimmed === "*" || trimmed === "-";
     const isNumbered = /^\d+[.)]\s+/.test(trimmed);
     if (!isBullet && !isNumbered) {
         return null;
@@ -749,7 +759,7 @@ function parseTestStep(lines, index, allowEmpty = false, snippetId) {
     }
     let rawTitle;
     if (isBullet) {
-        rawTitle = unescapeMarkdown(trimmed.slice(2)).trim();
+        rawTitle = unescapeMarkdown((trimmed.startsWith("* ") || trimmed.startsWith("- ")) ? trimmed.slice(2) : trimmed.slice(1)).trim();
     }
     else {
         // For numbered lists, remove the number and delimiter
@@ -793,7 +803,7 @@ function parseTestStep(lines, index, allowEmpty = false, snippetId) {
             continue;
         }
         const isNumberedStep = NUMBERED_STEP_REGEX.test(rawTrimmed);
-        const isNewStep = (!hasIndent && (rawTrimmed.startsWith("* ") || rawTrimmed.startsWith("- "))) ||
+        const isNewStep = (!hasIndent && (rawTrimmed.startsWith("* ") || rawTrimmed.startsWith("- ") || rawTrimmed === "*" || rawTrimmed === "-")) ||
             (!hasIndent && isNumberedStep);
         if (isNewStep) {
             break;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testomatio-editor-blocks",
-  "version": "0.4.35",
+  "version": "0.4.36",
   "description": "Custom BlockNote schema, markdown conversion helpers, and UI for Testomatio-style test cases and steps.",
   "type": "module",
   "main": "./package/index.js",

package/src/App.tsx

@@ -22,7 +22,6 @@ import { customSchema, type CustomEditor } from "./editor/customSchema";
 import { setStepsFetcher, type StepJsonApiDocument } from "./editor/stepAutocomplete";
 import { setSnippetFetcher, type SnippetJsonApiDocument } from "./editor/snippetAutocomplete";
 import { setImageUploadHandler } from "./editor/stepImageUpload";
-import { canInsertStepOrSnippet } from "./editor/blocks/step";
 import "./App.css";
 
 const focusStepField = (
@@ -335,11 +334,7 @@ function CustomSlashMenu() {
       },
     };
 
-    const cursorBlock = editor.getTextCursorPosition()?.block;
-    const canInsert = cursorBlock ? canInsertStepOrSnippet(editor, cursorBlock.id) : false;
-    const customItems = canInsert ? [stepItem, snippetItem] : [];
-
-    return filterSuggestionItems([...defaultItems, ...customItems], query);
+    return filterSuggestionItems([...defaultItems, stepItem, snippetItem], query);
   };
 
   return <SuggestionMenuController triggerCharacter="/" getItems={getItems} />;
@@ -489,7 +484,7 @@ function App() {
     const fallbackBlock = documentBlocks[documentBlocks.length - 1];
     const referenceId = selectedBlock?.id ?? fallbackBlock?.id;
 
-    if (!referenceId || !canInsertStepOrSnippet(editor, referenceId)) {
+    if (!referenceId) {
       return;
     }
 

package/src/editor/blocks/step.tsx

@@ -212,32 +212,6 @@ export const stepBlock = createReactBlockSpec(
         return count;
       }, [block.id, documentVersion, editor.document]);
 
-      // Check if there is a preceding "Steps" heading
-      const hasStepsHeading = useMemo(() => {
-        const allBlocks = editor.document;
-        const blockIndex = allBlocks.findIndex((b) => b.id === block.id);
-        if (blockIndex < 0) return false;
-
-        for (let i = blockIndex - 1; i >= 0; i--) {
-          const b = allBlocks[i];
-          if (b.type === "testStep" || b.type === "snippet" || isEmptyParagraph(b)) {
-            continue;
-          }
-          if (b.type === "heading") {
-            const text = (Array.isArray(b.content) ? b.content : [])
-              .filter((n: any) => n.type === "text")
-              .map((n: any) => n.text ?? "")
-              .join("")
-              .trim()
-              .toLowerCase()
-              .replace(/[:\-–—]$/, "");
-            return isStepsHeading(text);
-          }
-          return false;
-        }
-        return false;
-      }, [block.id, documentVersion, editor.document]);
-
       useEditorChange(() => {
         setDocumentVersion((version) => version + 1);
       }, editor);
@@ -417,17 +391,6 @@ export const stepBlock = createReactBlockSpec(
       const canToggleData = !dataHasContent;
       const canToggleExpected = !expectedHasContent;
 
-      // Render as plain text when not under a "Steps" heading
-      if (!hasStepsHeading) {
-        return (
-          <div className="bn-teststep-plain" data-block-id={block.id}>
-            <span>{stepTitle || "(empty step)"}</span>
-            {stepData ? <span className="bn-teststep-plain__data">{stepData}</span> : null}
-            {expectedResult ? <span className="bn-teststep-plain__expected">{expectedResult}</span> : null}
-          </div>
-        );
-      }
-
       if (viewMode === "horizontal") {
         return (
           <StepHorizontalView

package/src/editor/customMarkdownConverter.test.ts

@@ -105,6 +105,67 @@ describe("blocksToMarkdown", () => {
     );
   });
 
+  it("serializes a step with empty title but with stepData", () => {
+    const blocks: CustomEditorBlock[] = [
+      {
+        id: "s1",
+        type: "testStep",
+        props: {
+          stepTitle: "",
+          stepData: "Navigate to the page",
+          expectedResult: "",
+          listStyle: "bullet",
+        },
+        content: undefined,
+        children: [],
+      },
+    ];
+
+    expect(blocksToMarkdown(blocks)).toBe(
+      ["* ", "  Navigate to the page"].join("\n"),
+    );
+  });
+
+  it("serializes a step with empty title but with expectedResult", () => {
+    const blocks: CustomEditorBlock[] = [
+      {
+        id: "s1",
+        type: "testStep",
+        props: {
+          stepTitle: "",
+          stepData: "",
+          expectedResult: "Login form visible",
+          listStyle: "bullet",
+        },
+        content: undefined,
+        children: [],
+      },
+    ];
+
+    expect(blocksToMarkdown(blocks)).toBe(
+      ["* ", "  *Expected*: Login form visible"].join("\n"),
+    );
+  });
+
+  it("drops completely empty step (no title, no data, no expected)", () => {
+    const blocks: CustomEditorBlock[] = [
+      {
+        id: "s1",
+        type: "testStep",
+        props: {
+          stepTitle: "",
+          stepData: "",
+          expectedResult: "",
+          listStyle: "bullet",
+        },
+        content: undefined,
+        children: [],
+      },
+    ];
+
+    expect(blocksToMarkdown(blocks)).toBe("");
+  });
+
   it("serializes a snippet block with prefixed title", () => {
     const blocks: CustomEditorBlock[] = [
       {
@@ -382,6 +443,62 @@ describe("blocksToMarkdown", () => {
     );
   });
 
+  it("serializes table cells with styled text and newlines without trapping <br/> inside markers", () => {
+    const blocks: CustomEditorBlock[] = [
+      {
+        id: "tbl3",
+        type: "table",
+        props: { textColor: "default" },
+        content: {
+          type: "tableContent",
+          columnWidths: [undefined, undefined],
+          headerRows: 1,
+          rows: [
+            {
+              cells: [
+                {
+                  type: "tableCell",
+                  props: cellProps,
+                  content: [{ type: "text", text: "Col A", styles: {} }],
+                },
+                {
+                  type: "tableCell",
+                  props: cellProps,
+                  content: [{ type: "text", text: "Col B", styles: {} }],
+                },
+              ],
+            },
+            {
+              cells: [
+                {
+                  type: "tableCell",
+                  props: cellProps,
+                  content: [{ type: "text", text: "ok", styles: {} }],
+                },
+                {
+                  type: "tableCell",
+                  props: cellProps,
+                  content: [
+                    { type: "text", text: "opened\nnewline", styles: { bold: true } },
+                  ],
+                },
+              ],
+            },
+          ],
+        },
+        children: [],
+      },
+    ];
+
+    expect(blocksToMarkdown(blocks)).toBe(
+      [
+        "| Col A | Col B |",
+        "| --- | --- |",
+        "| ok | **opened**<br/>**newline** |",
+      ].join("\n"),
+    );
+  });
+
   it("parses a test step with inline image in the title, moving the image to step data", () => {
     const markdown = [
       "## Steps",
@@ -419,6 +536,55 @@ describe("markdownToBlocks", () => {
     ]);
   });
 
+  it("parses a step with empty title but with step data", () => {
+    const markdown = ["* ", "  Navigate to the page"].join("\n");
+
+    expect(markdownToBlocks(markdown)).toEqual([
+      {
+        type: "testStep",
+        props: {
+          stepTitle: "",
+          stepData: "Navigate to the page",
+          expectedResult: "",
+          listStyle: "bullet",
+        },
+        children: [],
+      },
+    ]);
+  });
+
+  it("round-trips a title-less step with data", () => {
+    const blocks: CustomEditorBlock[] = [
+      {
+        id: "s1",
+        type: "testStep",
+        props: {
+          stepTitle: "",
+          stepData: "Open the browser",
+          expectedResult: "Page loads",
+          listStyle: "bullet",
+        },
+        content: undefined,
+        children: [],
+      },
+    ];
+
+    const md = blocksToMarkdown(blocks);
+    const parsed = markdownToBlocks(md);
+    expect(parsed).toEqual([
+      {
+        type: "testStep",
+        props: {
+          stepTitle: "",
+          stepData: "Open the browser",
+          expectedResult: "Page loads",
+          listStyle: "bullet",
+        },
+        children: [],
+      },
+    ]);
+  });
+
   it("parses snippet markdown into snippet blocks", () => {
     const markdown = [
       "<!-- begin snippet #501 -->",

package/src/editor/customMarkdownConverter.ts

@@ -174,12 +174,21 @@ function applyTextStyles(text: string, styles: EditorStyles | undefined): string
     });
   }
 
-  for (const wrapper of wrappers) {
-    const suffix = wrapper.suffix ?? wrapper.prefix;
-    result = `${wrapper.prefix}${result}${suffix}`;
-  }
+  // Split on newlines so that style markers wrap each line individually.
+  // This prevents <br/> (inserted by table cell formatting) from being
+  // trapped inside markers like **bold<br/>text**.
+  const segments = result.split("\n");
+  const wrapped = segments.map((segment) => {
+    if (!segment) return segment;
+    let s = segment;
+    for (const wrapper of wrappers) {
+      const suffix = wrapper.suffix ?? wrapper.prefix;
+      s = `${wrapper.prefix}${s}${suffix}`;
+    }
+    return s;
+  });
 
-  return result;
+  return wrapped.join("\n");
 }
 
 function inlineToMarkdown(content: CustomEditorBlock["content"]): string {
@@ -392,18 +401,19 @@ function serializeBlock(
         return flattenWithBlankLine(lines, true);
       }
 
-      if (stepTitle.length > 0) {
-        const normalizedTitle = stepTitle
-          .split(/\r?\n/)
-          .map((segment: string) => segment.trim())
-          .filter((segment: string) => segment.length > 0)
-          .join(" ");
-
-        if (normalizedTitle.length > 0) {
-          const listStyle = (block.props as any).listStyle ?? "bullet";
-          const prefix = listStyle === "ordered" ? `${(stepIndex ?? 0) + 1}.` : "*";
-          lines.push(`${prefix} ${normalizedTitle}`);
-        }
+      const normalizedTitle = stepTitle
+        .split(/\r?\n/)
+        .map((segment: string) => segment.trim())
+        .filter((segment: string) => segment.length > 0)
+        .join(" ");
+
+      const normalizedExpectedForCheck = stripExpectedPrefix(expectedResult).trim();
+      const hasContent = stepData.length > 0 || normalizedExpectedForCheck.length > 0;
+
+      if (normalizedTitle.length > 0 || hasContent) {
+        const listStyle = (block.props as any).listStyle ?? "bullet";
+        const prefix = listStyle === "ordered" ? `${(stepIndex ?? 0) + 1}.` : "*";
+        lines.push(normalizedTitle.length > 0 ? `${prefix} ${normalizedTitle}` : `${prefix} `);
       }
 
       if (stepData.length > 0) {
@@ -734,7 +744,7 @@ function detectListType(trimmed: string): "bullet" | "numbered" | "check" | null
   if (/^\d+[.)]\s+/.test(trimmed)) {
     return "numbered";
   }
-  if (/^[-*+]\s+/.test(trimmed)) {
+  if (/^[-*+](\s+|$)/.test(trimmed)) {
     return "bullet";
   }
   return null;
@@ -850,7 +860,7 @@ function parseList(
       });
     } else {
       const bulletMatch = trimmed.match(/^[-*+]\s+(.*)$/);
-      const text = bulletMatch?.[1] ?? trimmed.slice(2);
+      const text = bulletMatch?.[1] ?? (trimmed.length <= 1 ? "" : trimmed.slice(2));
       items.push({
         type: "bulletListItem",
         props: cloneBaseProps(),
@@ -880,7 +890,7 @@ function isLikelyStep(lines: string[], index: number): boolean {
     if (hasIndent) return true;
 
     // Stop at new list items, headings, or other block-level elements (only if not indented)
-    if (/^[-*+]\s/.test(trimmed) || /^\d+[.)]\s/.test(trimmed)) break;
+    if (/^[-*+](\s|$)/.test(trimmed) || /^\d+[.)]\s/.test(trimmed)) break;
     if (trimmed.startsWith("#") || trimmed.startsWith(">") || trimmed.startsWith("|") || trimmed.startsWith("```") || trimmed.startsWith(":::")) break;
 
     // Check for expected result markers
@@ -899,7 +909,7 @@ function parseTestStep(
 ): { block: CustomPartialBlock; nextIndex: number } | null {
   const current = lines[index];
   const trimmed = current.trim();
-  const isBullet = trimmed.startsWith("* ") || trimmed.startsWith("- ");
+  const isBullet = trimmed.startsWith("* ") || trimmed.startsWith("- ") || trimmed === "*" || trimmed === "-";
   const isNumbered = /^\d+[.)]\s+/.test(trimmed);
 
   if (!isBullet && !isNumbered) {
@@ -915,7 +925,9 @@ function parseTestStep(
 
   let rawTitle: string;
   if (isBullet) {
-    rawTitle = unescapeMarkdown(trimmed.slice(2)).trim();
+    rawTitle = unescapeMarkdown(
+      (trimmed.startsWith("* ") || trimmed.startsWith("- ")) ? trimmed.slice(2) : trimmed.slice(1)
+    ).trim();
   } else {
     // For numbered lists, remove the number and delimiter
     rawTitle = unescapeMarkdown(trimmed.replace(/^\d+[.)]\s+/, "")).trim();
@@ -963,7 +975,7 @@ function parseTestStep(
     }
     const isNumberedStep = NUMBERED_STEP_REGEX.test(rawTrimmed);
     const isNewStep =
-      (!hasIndent && (rawTrimmed.startsWith("* ") || rawTrimmed.startsWith("- "))) ||
+      (!hasIndent && (rawTrimmed.startsWith("* ") || rawTrimmed.startsWith("- ") || rawTrimmed === "*" || rawTrimmed === "-")) ||
       (!hasIndent && isNumberedStep);
 
     if (isNewStep) {