testilo 41.5.3 → 41.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testilo",
-  "version": "41.5.3",
+  "version": "41.5.5",
   "description": "Prepares Testaro jobs and processes Testaro reports",
   "main": "call.js",
   "scripts": {

package/procs/digest/tdp49/index.html

@@ -165,7 +165,7 @@
         </ul>
         <h3>Scoring method details</h3>
         <p>The above component descriptions omit various details.</p>
-        <p>About a thousand tool rules are classified into <dfn>issues</dfn> in the <code>tic45.js</code> file used by this procedure. Each of those rules has a <dfn>quality</dfn>, ranging from 0 to 1. When the <strong>issue score</strong> is computed, the count of violations of each rule is multiplied by the quality of that rule. Whichever tool has the largest quality-weighted violation count for an issue, that count is treated as the instance count for the issue. Thus, if 8 tools each report 15 violations within the issue, and their rule qualities are all 1, the instance count is 15, not 120. Moreover, the issue itself has a <dfn>weight</dfn>, ranging from 1 to 4, representing its importance. This instance count is multiplied by that weight. That product is further multiplied by the <code>issueCountWeight</code> value, namely 10. That final product is further adjusted if the issue is inherently limited in instance count. For example, if the issue is that the page <code>html</code> element has no <code>lang</code> attribute, the instance count is limited to 1. If there is such a limit, the <code>maxWeight</code> value, namely 30, is divided by the actual instance count and the quotient is added to 1. That product (or 1 if there is no limit) is multiplied by the instance count, and then the result is treated as the contribution of the issue to the issue score.</p>
+        <p>About a thousand tool rules are classified into <dfn>issues</dfn> in the <code>tic49.js</code> file used by this procedure. Each of those rules has a <dfn>quality</dfn>, ranging from 0 to 1. When the <strong>issue score</strong> is computed, the count of violations of each rule is multiplied by the quality of that rule. Whichever tool has the largest quality-weighted violation count for an issue, that count is treated as the instance count for the issue. Thus, if 8 tools each report 15 violations within the issue, and their rule qualities are all 1, the instance count is 15, not 120. Moreover, the issue itself has a <dfn>weight</dfn>, ranging from 1 to 4, representing its importance. This instance count is multiplied by that weight. That product is further multiplied by the <code>issueCountWeight</code> value, namely 10. That final product is further adjusted if the issue is inherently limited in instance count. For example, if the issue is that the page <code>html</code> element has no <code>lang</code> attribute, the instance count is limited to 1. If there is such a limit, the <code>maxWeight</code> value, namely 30, is divided by the actual instance count and the quotient is added to 1. That product (or 1 if there is no limit) is multiplied by the instance count, and then the result is treated as the contribution of the issue to the issue score.</p>
         <p>Each <dfn>solo</dfn> (not yet issue-classified) rule violation is multiplied by the sum of 1 and the ordinal severity of the rule, to produce the <strong>solo score</strong>.</p>
         <p>Each rule violation reported by each tool is severity-weighted in the same way as solo rule violations are. Then the sum of those violations is multiplied by the <code>toolWeight</code> value, namely 0.1, to produce the <strong>tool score</strong>.</p>
         <p>The count of elements reported as violators of any rule is multiplied by the <code>elementWeight</code> value, namely 2, to produce the <strong>element score</strong>.</p>

package/procs/score/tic49.js

@@ -284,12 +284,10 @@ exports.issues = {
           quality: 0.5,
           what: 'Script removes the focus when focus is received [invalid]'
         },
-        qualWeb: {
-          'QW-WCAG-T32': {
-            variable: false,
-            quality: 1,
-            what: 'ol, ul or dl may fail to be used for a list or group of links [speculative]'
-          }
+        'QW-WCAG-T32': {
+          variable: false,
+          quality: 1,
+          what: 'ol, ul or dl may fail to be used for a list or group of links [speculative]'
         }
       }
     }

package/procs/score/tsp49.js

@@ -50,8 +50,6 @@ const issueCountWeight = 10;
 */
 const maxWeight = 30;
 
-// 2. Solo
-
 // 3. Tool
 /*
   Severity: amount added to each raw tool score by each violation of a rule with ordinal severity 0
@@ -90,7 +88,7 @@ const latencyWeight = 2;
 
 // RULE CONSTANTS
 
-// Initialize a table of tool rules.
+// Initialize a table of issue-classified tool rules.
 const issueIndex = {};
 // Initialize an array of variably named tool rules.
 const issueMatcher = [];
@@ -100,10 +98,8 @@ Object.keys(issues).forEach(issueName => {
   Object.keys(issues[issueName].tools).forEach(toolName => {
     // For each of those rules:
     Object.keys(issues[issueName].tools[toolName]).forEach(ruleID => {
+      issueIndex[toolName] ??= {};
       // Add it to the table of tool rules.
-      if (! issueIndex[toolName]) {
-        issueIndex[toolName] = {};
-      }
       issueIndex[toolName][ruleID] = issueName;
       // If it is variably named:
       if (issues[issueName].tools[toolName][ruleID].variable) {
@@ -197,8 +193,8 @@ exports.scorer = report => {
           standardResult.instances.forEach(instance => {
             const {ordinalSeverity, pathID, ruleID, what} = instance;
             const count = instance.count || 1;
-            // If the rule ID is not in the table of tool rules:
             let canonicalRuleID = ruleID;
+            // If the rule ID is not in the table of issue-classified tool rules:
             if (! issueIndex[which][ruleID]) {
               // Convert it to the variably named tool rule that it matches, if any.
               canonicalRuleID = issueMatcher.find(pattern => {