testilo 20.0.3 → 21.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testilo",
-  "version": "20.0.3",
+  "version": "21.1.0",
   "description": "Prepares and processes Testaro reports",
   "main": "aim.js",
   "scripts": {

package/procs/digest/{tdp37 → tdp38}/index.js

@@ -3,14 +3,14 @@
 // IMPORTS
 
 // Module to classify tool rules into issues
-const {issues} = require('../../score/tic37');
+const {issues} = require('../../score/tic38');
 // Module to process files.
 const fs = require('fs/promises');
 
 // CONSTANTS
 
 // Digester ID.
-const id = 'tdp37';
+const id = 'tdp38';
 // Newline with indentations.
 const innerJoiner = '\n        ';
 
@@ -53,9 +53,14 @@ const populateQuery = (report, query) => {
   // Get rows for the issue-score table.
   issueIDs.forEach(issueID => {
     const {score, tools} = details.issue[issueID];
-    rows.issueRows.push(
-      getIssueScoreRow(issues[issueID].summary, issues[issueID].wcag, score, Object.keys(tools))
-    );
+    if (issues[issueID]) {
+      rows.issueRows.push(
+        getIssueScoreRow(issues[issueID].summary, issues[issueID].wcag, score, Object.keys(tools))
+      );
+    }
+    else {
+      console.log(`ERROR: Issue ${issueID} not found`);
+    }
   });
   // Add the rows to the query.
   ['summaryRows', 'issueRows'].forEach(rowType => {

package/procs/score/tic38.js

@@ -54,6 +54,11 @@ exports.issues = {
           quality: 0,
           what: 'Document contains a commercial overlay modifier that may fail or invalidate test results [unreliable]'
         },
+        object_missing_body: {
+          variable: false,
+          quality: 0,
+          what: 'object element has no body to act as a text alternative [invalid]'
+        },
         reflow: {
           variable: false,
           quality: 0,
@@ -1328,7 +1333,7 @@ exports.issues = {
     summary: 'label referent ineligible',
     why: 'User cannot get help understanding an item in a form',
     wcag: '1.3.1',
-    weight: 3,
+    weight: 4,
     tools: {
       aslint: {
         label_inappropriate_associationN: {
@@ -1360,6 +1365,21 @@ exports.issues = {
       }
     }
   },
+  buttonIDInLabelBad: {
+    summary: 'label contains button with nonmatching ID',
+    why: 'User cannot get help understanding an item in a form',
+    wcag: '1.3.1',
+    weight: 4,
+    tools: {
+      nuVal: {
+        'Any button descendant of a label element with a for attribute must have an ID value that matches that for attribute.': {
+          variable: false,
+          quality: 1,
+          what: 'label element has a button descendant whose ID differs from the for attribute of the label'
+        }
+      }
+    }
+  },
   ariaLabelWrongRisk: {
     summary: 'dubious aria-label',
     why: 'User may fail to get help understanding an item in a form',
@@ -1988,6 +2008,21 @@ exports.issues = {
       }
     }
   },
+  linkPairRisk: {
+    summary: 'text and image link may merit combination',
+    why: 'Keyboard-only user may expend extra effort to skip a link',
+    wcag: '2.4.4',
+    weight: 1,
+    tools: {
+      htmlcs: {
+        'AAA.1_1_1.H2.EG4': {
+          variable: false,
+          quality: 1,
+          what: 'Adjacent links, one with text and the other with a textless image, may merit combination'
+        }
+      }
+    }
+  },
   pageNewWindow: {
     summary: 'page immediately opens window',
     why: 'User promised a document gets another document, too',
@@ -2624,29 +2659,34 @@ exports.issues = {
         'AAA.2_4_8.H59.1': {
           variable: false,
           quality: 1,
-          what: 'link element is not in the document head'
+          what: 'Element is not in the document head'
+        },
+        'AAA.2_4_8.H59.2a': {
+          variable: false,
+          quality: 1,
+          what: 'Element has no nonempty rel attribute for the type'
         },
         'A link element with an as attribute must have a rel attribute that contains the value preload or the value modulepreload or the value prefetch.': {
           variable: false,
           quality: 1,
-          what: 'link element with an as attribute has no rel attribute with preload, modulepreload, or prefetch as its value'
+          what: 'Element with an as attribute has no rel attribute with preload, modulepreload, or prefetch as its value'
         }
       },
       nuVal: {
         'A link element must not appear as a descendant of a body element unless the link element has an itemprop attribute or has a rel attribute whose value contains dns-prefetch, modulepreload, pingback, preconnect, prefetch, preload, prerender, or stylesheet.': {
           variable: false,
           quality: 1,
-          what: 'link element with a body ancestor has no itemprop or valid rel attribute'
+          what: 'Element has a body ancestor but no itemprop or valid rel attribute'
         },
         'A link element with an as attribute must have a rel attribute that contains the value preload or the value modulepreload or the value prefetch.': {
           variable: false,
           quality: 1,
-          what: 'link element with an as attribute has no rel attribute with preload, modulepreload, or prefetch as its value'
+          what: 'Element has an as attribute but no rel attribute with preload, modulepreload, or prefetch as its value'
         },
         'A link element with an as attribute must have a rel attribute that contains the value preload or the value modulepreload.': {
           variable: false,
           quality: 1,
-          what: 'link element with an as attribute has no rel attribute with preload or modulepreload as its value'
+          what: 'Element has an as attribute but no rel attribute with preload or modulepreload as its value'
         }
       }
     }
@@ -2666,17 +2706,17 @@ exports.issues = {
         '^Element meta is missing one or more of the following attributes: .+$': {
           variable: true,
           quality: 1,
-          what: 'meta element is missing a required attribute'
+          what: 'Element is missing a required attribute'
         },
         'A document must not include more than one meta element with its name attribute set to the value description.': {
           variable: false,
           quality: 1,
-          what: 'meta element with name="description" is not the only one'
+          what: 'Element with name="description" is not the only meta element with that name'
         },
         'A document must not include both a meta element with an http-equiv attribute whose value is content-type, and a meta element with a charset attribute.': {
           variable: false,
           quality: 1,
-          what: 'meta element with http-equiv="content-type" is incompatible with the meta element with a charset attribute'
+          what: 'Element with http-equiv="content-type" is incompatible with the meta element with a charset attribute'
         },
         'A document must not include more than one meta element with a http-equiv attribute whose value is content-type.': {
           variable: false,
@@ -2686,7 +2726,7 @@ exports.issues = {
         'A meta element with an http-equiv attribute whose value is X-UA-Compatible must have a content attribute with the value IE=edge.': {
           variable: false,
           quality: 1,
-          what: 'meta element with http-equiv="X-UA-Compatible" has no content="IE=edge"'
+          what: 'Element with http-equiv="X-UA-Compatible" has no content="IE=edge"'
         },
         'A document must not include more than one meta element with a charset attribute.': {
           variable: false,
@@ -3510,7 +3550,7 @@ exports.issues = {
   },
   requirementRedundant: {
     summary: 'requirement redundant',
-    why: 'Help determining whether a form item must be completed is exposed to risk of corruption',
+    why: 'Help determining whether a form item must be completed is at risk of corruption',
     wcag: '1.3.5',
     weight: 1,
     tools: {
@@ -3884,6 +3924,21 @@ exports.issues = {
       }
     }
   },
+  typeBad: {
+    summary: 'type invalid',
+    why: 'Document styles are at risk of corruption',
+    wcag: '1.3.1',
+    weight: 4,
+    tools: {
+      nuVal: {
+        'The only allowed value for the type attribute for the style element is text/css (with no parameters). (But the attribute is not needed and should be omitted altogether.)': {
+          variable: false,
+          quality: 1,
+          what: 'type attribute is invalid'
+        }
+      }
+    }
+  },
   typeRedundant: {
     summary: 'type redundant',
     why: 'Document includes unnecessary code',
@@ -4125,6 +4180,13 @@ exports.issues = {
           what: 'Document head element contains an empty title element'
         }
       },
+      ibm: {
+        'page_title_exists': {
+          variable: false,
+          quality: 1,
+          what: 'Page has no title'
+        }
+      },
       nuVal: {
         'Element head is missing a required instance of child element title.': {
           variable: false,
@@ -4605,7 +4667,22 @@ exports.issues = {
         listitem: {
           variable: false,
           quality: 1,
-          what: 'li element is not contained by a ul or ol element'
+          what: 'Element is not contained by a ul or ol element'
+        }
+      }
+    }
+  },
+  descriptionOrphan: {
+    summary: 'description list orphan',
+    why: 'User cannot get help on whether an item is in a list',
+    wcag: '1.3.1',
+    weight: 4,
+    tools: {
+      qualWeb: {
+        'The test target is not contained in a correct description list element.': {
+          variable: false,
+          quality: 1,
+          what: 'Element is not contained by a valid dl element'
         }
       }
     }
@@ -7659,7 +7736,7 @@ exports.issues = {
   },
   obsolete: {
     summary: 'code obsolete',
-    why: 'Document contains invalid code',
+    why: 'Document contains code that is no longer standard',
     wcag: '4.1',
     weight: 3,
     tools: {
@@ -7676,6 +7753,11 @@ exports.issues = {
         }
       },
       nuVal: {
+        'Legacy doctype. Expected <!DOCTYPE html>.': {
+          variable: false,
+          quality: 1,
+          what: 'doctype is obsolete'
+        },
         'Obsolete doctype. Expected <!DOCTYPE html>.': {
           variable: false,
           quality: 1,
@@ -7711,11 +7793,21 @@ exports.issues = {
           quality: 1,
           what: 'CSS style sheet includes HTML syntax'
         },
+        '^CSS: column-count: .+ is not valid, only values greater than 0 allowed.*$': {
+          variable: true,
+          quality: 1,
+          what: 'CSS column-count property has a nonpositive value'
+        },
         'CSS: font-size: One operand must be a number.': {
           variable: false,
           quality: 1,
           what: 'CSS font-size property has no numeric operand'
         },
+        '^CSS: font-weight: .+ is not valid, only values greater than or equal to 1.0 are allowed.*$': {
+          variable: true,
+          quality: 1,
+          what: 'CSS font-weight property has a value smaller than 1'
+        },
         '^CSS: .+: Parse Error.*$': {
           variable: true,
           quality: 1,
@@ -7811,6 +7903,11 @@ exports.issues = {
           quality: 1,
           what: 'CSS @charset at-rule is not at the start of its style sheet'
         },
+        'CSS: @import are not allowed after any valid statement other than @charset and @import.': {
+          variable: false,
+          quality: 1,
+          what: 'CSS @import at-rule is after an at-rule other than @charset or @import'
+        },
         '^CSS: perspective: .+ is not valid, only values greater than 0 allowed.*$': {
           variable: true,
           quality: 0.5,
@@ -7988,11 +8085,26 @@ exports.issues = {
           quality: 1,
           what: 'Comment contains --'
         },
+        'The document is not mappable to XML 1.0 due to a trailing hyphen in a comment.': {
+          variable: false,
+          quality: 1,
+          what: 'Comment ends with -'
+        },
+        'Bogus comment.': {
+          variable: false,
+          quality: 1,
+          what: 'Comment is missing a valid termination'
+        },
         '^Element name .+ cannot be represented as XML 1\\.0.*$': {
           variable: true,
           quality: 1,
           what: 'Invalid element name'
         },
+        '^Bad element name .*: Code point .* is not allowed*$': {
+          variable: true,
+          quality: 1,
+          what: 'Element name contains an invalid character'
+        },
         '^Forbidden code point U+.+$': {
           variable: true,
           quality: 1,
@@ -8073,6 +8185,11 @@ exports.issues = {
           quality: 1,
           what: 'Element with a srcset attribute with a width has no sizes attribute'
         },
+        'When the srcset attribute has any image candidate string with a width descriptor, the sizes attribute must also be specified.': {
+          variable: false,
+          quality: 1,
+          what: 'Element with a srcset attribute with a width has no valid sizes attribute'
+        },
         '^The text content of element .+ was not in the required format: Expected .+ but found .+ instead.*$': {
           variable: true,
           quality: 1,

package/procs/score/tsp38.js

@@ -283,7 +283,7 @@ exports.scorer = report => {
       + summary.prevention
       + summary.log
       + summary.latency;
-      // Add the score to the report.
+      // Add the score to the report or replace the existing score of the report.
       report.score = score;
     }
     // Otherwise, i.e. if none of them is a test act:

package/procs/digest/tdp31/index.html

@@ -1,72 +0,0 @@
-<!DOCTYPE HTML>
-<html lang="en-US">
-  <head>
-    <meta charset="UTF-8">
-    <meta name="viewport" content="width=device-width, initial-scale=1">
-    <meta name="author" content="Testilo">
-    <meta name="creator" content="Testilo">
-    <meta name="publisher" name="Testilo">
-    <meta name="description" content="report of accessibility testing of a web page">
-    <meta name="keywords" content="accessibility a11y web testing">
-    <title>Accessibility digest</title>
-    <link rel="icon" href="favicon.png">
-    <link rel="stylesheet" href="style.css">
-  </head>
-  <body>
-    <main>
-      <header>
-        <h1>Accessibility digest</h1>
-        <table class="allBorder">
-          <caption>Synopsis</caption>
-          <tr><th>Page</th><td>__org__</td></tr>
-          <tr><th>URL</th><td>__url__</td></tr>
-          <tr><th>Requester</th><td>__requester__</td></tr>
-          <tr><th>Test date</th><td>__dateSlash__</td></tr>
-          <tr><th>Score</th><td>__total__</td></tr>
-          <tr><th>Tested by</th><td>Testaro, procedure <code>__ts__</code></td></tr>
-          <tr><th>Scored by</th><td>Testilo, procedure <code>__sp__</code></td></tr>
-          <tr><th>Digested by</th><td>Testilo, procedure <code>__dp__</code></td></tr>
-        </table>
-      </header>
-      <h2>Introduction</h2>
-      <p>This is a digest of results from a battery of <a href="https://www.w3.org/WAI/">web accessibility</a> tests.</p>
-      <p>Nine different <dfn>tools</dfn> (Alfa, Axe, Continuum, Equal Access, HTML CodeSniffer, Nu Html Checker, QualWeb, Testaro, and WAVE) tested the web page of __org__ at __url__ to check its compliance with various <dfn>rules</dfn>. There were a total of about 900 rules, classified into about 260 accessibility <dfn>issues</dfn>.</p>
-      <p>The results were interpreted to yield an aggregate score of __total__, where 0 would be <q>perfect</q>.</p>
-      <h2>Total score</h2>
-      <p>The total score is the sum of five components.</p>
-      <table class="allBorder secondCellRight">
-        <caption>Score summary</caption>
-        <thead>
-          <tr><th>Component</th><th>Score</th><th>Description</th></tr>
-        </thead>
-        <tbody class="headersLeft">
-          <tr><th>total</th><td>__total__</td><td>Sum of the component scores</td></tr>
-          <tr><th>issue</th><td>__issue__</td><td>Severity and number of reported defects</td></tr>
-          <tr><th>tool</th><td>__tool__</td><td>Tool-by-tool defect ratings</td></tr>
-          <tr><th>prevention</th><td>__prevention__</td><td>Failed attempts by tools to test the page</td></tr>
-          <tr><th>log</th><td>__log__</td><td>Browser warnings about the page</td></tr>
-          <tr><th>latency</th><td>__latency__</td><td>Abnormal delay in page responses</td></tr>
-        </tbody>
-      </table>
-      <h2>Issue scores</h2>
-      <p>The score of an issue depends on the <dfn>severity</dfn> (user impact and certainty) of the issue and on how many instances were reported (by one or more tools).</p>
-      <table class="allBorder secondCellRight">
-        <caption>Issue scores</caption>
-        <thead>
-          <tr><th>Issue</th><th>Score</th></tr>
-        </thead>
-        <tbody class="headersLeft">
-          __issueRows__
-        </tbody>
-      </table>
-      <h2>Itemized issues</h2>
-      <p>The reported rule violations are itemized below, issue by issue. Additional details can be inspected in the complete report at the end of this page.</p>
-      __issueDetailRows__
-      <h2>Complete report</h2>
-      <pre>__report__</pre>
-      <footer>
-        <p class="date">Produced <time itemprop="datePublished" datetime="__dateISO__">__dateSlash__</time></p>
-      </footer>
-    </main>
-  </body>
-</html>

package/procs/digest/tdp31/index.js

@@ -1,105 +0,0 @@
-// index: digester for scoring procedure tsp28.
-
-// IMPORTS
-
-// Issue classification
-const {issues} = require('../../score/tic31');
-// Function to process files.
-const fs = require('fs/promises');
-
-// CONSTANTS
-
-// Digester ID.
-const id = 'tdp31';
-// Newlines with indentations.
-const joiner = '\n      ';
-const innerJoiner = '\n        ';
-
-// FUNCTIONS
-
-// Makes strings HTML-safe.
-const htmlEscape = textOrNumber => textOrNumber
-.toString()
-.replace(/&/g, '&')
-.replace(/</g, '&lt;');
-// Gets a row of the score-summary table.
-const getScoreRow = (componentName, score) => `<tr><th>${componentName}</th><td>${score}</td></tr>`;
-// Adds parameters to a query for a digest.
-const populateQuery = (report, query) => {
-  const {sources, jobData, score} = report;
-  const {script, target, requester} = sources;
-  const {scoreProcID, summary, details} = score;
-  query.ts = script;
-  query.sp = scoreProcID;
-  query.dp = id;
-  // Add the job data to the query.
-  query.dateISO = jobData.endTime.slice(0, 10);
-  query.dateSlash = query.dateISO.replace(/-/g, '/');
-  query.org = target.what;
-  query.url = target.which;
-  query.requester = requester;
-  // Add values for the score-summary table to the query.
-  const rows = {
-    summaryRows: [],
-    issueRows: []
-  };
-  ['total', 'issue', 'tool', 'prevention', 'log', 'latency'].forEach(sumItem => {
-    query[sumItem] = summary[sumItem];
-    rows.summaryRows.push(getScoreRow(sumItem, query[sumItem]));
-  });
-  // Sort the issue IDs in descending score order.
-  const issueIDs = Object.keys(details.issue);
-  issueIDs.sort((a, b) => details.issue[b].score - details.issue[a].score);
-  // Get rows for the issue-score table.
-  issueIDs.forEach(issueID => {
-    rows.issueRows.push(getScoreRow(issueID, details.issue[issueID].score));
-  });
-  // Add the rows to the query.
-  ['summaryRows', 'issueRows'].forEach(rowType => {
-    query[rowType] = rows[rowType].join(innerJoiner);
-  });
-  // Add paragraph groups about the issue details to the query.
-  const issueDetailRows = [];
-  issueIDs.forEach(issueID => {
-    issueDetailRows.push(`<h3 class="bars">Issue <code>${issueID}</code></h3>`);
-    issueDetailRows.push(`<p>WCAG: ${issues[issueID].wcag || 'N/A'}</p>`);
-    const issueData = details.issue[issueID];
-    issueDetailRows.push(`<p>Score: ${issueData.score}</p>`);
-    const toolIDs = Object.keys(issueData.tools);
-    toolIDs.forEach(toolID => {
-      issueDetailRows.push(`<h4>Complaints by <code>${toolID}</code></h5>`);
-      const ruleIDs = Object.keys(issueData.tools[toolID]);
-      ruleIDs.forEach(ruleID => {
-        const ruleData = issueData.tools[toolID][ruleID];
-        issueDetailRows.push(`<h5>Rule <code>${ruleID}</code></h5>`);
-        issueDetailRows.push(`<p>Description: ${ruleData.what}</p>`);
-        issueDetailRows.push(`<p>Count of instances: ${ruleData.complaints.countTotal}</p>`);
-        issueDetailRows.push('<h6>Complaint specifics</h6>');
-        issueDetailRows.push('<ul>');
-        ruleData.complaints.texts.forEach(text => {
-          issueDetailRows.push(`  <li>${htmlEscape(text || '')}</li>`);
-        });
-        issueDetailRows.push('</ul>');
-      });
-    });
-  });
-  query.issueDetailRows = issueDetailRows.join(innerJoiner);
-  // Add an HTML-safe copy of the report to the query to be appended to the digest.
-  const reportJSON = JSON.stringify(report, null, 2);
-  const reportJSONSafe = htmlEscape(reportJSON);
-  query.report = reportJSONSafe;
-};
-// Returns a digested report.
-exports.digester = async report => {
-  // Create a query to replace placeholders.
-  const query = {};
-  populateQuery(report, query);
-  // Get the template.
-  let template = await fs.readFile(`${__dirname}/index.html`, 'utf8');
-  // Replace its placeholders.
-  Object.keys(query).forEach(param => {
-    template = template.replace(new RegExp(`__${param}__`, 'g'), query[param]);
-  });
-  // Return the digest.
-  return template;
-};

package/procs/digest/tdp33/index.html

@@ -1,72 +0,0 @@
-<!DOCTYPE HTML>
-<html lang="en-US">
-  <head>
-    <meta charset="UTF-8">
-    <meta name="viewport" content="width=device-width, initial-scale=1">
-    <meta name="author" content="Testilo">
-    <meta name="creator" content="Testilo">
-    <meta name="publisher" name="Testilo">
-    <meta name="description" content="report of accessibility testing of a web page">
-    <meta name="keywords" content="accessibility a11y web testing">
-    <title>Accessibility digest</title>
-    <link rel="icon" href="favicon.png">
-    <link rel="stylesheet" href="style.css">
-  </head>
-  <body>
-    <main>
-      <header>
-        <h1>Accessibility digest</h1>
-        <table class="allBorder">
-          <caption>Synopsis</caption>
-          <tr><th>Page</th><td>__org__</td></tr>
-          <tr><th>URL</th><td>__url__</td></tr>
-          <tr><th>Requester</th><td>__requester__</td></tr>
-          <tr><th>Test date</th><td>__dateSlash__</td></tr>
-          <tr><th>Score</th><td>__total__</td></tr>
-          <tr><th>Tested by</th><td>Testaro, procedure <code>__ts__</code></td></tr>
-          <tr><th>Scored by</th><td>Testilo, procedure <code>__sp__</code></td></tr>
-          <tr><th>Digested by</th><td>Testilo, procedure <code>__dp__</code></td></tr>
-        </table>
-      </header>
-      <h2>Introduction</h2>
-      <p>This is a digest of results from a battery of <a href="https://www.w3.org/WAI/">web accessibility</a> tests.</p>
-      <p>Nine different <dfn>tools</dfn> (Alfa, Axe, Continuum, Equal Access, HTML CodeSniffer, Nu Html Checker, QualWeb, Testaro, and WAVE) tested the web page of __org__ at __url__ to check its compliance with various <dfn>rules</dfn>. There were a total of about 900 rules, classified into about 260 accessibility <dfn>issues</dfn>.</p>
-      <p>The results were interpreted to yield an aggregate score of __total__, where 0 would be <q>perfect</q>.</p>
-      <h2>Total score</h2>
-      <p>The total score is the sum of five components.</p>
-      <table class="allBorder secondCellRight">
-        <caption>Score summary</caption>
-        <thead>
-          <tr><th>Component</th><th>Score</th><th>Description</th></tr>
-        </thead>
-        <tbody class="headersLeft">
-          <tr><th>total</th><td>__total__</td><td>Sum of the component scores</td></tr>
-          <tr><th>issue</th><td>__issue__</td><td>Severity and number of reported defects</td></tr>
-          <tr><th>tool</th><td>__tool__</td><td>Tool-by-tool defect ratings</td></tr>
-          <tr><th>prevention</th><td>__prevention__</td><td>Failed attempts by tools to test the page</td></tr>
-          <tr><th>log</th><td>__log__</td><td>Browser warnings about the page</td></tr>
-          <tr><th>latency</th><td>__latency__</td><td>Abnormal delay in page responses</td></tr>
-        </tbody>
-      </table>
-      <h2>Issue scores</h2>
-      <p>The score of an issue depends on the <dfn>severity</dfn> (user impact and certainty) of the issue and on how many instances were reported (by one or more tools).</p>
-      <table class="allBorder secondCellRight">
-        <caption>Issue scores</caption>
-        <thead>
-          <tr><th>Issue</th><th>Score</th></tr>
-        </thead>
-        <tbody class="headersLeft">
-          __issueRows__
-        </tbody>
-      </table>
-      <h2>Itemized issues</h2>
-      <p>The reported rule violations are itemized below, issue by issue. Additional details can be inspected in the complete report at the end of this page.</p>
-      __issueDetailRows__
-      <h2>Complete report</h2>
-      <pre>__report__</pre>
-      <footer>
-        <p class="date">Produced <time itemprop="datePublished" datetime="__dateISO__">__dateSlash__</time></p>
-      </footer>
-    </main>
-  </body>
-</html>