testilo 17.0.0 → 17.0.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testilo",
-  "version": "17.0.0",
+  "version": "17.0.1",
   "description": "Prepares and processes Testaro reports",
   "main": "aim.js",
   "scripts": {

package/procs/analyze/coverage.js

@@ -0,0 +1,69 @@
+/*
+  coverage.js
+  Checks coverage of Testaro tests in an issue classification.
+*/
+
+// Returns a tabulation of the instance counts of issues reported by tools in scored reports.
+const coverage = ticID => {
+  const evalRules = {
+    allCaps: 'leaf elements with entirely upper-case text longer than 7 characters',
+    allHidden: 'page that is entirely or mostly hidden',
+    allSlanted: 'leaf elements with entirely italic or oblique text longer than 39 characters',
+    autocomplete: 'name and email inputs without autocomplete attributes',
+    bulk: 'large count of visible elements',
+    buttonMenu: 'nonstandard keyboard navigation between items of button-controlled menus',
+    captionLoc: 'caption elements that are not first children of table elements',
+    distortion: 'distorted text',
+    docType: 'document without a doctype property',
+    dupAtt: 'elements with duplicate attributes',
+    embAc: 'active elements embedded in links or buttons',
+    filter: 'filter styles on elements',
+    focAll: 'discrepancies between focusable and Tab-focused elements',
+    focInd: 'missing and nonstandard focus indicators',
+    focOp: 'Tab-focusable elements that are not operable',
+    focVis: 'links that are invisible when focused',
+    headEl: 'invalid elements within the head',
+    headingAmb: 'same-level sibling headings with identical texts',
+    hover: 'hover-caused content changes',
+    hovInd: 'hover indication nonstandard',
+    hr: 'hr element instead of styles used for vertical segmentation',
+    labClash: 'labeling inconsistencies',
+    legendLoc: 'legend elements that are not first children of fieldset elements',
+    lineHeight: 'text with a line height less than 1.5 times its font size',
+    linkExt: 'links that automatically open new windows',
+    linkAmb: 'links with identical texts but different destinations',
+    linkOldAtt: 'links with deprecated attributes',
+    linkTitle: 'links with title attributes repeating text content',
+    linkTo: 'links without destinations',
+    linkUl: 'missing underlines on inline links',
+    miniText: 'text smaller than 11 pixels',
+    motion: 'motion without user request',
+    nonTable: 'table elements used for layout',
+    opFoc: 'Operable elements that are not Tab-focusable',
+    optRoleSel: 'Non-option elements with option roles that have no aria-selected attributes',
+    phOnly: 'input elements with placeholders but no accessible names',
+    pseudoP: 'adjacent br elements suspected of nonsemantically simulating p elements',
+    radioSet: 'radio buttons not grouped into standard field sets',
+    role: 'invalid and native-replacing explicit roles',
+    styleDiff: 'style inconsistencies',
+    tabNav: 'nonstandard keyboard navigation between elements with the tab role',
+    targetSize: 'buttons, inputs, and non-inline links smaller than 44 pixels wide and high',
+    titledEl: 'title attributes on inappropriate elements',
+    zIndex: 'non-default Z indexes'
+  };
+  const {issues} = require(`${__dirname}/../score/${ticID}`);
+  const testaroRuleIDs = new Set();
+  Object.values(issues).forEach(issue => {
+    if (issue.tools && issue.tools.testaro) {
+      Object.keys(issue.tools.testaro).forEach(ruleID => {
+        testaroRuleIDs.add(ruleID);
+      });
+    }
+  });
+  Object.keys(evalRules).forEach(ruleID => {
+    if (! testaroRuleIDs.has(ruleID)) {
+      console.log(`${ticID} is missing ${ruleID}`);
+    }
+  });
+};
+coverage('tic35');

package/procs/analyze/credit.js

@@ -17,7 +17,7 @@ exports.credit = reports => {
     // If it is valid:
     if (report.score && report.score.details && report.score.details.issue) {
       // For each issue:
-      const issues = report.score.details.issue;
+      const issues = report.score.details && report.score.details.issue;
       Object.keys(issues).forEach(issueID => {
         // For each tool with any complaints about it:
         if (! counts[issueID]) {
@@ -28,19 +28,29 @@ exports.credit = reports => {
           Object.keys(issueTools).forEach(toolID => {
             // For each rule cited by any of those complaints:
             if (! counts[issueID][toolID]) {
-              counts[issueID][toolID] = 0;
+              counts[issueID][toolID] = {
+                total: 0,
+                rules: {}
+              };
             }
             Object.keys(issueTools[toolID]).forEach(ruleID => {
               // If an instance count was recorded:
               const {complaints} = issueTools[toolID][ruleID];
               if (complaints && complaints.countTotal) {
                 // Add it to the tally.
-                counts[issueID][toolID] += complaints.countTotal;
+                counts[issueID][toolID].total += complaints.countTotal;
+                // Add a rule itemization to the tally.
+                if (! counts[issueID][toolID].rules[ruleID]) {
+                  counts[issueID][toolID].rules[ruleID] = 0;
+                }
+                counts[issueID][toolID].rules[ruleID] += complaints.countTotal;
               }
               // Otherwise, i.e. if no instance count was recorded:
               else {
                 // Report this.
-                console.log(`ERROR: Missing countTotal for ${toolID} in ${issueID}`);
+                console.log(
+                  `ERROR: Report ${report.id} missing countTotal for ${toolID} in ${issueID}`
+                );
               }
             });
           });
@@ -69,9 +79,9 @@ exports.credit = reports => {
       // Add the tools with the maximum instance count to the tally.
       const maxCount = Object
       .values(counts[issueID])
-      .reduce((max, current) => Math.max(max, current));
+      .reduce((max, current) => Math.max(max, current ? current.total : 0), 0);
       Object.keys(counts[issueID]).forEach(toolID => {
-        if (counts[issueID][toolID] === maxCount) {
+        if (maxCount && counts[issueID][toolID].total === maxCount) {
           if (! mosts[issueID]) {
             mosts[issueID] = [];
           }

package/procs/score/tic34.js

@@ -354,7 +354,7 @@ exports.issues = {
         863: {
           variable: false,
           quality: 1,
-          what: 'input has an accessible name that depends on a placeholder'
+          what: 'input element has an accessible name that depends on a placeholder'
         }
       }
     }

package/procs/score/tic35.js

@@ -1,9 +1,8 @@
 /*
   tic35
-  CONTINUUM NOT YET REMOVED
   Testilo issue classification 35
 
-  Classifies approximately 650 rules of the tools of Testaro into 256 issues.
+  Classifies about 650 rules of the tools of Testaro into 256 issues.
 
   Issue properties:
     why: expected impact
@@ -351,11 +350,11 @@ exports.issues = {
     wcag: '4.1.2',
     weight: 3,
     tools: {
-      continuum: {
-        863: {
+      testaro: {
+        phOnly: {
           variable: false,
           quality: 1,
-          what: 'input element has an accessible name that depends on a placeholder'
+          what: 'input element has a placeholder but no accessible name'
         }
       }
     }
@@ -1365,8 +1364,8 @@ exports.issues = {
     wcag: '1.3.1',
     weight: 4,
     tools: {
-      continuum: {
-        83: {
+      testaro: {
+        adbBadID: {
           variable: false,
           quality: 1,
           what: 'aria-describedby attribute references an invalid or duplicate ID'
@@ -1678,13 +1677,6 @@ exports.issues = {
     wcag: '1.3.1',
     weight: 4,
     tools: {
-      continuum: {
-        872: {
-          variable: false,
-          quality: 1,
-          what: 'textarea element has no accessible name, but only a placeholder attribute'
-        }
-      },
       htmlcs: {
         'AAA.4_1_2.H91.Textarea.Name': {
           variable: false,
@@ -2081,13 +2073,6 @@ exports.issues = {
           what: 'svg element with an img role has no text alternative'
         }
       },
-      continuum: {
-        123: {
-          variable: false,
-          quality: 1,
-          what: 'svg element has no machanism allowing an accessible name to be calculated'
-        }
-      },
       qualWeb: {
         'QW-ACT-R21': {
           variable: false,
@@ -2961,28 +2946,6 @@ exports.issues = {
           what: 'Element does not have all required states and properties'
         }
       },
-      continuum: {
-        1039: {
-          variable: false,
-          quality: 1,
-          what: 'Element with a checkbox role has no aria-checked attribute'
-        },
-        1040: {
-          variable: false,
-          quality: 1,
-          what: 'Element with a combobox role has no aria-controls or no aria-expanded attribute'
-        },
-        1042: {
-          variable: false,
-          quality: 1,
-          what: 'Element with an option role has no aria-selected attribute'
-        },
-        1043: {
-          variable: false,
-          quality: 1,
-          what: 'Element with a radio role has no aria-checked attribute'
-        }
-      },
       nuVal: {
         '^Element .+ is missing required attribute aria-.+$': {
           variable: true,
@@ -2999,6 +2962,20 @@ exports.issues = {
       }
     }
   },
+  ariaMissingRisk: {
+    why: 'Item may behave improperly',
+    wcag: '4.1.2',
+    weight: 2,
+    tools: {
+      testaro: {
+        optRoleSel: {
+          variable: false,
+          quality: 1,
+          what: 'Non-option element with an explicit option role has no aria-selected attribute'
+        }
+      }
+    }
+  },
   ariaAttributeBad: {
     why: 'Item behavior violates user expectations',
     wcag: '4.1.2',
@@ -3043,108 +3020,6 @@ exports.issues = {
           what: 'aria-roledescription is on an element with no semantic role'
         }
       },
-      continuum: {
-        16: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-multiline attribute, which is not allowed'
-        },
-        38: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-pressed attribute, which is not allowed'
-        },
-        64: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-valuemax attribute that is not set to an integer'
-        },
-        257: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-checked attribute, which is not allowed'
-        },
-        260: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-level attribute, which is not allowed'
-        },
-        261: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-multiselectable attribute, which is not allowed'
-        },
-        264: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-selected attribute, which is not allowed'
-        },
-        270: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-required attribute, which is not allowed'
-        },
-        278: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-modal attribute, which is not allowed'
-        },
-        279: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-posinset attribute without having a compatible role'
-        },
-        280: {
-          variable: false,
-          quality: 1,
-          what: 'Element has aria-posinset and aria-setsize attributes without having a compatible role'
-        },
-        281: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-expanded attribute, which is not allowed'
-        },
-        282: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-autocomplete attribute, which is not allowed'
-        },
-        283: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-activedescendant attribute, which is not allowed'
-        },
-        331: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-owns attribute set to a non-null value'
-        },
-        333: {
-          variable: false,
-          quality: 1,
-          what: 'Element with a textbox role has an aria-owns attribute, which is not allowed'
-        },
-        334: {
-          variable: false,
-          quality: 1,
-          what: 'Element with a searchbox role has an aria-owns attribute, which is not allowed'
-        },
-        609: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-setsize attribute but has no aria-posinset attribute'
-        },
-        610: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an aria-setsize attribute without having a compatible role'
-        },
-        1066: {
-          variable: false,
-          quality: 1,
-          what: 'Element has an ARIA attribute which is not valid'
-        }
-      },
       ibm: {
         aria_semantics_attribute: {
           variable: false,
@@ -4336,18 +4211,6 @@ exports.issues = {
           quality: 1,
           what: 'li element is not contained by a ul or ol element'
         }
-      },
-      continuum: {
-        99: {
-          variable: false,
-          quality: 1,
-          what: 'li element has no ul, ol, or list-role parent'
-        },
-        385: {
-          variable: false,
-          quality: 1,
-          what: 'list item has no ul, ol, or list-role parent or owner'
-        }
       }
     }
   },
@@ -4583,8 +4446,8 @@ exports.issues = {
     wcag: '4.1.2',
     weight: 4,
     tools: {
-      continuum: {
-        738: {
+      testaro: {
+        legendLoc: {
           variable: false,
           quality: 1,
           what: 'legend element is not the first child of its fieldset element'
@@ -4766,6 +4629,20 @@ exports.issues = {
       }
     }
   },
+  tableCaptionLoc: {
+    why: 'User cannot get help on the topic of a table',
+    wcag: '1.3.1',
+    weight: 3,
+    tools: {
+      testaro: {
+        captionLoc: {
+          variable: false,
+          quality: 1,
+          what: 'caption element is not the first child of a table element'
+        }
+      }
+    }
+  },
   cellHeadersNotInferrable: {
     why: 'User cannot get help on relationships in a table',
     wcag: '1.3.1',
@@ -4775,7 +4652,7 @@ exports.issues = {
         'AAA.1_3_1.H43.HeadersRequired': {
           variable: false,
           quality: 1,
-          what: 'Complex table requires headers attributes of cells'
+          what: 'Complex table is missing headers attributes of cells'
         }
       },
       ibm: {
@@ -5752,18 +5629,6 @@ exports.issues = {
     wcag: '1.3.6',
     weight: 3,
     tools: {
-      continuum: {
-        531: {
-          variable: false,
-          quality: 1,
-          what: 'nav element has an accessible name that is non-unique among the nav elements'
-        },
-        533: {
-          variable: false,
-          quality: 1,
-          what: 'nav element is not the only nav element but has no accessible name'
-        }
-      },
       ibm: {
         Rpt_Aria_MultipleNavigationLandmarks_Implicit: {
           variable: false,
@@ -5884,7 +5749,7 @@ exports.issues = {
     weight: 4,
     tools: {
       testaro: {
-        focOp: {
+        opFoc: {
           variable: false,
           quality: 1,
           what: 'Operable element is not Tab-focusable'
@@ -6207,8 +6072,8 @@ exports.issues = {
     wcag: '1.3.3',
     weight: 1,
     tools: {
-      continuum: {
-        141: {
+      testaro: {
+        imageLink: {
           variable: false,
           quality: 1,
           what: 'a element has an href attribute set to an image file reference'
@@ -6445,7 +6310,7 @@ exports.issues = {
     weight: 1,
     tools: {
       testaro: {
-        filterStyle: {
+        filter: {
           variable: false,
           quality: 1,
           what: 'Element styles include filter'
@@ -7034,6 +6899,13 @@ exports.issues = {
           what: 'HTML element is used to control the visual presentation of content'
         }
       },
+      testaro: {
+        linkOldAtt: {
+          variable: false,
+          quality: 1,
+          what: 'a element has a deprecated attribute'
+        }
+      },
       wave: {
         longdesc: {
           variable: false,