testilo 16.2.0 → 17.0.1

package/README.md

@@ -344,12 +344,11 @@ This is a valid Testaro job.
 
 If, however, you requested a merger **with** isolation, then Testilo would take cognizance of the fact that an `axe` test act is a target-modifying act. Testilo would therefore act as if another instance of the placeholder had been located in the script after the `axe` test act. So, copies of the same 6 acts that precede the `axe` test act would be inserted **after** the `axe` test act, too.
 
-Of the 10 tools providing tests for Testaro, 6 are target-modifying:
+Of the 8 tools providing tests for Testaro, 4 are target-modifying:
 - `axe`
-- `continuum`
 - `htmlcs`
 - `ibm`
-- `wave`
+- `testaro`
 
 #### Invocation
 
@@ -642,7 +641,7 @@ node call credit legislators 23pl
 
 When a user invokes `credit` in this example, the `call` module:
 - gets all the reports in the `scored` subdirectory of the `process.env.REPORTDIR` directory whose file names begin with `23pl`.
-- writes the credit report as JSON file named `legislators.json` to the `credit` subdirectory of the `process.env.REPORTDIR` directory.
+- writes the credit report as a JSON file named `legislators.json` to the `credit` subdirectory of the `process.env.REPORTDIR` directory.
 
 The third argument to `call` (`23pl` in this example) is optional. If it is omitted, `call` will get and `credit()` will tabulate all the reports in the `scored` directory.
 

package/call.js

@@ -279,7 +279,7 @@ else if (fn === 'compare' && fnArgs.length > 1 && fnArgs.length < 4) {
     console.log('Execution completed');
   });
 }
-else if (fn === 'credit' && fnArgs.length === 2) {
+else if (fn === 'credit' && fnArgs.length > 0 && fnArgs.length < 3) {
   callCredit(... fnArgs)
   .then(() => {
     console.log('Execution completed');

package/merge.js

@@ -18,7 +18,6 @@ const stdRequester = process.env.REQUESTER;
 // Tools that alter the page.
 const contaminantNames = new Set([
   'axe',
-  'continuum',
   'htmlcs',
   'ibm'
 ]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testilo",
-  "version": "16.2.0",
+  "version": "17.0.1",
   "description": "Prepares and processes Testaro reports",
   "main": "aim.js",
   "scripts": {

package/procs/analyze/coverage.js

@@ -0,0 +1,69 @@
+/*
+  coverage.js
+  Checks coverage of Testaro tests in an issue classification.
+*/
+
+// Returns a tabulation of the instance counts of issues reported by tools in scored reports.
+const coverage = ticID => {
+  const evalRules = {
+    allCaps: 'leaf elements with entirely upper-case text longer than 7 characters',
+    allHidden: 'page that is entirely or mostly hidden',
+    allSlanted: 'leaf elements with entirely italic or oblique text longer than 39 characters',
+    autocomplete: 'name and email inputs without autocomplete attributes',
+    bulk: 'large count of visible elements',
+    buttonMenu: 'nonstandard keyboard navigation between items of button-controlled menus',
+    captionLoc: 'caption elements that are not first children of table elements',
+    distortion: 'distorted text',
+    docType: 'document without a doctype property',
+    dupAtt: 'elements with duplicate attributes',
+    embAc: 'active elements embedded in links or buttons',
+    filter: 'filter styles on elements',
+    focAll: 'discrepancies between focusable and Tab-focused elements',
+    focInd: 'missing and nonstandard focus indicators',
+    focOp: 'Tab-focusable elements that are not operable',
+    focVis: 'links that are invisible when focused',
+    headEl: 'invalid elements within the head',
+    headingAmb: 'same-level sibling headings with identical texts',
+    hover: 'hover-caused content changes',
+    hovInd: 'hover indication nonstandard',
+    hr: 'hr element instead of styles used for vertical segmentation',
+    labClash: 'labeling inconsistencies',
+    legendLoc: 'legend elements that are not first children of fieldset elements',
+    lineHeight: 'text with a line height less than 1.5 times its font size',
+    linkExt: 'links that automatically open new windows',
+    linkAmb: 'links with identical texts but different destinations',
+    linkOldAtt: 'links with deprecated attributes',
+    linkTitle: 'links with title attributes repeating text content',
+    linkTo: 'links without destinations',
+    linkUl: 'missing underlines on inline links',
+    miniText: 'text smaller than 11 pixels',
+    motion: 'motion without user request',
+    nonTable: 'table elements used for layout',
+    opFoc: 'Operable elements that are not Tab-focusable',
+    optRoleSel: 'Non-option elements with option roles that have no aria-selected attributes',
+    phOnly: 'input elements with placeholders but no accessible names',
+    pseudoP: 'adjacent br elements suspected of nonsemantically simulating p elements',
+    radioSet: 'radio buttons not grouped into standard field sets',
+    role: 'invalid and native-replacing explicit roles',
+    styleDiff: 'style inconsistencies',
+    tabNav: 'nonstandard keyboard navigation between elements with the tab role',
+    targetSize: 'buttons, inputs, and non-inline links smaller than 44 pixels wide and high',
+    titledEl: 'title attributes on inappropriate elements',
+    zIndex: 'non-default Z indexes'
+  };
+  const {issues} = require(`${__dirname}/../score/${ticID}`);
+  const testaroRuleIDs = new Set();
+  Object.values(issues).forEach(issue => {
+    if (issue.tools && issue.tools.testaro) {
+      Object.keys(issue.tools.testaro).forEach(ruleID => {
+        testaroRuleIDs.add(ruleID);
+      });
+    }
+  });
+  Object.keys(evalRules).forEach(ruleID => {
+    if (! testaroRuleIDs.has(ruleID)) {
+      console.log(`${ticID} is missing ${ruleID}`);
+    }
+  });
+};
+coverage('tic35');

package/procs/analyze/credit.js

@@ -17,7 +17,7 @@ exports.credit = reports => {
     // If it is valid:
     if (report.score && report.score.details && report.score.details.issue) {
       // For each issue:
-      const issues = report.score.details.issue;
+      const issues = report.score.details && report.score.details.issue;
       Object.keys(issues).forEach(issueID => {
         // For each tool with any complaints about it:
         if (! counts[issueID]) {
@@ -28,19 +28,29 @@ exports.credit = reports => {
           Object.keys(issueTools).forEach(toolID => {
             // For each rule cited by any of those complaints:
             if (! counts[issueID][toolID]) {
-              counts[issueID][toolID] = 0;
+              counts[issueID][toolID] = {
+                total: 0,
+                rules: {}
+              };
             }
             Object.keys(issueTools[toolID]).forEach(ruleID => {
               // If an instance count was recorded:
               const {complaints} = issueTools[toolID][ruleID];
               if (complaints && complaints.countTotal) {
                 // Add it to the tally.
-                counts[issueID][toolID] += complaints.countTotal;
+                counts[issueID][toolID].total += complaints.countTotal;
+                // Add a rule itemization to the tally.
+                if (! counts[issueID][toolID].rules[ruleID]) {
+                  counts[issueID][toolID].rules[ruleID] = 0;
+                }
+                counts[issueID][toolID].rules[ruleID] += complaints.countTotal;
               }
               // Otherwise, i.e. if no instance count was recorded:
               else {
                 // Report this.
-                console.log(`ERROR: Missing countTotal for ${toolID} in ${issueID}`);
+                console.log(
+                  `ERROR: Report ${report.id} missing countTotal for ${toolID} in ${issueID}`
+                );
               }
             });
           });
@@ -69,9 +79,9 @@ exports.credit = reports => {
       // Add the tools with the maximum instance count to the tally.
       const maxCount = Object
       .values(counts[issueID])
-      .reduce((max, current) => Math.max(max, current));
+      .reduce((max, current) => Math.max(max, current ? current.total : 0), 0);
       Object.keys(counts[issueID]).forEach(toolID => {
-        if (counts[issueID][toolID] === maxCount) {
+        if (maxCount && counts[issueID][toolID].total === maxCount) {
           if (! mosts[issueID]) {
             mosts[issueID] = [];
           }

package/procs/score/tic34.js

@@ -354,7 +354,7 @@ exports.issues = {
         863: {
           variable: false,
           quality: 1,
-          what: 'input has an accessible name that depends on a placeholder'
+          what: 'input element has an accessible name that depends on a placeholder'
         }
       }
     }