testilo 13.6.0 → 13.6.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "testilo",
-  "version": "13.6.0",
-  "description": "Client that scores and digests Testaro reports",
+  "version": "13.6.2",
+  "description": "Prepares and processes Testaro reports",
   "main": "aim.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"

package/procs/digest/tdp27/index.js

@@ -21,8 +21,7 @@ const innerJoiner = '\n        ';
 const htmlEscape = textOrNumber => textOrNumber
 .toString()
 .replace(/&/g, '&')
-.replace(/</g, '&lt;')
-.replace(/"/g, '&quot;');
+.replace(/</g, '&lt;');
 // Gets a row of the score-summary table.
 const getScoreRow = (componentName, score) => `<tr><th>${componentName}</th><td>${score}</td></tr>`;
 // Adds parameters to a query for a digest.
@@ -71,13 +70,13 @@ const populateQuery = (report, query) => {
       issueDetailRows.push(`<h4>Complaints by <code>${toolID}</code></h5>`);
       const ruleIDs = Object.keys(issueData.tools[toolID]);
       ruleIDs.forEach(ruleID => {
+        const ruleData = issueData.tools[toolID][ruleID];
         issueDetailRows.push(`<h5>Rule <code>${ruleID}</code></h5>`);
-        issueDetailRows.push(
-          `<p>Count of instances: ${issueData.tools[toolID][ruleID].complaints.countTotal}</p>`
-        );
+        issueDetailRows.push(`<p>Description: ${ruleData.what}</p>`);
+        issueDetailRows.push(`<p>Count of instances: ${ruleData.complaints.countTotal}</p>`);
         issueDetailRows.push('<h6>Complaint specifics</h6>');
         issueDetailRows.push('<ul>');
-        issueData.tools[toolID][ruleID].complaints.texts.forEach(text => {
+        ruleData.complaints.texts.forEach(text => {
           issueDetailRows.push(`  <li>${htmlEscape(text || '')}</li>`);
         });
         issueDetailRows.push('</ul>');

package/procs/score/tic27.js

@@ -237,17 +237,17 @@ exports.issueClasses = {
         507: {
           variable: false,
           quality: 1,
-          what: 'element with a radio role has no mechanism that allows an accessible name to be calculated'
+          what: 'Element with a radio role has no mechanism that allows an accessible name to be calculated'
         },
         509: {
           variable: false,
           quality: 1,
-          what: 'element with a textbox role has no mechanism that allows an accessible name to be calculated'
+          what: 'Element with a textbox role has no mechanism that allows an accessible name to be calculated'
         },
         510: {
           variable: false,
           quality: 1,
-          what: 'element with a combobox role has no mechanism that allows an accessible name to be calculated'
+          what: 'Element with a combobox role has no mechanism that allows an accessible name to be calculated'
         }
       },
       htmlcs: {
@@ -379,6 +379,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'figure element has no associated label'
+        },
+        figure_label_exists: {
+          variable: false,
+          quality: 1,
+          what: 'figure element has no associated label'
         }
       }
     }
@@ -410,7 +415,7 @@ exports.issueClasses = {
         87: {
           variable: false,
           quality: 1,
-          what: 'element with an image, graphics-symbol, or graphics-document role has no mechanism to calculate an accessible name'
+          what: 'Element with an image, graphics-symbol, or graphics-document role has no mechanism to calculate an accessible name'
         },
         89: {
           variable: false,
@@ -431,10 +436,20 @@ exports.issueClasses = {
           quality: 1,
           what: 'Element with an img role has no non-empty label'
         },
+        aria_img_labelled: {
+          variable: false,
+          quality: 1,
+          what: 'Element with an img role has no label or an empty label'
+        },
         WCAG20_Img_HasAlt: {
           variable: false,
           quality: 1,
           what: 'Image has no alt attribute conveying its meaning, or alt="" if decorative'
+        },
+        img_alt_valid: {
+          variable: false,
+          quality: 1,
+          what: 'Image has neither an alt attribute nor an ARIA label or title'
         }
       },
       nuVal: {
@@ -643,7 +658,7 @@ exports.issueClasses = {
         235: {
           variable: false,
           quality: 1,
-          what: 'element with an img, graphics-symbol, or graphics-document role has a suspicious calculated accessible name'
+          what: 'Element with an img, graphics-symbol, or graphics-document role has a suspicious calculated accessible name'
         }
       },
       qualWeb: {
@@ -744,6 +759,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'Page detected as HTML, but has no lang attribute'
+        },
+        html_lang_exists: {
+          variable: false,
+          quality: 1,
+          what: 'Page detected as HTML, but has no lang attribute'
         }
       },
       nuVal: {
@@ -1266,6 +1286,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'Checkbox or radio button label precedes the input control'
+        },
+        input_label_after: {
+          variable: false,
+          quality: 1,
+          what: 'Label text is located before its associated checkbox or radio button element'
         }
       },
       qualWeb: {
@@ -1285,7 +1310,7 @@ exports.issueClasses = {
         95: {
           variable: false,
           quality: 1,
-          what: 'element has an aria-labelledby value that includes an invalid or duplicate id'
+          what: 'Element has an aria-labelledby value that includes an invalid or duplicate id'
         }
       },
       htmlcs: {
@@ -1892,14 +1917,14 @@ exports.issueClasses = {
         r94: {
           variable: false,
           quality: 1,
-          what: 'element with a menuitem role has no accessible name'
+          what: 'Element with a menuitem role has no accessible name'
         }
       },
       qualWeb: {
         'QW-ACT-R66': {
           variable: false,
           quality: 1,
-          what: 'Menuitem has no non-empty accessible name'
+          what: 'menuitem element has no non-empty accessible name'
         }
       }
     }
@@ -2060,7 +2085,7 @@ exports.issueClasses = {
         r47: {
           variable: false,
           quality: 1,
-          what: 'Meta element restricts zooming'
+          what: 'meta element restricts zooming'
         }
       },
       axe: {
@@ -2243,12 +2268,18 @@ exports.issueClasses = {
           quality: 1,
           what: 'Overflow is hidden or clipped if the text is enlarged'
         }
-      },
+      }
+    }
+  },
+  overflowHiddenRisk: {
+    wcag: '1.4.4',
+    weight: 1,
+    tools: {
       qualWeb: {
         'QW-ACT-R40': {
           variable: false,
           quality: 1,
-          what: 'Zoomed text node is clipped by a CSS overflow declaration'
+          what: 'Zoomed text node may be clipped by a CSS overflow declaration'
         }
       }
     }
@@ -2310,6 +2341,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'link element with an as attribute has no rel attribute with preload, modulepreload, or prefetch as its value'
+        },
+        'A link element with an as attribute must have a rel attribute that contains the value preload or the value modulepreload.': {
+          variable: false,
+          quality: 1,
+          what: 'link element with an as attribute has no rel attribute with preload or modulepreload as its value'
         }
       }
     }
@@ -2362,7 +2398,7 @@ exports.issueClasses = {
         '^Bad value .+ for attribute .+ on element meta.*$': {
           variable: true,
           quality: 1,
-          what: 'attribute of a meta element has an invalid value'
+          what: 'Attribute of a meta element has an invalid value'
         }
       }
     }
@@ -2538,7 +2574,7 @@ exports.issueClasses = {
         412: {
           variable: false,
           quality: 1,
-          what: 'element has a role attribute set to an invalid ARIA role value'
+          what: 'Element has a role attribute set to an invalid ARIA role value'
         }
       },
       ibm: {
@@ -2562,6 +2598,11 @@ exports.issueClasses = {
           quality: 1,
           what: 'Element has a contentinfo role when no element has a main role'
         },
+        aria_contentinfo_misuse: {
+          variable: false,
+          quality: 1,
+          what: 'Element with a contentinfo role is present without an element with a main role'
+        },
         Rpt_Aria_ValidRole: {
           variable: false,
           quality: 1,
@@ -2691,17 +2732,17 @@ exports.issueClasses = {
         '^Attribute .+ not allowed on element .+ at this point.*$': {
           variable: true,
           quality: 1,
-          what: 'attribute not allowed on this element'
+          what: 'Attribute not allowed on this element'
         },
         '^Bad value .* for attribute .+ on element .+$': {
           variable: true,
           quality: 1,
-          what: 'attribute on this element has an invalid value'
+          what: 'Attribute on this element has an invalid value'
         },
         '^Bad value .+ for the attribute .+$': {
           variable: true,
           quality: 1,
-          what: 'attribute has an invalid value'
+          what: 'Attribute has an invalid value'
         },
         '^Attribute .+ not allowed here.*$': {
           variable: true,
@@ -2736,17 +2777,17 @@ exports.issueClasses = {
         'The sizes attribute may be specified only if the srcset attribute is also present.': {
           variable: false,
           quality: 1,
-          what: 'element has a sizes attribute but no srcset attribute'
+          what: 'Element has a sizes attribute but no srcset attribute'
         },
         '^Bad value  for attribute (?:width|height) on element img: The empty string is not a valid non-negative integer.*$': {
           variable: true,
           quality: 1,
-          what: 'attribute has an empty value'
+          what: 'Attribute has an empty value'
         },
         '^.+ in an unquoted attribute value. Probable causes: Attributes running together or a URL query string in an unquoted attribute value.*$': {
           variable: true,
           quality: 1,
-          what: 'attribute has a value containing invalid punctuation'
+          what: 'Attribute has a value containing invalid punctuation'
         }
       }
     }
@@ -2970,12 +3011,12 @@ exports.issueClasses = {
         279: {
           variable: false,
           quality: 1,
-          what: 'element has an aria-posinset attribute without having a compatible role'
+          what: 'Element has an aria-posinset attribute without having a compatible role'
         },
         280: {
           variable: false,
           quality: 1,
-          what: 'element has aria-posinset and aria-setsize attributes without having a compatible role'
+          what: 'Element has aria-posinset and aria-setsize attributes without having a compatible role'
         },
         281: {
           variable: false,
@@ -3015,7 +3056,7 @@ exports.issueClasses = {
         610: {
           variable: false,
           quality: 1,
-          what: 'element has an aria-setsize attribute without having a compatible role'
+          what: 'Element has an aria-setsize attribute without having a compatible role'
         },
         1066: {
           variable: false,
@@ -3054,17 +3095,17 @@ exports.issueClasses = {
         'Attribute aria-activedescendant value should either refer to a descendant element, or should be accompanied by attribute aria-owns.': {
           variable: false,
           quality: 1,
-          what: 'element has no aria-owns attribute but its aria-activedescendant attribute references a non-descendant'
+          what: 'Element has no aria-owns attribute but its aria-activedescendant attribute references a non-descendant'
         },
         '^Bad value  for attribute .+ on element .+: Must be non-empty.*$': {
           variable: true,
           quality: 1,
-          what: 'attribute value is empty'
+          what: 'Attribute value is empty'
         },
         '^Bad value  for attribute aria-hidden on element .+$': {
           variable: true,
           quality: 1,
-          what: 'attribute aria-hidden has an empty value'
+          what: 'aria-hidden attribute has an empty value'
         },
         'The form attribute must refer to a form element.': {
           variable: false,
@@ -3811,7 +3852,7 @@ exports.issueClasses = {
         71: {
           variable: false,
           quality: 1,
-          what: 'element with a heading role has no aria-level attribute'
+          what: 'Element with a heading role has no aria-level attribute'
         }
       }
     }
@@ -4146,7 +4187,14 @@ exports.issueClasses = {
         'Element dl is missing a required child element.': {
           variable: false,
           quality: 1,
-          what: 'dl element has no child element.'
+          what: 'dl element has no child element'
+        }
+      },
+      qualWeb: {
+        'QW-BP24': {
+          variable: false,
+          quality: 1,
+          what: 'ul or ol element has a child other than li, script, or template'
         }
       }
     }
@@ -4294,6 +4342,19 @@ exports.issueClasses = {
       }
     }
   },
+  noOptionFocusable: {
+    wcag: '2.1.1',
+    weight: 1,
+    tools: {
+      ibm: {
+        aria_child_tabbable: {
+          variable: false,
+          quality: 1,
+          what: 'No descendent element with an option role is tabbable'
+        }
+      }
+    }
+  },
   accessKeyDuplicate: {
     wcag: '1.3.1',
     weight: 3,
@@ -4754,6 +4815,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'Form control has no associated label'
+        },
+        input_label_exists: {
+          variable: false,
+          quality: 1,
+          what: 'Element with the role of a form control has no associated label'
         }
       },
       qualWeb: {
@@ -5156,6 +5222,13 @@ exports.issueClasses = {
           quality: 1,
           what: 'main landmark is contained in another landmark'
         }
+      },
+      qualWeb: {
+        'QW-BP27': {
+          variable: false,
+          quality: 1,
+          what: 'main landmark is not at the top level'
+        }
       }
     }
   },
@@ -5351,6 +5424,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'Element with a form role has no unique purpose label among the form-role elements'
+        },
+        aria_form_label_unique: {
+          variable: false,
+          quality: 1,
+          what: 'Multiple elements with a form role do not have unique labels'
         }
       }
     }
@@ -5435,6 +5513,11 @@ exports.issueClasses = {
           variable: false,
           quality: 1,
           what: 'Element with a region role has no unique label among the region-role elements'
+        },
+        aria_region_label_unique: {
+          variable: false,
+          quality: 1,
+          what: 'Multiple elements with a region role do not have unique labels'
         }
       }
     }
@@ -5744,20 +5827,7 @@ exports.issueClasses = {
         hover: {
           variable: false,
           quality: 1,
-          what: 'Hovering is mis-indicated or changes content'
-        }
-      }
-    }
-  },
-  hoverSurprise: {
-    wcag: '1.4.13',
-    weight: 3,
-    tools: {
-      testaro: {
-        hover: {
-          variable: false,
-          quality: 1,
-          what: 'Hovering over element has unexpected effects'
+          what: 'Hovering is impossible or mis-indicated or changes content'
         }
       }
     }
@@ -6886,6 +6956,16 @@ exports.issueClasses = {
         }
       },
       nuVal: {
+        'No space between attributes.': {
+          variable: false,
+          quality: 1,
+          what: 'No space between attributes'
+        },
+        'Saw <?. Probable cause: Attempt to use an XML processing instruction in HTML. (XML processing instructions are not supported in HTML.)': {
+          variable: false,
+          quality: 1,
+          what: 'Left angle bracket is followed by a question mark'
+        },
         'Almost standards mode doctype. Expected <!DOCTYPE html>.': {
           variable: false,
           quality: 1,
@@ -7009,7 +7089,7 @@ exports.issueClasses = {
         'When the srcset attribute has any image candidate string with a width descriptor, the sizes attribute must also be present.': {
           variable: false,
           quality: 1,
-          what: 'element with a srcset attribute with a width has no sizes attribute'
+          what: 'Element with a srcset attribute with a width has no sizes attribute'
         },
         '^The text content of element .+ was not in the required format: Expected .+ but found .+ instead.*$': {
           variable: true,

package/procs/score/tsp27.js

@@ -120,8 +120,10 @@ exports.scorer = report => {
                 details.issue[issueID].tools[which] = {};
               }
               if (! details.issue[issueID].tools[which][ruleID]) {
+                const ruleData = issueClasses[issueID].tools[which][ruleID];
                 details.issue[issueID].tools[which][ruleID] = {
-                  quality: issueClasses[issueID].tools[which][ruleID].quality,
+                  quality: ruleData.quality,
+                  what: ruleData.what,
                   complaints: {
                     countTotal: 0,
                     texts: []
@@ -172,7 +174,7 @@ exports.scorer = report => {
           }
         });
         // Get the score for the issue.
-        issueData.score = issueData.weight * issueData.maxCount;
+        issueData.score = Math.round(issueData.weight * issueData.maxCount);
       });
       // Add the severity detail totals to the score.
       details.severity.total = Object.keys(details.severity.byTool).reduce((severityTotals, toolID) => {