testaro 77.0.0 → 77.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "77.0.0",
+  "version": "77.0.2",
   "description": "Run 1300 web accessibility tests from 10 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/launch.js

@@ -18,14 +18,6 @@
 
 const {addError} = require('./error');
 const headedBrowser = process.env.HEADED_BROWSER === 'true';
-// Whether to launch Chromium without its sandbox. The sandbox requires
-// unprivileged user-namespace cloning, which the default container seccomp
-// policies and some hardened hosts prohibit. Setting
-// TESTARO_CHROMIUM_NO_SANDBOX=true permits Chromium to run in such
-// environments; the alternative is to run the container with a seccomp
-// profile that permits user-namespace cloning. Applies only to Chromium;
-// WebKit and Firefox have no equivalent option.
-const chromiumNoSandbox = process.env.TESTARO_CHROMIUM_NO_SANDBOX === 'true';
 // Two flavors of Playwright:
 // - `playwrightCore`: the upstream Playwright SDK with no plugins attached.
 // - `playwrightExtra`: the playwright-extra wrapper. `run.js` registers
@@ -66,6 +58,14 @@ const errorWords = [
 // Seconds to wait between actions.
 const waits = Number(process.env.WAITS) ?? 0;
 const abortAssertively = process.env.ABORT_ASSERTIVELY === 'true';
+// Whether to launch Chromium without its sandbox. The sandbox requires
+// unprivileged user-namespace cloning, which the default container seccomp
+// policies and some hardened hosts prohibit. Setting
+// TESTARO_CHROMIUM_NO_SANDBOX=true permits Chromium to run in such
+// environments; the alternative is to run the container with a seccomp
+// profile that permits user-namespace cloning. Applies only to Chromium;
+// WebKit and Firefox have no equivalent option.
+const chromiumNoSandbox = process.env.TESTARO_CHROMIUM_NO_SANDBOX === 'true';
 
 // FUNCTIONS
 
@@ -77,6 +77,8 @@ const wait = exports.wait = ms => {
     }, ms);
   });
 };
+// Removes any trailing slashes from a URL, for redirection comparison.
+const deSlash = url => (url || '').replace(/\/+$/, '');
 // Close a browser context and/or its browser, if they exist.
 const browserClose = exports.browserClose = async page => {
   if (page) {
@@ -514,11 +516,11 @@ const launchOnce = async opts => {
       }
       // Base the wait on the need of the tool and the retry history.
       let waitUntil = xPathNeed === 'none' ? 'domcontentloaded' : 'networkidle';
-      if (relaxWait !== 'no' && waitUntil === 'networkidle') {
-        waitUntil = 'domcontentloaded';
+      if (relaxWait === 'partly' && waitUntil === 'networkidle') {
+        waitUntil = 'load';
       }
       if (relaxWait === 'fully') {
-        waitUntil = 'load';
+        waitUntil = 'domcontentloaded';
       }
       // Navigate to the specified URL and wait for the stability required by the next action.
       const navResult = await goTo(report, page, url, 10000, waitUntil);

package/testaro/autocomplete.js

@@ -79,12 +79,18 @@ exports.reporter = async (
   };
   const selector = 'body input[type=text], body input[type=email], body input:not([type])';
   const whats = 'Inputs are missing required autocomplete attributes';
-  const placeHolders = Object.keys(labels).map(key => `__${key}Labels__`);
-  const replacers = Object.values(labels).map(value => JSON.stringify(value));
+  // Each placeholder sits inside single quotes in getBadWhat (e.g. name: ['__nameLabels__']).
+  // Replace the quoted placeholder with the bracket-stripped JSON so the result is a proper
+  // element list (name: ["your name", ...]) rather than a one-element array holding the JSON
+  // text of the array (name: ['["your name", ...]']), which never matches an accessible name.
+  const placeHolders = Object.keys(labels).map(key => `'__${key}Labels__'`);
+  const replacers = Object.values(labels).map(value => JSON.stringify(value).slice(1, -1));
   // Create a stringified getBadWhat, with placeholders replaced with the specified label arrays.
   let getBadWhatString = getBadWhat.toString();
   [0, 1, 2, 3].forEach(index => {
     getBadWhatString = getBadWhatString.replace(placeHolders[index], replacers[index]);
   });
-  return doTest(page, report.catalog, withItems, 'autocomplete', selector, whats, 2, getBadWhatString);
+  return doTest(
+    page, report.catalog, withItems, 'autocomplete', selector, whats, 2, getBadWhatString
+  );
 };

package/validation/tests/jobProperties/autocomplete.json

@@ -67,7 +67,7 @@
         [
           "standardResult.totals.2",
           "=",
-          4
+          3
         ],
         [
           "standardResult.instances.1.what",
@@ -120,7 +120,7 @@
         [
           "standardResult.totals.2",
           "=",
-          4
+          3
         ],
         [
           "standardResult.instances.0.what",
@@ -135,7 +135,7 @@
         [
           "standardResult.instances.0.count",
           "=",
-          4
+          3
         ]
       ],
       "rules": [