testaro 76.1.2 → 76.2.1

package/README.md

@@ -201,6 +201,8 @@ Here is a sample job, showing properties that you can set:
 
 The `device` property lets you choose among [about 125 devices recognized by Playwright](https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/deviceDescriptorsSource.json).
 
+The `browserID` property dictates the first browser type that Testaro uses for its requests. When requests with that browser type are repeatedly rejected, Testaro switches to a different browser type and also replaces the `browserID` property of the job with that new browser type. Targets and their edge-management platforms often block requests from one browser type but not another, so switching browser types can make a job succeed instead of failing or make it finish quickly instead of slowly.
+
 The act types and their options are documented in the `etc` property of the [actSpecs.js](actSpecs.js) object and in the [actSpecs-doc.md](actSpecs-doc.md) file.
 
 ## Running jobs

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "76.1.2",
+  "version": "76.2.1",
   "description": "Run 1300 web accessibility tests from 10 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/catalog.js

@@ -65,8 +65,17 @@ exports.getCatalog = async report => {
         // Initialize the index of the current heading.
         let headingIndex = '';
         // For each element in the page:
-        for (const index in elements) {
-          const element = elements[index];
+        // Iterate by numeric index rather than `for...in`. `for...in` over this
+        // array also enumerates any enumerable members added to Array.prototype
+        // by the TARGET page's own scripts (e.g. legacy MooTools/Prototype-style
+        // extensions); `element` then becomes that injected value and the
+        // element.closest(...) call below throws "closest is not a function",
+        // aborting the entire catalog and the job. The indexed loop sees only
+        // real elements. `index` is kept as a string so the catalog keys
+        // (cat[index], texts[...].push(index)) are unchanged.
+        for (let i = 0; i < elements.length; i++) {
+          const index = String(i);
+          const element = elements[i];
           // Get its ID and tag name.
           const {id, tagName} = element;
           // Get its start tag.

package/procs/launch.js

@@ -172,11 +172,26 @@ const goTo = exports.goTo = async (report, page, url, timeout, waitUntil) => {
     }
     // Otherwise, if the response status was prohibition:
     else if (httpStatus === 403) {
-      // Return this.
+      // Log this.
       console.log(`ERROR: Visit to ${url} prohibited (status 403)`);
+      // Collect diagnostic data from the response.
+      let rejectionData = {status: 403};
+      try {
+        const headers = await response.allHeaders();
+        rejectionData.server = headers['server'] || '';
+        rejectionData.cfRay = headers['cf-ray'] || '';
+        rejectionData.via = headers['via'] || '';
+        rejectionData.xAkamai = headers['x-akamai-transformed'] || '';
+        rejectionData.xSucuri = headers['x-sucuri-id'] || '';
+        rejectionData.xWaf = headers['x-waf-event-info'] || '';
+        rejectionData.headers = headers;
+      }
+      catch {}
+      // Return the prohibition and the data.
       return {
         success: false,
-        error: 'status403'
+        error: 'status403',
+        rejectionData
       };
     }
     // Otherwise, if the response status was rejection of excessive requests:
@@ -534,8 +549,12 @@ const launchOnce = async opts => {
       }
       // Otherwise, i.e. if the navigation failed:
       else {
+        const {rejectionData} = navResult;
+        const addendum = rejectionData
+        ? ` (rejection data: ${JSON.stringify(rejectionData, null, 2)})`
+        : '';
         // Throw an error.
-        throw new Error(`Navigation failed (${navResult.error})`);
+        throw new Error(`Navigation failed: ${navResult.error}${addendum}`);
       }
     }
     // If the browser and page creation and navigation threw an error:
@@ -648,7 +667,8 @@ exports.launch = async (opts = {}) => {
           if (tempBrowserID && unusedBrowserIDs.length && ! retriesLeft) {
             // Change the browser type.
             tempBrowserID = unusedBrowserIDs.shift();
-            console.log(`NOTICE: Changing browser type to ${tempBrowserID}`);
+            console.log(`NOTICE: Changing job browser type to ${tempBrowserID}`);
+            report.browserID = tempBrowserID;
             // Reset the retries.
             retriesLeft = retries;
           }