testaro 74.1.1 → 74.1.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "74.1.1",
+  "version": "74.1.3",
   "description": "Run 1300 web accessibility tests from 10 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/nu.js

@@ -58,6 +58,14 @@ exports.curate = async (data, nuData, rules) => {
     const nuDataClean = JSON.parse(nuDataValid);
     result = nuDataClean;
   }
+  // Guarantee result.messages is always an iterable. The W3C API returns
+  // {messages: [...]} on success, but on HTTP errors (e.g. 502) or fetch
+  // failures nuVal leaves nuData={}, so result becomes {}
+  // and `result.messages.filter(...)` below throws
+  // "Cannot read properties of undefined (reading 'filter')".
+  if (result && ! Array.isArray(result.messages)) {
+    result.messages = [];
+  }
   // If there is a result and rules were specified:
   if (result && rules && Array.isArray(rules) && rules.length) {
     // Remove all messages except those specified.

package/tests/nuVal.js

@@ -11,7 +11,7 @@
 /*
   nuVal
   This tool subjects a page and its source to the Nu Html Checker, thereby testing scripted content found only in the loaded page and erroneous content before the browser corrects it. The API erratically replaces left and right double quotation marks with invalid UTF-8, which appears as 2 or 3 successive instances of the replacement character (U+fffd). Therefore, this test removes all such quotation marks and the replacement character. That causes 'Bad value “” for' to become 'Bad value  for'. Since the corruption of quotation marks is erratic, no better solution is known.
-  This tool is the API version of the Nu Html Checker. It is an alternative to the nuVnu tool, which uses the same validator as an installed dependency. Each tool has advantages and disadvantages. The main advantage of nuVal is that it does not require the Testaro host to provide a Java virtual machine. The main disadvantage of nuVal is that it returns 502 status errors when the content being uploaded is larger than about 80,000 bytes. The main advantage of the nuVnu tool is that it can evaluate pages larger than about 80,000 bytes and pages reachable from the host that Testaro runs on even if not reachable from the public Internet.
+  This tool is the API version of the Nu Html Checker. It is an alternative to the nuVnu tool, which uses the same validator as an installed dependency. Each tool has advantages and disadvantages. The main advantage of nuVal is that it does not require the Testaro host to provide a Java virtual machine. The main advantage of the nuVnu tool is that it can evaluate pages reachable from the host that Testaro runs on even if not reachable from the public Internet.
 */
 
 // IMPORTS

package/tests/testaro.js

@@ -504,7 +504,14 @@ exports.reporter = async (page, report, actIndex) => {
     && ['y', 'n'].includes(ruleSpec[0])
     && ruleSpec.slice(1).every(ruleID => allRuleIDs.includes(ruleID))
   ) {
-    // Get the rules to be (y) or not to be (n) tested for and their execution order.
+    // Get the rules to be tested for and their execution order.
+    // 'y' = include-list: run exactly the rules in ruleSpec.slice(1).
+    // 'n' = exclude-list: run all defaultOn rules EXCEPT those in
+    //       ruleSpec.slice(1). (The prior implementation was a no-op:
+    //       it checked against `allRuleIDs` — which is every rule's id —
+    //       so the predicate was never true, and it returned rule
+    //       objects rather than IDs, which then never matched the
+    //       string comparison on the next line.)
     const excludeIDs = ruleSpec.slice(1);
     const jobRuleIDs = ruleSpec[0] === 'y'
     ? excludeIDs