testaro 72.4.3 → 72.4.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "72.4.3",
+  "version": "72.4.4",
   "description": "Run 1300 web accessibility tests from 10 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/testaro/linkUl.js

@@ -9,7 +9,7 @@
 
 /*
   linkUl
-  This test reports failures to underline inline links. Underlining and color are the traditional style properties that identify links. Lists of links containing only links may be recognizable without underlines, but other links are difficult or impossible to distinguish visually from surrounding text if not underlined. Underlining adjacent links only on hover provides an indicator valuable only to mouse users, and even they must traverse the text with a mouse merely to discover which passages are links.
+  This test reports failures to underline links that have adjacent text. Underlining and color are the traditional style properties that identify links. A link whose text is the entire text of its block may be recognizable without underlining, but otherwise links are difficult or impossible to distinguish visually from surrounding text if not underlined. Underlining links only on hover provides an indicator valuable only to mouse users, and even they must traverse the text with a mouse merely to discover which passages are links.
 */
 
 // IMPORTS
@@ -21,24 +21,28 @@ const {doTest} = require('../procs/testaro');
 // Runs the test and returns the result.
 exports.reporter = async (page, catalog, withItems) => {
   const getBadWhat = element => {
-    const liAncestor = element.closest('li');
-    // If the element is not the only link inside a list item:
-    if (! (liAncestor && liAncestor.getElementsByTagName('a').length === 1)) {
-      const styleDec = window.getComputedStyle(element);
-      const {textDecoration} = styleDec;
-      // If the element text is not underlined:
-      if (! textDecoration.includes('underline')) {
-        const styleDec = window.getComputedStyle(element);
-        const {display} = styleDec;
-        // If the element has does not have a block display style:
-        if (display !== 'block') {
-          // Return a violation description.
-          return 'Element is not a list item but is not underlined';
-        }
+    let {display, textDecorationLine} = window.getComputedStyle(element);
+    // If the element is not underlined:
+    if (! textDecorationLine.includes('underline')) {
+      let ancestor = element;
+      // Get its closest non-inline ancestor.
+      while (display === 'inline') {
+        ancestor = ancestor.parentElement;
+        display = ancestor ? window.getComputedStyle(ancestor).display : null;
+      }
+      // Removes superfluous whitespace from a string.
+      const compact = string => string?.replace(/\s+/g, ' ')?.trim();
+      // If the rendered compacted text of that ancestor includes more than that of the element:
+      if (
+        compact(element.textContent) !== compact(ancestor?.textContent)
+        && compact(element.innerText) !== compact(ancestor?.innerText)
+      ) {
+        // Return a violation description.
+        return 'Element has adjacent text but is not underlined';
       }
     }
   };
-  const whats = 'Links that are not list items are not underlined';
+  const whats = 'Links with adjacent text are not underlined';
   return await doTest(
     page, catalog, withItems, 'linkUl', 'body a', whats, 1, getBadWhat.toString()
   );