testaro 60.8.1 → 60.8.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "60.8.1",
+  "version": "60.8.2",
   "description": "Run 1000 web accessibility tests from 11 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/run.js

@@ -462,6 +462,8 @@ const launch = exports.launch = async (
               });
               const {x, y, width, height} = boxData;
               const {tagName, id = ''} = element;
+              const rawExcerpt = element.textContent.trim() || element.outerHTML.trim();
+              const excerpt = rawExcerpt.replace(/\s+/g, ' ').slice(0, 200);
               // Return an itemized instance.
               return {
                 ruleID,
@@ -480,7 +482,7 @@ const launch = exports.launch = async (
                     height
                   }
                 },
-                excerpt: element.textContent.trim().replace(/\s+/g, ' ').slice(0, 100),
+                excerpt,
                 boxID: [x, y, width, height].join(':'),
                 pathID: window.getXPath(element)
               };

package/testaro/altScheme.js

@@ -1,6 +1,7 @@
 /*
   © 2025 CVS Health and/or one of its affiliates. All rights reserved.
   © 2025 Juan S. Casado. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -25,34 +26,52 @@
 
 /*
   altScheme
-  Identify img elements whose alt attribute is an entire URL or clearly a file name (favicon).
+  Identify img elements whose alt attribute is a URL or file name.
 */
 
-const {init, getRuleResult} = require('../procs/testaro');
+// FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Candidate images: any img with an alt attribute (including empty)
-  const all = await init(100, page, 'img[alt]');
-  for (const loc of all.allLocs) {
-    const isBad = await loc.evaluate(el => {
-      const alt = (el.getAttribute('alt') || '').trim();
-      if (!alt) return false;
-  // full-string URL (http(s) or file or ftp) — must be the entire alt value
-  if (/^\s*(?:https?:|file:|ftp:)\S+\s*$/i.test(alt)) return true;
-      // favicon or typical file names
-      if (/favicon/i.test(alt)) return true;
-  // common image file extensions that occupy the entire alt or are the base filename
-  if (/^\s*\S+\.(?:png|jpe?g|gif|svg|webp|ico)\s*$/i.test(alt)) return true;
-      // match exact equality with src or href attributes
-      const href = (el.getAttribute('href') || el.getAttribute('src') || '').trim();
-      if (href && alt === href) return true;
-      return false;
+  // Return totals and standard instances for the rule.
+  return await page.evaluate(withItems => {
+    // Get all candidates, i.e. img elements with alt attributes.
+    const candidates = document.body.querySelectorAll('img[alt]');
+    let violationCount = 0;
+    const instances = [];
+    // For each candidate:
+    candidates.forEach(element => {
+      const alt = (element.getAttribute('alt') || '').trim();
+      // If it is non-empty:
+      if (alt) {
+        const isURL = /^(?:https?:|file:|ftp:)\S+$/i.test(alt);
+        const isFileName = /favicon|^\S+\.(?:png|jpe?g|gif|svg|webp|ico)$/i.test(alt);
+        // If it is a URL or file name:
+        if (isURL || isFileName) {
+          // Increment the violation count.
+          violationCount++;
+          // If itemization is required:
+          if (withItems) {
+            const valueType = isURL && isFileName
+            ? 'the URL of an image file'
+            : (isURL ? 'a URL' : 'a file name');
+            const what = `img element has an alt attribute with ${valueType} as its value`;
+            // Add an instance to the instances.
+            instances.push(window.getInstance(element, 'altScheme', what, 1, 2));
+          }
+        }
+      }
     });
-    if (isBad) all.locs.push(loc);
-  }
-  const whats = [
-    'Element has an alt attribute with a URL as its entire value',
-    'img elements have alt attributes with URLs as their entire values'
-  ];
-  return await getRuleResult(withItems, all, 'altScheme', whats, 2);
+    // If there were any violations and itemization is not required:
+    if (violationCount && ! withItems) {
+      const what = 'img elements have alt attributes with URL or filename values';
+      // Add a summary instance to the instances.
+      instances.push(window.getInstance(null, 'altScheme', what, violationCount, 2, 'IMG'));
+    }
+    return {
+      data: {},
+      totals: [0, violationCount, 0, 0],
+      standardInstances: instances
+    };
+  }, withItems);
 };

package/validation/tests/targets/altScheme/index.html

@@ -37,8 +37,8 @@
       <p><img id="mapGIF" href="https://urbaninstitute.github.io/r-at-urban/mapping/www/images/yay_maps.gif" alt="animated map of the USA"></p>
       <p>Defect 1: Look at this other map:</p>
       <p><img id="mapPNG" href="https://upload.wikimedia.org/wikipedia/commons/f/f7/Blank_map_of_states.png" alt="https://upload.wikimedia.org/wikipedia/commons/f/f7/Blank_map_of_states.png"></p>
-      <p>Defect 2: Look at this pattern:</p>
-      <p><img href="http://httpforever.com/css/images/header-major-on-light.svg" alt="http://httpforever.com/css/images/header-major-on-light.svg"></p>
+      <p>Defect 2: This image has a file name as a text alternative:</p>
+      <p><img href="http://httpforever.com/css/images/header-major-on-light.svg" alt="header-major-on-light.svg"></p>
       <p>Defect 3: Look at this icon:</p>
       <p><img href="file://favicon.png" alt="file://favicon.png"></p>
       <p>This map has an empty text alternative, but that does not violate the altScheme rule:</p>

package/testaro/allHidden-old.js

@@ -1,98 +0,0 @@
-/*
-  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
-  © 2025 Jonathan Robert Pool. All rights reserved.
-
-  MIT License
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-
-/*
-  allHidden
-  This test reports a page that is entirely or mainly hidden.
-*/
-
-// FUNCTIONS
-
-// Runs the test and returns the result.
-exports.reporter = async page => {
-  // Get data on violations of the rule.
-  const violationData = await page.evaluate(() => {
-    // Get all candidates, i.e. the regions that should never be hidden.
-    const regions = {
-      html: {
-        element: document.documentElement,
-        severity: 3
-      },
-      body: {
-        element: document.body,
-        severity: 2
-      },
-      main: {
-        element: document.querySelector('main, [role=main]'),
-        severity: 1
-      }
-    };
-    let violationCounts = [0, 0, 0, 0];
-    const instances = [];
-    // For each candidate:
-    Object.keys(regions).forEach(regionName => {
-      const region = regions[regionName];
-      const {element, severity} = region;
-      console.log(`XXX ${regionName}`);
-      const tagName = regionName.toUpperCase();
-      // If it is not main and does not exist:
-      if (! element && regionName !== 'main') {
-        console.log(`XXX ${regionName} is not main anddoes not exist`);
-        // Increment the violation count.
-        violationCounts[3]++;
-        // Add an instance to the instances.
-        const what = `The ${regionName} region does not exist`;
-        // Add a summary instance to the instances.
-        instances.push(window.getInstance(null, 'allHidden', what, 1, 3, tagName));
-      }
-      // Otherwise, if it exists:
-      else if (element) {
-        console.log(`XXX ${regionName} exists`);
-        const styleDec = window.getComputedStyle(element);
-        const {display, visibility} = styleDec;
-        // If it is hidden:
-        if (display === 'none' || visibility === 'hidden' || element.ariaHidden === 'true') {
-          // Increment the violation count.
-          violationCounts[severity]++;
-          // Add an instance to the instances.
-          const what = `The ${regionName} region is hidden`;
-          // Add an instance to the instances.
-          instances.push(window.getInstance(element, 'allHidden', what, 1, severity, tagName));
-        }
-      }
-    });
-    return {
-      violationCounts,
-      instances
-    };
-  });
-  const {violationCounts, instances} = violationData;
-  // Return the result.
-  return {
-    data: {},
-    totals: violationCounts,
-    standardInstances: instances
-  };
-};