testaro 60.7.0 → 60.7.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "60.7.0",
+  "version": "60.7.2",
   "description": "Run 1000 web accessibility tests from 11 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/testaro.js

@@ -90,19 +90,19 @@ const getRuleResult = exports.getRuleResult = async (
     // If itemization is required:
     if (withItems) {
       // Get the bounding box of the element.
-      const {location} = elData;
+      const {tagName,id, location, excerpt} = elData;
       const box = location.type === 'box' ? location.spec : await boxOf(loc);
       // Add a standard instance to the result.
       standardInstances.push({
         ruleID,
         what: whatParam ? whats[0].replace('__param__', whatParam) : whats[0],
         ordinalSeverity,
-        tagName: elData.tagName,
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt,
+        tagName,
+        id,
+        location,
+        excerpt,
         boxID: boxToString(box),
-        pathID: await xPath(loc)
+        pathID: tagName === 'HTML' ? '/html' : await xPath(loc)
       });
     }
   }
@@ -151,7 +151,9 @@ exports.simplify = async (page, withItems, ruleData) => {
     complaints.instance,
     complaints.summary
   ];
-  const result = await getRuleResult(withItems, all, ruleID, whats, ordinalSeverity, summaryTagName);
+  const result = await getRuleResult(
+    withItems, all, ruleID, whats, ordinalSeverity, summaryTagName
+  );
   // Return the result.
   return result;
 };

package/reproInitScripts.js

@@ -0,0 +1,51 @@
+/*
+  reproInitScripts.js
+  Minimal example to demonstrate an apparent Playwright bug reported as issue 38442
+  (https://github.com/microsoft/playwright/issues/38442).
+*/
+
+// save as e.g. reproInitScripts.js
+// run with: node reproInitScripts.js
+
+const {chromium} = require('playwright');
+
+(async () => {
+
+  const browser = await chromium.launch({headless: true});
+  const context = await browser.newContext();
+
+  context.on('page', async page => {
+    console.log('context.on("page") fired');
+
+    // First init script
+    await page.addInitScript(() => {
+      window.helperOne = () => 'one';
+    });
+
+    // Second init script
+    await page.addInitScript(() => {
+      window.helperTwo = () => 'two';
+    });
+
+    // Third init script
+    await page.addInitScript(() => {
+      window.helperThree = () => 'three';
+    });
+
+  });
+
+  const page = await context.newPage();
+
+  await page.goto('https://example.com', {waitUntil: 'domcontentloaded'});
+
+  const result = await page.evaluate(() => ({
+    helperOne: typeof window.helperOne,
+    helperTwo: typeof window.helperTwo,
+    helperThree: typeof window.helperThree
+  }));
+
+  console.log('Helper types:', result);
+
+  await browser.close();
+
+})();

package/run.js

@@ -372,8 +372,9 @@ const launch = exports.launch = async (
       browserContext.setDefaultTimeout(0);
       // When a page (i.e. tab) is added to the browser context (i.e. browser window):
       browserContext.on('page', async page => {
-        // Mask automation detection
-        await page.addInitScript(() => {
+        const isTestaroTest = act.type === 'test' && act.which === 'testaro';
+        // Mask automation detection.
+        await page.addInitScript(isTestaroTest => {
           Object.defineProperty(navigator, 'webdriver', {get: () => undefined});
           window.chrome = {runtime: {}};
           Object.defineProperty(navigator, 'plugins', {
@@ -382,11 +383,63 @@ const launch = exports.launch = async (
           Object.defineProperty(navigator, 'languages', {
             get: () => ['en-US', 'en']
           });
-        });
-        // If the act is a testaro test act:
-        if (act.type === 'test' && act.which === 'testaro') {
-          // Add a script that defines a window method to get the XPath of an element.
-          await page.addInitScript(() => {
+          // If the act is a testaro test act:
+          if (isTestaroTest) {
+            // Add a window method to return an instance.
+            window.getInstance = (
+              element, ruleID, what, count = 1, ordinalSeverity, summaryTagName = ''
+            ) => {
+              // If the element exists:
+              if (element) {
+                // Get its properties.
+                const boxData = element.getBoundingClientRect();
+                ['x', 'y', 'width', 'height'].forEach(dimension => {
+                  boxData[dimension] = Math.round(boxData[dimension]);
+                });
+                const {x, y, width, height} = boxData;
+                const {tagName, id = ''} = element;
+                // Return an itemized instance.
+                return {
+                  ruleID,
+                  what,
+                  count,
+                  ordinalSeverity,
+                  tagName,
+                  id,
+                  location: {
+                    doc: 'dom',
+                    type: 'box',
+                    spec: {
+                      x,
+                      y,
+                      width,
+                      height
+                    }
+                  },
+                  excerpt: element.textContent.trim().replace(/\s+/g, ' ').slice(0, 100),
+                  boxID: [x, y, width, height].join(':'),
+                  pathID: window.getXPath(element)
+                };
+              }
+              // Otherwise, i.e. if no element exists, return a summary instance.
+              return {
+                ruleID,
+                what,
+                count,
+                ordinalSeverity,
+                tagName: summaryTagName,
+                id: '',
+                location: {
+                  doc: '',
+                  type: '',
+                  spec: ''
+                },
+                excerpt: '',
+                boxID: '',
+                pathID: ''
+              };
+            };
+            // Add a window method to get the XPath of an element.
             window.getXPath = element => {
               if (!element || element.nodeType !== Node.ELEMENT_NODE) {
                 return '';
@@ -432,8 +485,8 @@ const launch = exports.launch = async (
               // Return the XPath.
               return `/${segments.join('/')}`;
             };
-          });
-        }
+          }
+        }, isTestaroTest);
         // Ensure the report has a jobData property.
         report.jobData ??= {};
         const {jobData} = report;

package/testaro/adbID.js

@@ -25,43 +25,93 @@
 
 /*
   adbID
-  Clean-room rule: report elements that reference aria-describedby targets that are missing or ambiguous (duplicate ids).
+  This test reports elements referencing aria-describedby targets that are missing
+  or, because of duplicate IDs, ambiguous. An earlier version of this test was
+  originally developed under a clean-room procedure to ensure its independence from
+  the implementation of a test for a similar rule in the Tenon tool.
 */
 
-const {init, getRuleResult} = require('../procs/testaro');
+// FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // elements that reference aria-describedby
-  const all = await init(200, page, '[aria-describedby]');
-  for (const loc of all.allLocs) {
-    const isBad = await loc.evaluate(el => {
-      const raw = el.getAttribute('aria-describedby') || '';
-      const ids = raw.trim().split(/\s+/).filter(Boolean);
-      if (ids.length === 0) return false;
-      // for each referenced id, check how many elements have that id
-      for (const id of ids) {
-        try {
-          // exact match (case-sensitive)
-          const exact = document.querySelectorAll('#' + CSS.escape(id));
-          if (exact.length === 1) continue;
-          // if not exactly one, try case-insensitive match by normalizing
-          const allIds = Array.from(document.querySelectorAll('[id]')).map(e => e.getAttribute('id'));
-          const ci = allIds.filter(i => i && i.toLowerCase() === id.toLowerCase()).length;
-          if (ci === 1) continue;
-          // otherwise it's missing or ambiguous
-          return true;
-        } catch (e) {
-          return true;
+  // Get data on violations of the rule.
+  const violationData = await page.evaluate(withItems => {
+    // Get all candidates, i.e. elements with aria-describedby attributes.
+    const candidates = document.body.querySelectorAll('[aria-describedby]');
+    let violationCount = 0;
+    const instances = [];
+    // For each candidate:
+    candidates.forEach(element => {
+      // Get the IDs in its aria-describedby attribute.
+      const IDs = element.getAttribute('aria-describedby').trim().split(/\s+/).filter(Boolean);
+      // If there are none:
+      if (! IDs.length) {
+        // Increment the violation count.
+        violationCount++;
+        // If itemization is required:
+        if (withItems) {
+          const what = 'Element has an aria-describedby attribute with no value';
+          // Add an instance to the instances.
+          instances.push(window.getInstance(element, 'adbID', what, 1, 3));
+        }
+      }
+      // Otherwise, i.e. if there is at least 1 ID:
+      else {
+        // For each ID:
+        for (const id of IDs) {
+          // Get the element with that ID.
+          const describer = document.getElementById(id);
+          // If it doesn't exist:
+          if (! describer) {
+            // Increment the violation count.
+            violationCount++;
+            // If itemization is required:
+            if (withItems) {
+              const what = `No element has the aria-describedby ID ${id}`;
+              // Add an instance to the instances.
+              instances.push(window.getInstance(element, 'adbID', what, 1, 3));
+            }
+            // Stop checking the element.
+            break;
+          }
+          // Otherwise, i.e. if it exists:
+          else {
+            // Get the elements with that ID.
+            const sameIDElements = document.querySelectorAll(`#${id}`);
+            // If there is more than one:
+            if (sameIDElements.length > 1) {
+              // Increment the violation count.
+              violationCount++;
+              // If itemization is required:
+              if (withItems) {
+                const what = `Multiple elements share the aria-describedby ID ${id}`;
+                // Add an instance to the instances.
+                instances.push(window.getInstance(element, 'adbID', what, 1, 2));
+              }
+              // Stop checking the element.
+              break;
+            }
+          }
         }
       }
-      return false;
     });
-    if (isBad) all.locs.push(loc);
-  }
-
-  const whats = [
-    'Referenced description of the element is ambiguous or missing',
-    'Referenced descriptions of elements are ambiguous or missing'
-  ];
-  return await getRuleResult(withItems, all, 'adbID', whats, 3);
+    // If there were any violations and itemization is not required:
+    if (violationCount && ! withItems) {
+      const what = 'Elements have aria-describedby attributes with missing or invalid id values';
+      // Add a summary instance to the instances.
+      instances.push(window.getInstance(null, 'lineHeight', what, violationCount, 3));
+    }
+    return {
+      violationCount,
+      instances
+    };
+  }, withItems);
+  const {violationCount, instances} = violationData;
+  // Return the result.
+  return {
+    data: {},
+    totals: [0, violationCount, 0, 0],
+    standardInstances: instances
+  };
 };

package/testaro/lineHeight.js

@@ -36,67 +36,56 @@
 
 // Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  const violators = await page.evaluate(() => {
-    const elements = document.body.querySelectorAll('*');
-    const elementsWithText = Array.from(elements).filter(el =>
+  // Get data on violations of the rule.
+  const violationData = await page.evaluate(withItems => {
+    // Get all elements.
+    const allElements = document.body.querySelectorAll('*');
+    // Get all violation candidates, i.e. elements that have non-empty child text nodes.
+    const candidates = Array.from(allElements).filter(el =>
       Array.from(el.childNodes).some(child =>
         child.nodeType === Node.TEXT_NODE &&
         child.textContent.trim().length
       )
     );
-    const violatorData = [];
-    elementsWithText.forEach(el => {
-      const styleDec = window.getComputedStyle(el);
+    let violationCount = 0;
+    const instances = [];
+    // For each candidate:
+    candidates.forEach(element => {
+      // Get its relevant style properties.
+      const styleDec = window.getComputedStyle(element);
       const {fontSize, lineHeight} = styleDec;
       const fontSizeNum = Number.parseFloat(fontSize);
       const lineHeightNum = Number.parseFloat(lineHeight);
-      const fontSizeTrunc = fontSizeNum.toFixed(1);
-      const lineHeightTrunc = lineHeightNum.toFixed(1);
+      // If it violates the rule:
       if (lineHeightNum < 1.495 * fontSizeNum) {
-        const boxData = el.getBoundingClientRect();
-        ['x', 'y', 'width', 'height'].forEach(dimension => {
-          boxData[dimension] = Math.round(boxData[dimension]);
-        });
-        const {x, y, width, height} = boxData;
-        violatorData.push({
-          tagName: el.tagName,
-          id: el.id,
-          location: {
-            doc: 'dom',
-            type: 'box',
-            spec: {
-              x,
-              y,
-              width,
-              height
-            }
-          },
-          excerpt: el.textContent.trim(),
-          boxID: [x, y, width, height].join(':'),
-          pathID: window.getXPath(el),
-          fontSize: fontSizeTrunc,
-          lineHeight: lineHeightTrunc
-        });
+        // Increment the violation count.
+        violationCount++;
+        // If itemization is required:
+        if (withItems) {
+          const fontSizeRounded = fontSizeNum.toFixed(1);
+          const lineHeightRounded = lineHeightNum.toFixed(1);
+          const what = `Element line height (${lineHeightRounded}px) is less than 1.5 times its font size (${fontSizeRounded}px)`;
+          // Add an instance to the instances.
+          instances.push(window.getInstance(element, 'lineHeight', what, 1, 1));
+        }
       }
     });
-    return violatorData;
-  });
+    // If there were any violations and itemization is not required:
+    if (violationCount && ! withItems) {
+      const what = 'Element line heights are less than 1.5 times their font sizes';
+      // Add a summary instance to the instances.
+      instances.push(window.getInstance(null, 'lineHeight', what, violationCount, 1));
+    }
+    return {
+      violationCount,
+      instances
+    };
+  }, withItems);
+  const {violationCount, instances} = violationData;
+  // Return the result.
   return {
     data: {},
-    totals: [0, violators.length, 0, 0],
-    standardInstances: violators.map(violator => {
-      const {tagName, id, location, excerpt, boxID, pathID, fontSize, lineHeight} = violator;
-      return {
-        ruleID: 'lineHeight',
-        what: `Element line height (${lineHeight}px) is less than 1.5 times its font size (${fontSize}px)`,
-        ordinalSeverity: 1,
-        tagName,
-        id,
-        location,
-        excerpt,
-        boxID,
-        pathID
-      };
-    })
+    totals: [0, violationCount, 0, 0],
+    standardInstances: instances
   };
 };

package/testaro/lineHeight-slow.js

@@ -1,70 +0,0 @@
-/*
-  © 2023–2024 CVS Health and/or one of its affiliates. All rights reserved.
-  © 2025 Jonathan Robert Pool. All rights reserved.
-
-  MIT License
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-
-/*
-  lineHeight
-  Related to Tenon rule 144.
-  This test reports elements whose line heights are less than 1.5 times their font sizes. Even
-  such elements with no text create accessibility risk, because any text node added to one of
-  them would have a substandard line height. Nonetheless, elements with no non-spacing text in
-  their subtrees are excluded.
-*/
-
-// IMPORTS
-
-// Module to perform common operations.
-const {init, getRuleResult} = require('../procs/testaro');
-
-// FUNCTIONS
-
-// Runs the test and returns the result.
-exports.reporter = async (page, withItems) => {
-  // Initialize the locators and result.
-  const all = await init(100, page, 'body *', {hasText: /[^\s]/});
-  // For each locator:
-  for (const loc of all.allLocs) {
-    // Get whether its element violates the rule.
-    const data = await loc.evaluate(el => {
-      const styleDec = window.getComputedStyle(el);
-      const {fontSize, lineHeight} = styleDec;
-      return {
-        fontSize: Number.parseFloat(fontSize),
-        lineHeight: Number.parseFloat(lineHeight)
-      };
-    });
-    // If it does, after a grace margin for rounding:
-    const isBad = data.lineHeight < 1.49 * data.fontSize;
-    if (isBad) {
-      // Add the locator to the array of violators.
-      all.locs.push([loc, `font size ${data.fontSize} px, line height ${data.lineHeight} px`]);
-    }
-  }
-  // Populate and return the result.
-  const whats = [
-    'Element line height is less than 1.5 times its font size (__param__)',
-    'Elements have line heights less than 1.5 times their font sizes'
-  ];
-  return await getRuleResult(withItems, all, 'lineHeight', whats, 1);
-};