testaro 60.16.2 → 60.18.0

package/testaro/linkUl.js

@@ -10,43 +10,37 @@
 
 /*
   linkUl
-  This test reports failures to underline inline links. Underlining and color are the traditional style properties that identify links. Lists of links containing only links can be recognized without underlines, but other links are difficult or impossible to distinguish visually from surrounding text if not underlined. Underlining adjacent links only on hover provides an indicator valuable only to mouse users, and even they must traverse the text with a mouse merely to discover which passages are links.
+  This test reports failures to underline inline links. Underlining and color are the traditional style properties that identify links. Lists of links containing only links may be recognizable without underlines, but other links are difficult or impossible to distinguish visually from surrounding text if not underlined. Underlining adjacent links only on hover provides an indicator valuable only to mouse users, and even they must traverse the text with a mouse merely to discover which passages are links.
 */
 
-// ########## IMPORTS
+// IMPORTS
 
-// Module to perform common operations.
-const {simplify} = require('../procs/testaro');
-// Module to classify links.
-const {isInlineLink} = require('../procs/isInlineLink');
+const {doTest} = require('../procs/testaro');
 
-// ########## FUNCTIONS
+// FUNCTIONS
 
 // Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Specify the rule.
-  const ruleData = {
-    ruleID: 'linkUl',
-    selector: 'a',
-    pruner: async loc => {
-      // Get whether each link is underlined.
-      const isUnderlined = await loc.evaluate(el => {
-        const styleDec = window.getComputedStyle(el);
-        return styleDec.textDecorationLine === 'underline';
-      });
-      // If it is not:
-      if (! isUnderlined) {
-        // Return whether it is a violator.
-        return await isInlineLink(loc);
+  const getBadWhat = element => {
+    const liAncestor = element.closest('li');
+    // If the element is not the only link inside a list item:
+    if (! (liAncestor && liAncestor.getElementsByTagName('a').length === 1)) {
+      const styleDec = window.getComputedStyle(element);
+      const {textDecoration} = styleDec;
+      // If the element text is not underlined:
+      if (! textDecoration.includes('underline')) {
+        const styleDec = window.getComputedStyle(element);
+        const {display} = styleDec;
+        // If the element has does not have a block display style:
+        if (display !== 'block') {
+          // Return a violation description.
+          return 'Element is not a list item but is not underlined';
+        }
       }
-    },
-    complaints: {
-      instance: 'Link is inline but has no underline',
-      summary: 'Inline links are missing underlines'
-    },
-    ordinalSeverity: 1,
-    summaryTagName: 'A'
+    }
   };
-  // Run the test and return the result.
-  return await simplify(page, withItems, ruleData);
+  const whats = 'Links that are not list items are not underlined';
+  return await doTest(
+    page, withItems, 'linkUl', 'a', whats, 1, 'A', getBadWhat.toString()
+  );
 };

package/testaro/nonTable.js

@@ -14,65 +14,49 @@
   This test reports tables used for layout.
 */
 
-// ########## IMPORTS
+// IMPORTS
 
-// Module to perform common operations.
-const {simplify} = require('../procs/testaro');
+const {doTest} = require('../procs/testaro');
 
-// ########## FUNCTIONS
+// FUNCTIONS
 
 // Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Specify the rule.
-  const ruleData = {
-    ruleID: 'nonTable',
-    selector: 'table',
-    pruner: async loc => await loc.evaluate(el => {
-      const role = el.getAttribute('role');
-      // If it contains another table:
-      if (el.querySelector('table')) {
-        // Return misuse.
-        return true;
-      }
-      // Otherwise, if it has only 1 column or 1 row:
-      else if (
-        el.querySelectorAll('tr').length === 1
-        || Math.max(
-          ... Array
-          .from(el.querySelectorAll('tr'))
-          .map(row => Array.from(row.querySelectorAll('th, td')).length)
-        ) === 1
-      ) {
-        // Return misuse.
-        return true;
-      }
-      // Otherwise, if it contains an object or player:
-      else if (el.querySelector('object, embed, applet, audio, video')) {
-        // Return misuse.
-        return true;
-      }
-      // Otherwise, if it contains a table-compatible element:
-      else if (
-        el.caption
-        || ['grid', 'treegrid'].includes(role)
-        || el.querySelector('col, colgroup, tfoot, thead, th')
-      ) {
-        // Return validity.
-        return false;
-      }
-      // Otherwise:
-      else {
-        // Return misuse.
-        return true;
-      }
-    }),
-    complaints: {
-      instance: 'Table is misused to arrange content',
-      summary: 'Tables are misused to arrange content'
-    },
-    ordinalSeverity: 2,
-    summaryTagName: 'TABLE'
+  const getBadWhat = element => {
+    // If the element contains another table:
+    if (element.querySelector('table')) {
+      // Return a violation description.
+      return 'Element contains another table';
+    }
+    const rowCount = element.querySelectorAll('tr').length;
+    const columnCount = Math.max(
+      ... Array
+      .from(element.querySelectorAll('tr'))
+      .map(row => Array.from(row.querySelectorAll('th, td')).length)
+    );
+    // Otherwise, if it has only 1 column or 1 row:
+    if (rowCount === 1 || columnCount === 1) {
+      // Return a violation description.
+      return 'Element has only one row or one column';
+    }
+    // Otherwise, if it contains an object or player:
+    if (element.querySelector('object, embed, applet, audio, video')) {
+      // Return a violation description.
+      return 'Element contains an object or player';
+    }
+    const role = element.getAttribute('role');
+    // Otherwise, if it has no table-compatible explicit role or descendant element:
+    if (! (
+      ['grid', 'treegrid'].includes(role)
+      || element.caption
+      || element.querySelector('col, colgroup, tfoot, th, thead')
+    )) {
+      // Return a violation description.
+      return 'Element has no table-compatible explicit role or descendant element';
+    }
   };
-  // Run the test and return the result.
-  return await simplify(page, withItems, ruleData);
+  const whats = 'table elements are misused for non-table content';
+  return await doTest(
+    page, withItems, 'nonTable', 'table', whats, 2, 'TABLE', getBadWhat.toString()
+  );
 };

package/testaro/optRoleSel.js

@@ -1,6 +1,7 @@
 /*
   © 2025 CVS Health and/or one of its affiliates. All rights reserved.
   © 2025 Juan S. Casado.
+  © 2025 Jonathan Robert Pool.
 
   Licensed under the MIT License. See LICENSE file at the project root or
   https://opensource.org/license/mit/ for details.
@@ -11,24 +12,26 @@
 /*
   optRoleSel
   Clean-room rule.
-  This test reports elements with role="option" that are missing aria-selected attributes.
+  This test reports elements with role=option that are missing aria-selected attributes.
 */
 
-const {simplify} = require('../procs/testaro');
+// IMPORTS
 
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  const ruleData = {
-    ruleID: 'optRoleSel',
-    selector: '[role="option"]',
-    pruner: async (loc) => await loc.evaluate(el => {
-      return ! el.hasAttribute('aria-selected');
-    }),
-    complaints: {
-      instance: 'Element has an explicit option role but no aria-selected attribute',
-      summary: 'Elements with explicit option roles have no aria-selected attributes'
-    },
-    ordinalSeverity: 1,
-    summaryTagName: ''
+  const getBadWhat = element => {
+    // If the element has no aria-selected attribute:
+    if (! element.hasAttribute('aria-selected')) {
+      // Return a violation description.
+      return 'Element has role=option but no aria-selected attribute';
+    }
   };
-  return await simplify(page, withItems, ruleData);
+  const whats = 'Elements with role=option have no aria-selected attributes';
+  return await doTest(
+    page, withItems, 'optRoleSel', '[role="option"]', whats, 1, null, getBadWhat.toString()
+  );
 };

package/testaro/pseudoP.js

@@ -0,0 +1,54 @@
+/*
+  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+/*
+  pseudoP
+  This test reports 2 or more sequential br elements without intervening text content. They may be inferior substitutes for p elements.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    // Get the node before the element node.
+    const previousNode = element.previousSibling;
+    let isBad = false;
+    // If it is a br element:
+    if (previousNode && previousNode.nodeType === Node.ELEMENT_NODE && previousNode.tagName === 'BR') {
+      // Classify the element as a violator.
+      isBad = true;
+    }
+    // Otherwise, if it is a text node:
+    else if (previousNode && previousNode.nodeType === Node.TEXT_NODE) {
+      // If the text node contains only whitespace:
+      if (previousNode.textContent.trim() === '') {
+        // Get the node before the text node.
+        const beforeText = previousNode.previousSibling;
+        // If that node is a br element:
+        if (beforeText && beforeText.nodeType === Node.ELEMENT_NODE && beforeText.tagName === 'BR') {
+          // Classify the element as a violator.
+          isBad = true;
+        }
+      }
+    }
+    // If the element is a violator:
+    if (isBad) {
+      // Return a violation description.
+      return `Element follows another br element, possibly constituting a pseudo-paragraph`;
+    }
+  };
+  const whats = 'br elements follow other br elements, possibly constituting pseudo-paragraphs';
+  return await doTest(
+    page, withItems, 'pseudoP', 'body br', whats, 0, 'BR', getBadWhat.toString()
+  );
+};

package/testaro/role.js

@@ -10,7 +10,7 @@
 
 /*
   role
-  This test reports elements with native-replacing explicit role attributes.
+  This test reports elements with native-replacing explicit role attributes. This test uses the getBasicResult function in order to have access to the aria-query dependency.
 */
 
 // IMPORTS

package/testaro/textSem.js

@@ -1,6 +1,6 @@
 /*
   © 2025 CVS Health and/or one of its affiliates. All rights reserved.
-  © 2025 Juan S. Casado.
+  © 2025 Jonathan Robert Pool.
 
   Licensed under the MIT License. See LICENSE file at the project root or
   https://opensource.org/license/mit/ for details.

package/testaro/titledEl.js

@@ -0,0 +1,34 @@
+/*
+  © 2023–2025 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+
+/*
+  titledEl
+  This test reports suspicious use of title attributes.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+// Runs the test and returns the result.
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    const elementType = element.tagName.toLowerCase();
+    // Return a violation description.
+    return `Likely ineffective title attribute is used on the ${elementType} element`;
+  }
+  const selector = '[title]:not(iframe, link, style)';
+  const whats = 'title attributes are used on elements they are likely ineffective on';
+  return await doTest(
+    page, withItems, 'titledEl', selector, whats, 0, null, getBadWhat.toString()
+  );
+};