testaro 60.16.2 → 60.17.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "60.16.2",
+  "version": "60.17.0",
   "description": "Run 1000 web accessibility tests from 11 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/testaro.js

@@ -169,12 +169,13 @@ exports.doTest = async (
     const candidates = document.body.querySelectorAll(candidateSelector);
     let violationCount = 0;
     const instances = [];
-    // Get a violation function.
+    // Get a function that returns a violation description, if any, for the candidate.
     const getBadWhat = eval(`(${getBadWhatString})`);
     // For each candidate:
     for (const candidate of candidates) {
+      // Get the violation description, if any.
       const violationWhat = await getBadWhat(candidate);
-      // If it violates the rule:
+      // If the candidate violates the rule:
       if (violationWhat) {
         // Increment the violation count.
         violationCount++;

package/testaro/hr.js

@@ -0,0 +1,32 @@
+/*
+  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+
+/*
+  hr
+  This test reports the use of hr elements.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+// Runs the test and returns the result.
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    // Return a violation description.
+    return `hr element is used for vertical segmentation`;
+  }
+  const whats = 'HR elements are used for vertical segmentation';
+  return await doTest(
+    page, withItems, 'hr', 'hr', whats, 0, 'HR', getBadWhat.toString()
+  );
+};

package/testaro/linkExt.js

@@ -0,0 +1,31 @@
+/*
+  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+
+/*
+  linkExt
+  This test reports links with target=_blank attributes.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    // Return a violation description.
+    return `Link has a target=_blank attribute`;
+  };
+  const whats = 'Links have target=_blank attributes';
+  return await doTest(
+    page, withItems, 'linkExt', 'a[target=_blank]', whats, 0, 'A', getBadWhat.toString()
+  );
+};

package/testaro/linkOldAtt.js

@@ -0,0 +1,43 @@
+/*
+  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+
+/*
+  linkOldAtt
+  This test reports links with deprecated attributes.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    const attNames = element.getAttributeNames();
+    const allBadAttNames = ['charset', 'coords', 'name', 'rev', 'shape'];
+    const elementBadAttNames = allBadAttNames.filter(att => attNames.includes(att));
+    // If the element has 1 deprecated attribute:
+    if (elementBadAttNames.length === 1) {
+      // Return a violation description.
+      return `${elementBadAttNames[0]} attribute is deprecated`;
+    }
+    // Otherwise, if the element has 2 or more deprecated attributes:
+    if (elementBadAttNames.length > 1) {
+      // Return a violation description.
+      return `Element has deprecated attributes: ${elementBadAttNames.join(', ')}`;
+    }
+  };
+  const selector = 'a[charset], a[coords], a[name], a[rev], a[shape]';
+  const whats = 'Links have deprecated attributes';
+  return await doTest(
+    page, withItems, 'linkOldAtt', selector, whats, 1, 'A', getBadWhat.toString()
+  );
+};

package/testaro/linkTo.js

@@ -0,0 +1,37 @@
+/*
+  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+/*
+  linkTo
+  This test reports links without href attributes.
+*/
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    const isVisible = element.checkVisibility({
+      contentVisibilityAuto: true,
+      opacityProperty: true,
+      visibilityProperty: true
+    });
+    // If the element is visible:
+    if (isVisible) {
+      // Return a violation description.
+      return `Element has no href attribute`;
+    }
+  };
+  const whats = 'Links are missing href attributes';
+  return await doTest(
+    page, withItems, 'linkTo', 'a:not([href]', whats, 2, 'A', getBadWhat.toString()
+  );
+};

package/testaro/pseudoP.js

@@ -0,0 +1,54 @@
+/*
+  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+/*
+  pseudoP
+  This test reports 2 or more sequential br elements without intervening text content. They may be inferior substitutes for p elements.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    // Get the node before the element node.
+    const previousNode = element.previousSibling;
+    let isBad = false;
+    // If it is a br element:
+    if (previousNode && previousNode.nodeType === Node.ELEMENT_NODE && previousNode.tagName === 'BR') {
+      // Classify the element as a violator.
+      isBad = true;
+    }
+    // Otherwise, if it is a text node:
+    else if (previousNode && previousNode.nodeType === Node.TEXT_NODE) {
+      // If the text node contains only whitespace:
+      if (previousNode.textContent.trim() === '') {
+        // Get the node before the text node.
+        const beforeText = previousNode.previousSibling;
+        // If that node is a br element:
+        if (beforeText && beforeText.nodeType === Node.ELEMENT_NODE && beforeText.tagName === 'BR') {
+          // Classify the element as a violator.
+          isBad = true;
+        }
+      }
+    }
+    // If the element is a violator:
+    if (isBad) {
+      // Return a violation description.
+      return `Element follows another br element, possibly constituting a pseudo-paragraph`;
+    }
+  };
+  const whats = 'br elements follow other br elements, possibly constituting pseudo-paragraphs';
+  return await doTest(
+    page, withItems, 'pseudoP', 'body br', whats, 0, 'BR', getBadWhat.toString()
+  );
+};

package/testaro/textSem.js

@@ -1,6 +1,6 @@
 /*
   © 2025 CVS Health and/or one of its affiliates. All rights reserved.
-  © 2025 Juan S. Casado.
+  © 2025 Jonathan Robert Pool.
 
   Licensed under the MIT License. See LICENSE file at the project root or
   https://opensource.org/license/mit/ for details.

package/testaro/titledEl.js

@@ -0,0 +1,34 @@
+/*
+  © 2023–2025 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool.
+
+  Licensed under the MIT License. See LICENSE file at the project root or
+  https://opensource.org/license/mit/ for details.
+
+  SPDX-License-Identifier: MIT
+*/
+
+/*
+  titledEl
+  This test reports suspicious use of title attributes.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+// Runs the test and returns the result.
+exports.reporter = async (page, withItems) => {
+  const getBadWhat = element => {
+    const elementType = element.tagName.toLowerCase();
+    // Return a violation description.
+    return `Likely ineffective title attribute is used on the ${elementType} element`;
+  }
+  const selector = '[title]:not(iframe, link, style)';
+  const whats = 'title attributes are used on elements they are likely ineffective on';
+  return await doTest(
+    page, withItems, 'titledEl', selector, whats, 0, null, getBadWhat.toString()
+  );
+};

package/tests/testaro.js

@@ -547,158 +547,136 @@ exports.reporter = async (page, report, actIndex) => {
       };
       browser.on('disconnected', disconnectHandler);
     }
-    // Initialize an argument array for reporter or jsonTest.
+    // Initialize an argument array for the reporter.
     const ruleArgs = [page, withItems];
-    const ruleFileNames = await fs.readdir(`${__dirname}/../testaro`);
-    const isJS = ruleFileNames.includes(`${ruleID}.js`);
-    const isJSON = ruleFileNames.includes(`${ruleID}.json`);
-    // If the rule is defined with JavaScript or JSON but not both:
-    if ((isJS || isJSON) && ! (isJS && isJSON)) {
-      // If with JavaScript and it has extra arguments:
-      if (isJS && argRules && argRules.includes(ruleID)) {
-        // Add them to the argument array.
-        ruleArgs.push(... args[ruleID]);
-      }
-      result[ruleID] ??= {};
-      const ruleResult = result[ruleID];
-      const {what} = rule;
-      ruleResult.what = what || '';
-      const startTime = Date.now();
-      let timeout;
-      let testRetries = 2;
-      let testSuccess = false;
-      while (testRetries > 0 && ! testSuccess) {
-        try {
-          // Apply a time limit to the test.
-          const timeLimit = 1000 * timeoutMultiplier * rule.timeOut;
-          // If the time limit expires during the test:
-          const timer = new Promise(resolve => {
-            timeout = setTimeout(() => {
-              // Add data about the test, including its prevention, to the result.
-              const endTime = Date.now();
-              testTimes.push([rule, Math.round((endTime - startTime) / 1000)]);
-              data.rulePreventions.push(ruleID);
-              data.rulePreventionMessages[ruleID] = 'Timeout';
-              ruleResult.totals = [0, 0, 0, 0];
-              ruleResult.standardInstances = [];
-              console.log(`ERROR: Test of testaro rule ${ruleID} timed out`);
-              resolve({timedOut: true});
-            }, timeLimit);
-          });
-          // Perform the test, subject to the time limit.
-          const ruleReport = isJS
-            ? require(`../testaro/${ruleID}`).reporter(... ruleArgs)
-            : jsonTest(ruleID, ruleArgs);
-          // Get the test result or a timeout result.
-          const ruleOrTimeoutReport = await Promise.race([timer, ruleReport]);
-          // If the test was completed:
-          if (! ruleOrTimeoutReport.timedOut) {
-            // Add data from the test to the result.
+    // If the rule has extra arguments:
+    if (argRules && argRules.includes(ruleID)) {
+      // Add them to the argument array.
+      ruleArgs.push(... args[ruleID]);
+    }
+    result[ruleID] ??= {};
+    const ruleResult = result[ruleID];
+    const {what} = rule;
+    ruleResult.what = what || '';
+    const startTime = Date.now();
+    let timeout;
+    let testRetries = 2;
+    let testSuccess = false;
+    // Until all permitted retries are exhausted or the test succeeds:
+    while (testRetries > 0 && ! testSuccess) {
+      try {
+        // Apply a time limit to the test.
+        const timeLimit = 1000 * timeoutMultiplier * rule.timeOut;
+        // If the time limit expires during the test:
+        const timer = new Promise(resolve => {
+          timeout = setTimeout(() => {
+            // Add data about the test, including its prevention, to the result.
             const endTime = Date.now();
-            testTimes.push([ruleID, Math.round((endTime - startTime) / 1000)]);
-            Object.keys(ruleOrTimeoutReport).forEach(key => {
-              ruleResult[key] = ruleOrTimeoutReport[key];
-            });
-            // If the test was prevented:
-            if (ruleResult.data?.prevented && ruleResult.data.error) {
-              // Add this to the result.
-              data.rulePreventions.push(ruleID);
-              data.rulePreventionMessages[ruleID] = ruleResult.data.error;
-            }
-            // If the result includes totals:
-            if (ruleResult.totals) {
-              // Round them.
-              ruleResult.totals = ruleResult.totals.map(total => Math.round(total));
-            }
-            // Prevent a retry of the test.
-            testSuccess = true;
-            // If testing is to stop after a failure and the page failed the test:
-            if (stopOnFail && ruleResult.totals && ruleResult.totals.some(total => total)) {
-              // Stop testing.
-              break;
-            }
-          }
-          // Otherwise, i.e. if the test timed out:
-          else {
-            // Report this.
+            testTimes.push([rule, Math.round((endTime - startTime) / 1000)]);
             data.rulePreventions.push(ruleID);
             data.rulePreventionMessages[ruleID] = 'Timeout';
-            // Stop retrying the test.
+            ruleResult.totals = [0, 0, 0, 0];
+            ruleResult.standardInstances = [];
+            console.log(`ERROR: Test of testaro rule ${ruleID} timed out`);
+            resolve({timedOut: true});
+          }, timeLimit);
+        });
+        // Perform the test, subject to the time limit.
+        const ruleReport = require(`../testaro/${ruleID}`).reporter(... ruleArgs);
+        // Get the test result or a timeout result.
+        const ruleOrTimeoutReport = await Promise.race([timer, ruleReport]);
+        // If the test was completed:
+        if (! ruleOrTimeoutReport.timedOut) {
+          // Add data from the test to the result.
+          const endTime = Date.now();
+          testTimes.push([ruleID, Math.round((endTime - startTime) / 1000)]);
+          Object.keys(ruleOrTimeoutReport).forEach(key => {
+            ruleResult[key] = ruleOrTimeoutReport[key];
+          });
+          // If the test was prevented:
+          if (ruleResult.data?.prevented && ruleResult.data.error) {
+            // Add this to the result.
+            data.rulePreventions.push(ruleID);
+            data.rulePreventionMessages[ruleID] = ruleResult.data.error;
+          }
+          // If the result includes totals:
+          if (ruleResult.totals) {
+            // Round them.
+            ruleResult.totals = ruleResult.totals.map(total => Math.round(total));
+          }
+          // Prevent a retry of the test.
+          testSuccess = true;
+          // If testing is to stop after a failure and the page failed the test:
+          if (stopOnFail && ruleResult.totals && ruleResult.totals.some(total => total)) {
+            // Stop testing.
             break;
           }
         }
-        // If an error is thrown by the test:
-        catch(error) {
-          const isPageClosed = ['closed', 'Protocol error', 'Target page'].some(phrase =>
-            error.message.includes(phrase)
+        // Otherwise, i.e. if the test timed out:
+        else {
+          // Report this.
+          data.rulePreventions.push(ruleID);
+          data.rulePreventionMessages[ruleID] = 'Timeout';
+          // Stop retrying the test.
+          break;
+        }
+      }
+      // If an error is thrown by the test:
+      catch(error) {
+        const isPageClosed = ['closed', 'Protocol error', 'Target page'].some(phrase =>
+          error.message.includes(phrase)
+        );
+        // If the page has closed and there are retries left:
+        if (isPageClosed && testRetries) {
+          // Report this and decrement the allowed retry count.
+          console.log(
+            `WARNING: Retry ${3 - testRetries--} of test ${ruleID} starting after page closed`
           );
-          // If the page has closed and there are retries left:
-          if (isPageClosed && testRetries) {
-            // Report this and decrement the allowed retry count.
-            console.log(
-              `WARNING: Retry ${3 - testRetries--} of test ${ruleID} starting after page closed`
-            );
-            await wait(2000);
-            // Replace the browser and the page in the run module and navigate to the target.
-            await launch(
-              report,
-              actIndex,
-              headEmulation,
-              report.browserID,
-              url
-            );
-            page = require('../run').page;
-            // If the page replacement failed:
-            if (! page) {
-              // Report this.
-              console.log(`ERROR: Browser relaunch to retry test ${ruleID} failed`);
-              data.rulePreventions.push(ruleID);
-              data.rulePreventionMessages[ruleID] = 'Retry failure due to browser relaunch failure';
-              // Stop retrying the test.
-              break;
-            }
-            // Update the rule arguments with the current page.
-            ruleArgs[0] = page;
-          }
-          // Otherwise, i.e. if the page is open or it is closed but no retries are left:
-          else {
-            // Treat the test as prevented.
+          await wait(2000);
+          // Replace the browser and the page in the run module and navigate to the target.
+          await launch(
+            report,
+            actIndex,
+            headEmulation,
+            report.browserID,
+            url
+          );
+          page = require('../run').page;
+          // If the page replacement failed:
+          if (! page) {
+            // Report this.
+            console.log(`ERROR: Browser relaunch to retry test ${ruleID} failed`);
             data.rulePreventions.push(ruleID);
-            data.rulePreventionMessages[ruleID] = error.message;
-            console.log(`ERROR: Test of testaro rule ${ruleID} prevented (${error.message})`);
-            // Do not retry the test even if retries are left.
+            data.rulePreventionMessages[ruleID] = 'Retry failure due to browser relaunch failure';
+            // Stop retrying the test.
             break;
           }
+          // Update the rule arguments with the current page.
+          ruleArgs[0] = page;
         }
-        finally {
-          // Clear the timeout.
-          clearTimeout(timeout);
+        // Otherwise, i.e. if the page is open or it is closed but no retries are left:
+        else {
+          // Treat the test as prevented.
+          data.rulePreventions.push(ruleID);
+          data.rulePreventionMessages[ruleID] = error.message;
+          console.log(`ERROR: Test of testaro rule ${ruleID} prevented (${error.message})`);
+          // Do not retry the test even if retries are left.
+          break;
         }
       }
-      // Clear the error listeners.
-      if (page && ! page.isClosed() && crashHandler) {
-        page.off('crash', crashHandler);
-        crashHandler = null;
-      }
-      if (browser && disconnectHandler) {
-        browser.off('disconnected', disconnectHandler);
-        disconnectHandler = null;
+      finally {
+        // Clear the timeout.
+        clearTimeout(timeout);
       }
     }
-    // Otherwise, i.e. if the rule is undefined or doubly defined:
-    else {
-      // Report this.
-      data.rulesInvalid.push(rule);
-      console.log(`ERROR: Rule ${rule.id} not validly defined`);
-      // Clear the crash listener.
-      if (page && ! page.isClosed() && crashHandler) {
-        page.off('crash', crashHandler);
-        crashHandler = null;
-      }
-      if (browser && disconnectHandler) {
-        browser.off('disconnected', disconnectHandler);
-        disconnectHandler = null;
-      }
+    // Clear the error listeners.
+    if (page && ! page.isClosed() && crashHandler) {
+      page.off('crash', crashHandler);
+      crashHandler = null;
+    }
+    if (browser && disconnectHandler) {
+      browser.off('disconnected', disconnectHandler);
+      disconnectHandler = null;
     }
     // Force a garbage collection.
     try {

package/testaro/hr.json

@@ -1,10 +0,0 @@
-{
-  "ruleID": "hr",
-  "selector": "body hr",
-  "complaints": {
-    "instance": "Element instead of styling is used for vertical segmentation",
-    "summary": "Elements instead of styling are used for vertical segmentation"
-  },
-  "ordinalSeverity": 0,
-  "summaryTagName": "HR"
-}

package/testaro/linkExt.json

@@ -1,10 +0,0 @@
-{
-  "ruleID": "linkExt",
-  "selector": "a[target=_blank]",
-  "complaints": {
-    "instance": "Link has a target=_blank attribute",
-    "summary": "Links have target=_blank attributes"
-  },
-  "ordinalSeverity": 0,
-  "summaryTagName": "A"
-}

package/testaro/linkOldAtt.json

@@ -1,10 +0,0 @@
-{
-  "ruleID": "linkOldAtt",
-  "selector": "a[charset], a[coords], a[name], a[rev], a[shape]",
-  "complaints": {
-    "instance": "Element has a deprecated attribute",
-    "summary": "Links have deprecated attributes"
-  },
-  "ordinalSeverity": 1,
-  "summaryTagName": "A"
-}

package/testaro/linkTo.json

@@ -1,10 +0,0 @@
-{
-  "ruleID": "linkTo",
-  "selector": "a:not([href]):visible",
-  "complaints": {
-    "instance": "Element has no href attribute",
-    "summary": "Links are missing href attributes"
-  },
-  "ordinalSeverity": 2,
-  "summaryTagName": "A"
-}

package/testaro/pseudoP.json

@@ -1,10 +0,0 @@
-{
-  "ruleID": "pseudoP",
-  "selector": "body br + br",
-  "complaints": {
-    "instance": "br element follows another br element, likely acting as a pseudo-paragraph",
-    "summary": "br elements follow other br elements, likely acting as pseudo-paragraphs"
-  },
-  "ordinalSeverity": 0,
-  "summaryTagName": "BR"
-}

package/testaro/titledEl.json

@@ -1,10 +0,0 @@
-{
-  "ruleID": "titledEl",
-  "selector": "[title]:not(button, iframe, input, link, select, textarea)",
-  "complaints": {
-    "instance": "Ineligible element has a title attribute",
-    "summary": "Ineligible elements have title attributes"
-  },
-  "ordinalSeverity": 2,
-  "summaryTagName": ""
-}