testaro 60.11.0 → 60.12.0

package/UPGRADES.md

@@ -3239,3 +3239,69 @@ Given your goal to move on with [testaro](cci:7://file:///Users/pool/Users/pool/
 - Plan separately for a future **element-matching module** that consumes all tools’ outputs and decides “these instances refer to the same DOM element”.
 
 That way, you get immediate performance and implementation wins in [testaro](cci:7://file:///Users/pool/Users/pool/Documents/Topics/work/testaro:0:0-0:0), without locking yourself into the fragile assumption that “XPath strings must match exactly across all tools.
+
+## Sampling and performance
+
+Refactoring Testaro tests to eliminate sampling of elements began in December 2025. Initial results suggest that refactoring decreases elapsed test times despite the fact that all applicable elements are examined rather than only a sample.
+
+In a run by the Kilotest server on the [home page of the Open Source Collective](https://opencollective.com/opensource), with about 2700 visible elements,the elapsed times of Testaro tests were:
+
+```json
+"ruleTestTimes": {
+  "allCaps": 11,
+  "opFoc": 10,
+  "allSlanted": 9,
+  "hovInd": 9,
+  "focOp": 8,
+  "targetSmall": 7,
+  "focAll": 7,
+  "focVis": 6,
+  "distortion": 5,
+  "linkAmb": 5,
+  "titledEl": 5,
+  "zIndex": 5,
+  "targetTiny": 4,
+  "shoot1": 4,
+  "linkTitle": 3,
+  "hover": 3,
+  "shoot0": 2,
+  "adbID": 2,
+  "linkUl": 2,
+  "buttonMenu": 2,
+  "focInd": 2,
+  "tabNav": 2,
+  "dupAtt": 0,
+  "imageLink": 1,
+  "labClash": 1,
+  "allHidden": 0,
+  "altScheme": 0,
+  "autocomplete": 0,
+  "bulk": 0,
+  "captionLoc": 0,
+  "datalistRef": 0,
+  "docType": 0,
+  "embAc": 0,
+  "headEl": 0,
+  "headingAmb": 0,
+  "hr": 0,
+  "legendLoc": 0,
+  "lineHeight": 0,
+  "linkExt": 0,
+  "linkOldAtt": 0,
+  "linkTo": 0,
+  "miniText": 0,
+  "nonTable": 0,
+  "optRoleSel": 0,
+  "phOnly": 0,
+  "pseudoP": 0,
+  "radioSet": 0,
+  "role": 0,
+  "secHeading": 0,
+  "styleDiff": 0,
+  "textSem": 0
+}
+```
+
+All of the tests with elapsed times longer than 2 seconds were not yet refactored. Some of the refactored tests applied `checkVisibility` to all `body` descendant elements.
+
+Credit for the speed improvement in refactored tests is apparently owed to the encapsulation of the entire test logic in a browser function, versus the repeated element-by-element execution of the same logic in Node.js with Playwright methods.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "60.11.0",
+  "version": "60.12.0",
   "description": "Run 1000 web accessibility tests from 11 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/screenShot.js

@@ -18,7 +18,7 @@ exports.screenShot = async (page, exclusion = null) => {
   const options = {
     fullPage: true,
     omitBackground: true,
-    timeout: 2000
+    timeout: 4000
   };
   if (exclusion) {
     options.mask = [exclusion];

package/procs/testaro.js

@@ -194,9 +194,18 @@ exports.doTest = async (
         violationCount++;
         // If itemization is required:
         if (withItems) {
+          const violationWhatStart = violationWhat.slice(0, 2);
+          let ruleSeverity = severity;
+          let ruleWhat = violationWhat
+          // If this violation has a custom severity:
+          if (/[0-3]:/.test(violationWhatStart)) {
+            // Get it and remove it from the violation description.
+            ruleSeverity = Number(violationWhat[0]);
+            ruleWhat = violationWhat.slice(2);
+          }
           // Add an instance to the instances.
           instances.push(
-            window.getInstance(element, ruleID, violationWhat, 1, severity)
+            window.getInstance(element, ruleID, ruleWhat, 1, ruleSeverity)
           );
         }
       }

package/testaro/focAndOp.js

@@ -0,0 +1,146 @@
+/*
+  © 2021–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
+
+  MIT License
+
+  Permission is hereby granted, free of charge, to any person obtaining a copy
+  of this software and associated documentation files (the "Software"), to deal
+  in the Software without restriction, including without limitation the rights
+  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+  copies of the Software, and to permit persons to whom the Software is
+  furnished to do so, subject to the following conditions:
+
+  The above copyright notice and this permission notice shall be included in all
+  copies or substantial portions of the Software.
+
+  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+  SOFTWARE.
+*/
+
+/*
+  focAndOp
+  Related to Tenon rule 190.
+
+  This test reports discrepancies between Tab-focusability and operability. The standard practice
+  is to make focusable elements operable and operable elements focusable. If focusable elements are
+  not operable, users are likely to be surprised that nothing happens when they try to operate such
+  elements. Conversely, if operable elements are not focusable, users who navigate with a
+  keyboard are prevented from operating those elements.  The test considers an element
+  Tab-focusable if its tabIndex property has the value 0. The test considers an element operable if
+  it has a non-inherited pointer cursor and is not a 'LABEL' element, has an operable tag name, has
+  an interactive explicit role, or has an 'onclick' attribute.
+*/
+
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
+
+// Runs the test and returns the result.
+exports.reporter = async (page, withItems) => {
+  // Define a violation function for execution in the browser.
+  const getBadWhat = element => {
+    // Get whether the element is visible.
+    const isVisible = element.checkVisibility({
+      contentVisibilityAuto: true,
+      opacityProperty: true,
+      visibilityProperty: true
+    });
+    // If so:
+    if (isVisible) {
+      // Get whether it is focusable.
+      const isFocusable = element.tabIndex === 0;
+      // Get the operable tagnames.
+      const opTags = new Set(['A', 'BUTTON', 'IFRAME', 'INPUT','OPTION', 'SELECT', 'TEXTAREA']);
+      // Get the operable roles.
+      const opRoles = new Set([
+        'button',
+        'checkbox',
+        'combobox',
+        'composite',
+        'grid',
+        'gridcell',
+        'input',
+        'link',
+        'listbox',
+        'menu',
+        'menubar',
+        'menuitem',
+        'menuitemcheckbox',
+        'option',
+        'radio',
+        'radiogroup',
+        'scrollbar',
+        'searchbox',
+        'select',
+        'slider',
+        'spinbutton',
+        'switch',
+        'tab',
+        'tablist',
+        'textbox',
+        'tree',
+        'treegrid',
+        'treeitem',
+        'widget',
+      ]);
+      // Initialize the operabilities of the element.
+      const opHow = [];
+      let hasPointer = false;
+      // If the element is not a label:
+      if (element.tagName !== 'LABEL') {
+        const styleDec = window.getComputedStyle(element);
+        hasPointer = styleDec.cursor === 'pointer';
+        // If it has a pointer cursor:
+        if (hasPointer) {
+          // Neutralize the cursor style of the parent element of the element.
+          element.parentElement.style.cursor = 'default';
+          // Get whether, after this, the element still has a pointer cursor.
+          hasPointer = styleDec.cursor === 'pointer';
+          // Add this to the operabilities of the element.
+          opHow.push('pointer cursor');
+        }
+      }
+      // If the element has a click event listener:
+      if (element.onclick) {
+        // Add this to the operabilities.
+        opHow.push('click listener');
+      }
+      // If the element has an operable explicit role:
+      const role = element.getAttribute('role');
+      if (opRoles.has(role)) {
+        // Add this to the operabilities.
+        opHow.push(`role ${role}`);
+      }
+      // If the element has an operable tagname:
+      const tagName = element.tagName;
+      if (opTags.has(tagName)) {
+        // Add this to the operabilities.
+        opHow.push(`tagname ${tagName}`);
+      }
+      const isOperable = opHow.length > 0;
+      // If the element is focusable but not operable:
+      if (isFocusable && ! isOperable) {
+        // Return a severity and violation description.
+        return '2:Element is Tab-focusable but not operable';
+      }
+      // Otherwise, if it is operable but not focusable:
+      else if (isOperable && ! isFocusable) {
+        // Return a severity and violation description.
+        return `3:Element is operable (${opHow.join(', ')}) but not Tab-focusable`;
+      }
+    }
+  };
+  const whats = 'Elements are Tab-focusable but not operable or vice versa';
+  // Perform the test and return the result.
+  return doTest(
+    page, withItems, 'focAndOp', 'body *', whats, 2, null, getBadWhat.toString()
+  );
+};

package/testaro/focInd.js

@@ -1,5 +1,6 @@
 /*
   © 2021–2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 

package/tests/testaro.js

@@ -385,17 +385,17 @@ const allRules = [
     defaultOn: true
   },
   {
-    id: 'focInd',
-    what: 'missing and nonstandard focus indicators',
+    id: 'focAndOp',
+    what: 'Tab-focusable elements that are not operable or vice versa',
     launchRole: 'waster',
-    timeOut: 10,
+    timeOut: 5,
     defaultOn: true
   },
   {
-    id: 'focOp',
-    what: 'Tab-focusable elements that are not operable',
+    id: 'focInd',
+    what: 'missing and nonstandard focus indicators',
     launchRole: 'waster',
-    timeOut: 5,
+    timeOut: 10,
     defaultOn: true
   },
   {
@@ -419,13 +419,6 @@ const allRules = [
     timeOut: 10,
     defaultOn: true
   },
-  {
-    id: 'opFoc',
-    what: 'operable elements that are not Tab-focusable',
-    launchRole: 'waster',
-    timeOut: 10,
-    defaultOn: true
-  },
   {
     id: 'tabNav',
     what: 'nonstandard keyboard navigation between elements with the tab role',

package/procs/operable.js

@@ -1,108 +0,0 @@
-/*
-  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
-
-  MIT License
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-
-/*
-  operable
-  Returns whether the element of a locator is operable., i.e. it has a non-inherited pointer cursor
-  and is not a 'LABEL' element, has an operable tag name, has an interactive explicit role, or has
-  an 'onclick' attribute. The isOperable function modifies the page.
-*/
-
-// ########## FUNCTIONS
-
-// Gets whether an element is operable.
-exports.isOperable = async loc => {
-  // Get whether and, if so, how the element is operable.
-  const operabilities = await loc.evaluate(el => {
-    // Operable tag names.
-    const opTags = new Set(['A', 'BUTTON', 'IFRAME', 'INPUT', 'SELECT', 'TEXTAREA']);
-    // Operable roles.
-    const opRoles = new Set([
-      'button',
-      'checkbox',
-      'combobox',
-      'composite',
-      'grid',
-      'gridcell',
-      'input',
-      'link',
-      'listbox',
-      'menu',
-      'menubar',
-      'menuitem',
-      'menuitemcheckbox',
-      'option',
-      'radio',
-      'radiogroup',
-      'scrollbar',
-      'searchbox',
-      'select',
-      'slider',
-      'spinbutton',
-      'switch',
-      'tab',
-      'tablist',
-      'textbox',
-      'tree',
-      'treegrid',
-      'treeitem',
-      'widget',
-    ]);
-    // Initialize the operabilities.
-    const opHow = [];
-    // If the element is not a label and has a non-inherited pointer cursor:
-    let hasPointer = false;
-    if (el.tagName !== 'LABEL') {
-      const styleDec = window.getComputedStyle(el);
-      hasPointer = styleDec.cursor === 'pointer';
-      if (hasPointer) {
-        el.parentElement.style.cursor = 'default';
-        hasPointer = styleDec.cursor === 'pointer';
-      }
-    }
-    if (hasPointer) {
-      // Add this to the operabilities.
-      opHow.push('pointer cursor');
-    }
-    // If the element is clickable:
-    if (el.onclick) {
-      // Add this to the operabilities.
-      opHow.push('click listener');
-    }
-    // If the element has an operable explicit role:
-    const role = el.getAttribute('role');
-    if (opRoles.has(role)) {
-      // Add this to the operabilities.
-      opHow.push(`role ${role}`);
-    }
-    // If the element has an operable type:
-    const tagName = el.tagName;
-    if (opTags.has(tagName)) {
-      // Add this to the operabilities.
-      opHow.push(`tag name ${tagName}`);
-    }
-    return opHow;
-  });
-  return operabilities;
-};

package/testaro/focOp.js

@@ -1,75 +0,0 @@
-/*
-  © 2021–2024 CVS Health and/or one of its affiliates. All rights reserved.
-  © 2025 Jonathan Robert Pool. All rights reserved.
-
-  MIT License
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-
-/*
-  focOp
-  Related to Tenon rule 190.
-
-  This test reports Tab-focusable elements that are not operable. The standard practice is to make
-  focusable elements operable. If focusable elements are not operable, users are likely to be
-  surprised that nothing happens when they try to operate such elements. The test considers an
-  element operable if it has a non-inherited pointer cursor and is not a 'LABEL' element, has an
-  operable tag name, has an interactive explicit role, or has an 'onclick' attribute. The test
-  considers an element Tab-focusable if its tabIndex property has the value 0.
-*/
-
-// ########## IMPORTS
-
-// Module to perform common operations.
-const {init, getRuleResult} = require('../procs/testaro');
-// Module to get operabilities.
-const {isOperable} = require('../procs/operable');
-
-// ########## FUNCTIONS
-
-// Runs the test and returns the result.
-exports.reporter = async (page, withItems) => {
-  // Initialize the locators and result.
-  const all = await init(100, page, 'body *');
-  all.result.data.focusableCount = 0;
-  // For each locator:
-  for (const loc of all.allLocs) {
-    // Get whether its element is focusable.
-    const isFocusable = await loc.evaluate(el => el.tabIndex === 0);
-    // If it is:
-    if (isFocusable) {
-      // Add this to the report.
-      all.result.data.focusableCount++;
-      // Get whether it is operable.
-      const howOperable = await isOperable(loc);
-      // If it is not:
-      if (! howOperable.length) {
-        // Add the locator to the array of violators.
-        all.locs.push(loc);
-      }
-    }
-  }
-  // Populate and return the result.
-  const whats = [
-    'Element is Tab-focusable but not operable', 'Elements are Tab-focusable but not operable'
-  ];
-  const result = await getRuleResult(withItems, all, 'focOp', whats, 2);
-  return result;
-};

package/testaro/miniText-orig.js

@@ -1,62 +0,0 @@
-/*
-  © 2022–2023 CVS Health and/or one of its affiliates. All rights reserved.
-
-  MIT License
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-
-/*
-  miniText
-  Derived from the bbc-a11y textCannotBeTooSmall test.
-  Related to Tenon rule 134.
-  This test reports elements with font sizes smaller than 11 pixels.
-*/
-
-// Module to perform common operations.
-const {init, getRuleResult} = require('../procs/testaro');
-
-// ########## FUNCTIONS
-
-// Runs the test and returns the result.
-exports.reporter = async (page, withItems) => {
-  // Initialize the locators and result.
-  const all = await init(100, page, 'body *:not(script, style):visible', {hasText: /[^\s]+/});
-  // For each locator:
-  for (const loc of all.allLocs) {
-    // Get the font size of its element if less than 11 pixels.
-    const fontSize = await loc.evaluate(el => {
-      const styleDec = window.getComputedStyle(el);
-      const fontSizeString = styleDec.fontSize;
-      const fontSize = Number.parseFloat(fontSizeString);
-      return fontSize < 11 ? fontSize : null;
-    });
-    // If it violates the rule:
-    if (fontSize) {
-      // Add the locator to the array of violators.
-      all.locs.push([loc, fontSize]);
-    }
-  }
-  // Populate and return the result.
-  const whats = [
-    'Element has a font size of __param__ pixels, smaller than 11 pixels',
-    'Elements have font sizes smaller than 11 pixels'
-  ];
-  return await getRuleResult(withItems, all, 'miniText', whats, 2);
-};

package/testaro/opFoc.js

@@ -1,76 +0,0 @@
-/*
-  © 2023–2024 CVS Health and/or one of its affiliates. All rights reserved.
-  © 2025 Jonathan Robert Pool. All rights reserved.
-
-  MIT License
-
-  Permission is hereby granted, free of charge, to any person obtaining a copy
-  of this software and associated documentation files (the "Software"), to deal
-  in the Software without restriction, including without limitation the rights
-  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-  copies of the Software, and to permit persons to whom the Software is
-  furnished to do so, subject to the following conditions:
-
-  The above copyright notice and this permission notice shall be included in all
-  copies or substantial portions of the Software.
-
-  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-  SOFTWARE.
-*/
-
-/*
-  opFoc
-  Related to Tenon rule 190.
-
-  This test reports operable elements that are not Tab-focusable. The standard practice is to make
-  operable elements focusable. If operable elements are not focusable, users who navigate with a
-  keyboard are prevented from operating those elements. The test considers an element operable if
-  it has a non-inherited pointer cursor and is not a 'LABEL' element, has an operable tag name, has
-  an interactive explicit role, or has an 'onclick' attribute. The test considers an element
-  Tab-focusable if its tabIndex property has the value 0.
-*/
-
-// ########## IMPORTS
-
-// Module to perform common operations.
-const {init, getRuleResult} = require('../procs/testaro');
-// Module to get operabilities.
-const {isOperable} = require('../procs/operable');
-
-// ########## FUNCTIONS
-
-// Runs the test and returns the result.
-exports.reporter = async (page, withItems) => {
-  // Initialize the locators and result.
-  const all = await init(100, page, 'body *');
-  all.result.data.operableCount = 0;
-  // For each locator:
-  for (const loc of all.allLocs) {
-    // Get whether and, if so, how its element is operable.
-    const operabilities = await isOperable(loc);
-    // If it is:
-    if (operabilities.length) {
-      // Add this to the report.
-      all.result.data.operableCount++;
-      // Get whether it is focusable.
-      const isFocusable = await loc.evaluate(el => el.tabIndex === 0);
-      // If it is not:
-      if (! isFocusable) {
-        // Add the locator to the array of violators.
-        all.locs.push([loc, operabilities.join(', ')]);
-      }
-    }
-  }
-  // Populate and return the result.
-  const whats = [
-    'Element is operable (__param__) but not Tab-focusable',
-    'Elements are operable but not Tab-focusable'
-  ];
-  const result = await getRuleResult(withItems, all, 'opFoc', whats, 3);
-  return result;
-};