testaro 60.10.3 → 60.12.0

package/UPGRADES.md

@@ -3239,3 +3239,69 @@ Given your goal to move on with [testaro](cci:7://file:///Users/pool/Users/pool/
 - Plan separately for a future **element-matching module** that consumes all tools’ outputs and decides “these instances refer to the same DOM element”.
 
 That way, you get immediate performance and implementation wins in [testaro](cci:7://file:///Users/pool/Users/pool/Documents/Topics/work/testaro:0:0-0:0), without locking yourself into the fragile assumption that “XPath strings must match exactly across all tools.
+
+## Sampling and performance
+
+Refactoring Testaro tests to eliminate sampling of elements began in December 2025. Initial results suggest that refactoring decreases elapsed test times despite the fact that all applicable elements are examined rather than only a sample.
+
+In a run by the Kilotest server on the [home page of the Open Source Collective](https://opencollective.com/opensource), with about 2700 visible elements,the elapsed times of Testaro tests were:
+
+```json
+"ruleTestTimes": {
+  "allCaps": 11,
+  "opFoc": 10,
+  "allSlanted": 9,
+  "hovInd": 9,
+  "focOp": 8,
+  "targetSmall": 7,
+  "focAll": 7,
+  "focVis": 6,
+  "distortion": 5,
+  "linkAmb": 5,
+  "titledEl": 5,
+  "zIndex": 5,
+  "targetTiny": 4,
+  "shoot1": 4,
+  "linkTitle": 3,
+  "hover": 3,
+  "shoot0": 2,
+  "adbID": 2,
+  "linkUl": 2,
+  "buttonMenu": 2,
+  "focInd": 2,
+  "tabNav": 2,
+  "dupAtt": 0,
+  "imageLink": 1,
+  "labClash": 1,
+  "allHidden": 0,
+  "altScheme": 0,
+  "autocomplete": 0,
+  "bulk": 0,
+  "captionLoc": 0,
+  "datalistRef": 0,
+  "docType": 0,
+  "embAc": 0,
+  "headEl": 0,
+  "headingAmb": 0,
+  "hr": 0,
+  "legendLoc": 0,
+  "lineHeight": 0,
+  "linkExt": 0,
+  "linkOldAtt": 0,
+  "linkTo": 0,
+  "miniText": 0,
+  "nonTable": 0,
+  "optRoleSel": 0,
+  "phOnly": 0,
+  "pseudoP": 0,
+  "radioSet": 0,
+  "role": 0,
+  "secHeading": 0,
+  "styleDiff": 0,
+  "textSem": 0
+}
+```
+
+All of the tests with elapsed times longer than 2 seconds were not yet refactored. Some of the refactored tests applied `checkVisibility` to all `body` descendant elements.
+
+Credit for the speed improvement in refactored tests is apparently owed to the encapsulation of the entire test logic in a browser function, versus the repeated element-by-element execution of the same logic in Node.js with Playwright methods.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "60.10.3",
+  "version": "60.12.0",
   "description": "Run 1000 web accessibility tests from 11 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/screenShot.js

@@ -18,7 +18,7 @@ exports.screenShot = async (page, exclusion = null) => {
   const options = {
     fullPage: true,
     omitBackground: true,
-    timeout: 2000
+    timeout: 4000
   };
   if (exclusion) {
     options.mask = [exclusion];

package/procs/testaro.js

@@ -157,3 +157,79 @@ exports.simplify = async (page, withItems, ruleData) => {
   // Return the result.
   return result;
 };
+// Performs a standard test.
+exports.doTest = async (
+  page,
+  withItems,
+  ruleID,
+  candidateSelector,
+  whats,
+  severity,
+  summaryTagName,
+  getBadWhatString
+) => {
+  // Return totals and standard instances for the rule.
+  return await page.evaluate(args => {
+    const [
+      withItems,
+      ruleID,
+      candidateSelector,
+      whats,
+      severity,
+      summaryTagName,
+      getBadWhatString
+    ] = args;
+    // Get all candidates.
+    const candidates = document.body.querySelectorAll(candidateSelector);
+    let violationCount = 0;
+    const instances = [];
+    // Get a violation function.
+    const getBadWhat = eval(`(${getBadWhatString})`);
+    // For each candidate:
+    candidates.forEach(element => {
+      const violationWhat = getBadWhat(element);
+      // If it violates the rule:
+      if (violationWhat) {
+        // Increment the violation count.
+        violationCount++;
+        // If itemization is required:
+        if (withItems) {
+          const violationWhatStart = violationWhat.slice(0, 2);
+          let ruleSeverity = severity;
+          let ruleWhat = violationWhat
+          // If this violation has a custom severity:
+          if (/[0-3]:/.test(violationWhatStart)) {
+            // Get it and remove it from the violation description.
+            ruleSeverity = Number(violationWhat[0]);
+            ruleWhat = violationWhat.slice(2);
+          }
+          // Add an instance to the instances.
+          instances.push(
+            window.getInstance(element, ruleID, ruleWhat, 1, ruleSeverity)
+          );
+        }
+      }
+    });
+    // If there are any violations and itemization is not required:
+    if (violationCount && ! withItems) {
+      // Add a summary instance to the instances.
+      instances.push(
+        window.getInstance(null, ruleID, whats, violationCount, severity, summaryTagName)
+      );
+    }
+    return {
+      data: {},
+      totals: [0, 0, 0, violationCount],
+      standardInstances: instances
+    }
+  }, [
+      withItems,
+      ruleID,
+      candidateSelector,
+      whats,
+      severity,
+      summaryTagName,
+      getBadWhatString
+    ]
+  );
+};

package/testaro/adbID.js

@@ -32,81 +32,50 @@
   the implementation of a test for a similar rule in the Tenon tool.
 */
 
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
 // FUNCTIONS
 
 // Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Return totals and standard instances for the rule.
-  return await page.evaluate(withItems => {
-    // Get all candidates, i.e. elements with aria-describedby attributes.
-    const candidates = document.body.querySelectorAll('[aria-describedby]');
-    let violationCount = 0;
-    const instances = [];
-    // For each candidate:
-    candidates.forEach(element => {
-      // Get the IDs in its aria-describedby attribute.
-      const IDs = element.getAttribute('aria-describedby').trim().split(/\s+/).filter(Boolean);
-      // If there are none:
-      if (! IDs.length) {
-        // Increment the violation count.
-        violationCount++;
-        // If itemization is required:
-        if (withItems) {
-          const what = 'Element has an aria-describedby attribute with no value';
-          // Add an instance to the instances.
-          instances.push(window.getInstance(element, 'adbID', what, 1, 3));
+  // Define a violation function for execution in the browser.
+  const getBadWhat = element => {
+    // Get the IDs in the aria-describedby attribute of the element.
+    const IDs = element.getAttribute('aria-describedby').trim().split(/\s+/).filter(Boolean);
+    // If there are none:
+    if (! IDs.length) {
+      // Return a violation description.
+      return 'Element has an aria-describedby attribute with no value';
+    }
+    // Otherwise, i.e. if there is at least 1 ID:
+    else {
+      // For each ID:
+      for (const id of IDs) {
+        // Get the element with that ID.
+        const describer = document.getElementById(id);
+        // If it doesn't exist:
+        if (! describer) {
+          // Return a violation description.
+          return `No element has the aria-describedby ID ${id}`;
         }
-      }
-      // Otherwise, i.e. if there is at least 1 ID:
-      else {
-        // For each ID:
-        for (const id of IDs) {
-          // Get the element with that ID.
-          const describer = document.getElementById(id);
-          // If it doesn't exist:
-          if (! describer) {
-            // Increment the violation count.
-            violationCount++;
-            // If itemization is required:
-            if (withItems) {
-              const what = `No element has the aria-describedby ID ${id}`;
-              // Add an instance to the instances.
-              instances.push(window.getInstance(element, 'adbID', what, 1, 3));
-            }
-            // Stop checking the element.
-            break;
-          }
-          // Otherwise, i.e. if it exists:
-          else {
-            // Get the elements with that ID.
-            const sameIDElements = document.querySelectorAll(`#${id}`);
-            // If there is more than one:
-            if (sameIDElements.length > 1) {
-              // Increment the violation count.
-              violationCount++;
-              // If itemization is required:
-              if (withItems) {
-                const what = `Multiple elements share the aria-describedby ID ${id}`;
-                // Add an instance to the instances.
-                instances.push(window.getInstance(element, 'adbID', what, 1, 2));
-              }
-              // Stop checking the element.
-              break;
-            }
+        // Otherwise, i.e. if it exists:
+        else {
+          // Get the elements with that ID.
+          const sameIDElements = document.querySelectorAll(`#${id}`);
+          // If there is more than one:
+          if (sameIDElements.length > 1) {
+            // Return a violation description.
+            return `Multiple elements share the aria-describedby ID ${id}`;
           }
         }
       }
-    });
-    // If there were any violations and itemization is not required:
-    if (violationCount && ! withItems) {
-      const what = 'Elements have aria-describedby attributes with missing or invalid id values';
-      // Add a summary instance to the instances.
-      instances.push(window.getInstance(null, 'adbID', what, violationCount, 3));
     }
-    return {
-      data: {},
-      totals: [0, violationCount, 0, 0],
-      standardInstances: instances
-    };
-  }, withItems);
+  };
+  const whats = 'Elements have aria-describedby attributes with missing or invalid id values';
+  // Perform the test and return the result.
+  return doTest(
+    page, withItems, 'adbID', '[aria-describedby]', whats, 3, null, getBadWhat.toString()
+  );
 };

package/testaro/altScheme.js

@@ -29,49 +29,35 @@
   Identify img elements whose alt attribute is a URL or file name.
 */
 
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
 // FUNCTIONS
 
 // Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Return totals and standard instances for the rule.
-  return await page.evaluate(withItems => {
-    // Get all candidates, i.e. img elements with alt attributes.
-    const candidates = document.body.querySelectorAll('img[alt]');
-    let violationCount = 0;
-    const instances = [];
-    // For each candidate:
-    candidates.forEach(element => {
-      const alt = (element.getAttribute('alt') || '').trim();
-      // If it is non-empty:
-      if (alt) {
-        const isURL = /^(?:https?:|file:|ftp:)\S+$/i.test(alt);
-        const isFileName = /favicon|^\S+\.(?:png|jpe?g|gif|svg|webp|ico)$/i.test(alt);
-        // If it is a URL or file name:
-        if (isURL || isFileName) {
-          // Increment the violation count.
-          violationCount++;
-          // If itemization is required:
-          if (withItems) {
-            const valueType = isURL && isFileName
-            ? 'the URL of an image file'
-            : (isURL ? 'a URL' : 'a file name');
-            const what = `img element has an alt attribute with ${valueType} as its value`;
-            // Add an instance to the instances.
-            instances.push(window.getInstance(element, 'altScheme', what, 1, 2));
-          }
-        }
+  // Define a violation function for execution in the browser.
+  const getBadWhat = element => {
+    // Get the value of the alt attribute of the element.
+    const alt = (element.getAttribute('alt') || '').trim();
+    // If it is non-empty:
+    if (alt) {
+      const isURL = /^(?:https?:|file:|ftp:)\S+$/i.test(alt);
+      const isFileName = /favicon|^\S+\.(?:png|jpe?g|gif|svg|webp|ico)$/i.test(alt);
+      // If it is a URL or file name:
+      if (isURL || isFileName) {
+        const valueType = isURL && isFileName
+        ? 'the URL of an image file'
+        : (isURL ? 'a URL' : 'a file name');
+        // Return a violation description.
+        return `img element has an alt attribute with ${valueType} as its value`;
       }
-    });
-    // If there were any violations and itemization is not required:
-    if (violationCount && ! withItems) {
-      const what = 'img elements have alt attributes with URL or filename values';
-      // Add a summary instance to the instances.
-      instances.push(window.getInstance(null, 'altScheme', what, violationCount, 2, 'IMG'));
     }
-    return {
-      data: {},
-      totals: [0, violationCount, 0, 0],
-      standardInstances: instances
-    };
-  }, withItems);
+  };
+  const whats = 'img elements have alt attributes with URL or filename values';
+  // Perform the test and return the result.
+  return doTest(
+    page, withItems, 'altScheme', 'img[alt]', whats, 1, 'IMG', getBadWhat.toString()
+  );
 };

package/testaro/captionLoc.js

@@ -1,6 +1,7 @@
 /*
   © 2025 CVS Health and/or one of its affiliates. All rights reserved.
   © 2025 Juan S. Casado. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -25,43 +26,28 @@
 
 /*
   captionLoc
-  Report caption elements that are not the first child of their table element.
+  Report caption elements that are not the first children of table elements.
 */
 
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
 // FUNCTIONS
 
 exports.reporter = async (page, withItems) => {
-  // Return totals and standard instances for the rule.
-  return await page.evaluate(withItems => {
-    // Get all candidates, i.e. caption elements.
-    const candidates = document.body.querySelectorAll('caption');
-    let violationCount = 0;
-    const instances = [];
-    // For each candidate:
-    candidates.forEach(element => {
-      const parent = element.parentElement;
-      // If the element is not the first child of a table element:
-      if (! parent || parent.tagName !== 'TABLE' || parent.firstElementChild !== el) {
-        // Increment the violation count.
-        violationCount++;
-        // If itemization is required:
-        if (withItems) {
-          const what = 'caption element is not the first child of a table element';
-          // Add an instance to the instances.
-          instances.push(window.getInstance(element, 'captionLoc', what, 1, 3));
-        }
-      }
-    });
-    // If there are any violations and itemization is not required:
-    if (violationCount && ! withItems) {
-      const what = 'caption elements are not the first children of table elements';
-      // Add a summary instance to the instances.
-      instances.push(window.getInstance(null, 'captionLoc', what, violationCount, 3, 'caption'));
-    }
-    return {
-      data: {},
-      totals: [0, 0, 0, violationCount],
-      standardInstances: instances
+  // Define a violation function for execution in the browser.
+  const getBadWhat = element => {
+    const parent = element.parentElement;
+    // If the element is not the first child of a table element:
+    if (! parent || parent.tagName !== 'TABLE' || parent.firstElementChild !== element) {
+      // Return a violation description.
+      return 'caption element is not the first child of a table element';
     }
-  }, withItems);
+  };
+  const whats = 'caption elements are not the first children of table elements';
+  // Perform the test and return the result.
+  return doTest(
+    page, withItems, 'captionLoc', 'caption', whats, 3, 'CAPTION', getBadWhat.toString()
+  );
 };

package/testaro/datalistRef.js

@@ -1,6 +1,7 @@
 /*
   © 2025 CVS Health and/or one of its affiliates. All rights reserved.
   © 2025 Juan S. Casado. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -28,22 +29,39 @@
   Report inputs whose list attribute references a missing or ambiguous datalist
 */
 
-const {init, getRuleResult} = require('../procs/testaro');
+// IMPORTS
+
+const {doTest} = require('../procs/testaro');
+
+// FUNCTIONS
 
 exports.reporter = async (page, withItems) => {
-  const all = await init(100, page, 'input[list]');
-  for (const loc of all.allLocs) {
-    const isBad = await loc.evaluate(el => {
-      const list = el.getAttribute('list');
-      if (!list) return false;
-      const matches = Array.from(document.querySelectorAll('datalist')).filter(d => d.id === list);
-      return matches.length !== 1;
-    });
-    if (isBad) all.locs.push(loc);
-  }
-  const whats = [
-    'list attribute of the element references an ambiguous or missing datalist element',
-    'list attributes of elements reference ambiguous or missing datalist elements'
-  ];
-  return await getRuleResult(withItems, all, 'datalistRef', whats, 3, 'INPUT');
+  const getBadWhat = element => {
+    // Get the ID of the datalist element referenced by the list attribute of the element.
+    const listID = element.getAttribute('list');
+    // If the element has a list attribute with a non-empty value:
+    if (listID) {
+      // Get the element it references.
+      const listElement = document.getElementById(listID);
+      // If no such element exists:
+      if (! listElement) {
+        // Return a violation description.
+        return 'input element list attribute references a missing element';
+      }
+      // Otherwise, if the element it references is not a datalist:
+      if (listElement.tagName.toLowerCase() !== 'datalist') {
+        // Return a violation description.
+        return 'input element list attribute references a non-datalist element';
+      }
+    }
+    // Otherwise, i.e. if it has no list attribute with a non-empty value:
+    else {
+      // Return a violation description.
+      return 'input element list attribute is empty';
+    }
+  };
+  const whats = 'list attributes of input elements are empty or IDs of no or non-datalist elements';
+  return doTest(
+    page, withItems, 'datalistRef', 'input[list]', whats, 3, 'INPUT', getBadWhat.toString()
+  );
 };

package/testaro/embAc.js

@@ -30,41 +30,23 @@
   non-obvious what a user will activate with a click.
 */
 
-// ########## IMPORTS
+// IMPORTS
 
-// Module to perform common operations.
-const {init, getRuleResult} = require('../procs/testaro');
+const {doTest} = require('../procs/testaro');
 
-// ########## FUNCTIONS
+// FUNCTIONS
 
-// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Initialize the locators and result.
-  const all = await init(
-    100,
-    page,
-    'a a, a button, a input, a select, button a, button button, button input, button select'
-  );
-  // For each locator:
-  for (const loc of all.allLocs) {
-    // Get whether its embedder is a link or a button.
-    const embedderTagName = await loc.evaluate(element => {
-      const embedder = element.parentElement.closest('a, button');
-      return embedder ? embedder.tagName : '';
-    });
-    let param = 'a link or button';
-    if (embedderTagName === 'A') {
-      param = 'a link';
-    }
-    else if (embedderTagName === 'BUTTON') {
-      param = 'a button';
-    }
-    all.locs.push([loc, param]);
-  }
-  // Populate and return the result.
-  const whats = [
-    'Interactive element is embedded in __param__',
-    'Interactive elements are contained by links or buttons'
-  ];
-  return await getRuleResult(withItems, all, 'embAc', whats, 2);
+  const getBadWhat = element => {
+    // Get whether the embedding element is a link or a button.
+    const embedder = element.parentElement.closest('a, button');
+    const embedderWhat = embedder.tagName.toLowerCase() === 'a' ? 'a link' : 'a button';
+    // Return a violation description.
+    return `interactive element is embedded in ${embedderWhat}`;
+  };
+  const selector = ['a', 'button', 'input', 'select']
+  .map(tag => `a ${tag}, button ${tag}`)
+  .join(', ');
+  const whats = 'interactive elements are embedded in links or buttons';
+  return doTest(page, withItems, 'embAc', selector, whats, 2, null, getBadWhat.toString());
 };