testaro 58.3.5 → 59.0.1

package/CONTRIBUTING.md

@@ -114,8 +114,6 @@ More complex Testaro rules are implemented in JavaScript. Some rules are _simpli
 
 The `selector` value is a CSS selector that identifies candidate elements for violation reporting. What makes this rule simplifiable, instead of simple, is that these elements may or may not be determined to violate the rule. Each of the elements identified by the selector must be further analyzed by the pruner. The pruner takes a Playwright locator as its argument and returns `true` if it finds that the element located by the locator violates the rule, or `false` if not.
 
-The `isDestructive` property should be set to `true` if your pruner modifies the page. Any pruner that calls the `isOperable()` function from the `operable` module does so.
-
 ### Complex rules
 
 Even more complex Testaro rules require analysis that cannot fit into the simple or simplifiable category. You can begin with existing JavaScript rules, or the `data/template.js` file, as an example.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "58.3.5",
+  "version": "59.0.1",
   "description": "Run 1000 web accessibility tests from 11 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/testaro.js

@@ -1,5 +1,6 @@
 /*
   © 2023–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -129,7 +130,7 @@ const report = exports.report = async (withItems, all, ruleID, whats, ordinalSev
 // Performs a simplifiable test.
 exports.simplify = async (page, withItems, ruleData) => {
   const {
-    ruleID, selector, pruner, isDestructive, complaints, ordinalSeverity, summaryTagName
+    ruleID, selector, pruner, complaints, ordinalSeverity, summaryTagName
   } = ruleData;
   // Get an object with initialized violation locators and result as properties.
   const all = await init(100, page, selector);
@@ -149,16 +150,6 @@ exports.simplify = async (page, withItems, ruleData) => {
     complaints.summary
   ];
   const result = await report(withItems, all, ruleID, whats, ordinalSeverity, summaryTagName);
-  // If the pruner modifies the page:
-  if (isDestructive) {
-    // Reload the page.
-    try {
-      await page.reload({timeout: 15000});
-    }
-    catch(error) {
-      console.log('ERROR: page reload timed out');
-    }
-  }
   // Return the result.
   return result;
 };

package/run.js

@@ -214,10 +214,15 @@ const goTo = async (report, page, url, timeout, waitUntil) => {
 // Closes the current browser.
 const browserClose = async () => {
   if (browser) {
-    let contexts = browser.contexts();
-    for (const context of contexts) {
-      await context.close();
-      contexts = browser.contexts();
+    for (const context of browser.contexts()) {
+      try {
+        await context.close();
+      }
+      catch(error) {
+        console.log(
+          `ERROR trying to close context: ${error.message.slice(0, 200).replace(/\n.+/s, '')}`
+        );
+      }
     }
     await browser.close();
     browser = null;
@@ -1447,7 +1452,6 @@ exports.doJob = async (job, opts = {}) => {
       }
     });
     // Perform the acts and get a report.
-    console.log('Performing the job acts');
     report = await doActs(report, opts);
     // Add the end time and duration to the report.
     const endTime = new Date();

package/testaro/allCaps.js

@@ -1,5 +1,6 @@
 /*
   © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -64,7 +65,6 @@ exports.reporter = async (page, withItems) => {
         return transformStyle === 'uppercase' && elText.length > 7;
       }
     }),
-    isDestructive: false,
     complaints: {
       instance: 'Element contains all-capital text',
       summary: 'Elements contain all-capital text'

package/testaro/allSlanted.js

@@ -1,5 +1,6 @@
 /*
   © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -47,7 +48,6 @@ exports.reporter = async (page, withItems) => {
       const elText = el.textContent;
       return ['italic', 'oblique'].includes(elStyleDec.fontStyle) && elText.length > 39;
     }),
-    isDestructive: false,
     complaints: {
       instance: 'Element contains all-italic or all-oblique text',
       summary: 'Elements contain all-italic or all-oblique text'

package/testaro/buttonMenu.js

@@ -1,5 +1,6 @@
 /*
   © 2023–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -292,13 +293,6 @@ exports.reporter = async (page, withItems, trialKeySpecs = []) => {
       excerpt: ''
     });
   }
-  // Reload the page, because attributes of elements were modified.
-  try {
-    await page.reload({timeout: 15000});
-  }
-  catch(error) {
-    console.log('ERROR: page reload timed out');
-  }
   return {
     data,
     totals,

package/testaro/distortion.js

@@ -1,5 +1,6 @@
 /*
   © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -48,7 +49,6 @@ exports.reporter = async (page, withItems) => {
       return transform
       && ['matrix', 'perspective', 'rotate', 'scale', 'skew'].some(key => transform.includes(key));
     }),
-    isDestructive: false,
     complaints: {
       instance: 'Element distorts its text',
       summary: 'Elements distort their texts'

package/testaro/focAll.js

@@ -1,5 +1,6 @@
 /*
   © 2021–2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -77,13 +78,6 @@ exports.reporter = async page => {
     tabFocused,
     discrepancy: tabFocused - focusableCount
   };
-  // Reload the page, because properties were added to elements.
-  try {
-    await page.reload({timeout: 15000});
-  }
-  catch(error) {
-    console.log('ERROR: page reload timed out');
-  }
   const count = Math.abs(data.discrepancy);
   // Return the result.
   return {

package/testaro/focOp.js

@@ -1,5 +1,6 @@
 /*
   © 2021–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -70,12 +71,5 @@ exports.reporter = async (page, withItems) => {
     'Element is Tab-focusable but not operable', 'Elements are Tab-focusable but not operable'
   ];
   const result = await report(withItems, all, 'focOp', whats, 2);
-  // Reload the page, because isOperable() modified it.
-  try {
-    await page.reload({timeout: 15000});
-  }
-  catch(error) {
-    console.log('ERROR: page reload timed out');
-  }
   return result;
 };

package/testaro/hover.js

@@ -1,5 +1,6 @@
 /*
   © 2021–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -104,12 +105,5 @@ exports.reporter = async (page, withItems) => {
     'Hovering over the element __param__',
     'Hovering over elements adds elements to or subtracts elements from the page'
   ];
-  // Reload the page, because hovering may have caused content changes.
-  try {
-    await page.reload({timeout: 15000});
-  }
-  catch(error) {
-    console.log('ERROR: page reload timed out');
-  }
   return await report(withItems, all, 'hover', whats, 0);
 };

package/testaro/imageLink.js

@@ -40,7 +40,6 @@ exports.reporter = async (page, withItems) => {
         return /\.(?:png|jpe?g|gif|svg|webp|ico)(?:$|[?#])/i.test(href);
       });
     },
-    isDestructive: false,
     complaints: {
       instance: 'Link destination is an image file',
       summary: 'Links have image files as their destinations'

package/testaro/legendLoc.js

@@ -48,7 +48,6 @@ exports.reporter = async (page, withItems) => {
         return true;
       });
     },
-    isDestructive: false,
     complaints: {
       instance: 'Element is not the first child of a fieldset element',
       summary: 'legend elements are not the first children of fieldset elements'

package/testaro/linkTitle.js

@@ -1,5 +1,6 @@
 /*
   © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -48,7 +49,6 @@ exports.reporter = async (page, withItems) => {
       const title = await loc.getAttribute('title');
       return elData.excerpt.toLowerCase().includes(title.toLowerCase());
     },
-    isDestructive: false,
     complaints: {
       instance: 'Link has a title attribute that repeats link text content',
       summary: 'Links have title attributes that repeat link text contents'

package/testaro/linkUl.js

@@ -1,5 +1,6 @@
 /*
   © 2021–2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -59,7 +60,6 @@ exports.reporter = async (page, withItems) => {
         return await isInlineLink(loc);
       }
     },
-    isDestructive: false,
     complaints: {
       instance: 'Link is inline but has no underline',
       summary: 'Inline links are missing underlines'

package/testaro/nonTable.js

@@ -1,5 +1,6 @@
 /*
   © 2022–2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -80,7 +81,6 @@ exports.reporter = async (page, withItems) => {
         return true;
       }
     }),
-    isDestructive: false,
     complaints: {
       instance: 'Table is misused to arrange content',
       summary: 'Tables are misused to arrange content'

package/testaro/opFoc.js

@@ -1,5 +1,6 @@
 /*
   © 2023–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -71,12 +72,5 @@ exports.reporter = async (page, withItems) => {
     'Elements are operable but not Tab-focusable'
   ];
   const result = await report(withItems, all, 'opFoc', whats, 3);
-  // Reload the page, because isOperable() modified it.
-  try {
-    await page.reload({timeout: 15000});
-  }
-  catch(error) {
-    console.log('ERROR: page reload timed out');
-  }
   return result;
 };

package/testaro/optRoleSel.js

@@ -39,7 +39,6 @@ exports.reporter = async (page, withItems) => {
         return ! el.hasAttribute('aria-selected');
       });
     },
-    isDestructive: false,
     complaints: {
       instance: 'Element has an explicit option role but no aria-selected attribute',
       summary: 'Elements with explicit option roles have no aria-selected attributes'

package/testaro/tabNav.js

@@ -1,5 +1,6 @@
 /*
   © 2021–2024 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2025 Jonathan Robert Pool. All rights reserved.
 
   MIT License
 
@@ -454,13 +455,6 @@ exports.reporter = async (page, withItems) => {
   const tabLists = await page.$$('[role=tablist]:visible');
   if (tabLists.length) {
     await testTabLists(tabLists, withItems, page);
-    // Reload the page, because keyboard navigation may have triggered content changes.
-    try {
-      await page.reload({timeout: 15000});
-    }
-    catch(error) {
-      console.log('ERROR: page reload timed out');
-    }
   }
   // Get the totals of navigation errors, bad tabs, and bad tab lists.
   const totals = data.totals ? [

package/tests/testaro.js

@@ -32,6 +32,8 @@
 
 // Module to perform common operations.
 const {init, report} = require('../procs/testaro');
+// Function to launch a browser.
+const {launch} = require('../run');
 // Module to handle files.
 const fs = require('fs/promises');
 
@@ -59,23 +61,17 @@ const futureEvalRulesCleanRoom = {
 // when preparing clean-room submissions.
 const futureRules = new Set([]);
 const evalRules = {
-  altScheme: 'img elements with alt attributes having URLs as their entire values',
-  captionLoc: 'caption elements that are not first children of table elements',
-  datalistRef: 'elements with ambiguous or missing referenced datalist elements',
-  secHeading: 'headings that violate the logical level order in their sectioning containers',
-  textSem: 'semantically vague elements i, b, and/or small',
   adbID: 'elements with ambiguous or missing referenced descriptions',
-  imageLink: 'links with image files as their destinations',
-  legendLoc: 'legend elements that are not first children of fieldset elements',
-  optRoleSel: 'Non-option elements with option roles that have no aria-selected attributes',
-  phOnly: 'input elements with placeholders but no accessible names',
   allCaps: 'leaf elements with entirely upper-case text longer than 7 characters',
   allHidden: 'page that is entirely or mostly hidden',
   allSlanted: 'leaf elements with entirely italic or oblique text longer than 39 characters',
+  altScheme: 'img elements with alt attributes having URLs as their entire values',
   attVal: 'duplicate attribute values',
   autocomplete: 'name and email inputs without autocomplete attributes',
   bulk: 'large count of visible elements',
   buttonMenu: 'nonstandard keyboard navigation between items of button-controlled menus',
+  captionLoc: 'caption elements that are not first children of table elements',
+  datalistRef: 'elements with ambiguous or missing referenced datalist elements',
   distortion: 'distorted text',
   docType: 'document without a doctype property',
   dupAtt: 'elements with duplicate attributes',
@@ -89,7 +85,9 @@ const evalRules = {
   hover: 'hover-caused content changes',
   hovInd: 'hover indication nonstandard',
   hr: 'hr element instead of styles used for vertical segmentation',
+  imageLink: 'links with image files as their destinations',
   labClash: 'labeling inconsistencies',
+  legendLoc: 'legend elements that are not first children of fieldset elements',
   lineHeight: 'text with a line height less than 1.5 times its font size',
   linkAmb: 'links with identical texts but different destinations',
   linkExt: 'links that automatically open new windows',
@@ -101,13 +99,17 @@ const evalRules = {
   motion: 'motion without user request',
   nonTable: 'table elements used for layout',
   opFoc: 'operable elements that are not Tab-focusable',
+  optRoleSel: 'Non-option elements with option roles that have no aria-selected attributes',
+  phOnly: 'input elements with placeholders but no accessible names',
   pseudoP: 'adjacent br elements suspected of nonsemantically simulating p elements',
   radioSet: 'radio buttons not grouped into standard field sets',
   role: 'native-replacing explicit roles',
+  secHeading: 'headings that violate the logical level order in their sectioning containers',
   styleDiff: 'style inconsistencies',
   tabNav: 'nonstandard keyboard navigation between elements with the tab role',
   targetSmall: 'buttons, inputs, and non-inline links smaller than 44 pixels wide and high',
   targetTiny: 'buttons, inputs, and non-inline links smaller than 24 pixels wide and high',
+  textSem: 'semantically vague elements i, b, and/or small',
   titledEl: 'title attributes on inappropriate elements',
   zIndex: 'non-default Z indexes'
 };
@@ -117,6 +119,37 @@ const etcRules = {
   textNodes: 'data on specified text nodes',
   title: 'page title',
 };
+// Tests that modify the page.
+const contaminators = [
+  'buttonMenu',
+  'elements',
+  'focAll',
+  'focOp',
+  'focInd',
+  'hover',
+  'hovInd',
+  'motion',
+  'opFoc',
+  'tabNav',
+  'textNodes'
+];
+// Extraordinary time limits on rules.
+const slowTestLimits = {
+  allCaps: 10,
+  buttonMenu: 15,
+  distortion: 10,
+  docType: 10,
+  focAll: 10,
+  focVis: 10,
+  hover: 10,
+  hovInd: 10,
+  labClash: 10,
+  lineHeight: 10,
+  motion: 15,
+  opFoc: 10,
+  tabNav: 10,
+  textSem: 10
+};
 
 // ######## FUNCTIONS
 
@@ -148,6 +181,7 @@ const wait = ms => {
 };
 // Conducts and reports Testaro tests.
 exports.reporter = async (page, report, actIndex) => {
+  const url = await page.url();
   const act = report.acts[actIndex];
   const {args, stopOnFail, withItems} = act;
   const argRules = args ? Object.keys(args) : null;
@@ -178,18 +212,44 @@ exports.reporter = async (page, report, actIndex) => {
   ) {
     // Wait 1 second to prevent out-of-order logging with granular reporting.
     await wait(1000);
-    // For each rule invoked except future rules:
-    const calledRules = rules[0] === 'y'
+    let calledRules = rules[0] === 'y'
       ? rules.slice(1)
       : Object.keys(evalRules).filter(ruleID => ! rules.slice(1).includes(ruleID));
+    const calledContaminators = calledRules.filter(rule => contaminators.includes(rule)).sort();
+    const calledBenignRules = calledRules.filter(rule => ! contaminators.includes(rule)).sort();
     const testTimes = [];
-    for (const rule of calledRules.filter(rule => ! futureRules.has(rule))) {
+    let contaminatorsStarted = false;
+    // Starting with the noncontaminators, for each rule invoked:
+    for (const rule of calledBenignRules.concat(calledContaminators)) {
+      const pageClosed = page.isClosed();
+      const isContaminator = contaminators.includes(rule);
+      // If it is a contaminator other than the first one or the page has closed:
+      if (contaminatorsStarted || pageClosed) {
+        // If the page has closed:
+        if (pageClosed) {
+          // Report this.
+          console.log(`WARNING: Relaunching browser for test ${rule} after abnormal closure`);
+        }
+        // Replace the browser and the page and navigate to the target.
+        await launch(
+          report,
+          process.env.DEBUG === 'true',
+          Number.parseInt(process.env.WAITS) || 0,
+          report.browserID,
+          url
+        );
+        page = require('../run').page;
+      }
+      // If it is a contaminator, ensure that future tests use new browsers.
+      if (isContaminator) {
+        contaminatorsStarted = true;
+      }
       // Initialize an argument array.
       const ruleArgs = [page, withItems];
-      // If the rule is defined with JavaScript or JSON but not both:
       const ruleFileNames = await fs.readdir(`${__dirname}/../testaro`);
       const isJS = ruleFileNames.includes(`${rule}.js`);
       const isJSON = ruleFileNames.includes(`${rule}.json`);
+      // If the rule is defined with JavaScript or JSON but not both:
       if ((isJS || isJSON) && ! (isJS && isJSON)) {
         // If with JavaScript and it has extra arguments:
         if (isJS && argRules && argRules.includes(rule)) {
@@ -204,8 +264,10 @@ exports.reporter = async (page, report, actIndex) => {
         result[rule].what = what;
         const startTime = Date.now();
         try {
-          // Apply a 15-second time limit to the test. If it expires:
+          // Apply a time limit to the test.
+          const timeLimit = 1000 * (slowTestLimits[rule] ?? 5);
           let timeout;
+          // If the time limit expires during the test:
           const timer = new Promise(resolve => {
             timeout = setTimeout(() => {
               // Add data about the test, including its prevention, to the result.
@@ -216,24 +278,26 @@ exports.reporter = async (page, report, actIndex) => {
               result[rule].standardInstances = [];
               console.log(`ERROR: Test of testaro rule ${rule} timed out`);
               resolve({timedOut: true});
-            }, 15000);
+            }, timeLimit);
           });
+          // Perform the test, subject to the time limit.
           const ruleReport = isJS
             ? require(`../testaro/${rule}`).reporter(... ruleArgs)
             : jsonTest(rule, ruleArgs);
-          const timeoutReport = await Promise.race([timer, ruleReport]);
+          // Get the test result or a timeout result.
+          const ruleOrTimeoutReport = await Promise.race([timer, ruleReport]);
           clearTimeout(timeout);
-          // If the test was completed before the deadline:
-          if (! timeoutReport.timedOut) {
+          // If the test was completed:
+          if (! ruleOrTimeoutReport.timedOut) {
             // Add data from the test to the result.
             const endTime = Date.now();
             testTimes.push([rule, Math.round((endTime - startTime) / 1000)]);
-            Object.keys(timeoutReport).forEach(key => {
-              result[rule][key] = timeoutReport[key];
+            Object.keys(ruleOrTimeoutReport).forEach(key => {
+              result[rule][key] = ruleOrTimeoutReport[key];
             });
             result[rule].totals = result[rule].totals.map(total => Math.round(total));
             // If testing is to stop after a failure and the page failed the test:
-            if (stopOnFail && timeoutReport.totals.some(total => total)) {
+            if (stopOnFail && ruleOrTimeoutReport.totals.some(total => total)) {
               // Stop testing.
               break;
             }
@@ -241,7 +305,7 @@ exports.reporter = async (page, report, actIndex) => {
         }
         // If an error is thrown by the test:
         catch(error) {
-          // Report this.
+          // Report the error.
           data.rulePreventions.push(rule);
           data.rulePreventionMessages[rule] = error.message;
           console.log(`ERROR: Test of testaro rule ${rule} prevented (${error.message})`);
@@ -254,6 +318,7 @@ exports.reporter = async (page, report, actIndex) => {
         console.log(`ERROR: Rule ${rule} not validly defined`);
       }
     }
+    // Record the test times in descending order.
     testTimes.sort((a, b) => b[1] - a[1]).forEach(pair => {
       data.ruleTestTimes[pair[0]] = pair[1];
     });