testaro 45.0.4 → 45.0.6

package/README.md

@@ -875,7 +875,7 @@ The rationales motivating the Testaro-defined tests can be found in comments wit
 
 ### Abnormal termination
 
-On some occasions a test throws an error that cannot be handled with a `try`-`catch` structure. It has been observed, for example, that the `ibm` test does this when the page content, rather than the page URL, is given to `getCompliance()` and the target is `https://globalsolutions.org` or `https://monsido.com`.
+On some occasions a test throws an error that cannot be handled with a `try`-`catch` structure. It has been observed, for example, that the `ibm` test does this when the page content, rather than the page URL, is given to `getCompliance()` and the target is `https://globalsolutions.org`, `https://monsido.com`, or `https://www.ambetterhealth.com/`.
 
 Some tools take apparently infinite time to perform their tests on some pages. To handle such stalling, Testaro subjects most tools to time limits. Further testing will be required before it can be determined whether this time limitation is robust. As currently implemented (without child processes), it may allow tool testing processes to continue and to write indefinitely to the response.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "45.0.4",
+  "version": "45.0.6",
   "description": "Run 1000 web accessibility tests from 10 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/identify.js

@@ -85,12 +85,17 @@ const addIDs = async (locators, recipient) => {
 };
 // Sanitizes a tag name.
 const tagify = tagName => {
-  const lcTagName = tagName.toLowerCase();
-  const safeTagName = lcTagName.replace(/[^a-z0-9]/g, '');
-  if (safeTagName !== lcTagName) {
-    console.log(`ERROR: Tag name ${tagName} invalid`);
+  if (tagName) {
+    const lcTagName = tagName.toLowerCase();
+    const safeTagName = lcTagName.replace(/[^a-z0-9]/g, '');
+    if (safeTagName !== lcTagName) {
+      console.log(`ERROR on page: Tag name ${tagName} invalid; treating it as ${safeTagName}`);
+    }
+    return safeTagName;
+  }
+  else {
+    return '';
   }
-  return safeTagName;
 };
 // Returns the XPath and box ID of the element of a standard instance.
 exports.identify = async (instance, page) => {

package/tests/aslint.js

@@ -85,17 +85,6 @@ exports.reporter = async (page, report, actIndex, timeLimit) => {
         timeout: 1000 * timeLimit
       };
       await reportLoc.waitFor(waitOptions);
-      // const timeResult = await doBy(timeLimit, reportLoc, 'waitFor', [waitArg], 'aslint testing');
-      // console.log(`timeResult type is ${typeof timeResult}`);
-      // If the result attachment timed out:
-      /*
-      if (timeResult === 'timedOut') {
-        // Report this.
-        data.prevented = true;
-        data.error = 'Attachment of results to page by aslint timed out';
-        await page.close({runBeforeUnload: true});
-      }
-      */
     }
     catch(error) {
       const message = 'Attachment of test results to page failed';

package/tests/wave.js

@@ -58,57 +58,66 @@ exports.reporter = async (page, report, actIndex) => {
           // When they arrive:
           response.on('end', async () => {
             // Delete unnecessary properties.
-            const actResult = JSON.parse(rawReport);
-            const {categories, statistics} = actResult;
-            delete categories.feature;
-            delete categories.structure;
-            delete categories.aria;
-            // If rules were specified:
-            if (rules && rules.length) {
-              // For each WAVE rule category:
-              ['error', 'contrast', 'alert'].forEach(category => {
-                // If any violations were reported:
-                if (
-                  categories[category]
-                  && categories[category].items
-                  && Object.keys(categories[category].items).length
-                ) {
-                  // For each rule violated:
-                  Object.keys(categories[category].items).forEach(ruleID => {
-                    // If it was not a specified rule:
-                    if (! rules.includes(ruleID)) {
-                      // Decrease the category violation count by the count of its violations.
-                      categories[category].count -= categories[category].items[ruleID].count;
-                      // Remove its violations from the report.
-                      delete categories[category].items[ruleID];
-                    }
-                  });
-                }
+            try {
+              const actResult = JSON.parse(rawReport);
+              const {categories, statistics} = actResult;
+              delete categories.feature;
+              delete categories.structure;
+              delete categories.aria;
+              // If rules were specified:
+              if (rules && rules.length) {
+                // For each WAVE rule category:
+                ['error', 'contrast', 'alert'].forEach(category => {
+                  // If any violations were reported:
+                  if (
+                    categories[category]
+                    && categories[category].items
+                    && Object.keys(categories[category].items).length
+                  ) {
+                    // For each rule violated:
+                    Object.keys(categories[category].items).forEach(ruleID => {
+                      // If it was not a specified rule:
+                      if (! rules.includes(ruleID)) {
+                        // Decrease the category violation count by the count of its violations.
+                        categories[category].count -= categories[category].items[ruleID].count;
+                        // Remove its violations from the report.
+                        delete categories[category].items[ruleID];
+                      }
+                    });
+                  }
+                });
+              }
+              // Add WCAG information from the WAVE documentation.
+              const waveDocJSON = await fs.readFile('procs/wavedoc.json');
+              const waveDoc = JSON.parse(waveDocJSON);
+              Object.keys(categories).forEach(categoryName => {
+                const category = categories[categoryName];
+                const {items} = category;
+                Object.keys(items).forEach(issueName => {
+                  const issueDoc = waveDoc.find((issue => issue.name === issueName));
+                  const {guidelines} = issueDoc;
+                  items[issueName].wcag = guidelines;
+                });
               });
+              // Add important data to the result.
+              if (statistics) {
+                data.pageTitle = statistics.pagetitle || '';
+                data.pageURL = statistics.pageurl || '';
+                data.time = statistics.time || null;
+                data.creditsRemaining = statistics.creditsremaining || null;
+                data.allItemCount = statistics.allitemcount || null;
+                data.totalElements = statistics.totalelements || null;
+              }
+              // Return the result.
+              resolve(actResult);
             }
-            // Add WCAG information from the WAVE documentation.
-            const waveDocJSON = await fs.readFile('procs/wavedoc.json');
-            const waveDoc = JSON.parse(waveDocJSON);
-            Object.keys(categories).forEach(categoryName => {
-              const category = categories[categoryName];
-              const {items} = category;
-              Object.keys(items).forEach(issueName => {
-                const issueDoc = waveDoc.find((issue => issue.name === issueName));
-                const {guidelines} = issueDoc;
-                items[issueName].wcag = guidelines;
-              });
-            });
-            // Add important data to the result.
-            if (statistics) {
-              data.pageTitle = statistics.pagetitle || '';
-              data.pageURL = statistics.pageurl || '';
-              data.time = statistics.time || null;
-              data.creditsRemaining = statistics.creditsremaining || null;
-              data.allItemCount = statistics.allitemcount || null;
-              data.totalElements = statistics.totalelements || null;
-            }
-            // Return the result.
-            resolve(actResult);
+            catch(error) {
+              console.log(`ERROR parsing tool report: ${error.message}`);
+              console.log(`rawReport: ${rawReport}`);
+              data.prevented = true;
+              data.error = error.message;
+              resolve(result);
+            };
           });
         }
       );