testaro 36.6.2 → 37.0.0

package/README.md

@@ -190,16 +190,12 @@ Job properties:
 - `observe`: `true` or `false`, indicating whether tool and Testaro-rule invocations are to be reported to the server as they occur, so that the server can update a waiting client.
 - `timeStamp`: a string in `yymmddThhMM` format, specifying a date and time before which the job is not to be performed.
 - `creationTimeStamp`: a string in `yymmddThhMM` format, describing when the job was created.
-- `sources`: an object describing where the job came from:
-   - `script`: the ID of the script (as used by Testilo) from which the job was made, or an empty string if none.
-   - `batch` : the ID of the batch (as used by Testilo) from which the target of this job was drawn, or an empty string if none.
-   - `lastTarget`: whether the the target was drawn from a batch and is the last target in the batch.
-   - `target`: an object whose `id`, `what`, and `which` properties describe the target being tested by this job, or, if there was no batch, have empty strings as values.
-   - `requester`: the email address that can receive a notice of completion of the job, or an empty string if no notice is to be sent.
+- `sources`: an object describing where the job came from. It may be an empty object, or an object containing any properties required by the job creator.
 - `creationTimeStamp`: the date and time in `yymmddThhMM` format when the job was created.
 - `timeStamp`: the date and time in `yymmddThhMM` format before which the job is not to be assigned.
 - `sendReportTo`: the URL to which the report of the job is to be sent, or an empty string if the report is not to be sent to a server.
-- `mergeID`: a randomly generated alphanumeric ID for the process (such as a Testilo merger of a script and a batch) that created the job, or an empty string if none.
+
+The job creator may add other properties (such as `mergeID` in this example) to a job.
 
 ### Reports
 

package/netWatch.js

@@ -149,7 +149,7 @@ exports.netWatch = async (isForever, intervalInSeconds, isCertTolerant = true) =
                     resolve(true);
                   }
                   // Otherwise, if the server sent a valid job:
-                  else if (id && sources && sources.target && sources.target.which) {
+                  else if (id && sources) {
                     // Restart the cycle.
                     cycleIndex = -1;
                     // Prevent further watching, if unwanted.
@@ -159,9 +159,7 @@ exports.netWatch = async (isForever, intervalInSeconds, isCertTolerant = true) =
                     // If the job specifies a report destination:
                     if (sendReportTo) {
                       // Perform the job, adding result data to it.
-                      const target = sources.target.which;
                       console.log(`${logStart}job ${id} (${nowString()})`);
-                      console.log(`>> It will test ${target}`);
                       console.log(`>> It will send report to ${sendReportTo}`);
                       await doJob(contentObj);
                       let reportJSON = JSON.stringify(contentObj, null, 2);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "36.6.2",
+  "version": "37.0.0",
   "description": "Run 1000 web accessibility tests from 10 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/run.js

@@ -295,9 +295,6 @@ const isValidReport = report => {
     if (! sources || typeof sources !== 'object') {
       return 'Bad report sources';
     }
-    if (typeof sources.script !== 'string') {
-      return 'Bad source script';
-    }
     if (
       ! (creationTimeStamp && typeof creationTimeStamp === 'string' && dateOf(creationTimeStamp))
     ) {

package/testaro/headingAmb.js

@@ -1,5 +1,5 @@
 /*
-  © 2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2023–2024 CVS Health and/or one of its affiliates. All rights reserved.
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
@@ -49,12 +49,11 @@ exports.reporter = async (page, withItems) => {
     // For each heading:
     headings.forEach((heading, index) => {
       // Get its level.
-      const level = heading.level;
-      // If there are prior non-inferior headings and the last one has the same-level and text:
+      const level = heading.tagName[1];
       // Get the prior headings.
       const priorHeadings = headings.slice(0, index);
       // Get the non-inferior ones among them.
-      const nonInferiors = priorHeadings.filter(priorHeading => priorHeading.level <= level);
+      const nonInferiors = priorHeadings.filter(priorHeading => priorHeading.tagName[1] <= level);
       // If there are any:
       const nonInferiorCount = nonInferiors.length;
       if (nonInferiorCount) {
@@ -85,7 +84,7 @@ exports.reporter = async (page, withItems) => {
           // Add a standard instance.
           standardInstances.push({
             ruleID: 'headingAmb',
-            what: 'Heading has the same text as a prior same-level sibling heading',
+            what: 'Heading has the same text as the prior same-level sibling heading',
             ordinalSeverity: 1,
             tagName: elData.tagName,
             id: elData.id,
@@ -96,7 +95,7 @@ exports.reporter = async (page, withItems) => {
         // Otherwise, i.e. if it does not exist:
         else {
           // Report this.
-          console.log('ERROR: Reportedly same-text sibling heading not found');
+          console.log('ERROR: Reportedly same-text adjacent sibling heading not found');
         }
       }
     }
@@ -105,7 +104,7 @@ exports.reporter = async (page, withItems) => {
       // Add a summary instance.
       standardInstances.push({
         ruleID: 'headingAmb',
-        what: 'Sibling same-level headings have the same text',
+        what: 'Adjacent sibling same-level headings have the same text',
         ordinalSeverity: 1,
         count: totals[1],
         tagName: '',

package/testaro/styleDiff.js

@@ -1,5 +1,5 @@
 /*
-  © 2021–2023 CVS Health and/or one of its affiliates. All rights reserved.
+  © 2021–2024 CVS Health and/or one of its affiliates. All rights reserved.
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
@@ -273,6 +273,7 @@ exports.reporter = async (page, withItems) => {
         });
       }
     });
+    // Return the result.
     return {
       data,
       totals,

package/testaro/tabNav.js

@@ -26,6 +26,10 @@
   Standards are based on https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel.
 */
 
+// CONSTANTS
+
+const data = {};
+
 // FUNCTIONS
 
 // Returns the text associated with an element.
@@ -105,7 +109,7 @@ const allText = async (page, elementHandle) => await page.evaluate(element => {
   return textChain;
 }, elementHandle);
 // Returns the index of the focused tab in an array of tabs.
-const focusedTab = async tabs => await page.evaluate(tabs => {
+const focusedTab = async (tabs, page) => await page.evaluate(tabs => {
   const focus = document.activeElement;
   return tabs.indexOf(focus);
 }, tabs)
@@ -115,7 +119,7 @@ const focusedTab = async tabs => await page.evaluate(tabs => {
 });
 // Tests a navigation on a tab element.
 const testKey = async (
-  tabs, tabElement, keyName, keyProp, goodIndex, elementIsCorrect, itemData
+  tabs, tabElement, keyName, keyProp, goodIndex, elementIsCorrect, itemData, withItems, page
 ) => {
   let pressed = true;
   // Click the tab element, to make the focus on it effective.
@@ -153,7 +157,7 @@ const testKey = async (
     // If the refocus and keypress succeeded:
     if (pressed) {
       // Identify which tab element is now focused, if any.
-      const focusIndex = await focusedTab(tabs);
+      const focusIndex = await focusedTab(tabs, page);
       // If the focus is correct:
       if (focusIndex === goodIndex) {
         // Increment the counts of correct navigations and correct key navigations.
@@ -230,7 +234,7 @@ const arrowTarget = (startIndex, tabCount, orientation, direction) => {
   Recursively tests tablist tab elements (per
   https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel)
 */
-const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
+const testTabs = async (tabs, index, listOrientation, listIsCorrect, withItems, page) => {
   const tabCount = tabs.length;
   // If any tab elements remain to be tested:
   if (index < tabCount) {
@@ -263,7 +267,17 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
       }
     }
     // Test the element with each navigation key.
-    isCorrect = await testKey(tabs, currentTab, 'Tab', 'tab', -1, isCorrect, itemData);
+    isCorrect = await testKey(
+      tabs,
+      currentTab,
+      'Tab',
+      'tab',
+      -1,
+      isCorrect,
+      itemData,
+      withItems,
+      page
+    );
     isCorrect = await testKey(
       tabs,
       currentTab,
@@ -271,7 +285,9 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
       'left',
       arrowTarget(index, tabCount, listOrientation, 'left'),
       isCorrect,
-      itemData
+      itemData,
+      withItems,
+      page
     );
     isCorrect = await testKey(
       tabs,
@@ -280,7 +296,9 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
       'right',
       arrowTarget(index, tabCount, listOrientation, 'right'),
       isCorrect,
-      itemData
+      itemData,
+      withItems,
+      page
     );
     isCorrect = await testKey(
       tabs,
@@ -289,7 +307,9 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
       'up',
       arrowTarget(index, tabCount, listOrientation, 'up'),
       isCorrect,
-      itemData
+      itemData,
+      withItems,
+      page
     );
     isCorrect = await testKey(
       tabs,
@@ -298,11 +318,23 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
       'down',
       arrowTarget(index, tabCount, listOrientation, 'down'),
       isCorrect,
-      itemData
+      itemData,
+      withItems,
+      page
+    );
+    isCorrect = await testKey(
+      tabs,
+      currentTab,
+      'Home',
+      'home',
+      0,
+      isCorrect,
+      itemData,
+      withItems,
+      page
     );
-    isCorrect = await testKey(tabs, currentTab, 'Home', 'home', 0, isCorrect, itemData);
     isCorrect = await testKey(
-      tabs, currentTab, 'End', 'end', tabCount - 1, isCorrect, itemData
+      tabs, currentTab, 'End', 'end', tabCount - 1, isCorrect, itemData, withItems, page
     );
     // Update the tablist status (Node 14 does not support the ES 2021 &&= operator).
     listIsCorrect = listIsCorrect && isCorrect;
@@ -312,7 +344,7 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
       data.tabElements[isCorrect ? 'correct' : 'incorrect'].push(itemData);
     }
     // Process the next tab element.
-    return await testTabs(tabs, index + 1, listOrientation, listIsCorrect);
+    return await testTabs(tabs, index + 1, listOrientation, listIsCorrect, withItems, page);
   }
   // Otherwise, i.e. if all tab elements have been tested:
   else {
@@ -321,7 +353,7 @@ const testTabs = async (tabs, index, listOrientation, listIsCorrect) => {
   }
 };
 // Recursively tests tablists.
-const testTabLists = async tabLists => {
+const testTabLists = async (tabLists, withItems, page) => {
   // If any tablists remain to be tested:
   if (tabLists.length) {
     const firstTabList = tabLists[0];
@@ -341,12 +373,12 @@ const testTabLists = async tabLists => {
       // If the tablist contains at least 2 tab elements:
       if (tabs.length > 1) {
         // Test them.
-        const isCorrect = await testTabs(tabs, 0, orientation, true);
+        const isCorrect = await testTabs(tabs, 0, orientation, true, withItems, page);
         // Increment the data.
         data.totals.tabLists.total++;
         data.totals.tabLists[isCorrect ? 'correct' : 'incorrect']++;
         // Process the remaining tablists.
-        await testTabLists(tabLists.slice(1));
+        await testTabLists(tabLists.slice(1), withItems, page);
       }
     }
   }
@@ -354,62 +386,60 @@ const testTabLists = async tabLists => {
 // Tests tab-list navigation and reports results.
 exports.reporter = async (page, withItems) => {
   // Initialize the results.
-  const data = {
-    totals: {
-      navigations: {
-        all: {
+  data.totals = {
+    navigations: {
+      all: {
+        total: 0,
+        correct: 0,
+        incorrect: 0
+      },
+      specific: {
+        tab: {
+          total: 0,
+          correct: 0,
+          incorrect: 0
+        },
+        left: {
+          total: 0,
+          correct: 0,
+          incorrect: 0
+        },
+        right: {
           total: 0,
           correct: 0,
           incorrect: 0
         },
-        specific: {
-          tab: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          },
-          left: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          },
-          right: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          },
-          up: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          },
-          down: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          },
-          home: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          },
-          end: {
-            total: 0,
-            correct: 0,
-            incorrect: 0
-          }
+        up: {
+          total: 0,
+          correct: 0,
+          incorrect: 0
+        },
+        down: {
+          total: 0,
+          correct: 0,
+          incorrect: 0
+        },
+        home: {
+          total: 0,
+          correct: 0,
+          incorrect: 0
+        },
+        end: {
+          total: 0,
+          correct: 0,
+          incorrect: 0
         }
-      },
-      tabElements: {
-        total: 0,
-        correct: 0,
-        incorrect: 0
-      },
-      tabLists: {
-        total: 0,
-        correct: 0,
-        incorrect: 0
       }
+    },
+    tabElements: {
+      total: 0,
+      correct: 0,
+      incorrect: 0
+    },
+    tabLists: {
+      total: 0,
+      correct: 0,
+      incorrect: 0
     }
   };
   if (withItems) {
@@ -421,7 +451,7 @@ exports.reporter = async (page, withItems) => {
   // Get an array of element handles for the visible tablists.
   const tabLists = await page.$$('[role=tablist]:visible');
   if (tabLists.length) {
-    await testTabLists(tabLists);
+    await testTabLists(tabLists, withItems, page);
     // Reload the page, because keyboard navigation may have triggered content changes.
     try {
       await page.reload({timeout: 15000});
@@ -430,21 +460,24 @@ exports.reporter = async (page, withItems) => {
       console.log('ERROR: page reload timed out');
     }
   }
+  // Get the totals of navigation errors, bad tabs, and bad tab lists.
   const totals = data.totals ? [
     data.totals.navigations.all.incorrect,
     data.totals.tabElements.incorrect,
     data.totals.tabLists.incorrect,
     0
   ] : [];
+  // Initialize the standard instances.
   const standardInstances = [];
-  if (data.tabElements && data.tabElements.incorrect) {
+  // If itemization is required:
+  if (withItems) {
+    // For each bad tab:
     data.tabElements.incorrect.forEach(item => {
+      // Create a standard instance.
       standardInstances.push({
         ruleID: 'tabNav',
-        what:
-        `Tab responds nonstandardly to ${item.navigationErrors.join(', ')}`,
+        what: `Tab responds nonstandardly to ${item.navigationErrors.join(', ')}`,
         ordinalSeverity: 1,
-        count: item.navigationErrors.length,
         tagName: item.tagName,
         id: item.id,
         location: {
@@ -456,7 +489,9 @@ exports.reporter = async (page, withItems) => {
       });
     });
   }
+  // Otherwise, if navigation is not required and any navigations are bad:
   else if (data.totals.navigations.all.incorrect) {
+    // Create a standard instance.
     standardInstances.push({
       ruleID: 'tabNav',
       what: 'Tab lists have nonstandard navigation',
@@ -472,6 +507,7 @@ exports.reporter = async (page, withItems) => {
       excerpt: ''
     });
   }
+  // Return the result.
   return {
     data,
     totals,

package/validation/tests/jobs/adbID.json

@@ -131,10 +131,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/allCaps.json

@@ -136,10 +136,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/allHidden.json

@@ -309,10 +309,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/allSlanted.json

@@ -131,10 +131,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/altScheme.json

@@ -146,10 +146,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/attVal.json

@@ -182,10 +182,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/autocomplete.json

@@ -146,10 +146,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/bulk.json

@@ -81,10 +81,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/buttonMenu.json

@@ -189,7 +189,7 @@
         [
           "standardResult.instances.0.what",
           "i",
-          "respond nonstandardly to navigation"
+          "behave nonstandardly"
         ],
         [
           "standardResult.instances.0.ordinalSeverity",
@@ -209,10 +209,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/captionLoc.json

@@ -131,10 +131,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/datalistRef.json

@@ -121,10 +121,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/distortion.json

@@ -106,10 +106,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }

package/validation/tests/jobs/docType.json

@@ -86,10 +86,9 @@
     }
   ],
   "sources": {
-    "script": "",
-    "host": {},
-    "requester": ""
   },
-  "creationTime": "2013-05-28T12:00:00",
-  "timeStamp": "00000"
+  "standard": "only",
+  "observe": false,
+  "timeStamp": "240101T1500",
+  "creationTimeStamp": "240101T1200"
 }