testaro 26.0.0 → 26.2.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "testaro",
-  "version": "26.0.0",
-  "description": "Run 920 web accessibility tests from 9 tools and get a standardized report",
+  "version": "26.2.0",
+  "description": "Run 650 web accessibility tests from 8 tools and get a standardized report",
   "main": "index.js",
   "scripts": {
     "tests": "node validation/executors/tests",

package/procs/nav.js

@@ -39,8 +39,10 @@ let browser;
 const deSlash = string => string.endsWith('/') ? string.slice(0, -1) : string;
 // Visits a URL and returns the response of the server.
 const goTo = async (report, page, url, timeout, waitUntil) => {
+  // If the URL is a file path:
   if (url.startsWith('file://')) {
-    url = url.replace('file://', `file://${__dirname}/`);
+    // Make it absolute.
+    url = url.replace('file://', `file://${__dirname.replace(/procs$/, '')}`);
   }
   // Visit the URL.
   const startTime = Date.now();

package/procs/operable.js

@@ -63,7 +63,7 @@ exports.isOperable = async loc => {
       opHow.push('pointer cursor');
     }
     // If the element is clickable:
-    if (el.onClick) {
+    if (el.onclick) {
       // Add this to the operabilities.
       opHow.push('click listener');
     }

package/run.js

@@ -211,8 +211,20 @@ const isValidReport = report => {
     if (! ['chromium', 'webkit', 'firefox'].includes(acts[0].which)) {
       return 'Bad first act which';
     }
-    if (! acts[0].url || typeof acts[0].url !== 'string' || ! isURL(acts[0].url)) {
-      return 'First act url not a URL';
+    if (acts[0].type !== 'launch' || (
+      (
+        ! acts[0].url
+        || typeof acts[0].url !== 'string'
+        || ! isURL(acts[0].url)
+      )
+      && (
+        acts[1].type !== 'url'
+        || ! acts[1].which
+        || typeof acts[1].which !== 'string'
+        || ! isURL(acts[1].which)
+      )
+    )) {
+      return 'First or second act has no valid URL';
     }
     const invalidAct = acts.find(act => ! isValidAct(act));
     if (invalidAct) {
@@ -450,7 +462,16 @@ const doActs = async (report, actIndex, page) => {
     const act = acts[actIndex];
     // If it is valid:
     if (isValidAct(act)) {
-      const whichSuffix = act.which ? ` (${act.which})` : '';
+      let actInfo = '';
+      if (act.which) {
+        if (act.type === 'launch' && act.url) {
+          actInfo = `${act.which} to ${act.url}`;
+        }
+        else {
+          actInfo = act.which;
+        }
+      }
+      const whichSuffix = actInfo ? ` (${actInfo})` : '';
       console.log(`>>>> ${act.type}${whichSuffix}`);
       // Increment the count of acts performed.
       actCount++;

package/testaro/buttonMenu.js

@@ -27,68 +27,58 @@ const getAdjacentIndexWithWrap = (groupSize, startIndex, increment) => {
   return newIndex;
 };
 // Returns whether a key created the expected effective focus.
-const focusSuccess = async (miLocAll, priorIndex, key, isPseudo) => {
+const focusSuccess = async (miLocsDir, priorIndex, key, isPseudo) => {
   // Initialize the result.
   const result = {
     isOK: false,
     newFocIndex: null
   };
-  // Get the index of the effectively focused menu item.
-  const focData = await miLocAll.evaluateAll((elements, isPseudo) => {
-    // Get the currently focused element.
-    let focEl = document.activeElement;
-    // If the menu manages pseudofocus:
-    let miFocIndex;
-    if (isPseudo) {
-      // Get the index of the effectively focused menu item.
-      const pseudoFocID = focEl.getAttribute('aria-activedescendant');
-      if (pseudoFocID) {
-        miFocIndex = elements.map(element => element.id).indexOf(pseudoFocID);
+  // For each of the menu items directly descending from the menu:
+  for (const miLocDir of miLocsDir) {
+    // Get whether it is effectively focused.
+    const hasFocus = await miLocDir.evaluate((el, isPseudo) => {
+      if (isPseudo) {
+        const effectiveID = document.activeElement.getAttribute('aria-activeDescendant');
+        if (effectiveID) {
+          const effectiveEl = document.getElementById(effectiveID);
+          return effectiveEl === el;
+        }
+        else {
+          return false;
+        }
       }
-    }
-    // Otherwise, i.e. if the menu manages true focus:
-    else {
-      // Get the index of the focused menu item.
-      miFocIndex = elements.indexOf(focEl);
-    }
-    // If an effectively focused menu item was identified:
-    if (miFocIndex > -1) {
-      // Return data on the menu items.
-      return {
-        count: elements.length,
-        miFocIndex
-      };
-    }
-    // Otherwise, i.e. if no effectively focused menu item was identified:
-    else {
-      // Return this.
-      return null;
-    }
-  }, isPseudo);
-  // If data on the menu items were obtained:
-  if (focData) {
-    // Get whether the effective focus is as expected and update the result.
-    if (key === 'Home' && focData.miFocIndex === 0) {
-      result.isOK = true;
-      result.newFocIndex = 0;
-    }
-    else if (key === 'End' && focData.miFocIndex === focData.count - 1) {
-      result.isOK = true;
-      result.newFocIndex = focData.count - 1;
-    }
-    else if (['ArrowLeft', 'ArrowUp'].includes(key)) {
-      const expectedIndex = getAdjacentIndexWithWrap(focData.count, priorIndex, -1);
-      if (focData.miFocIndex === expectedIndex) {
+      else {
+        return document.activeElement === el;
+      }
+    }, isPseudo);
+    // If it is:
+    if (hasFocus) {
+      // Get whether the effective focus is as expected and update the result.
+      const miFocIndex = miLocsDir.indexOf(miLocDir);
+      const miCount = miLocsDir.length;
+      if (key === 'Home' && miFocIndex === 0) {
         result.isOK = true;
-        result.newFocIndex = expectedIndex;
+        result.newFocIndex = 0;
       }
-    }
-    else if (['ArrowRight', 'ArrowDown'].includes(key)) {
-      const expectedIndex = getAdjacentIndexWithWrap(focData.count, priorIndex, 1);
-      if (focData.miFocIndex === expectedIndex) {
+      else if (key === 'End' && miFocIndex === miCount - 1) {
         result.isOK = true;
-        result.newFocIndex = expectedIndex;
+        result.newFocIndex = miCount - 1;
       }
+      else if (['ArrowLeft', 'ArrowUp'].includes(key)) {
+        const expectedIndex = getAdjacentIndexWithWrap(miCount, priorIndex, -1);
+        if (miFocIndex === expectedIndex) {
+          result.isOK = true;
+          result.newFocIndex = expectedIndex;
+        }
+      }
+      else if (['ArrowRight', 'ArrowDown'].includes(key)) {
+        const expectedIndex = getAdjacentIndexWithWrap(miCount, priorIndex, 1);
+        if (miFocIndex === expectedIndex) {
+          result.isOK = true;
+          result.newFocIndex = expectedIndex;
+        }
+      }
+      break;
     }
   }
   // Return the result.
@@ -139,13 +129,21 @@ exports.reporter = async (page, withItems, trialKeySpecs = []) => {
         });
         // If they were obtained:
         if (extraData) {
-          // Get locators for its direct menu items.
+          // Get locators for its descendant non-menu menu items.
           const miLocAll = menuLoc.locator(
-            ':scope [role=menuitem]:not([role=menu] [role=menuitem]):not([role=menubar] [role=menuitem])'
+            '[role=menuitem]:not([role=menu]), [role=menuitem]:not([role=menubar])'
           );
+          // Get which of them are direct descendants.
+          const areDirect = await miLocAll.evaluateAll((els, menuID) => {
+            return els.map(el => {
+              const itsMenu = el.closest('[role=menu], [role=menubar]');
+              return itsMenu.id && itsMenu.id === menuID;
+            });
+          }, menuID);
           const miLocsAll = await miLocAll.all();
+          const miLocsDir = miLocsAll.filter((loc, index) => areDirect[index]);
           // If there are at least 2 of them:
-          if (miLocsAll.length > 1) {
+          if (miLocsDir.length > 1) {
             // Ensure that the menu is collapsed.
             await menuLoc.evaluate(element => {
               element.setAttribute('aria-expanded', false);
@@ -193,7 +191,7 @@ exports.reporter = async (page, withItems, trialKeySpecs = []) => {
               // Press it.
               await page.keyboard.press(key);
               // Get whether the expected focus occurred.
-              const focData = await focusSuccess(miLocAll, focIndex, key, extraData.isPseudo);
+              const focData = await focusSuccess(miLocsDir, focIndex, key, extraData.isPseudo);
               // If so:
               if (focData.isOK) {
                 // Update the index of the effective focus.

package/testaro/hover.js

@@ -1,10 +1,11 @@
 /*
   hover
   This test reports unexpected impacts of hovering. The elements that are subjected to hovering
-  (called “triggers”) include all the elements that have aria-controls, aria-expanded,
-  onmouseenter, or onmouseover' attributes and a sample of all visible elements in the body. If
-  hovering over an element results in an increase or decrease in the total count of visible
-  elements in the body, the rule is considered violated.
+  (called “triggers”) include all the elements that have ARIA attributes associated with control
+  over the visibility of other elements and all the elements that have onmouseenter or
+  onmouseover attributes, as well as a sample of all visible elements in the body. If hovering over
+  an element results in an increase or decrease in the total count of visible elements in the body,
+  the rule is considered violated.
 */
 
 // ########## IMPORTS
@@ -17,11 +18,29 @@ const {init, report} = require('../procs/testaro');
 // Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
   // Initialize the locators and result.
-  const all = await init(
-    page, 'body [aria-controls], body [aria-expanded], body [onmouseenter], body [onmouseover]'
+  const allTrigger = await init(
+    page, '[aria-controls], [aria-expanded], [aria-haspopup], [onmouseenter], [onmouseover]'
   );
-  const miscAll = await init(page, 'body *:visible');
-  all.allLocs.push(... miscAll.allLocs.slice(0, - all.allLocs.length));
+  const allNonTrigger = await init(
+    page,
+    'body *:not([aria-controls]):not([aria-expanded]):not([aria-haspopup]):not([onmouseenter]):not([onmouseover])'
+  );
+  const populationSize
+    = allTrigger.result.data.populationSize + allNonTrigger.result.data.populationSize;
+  const sampleSize = allTrigger.result.data.sampleSize + allNonTrigger.result.data.sampleSize;
+  const all = {
+    allLocs: allTrigger.allLocs.concat(allNonTrigger.allLocs),
+    locs: [],
+    result: {
+      data: {
+        populationSize,
+        sampleSize,
+        populationRatio: sampleSize ? populationSize / sampleSize : null
+      },
+      totals: [0, 0, 0, 0],
+      standardInstances: []
+    }
+  };
   // For each locator:
   for (const loc of all.allLocs) {
     // Get how many elements are added or subtracted when the element is hovered over.
@@ -54,5 +73,12 @@ exports.reporter = async (page, withItems) => {
     'Hovering over the element __param__',
     'Hovering over elements adds elements to or subtracts elements from the page'
   ];
+  // Reload the page.
+  try {
+    await page.reload({timeout: 15000});
+  }
+  catch(error) {
+    console.log('ERROR: page reload timed out');
+  }
   return await report(withItems, all, 'hover', whats, 0);
 };

package/testaro/linkTo.js

@@ -15,6 +15,6 @@ exports.reporter = async (page, withItems) => {
   const all = await init(page, 'a:not([href]):visible');
   all.locs = all.allLocs;
   // Populate and return the result.
-  const whats = ['Link has no href attribute', 'inks are missing href attributes'];
-  return await report(withItems, all, 'linkTo', whats, 2);
+  const whats = ['Link has no href attribute', 'Links are missing href attributes'];
+  return await report(withItems, all, 'linkTo', whats, 2, 'A');
 };

package/validation/tests/jobs/allCaps.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/allCaps/index.html",
+      "url": "file://validation/tests/targets/allCaps/index.html",
       "what": "page with various letter cases"
     },
     {

package/validation/tests/jobs/allHidden.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/allHidden/good.html",
+      "url": "file://validation/tests/targets/allHidden/good.html",
       "what": "page with nothing hidden"
     },
     {
@@ -53,7 +49,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/noBody.html",
+      "which": "file://validation/tests/targets/allHidden/noBody.html",
       "what": "page with no body"
     },
     {
@@ -90,7 +86,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/noMain.html",
+      "which": "file://validation/tests/targets/allHidden/noMain.html",
       "what": "page with no main landmark"
     },
     {
@@ -128,7 +124,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/hiddenMain.html",
+      "which": "file://validation/tests/targets/allHidden/hiddenMain.html",
       "what": "page with a hidden main landmark"
     },
     {
@@ -171,7 +167,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/visHiddenMain.html",
+      "which": "file://validation/tests/targets/allHidden/visHiddenMain.html",
       "what": "page with a visually hidden main landmark"
     },
     {
@@ -209,7 +205,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/ariaHiddenBody.html",
+      "which": "file://validation/tests/targets/allHidden/ariaHiddenBody.html",
       "what": "page with an ARIA-hidden body"
     },
     {
@@ -242,7 +238,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/mixedHidden.html",
+      "which": "file://validation/tests/targets/allHidden/mixedHidden.html",
       "what": "page with mixed hidden states"
     },
     {
@@ -275,7 +271,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/allHidden/noneDoc.html",
+      "which": "file://validation/tests/targets/allHidden/noneDoc.html",
       "what": "page with none as its display property"
     },
     {

package/validation/tests/jobs/allSlanted.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/allSlanted/index.html",
+      "url": "file://validation/tests/targets/allSlanted/index.html",
       "what": "page with various slantednesses"
     },
     {

package/validation/tests/jobs/attVal.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/attVal/good.html",
+      "url": "file://validation/tests/targets/attVal/good.html",
       "what": "page with permitted attribute values"
     },
     {
@@ -66,7 +62,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/attVal/bad.html",
+      "which": "file://validation/tests/targets/attVal/bad.html",
       "what": "page with illicit attribute values"
     },
     {

package/validation/tests/jobs/autocomplete.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/autocomplete/good.html",
+      "url": "file://validation/tests/targets/autocomplete/good.html",
       "what": "page with correct autocomplete attributes"
     },
     {
@@ -60,7 +56,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/autocomplete/bad.html",
+      "which": "file://validation/tests/targets/autocomplete/bad.html",
       "what": "page with incorrect autocomplete attributes"
     },
     {

package/validation/tests/jobs/bulk.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/bulk/good.html",
+      "url": "file://validation/tests/targets/bulk/good.html",
       "what": "small page"
     },
     {
@@ -38,7 +34,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/bulk/bad.html",
+      "which": "file://validation/tests/targets/bulk/bad.html",
       "what": "large page"
     },
     {
@@ -75,11 +71,6 @@
           "standardResult.instances.0.ordinalSeverity",
           "=",
           0
-        ],
-        [
-          "standardResult.instances.0.count",
-          "=",
-          1
         ]
       ],
       "withItems": true,

package/validation/tests/jobs/buttonMenu.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/buttonMenu/good.html",
+      "url": "file://validation/tests/targets/buttonMenu/good.html",
       "what": "page with standard menu navigation"
     },
     {
@@ -43,7 +39,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/menuNav/bad.html",
+      "which": "file://validation/tests/targets/buttonMenu/bad.html",
       "what": "page with deviant menu navigation"
     },
     {

package/validation/tests/jobs/distortion.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/distortion/index.html",
+      "url": "file://validation/tests/targets/distortion/index.html",
       "what": "page with distorted text"
     },
     {

package/validation/tests/jobs/docType.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/docType/good.html",
+      "url": "file://validation/tests/targets/docType/good.html",
       "what": "page with doctype"
     },
     {
@@ -38,7 +34,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/docType/bad.html",
+      "which": "file://validation/tests/targets/docType/bad.html",
       "what": "page without doctype"
     },
     {

package/validation/tests/jobs/dupAtt.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/dupAtt/good.html",
+      "url": "file://validation/tests/targets/dupAtt/good.html",
       "what": "page without duplicate attributes"
     },
     {
@@ -38,7 +34,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/dupAtt/bad.html",
+      "which": "file://validation/tests/targets/dupAtt/bad.html",
       "what": "page with duplicate attributes"
     },
     {

package/validation/tests/jobs/elements.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/elements/index.html",
+      "url": "file://validation/tests/targets/elements/index.html",
       "what": "page with a shadow root"
     },
     {

package/validation/tests/jobs/embAc.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/embAc/good.html",
+      "url": "file://validation/tests/targets/embAc/good.html",
       "what": "page without embedding in links or buttons"
     },
     {
@@ -38,7 +34,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/embAc/bad.html",
+      "which": "file://validation/tests/targets/embAc/bad.html",
       "what": "page with embeddings in links and buttons"
     },
     {

package/validation/tests/jobs/filter.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/filter/good.html",
+      "url": "file://validation/tests/targets/filter/good.html",
       "what": "page with no filter styles"
     },
     {
@@ -38,7 +34,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/filter/bad.html",
+      "which": "file://validation/tests/targets/filter/bad.html",
       "what": "page with filter styles"
     },
     {

package/validation/tests/jobs/focAll.json

@@ -7,11 +7,7 @@
     {
       "type": "launch",
       "which": "chromium",
-      "what": "usual browser"
-    },
-    {
-      "type": "url",
-      "which": "__targets__/focAll/good.html",
+      "url": "file://validation/tests/targets/focAll/good.html",
       "what": "fully Tab-focusable page"
     },
     {
@@ -38,7 +34,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/focAll/less.html",
+      "which": "file://validation/tests/targets/focAll/less.html",
       "what": "partly Tab-focusable page"
     },
     {
@@ -85,7 +81,7 @@
     },
     {
       "type": "url",
-      "which": "__targets__/focAll/more.html",
+      "which": "file://validation/tests/targets/focAll/more.html",
       "what": "page with added Tab-focusability"
     },
     {