testaro 21.0.0 → 23.0.0

package/testaro/bulk.js

@@ -19,15 +19,18 @@ exports.reporter = async page => {
   const visiblesLoc = await page.locator('body :visible');
   const visibleLocs = await visiblesLoc.all();
   data.visibleElements = visibleLocs.length;
-  const count = Math.round(data.visibleElements / 400);
+  const severity = Math.min(4, Math.round(data.visibleElements / 400));
+  const totals = [0, 0, 0, 0];
+  if (severity) {
+    totals[severity - 1] = 1;
+  }
   return {
     data,
-    totals: [count, 0, 0, 0],
+    totals,
     standardInstances: data.visibleElements < 200 ? [] : [{
       ruleID: 'bulk',
       what: 'Page contains a large number of visible elements',
-      count,
-      ordinalSeverity: 0,
+      ordinalSeverity: severity - 1,
       tagName: 'HTML',
       id: '',
       location: {

package/testaro/hover.js

@@ -2,7 +2,7 @@
   hover
   This test reports unexpected impacts of hovering on the visible page. Impacts are measured by
   pixel changes outside the hovered element and by unhoverability.
-  
+
   The elements that are subjected to hovering (called “triggers”) are the Playwright-visible
   elements that have 'A', 'BUTTON', or (if not with role=menuitem) 'LI' tag names or have
   'onmouseenter' or 'onmouseover' attributes.
@@ -24,8 +24,8 @@
   action on the location where the center of the element is, rather than some other element with a
   higher zIndex value in the same location being the target.
 
-  WARNING: This test uses the Playwright page.screenshot method, which is not implemented for the
-  firefox browser type.
+  WARNING: This test uses the procs/visChange module. See the warning in that module about browser
+  types.
 */
 
 // IMPORTS
@@ -54,7 +54,7 @@ exports.reporter = async (page, withItems, sampleSize = 20) => {
   const psRatio = Math.max(1, locsAll.length / sampleSize);
   // Get a sample of the triggers.
   const sampleIndexes = getSample(locsAll, sampleSize);
-  const sample = locsAll.filter((loc, index) => sampleIndexes.includes(index));
+  const sample = sampleIndexes.map(index => locsAll[index]);
   // For each trigger in the sample:
   for (const loc of sample) {
     // Hover over it and get the fractional pixel change.

package/testaro/motion.js

@@ -7,9 +7,9 @@
   test compares two screen shots of the viewport 2 seconds and 6 seconds after page load. It
   reports a rule violation if any pixels change. The larger the change fraction, the greater the
   ordinal severity.
-  
-  WARNING: This test uses the Playwright page.screenshot method, which is not implemented for the
-  firefox browser type.
+
+  WARNING: This test uses the procs/visChange module. See the warning in that module about browser
+  types.
 */
 
 // IMPORTS

package/tests/testaro.js

@@ -1,9 +1,9 @@
 /*
   testaro
-  This test implements the Testaro evaluative ruleset for accessibility.
+  This test implements the Testaro evaluative rules.
 */
 
-// CONSTANTS
+// ######## CONSTANTS
 
 const evalRules = {
   allCaps: 'leaf elements with entirely upper-case text longer than 7 characters',
@@ -54,7 +54,7 @@ const etcRules = {
 
 // FUNCTIONS
 
-// Conducts and reports a Testaro test.
+// Conducts and reports Testaro tests.
 exports.reporter = async (page, options) => {
   const {withItems, stopOnFail, args} = options;
   const argRules = args ? Object.keys(args) : null;
@@ -62,7 +62,8 @@ exports.reporter = async (page, options) => {
   // Initialize the data.
   const data = {
     rules: {},
-    preventions: []
+    preventions: [],
+    testTimes: {}
   };
   // If the rule specification is valid:
   if (
@@ -71,10 +72,11 @@ exports.reporter = async (page, options) => {
     && rules.slice(1).every(rule => evalRules[rule] || etcRules[rule])
   ) {
     // For each rule invoked:
-    const realRules = rules[0] === 'y'
+    const calledRules = rules[0] === 'y'
       ? rules.slice(1)
       : Object.keys(evalRules).filter(ruleID => ! rules.slice(1).includes(ruleID));
-    for (const rule of realRules) {
+    const testTimes = [];
+    for (const rule of calledRules) {
       // Initialize an argument array.
       const ruleArgs = [page, withItems];
       // If the rule has extra arguments:
@@ -90,12 +92,20 @@ exports.reporter = async (page, options) => {
       data.rules[rule].what = what;
       console.log(`>>>>>> ${rule} (${what})`);
       try {
-        const report = await require(`../testaro/${rule}`).reporter(... ruleArgs);
-        Object.keys(report).forEach(key => {
-          data.rules[rule][key] = report[key];
+        const startTime = Date.now();
+        const ruleReport = await require(`../testaro/${rule}`).reporter(... ruleArgs);
+        // Add data from the test to the result.
+        const endTime = Date.now();
+        testTimes.push([rule, Math.round((endTime - startTime) / 1000)]);
+        Object.keys(ruleReport).forEach(key => {
+          data.rules[rule][key] = ruleReport[key];
+          data.rules[rule].totals = data.rules[rule].totals.map(total => Math.round(total));
+          if (ruleReport.prevented) {
+            data.preventions.push(rule);
+          }
         });
         // If testing is to stop after a failure and the page failed the test:
-        if (stopOnFail && report.totals.some(total => total)) {
+        if (stopOnFail && ruleReport.totals.some(total => total)) {
           // Stop testing.
           break;
         }
@@ -107,6 +117,9 @@ exports.reporter = async (page, options) => {
         console.log(`ERROR: Test of testaro rule ${rule} prevented (${error.message})`);
       }
     }
+    testTimes.sort((a, b) => b[1] - a[1]).forEach(pair => {
+      data.testTimes[pair[0]] = pair[1];
+    });
   }
   // Otherwise, i.e. if the rule specification is invalid:
   else {