testaro 18.7.0 → 18.9.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "testaro",
-  "version": "18.7.0",
+  "version": "18.9.0",
   "description": "Run 920 web accessibility tests from 9 tools and get a standardized report",
   "main": "index.js",
   "scripts": {

package/procs/isInlineLink.js

@@ -7,17 +7,14 @@
 exports.isInlineLink = async loc => await loc.evaluate(element => {
   // Initialize the link as inline.
   let result = true;
-  console.log('Initialized as inline');
   // If it is in a list item in a list of at least 2 links:
   const listAncestor = element.closest('ul, ol');
   if (listAncestor) {
-    console.log('Has a list ancestor');
     if (listAncestor.children.length > 1 && Array.from(listAncestor.children).every(child => {
       const isValidListItem = child.tagName === 'LI';
       const has1Link = child.querySelectorAll('a').length === 1;
       return isValidListItem && has1Link;
     })) {
-      console.log('List is pure');
       // If the list text is entirely link text:
       const listText = listAncestor.textContent.replace(/\s/g, '');
       let linkTextRaw = '';
@@ -27,7 +24,6 @@ exports.isInlineLink = async loc => await loc.evaluate(element => {
       const linkText = linkTextRaw.replace(/\s/g, '');
       console.log(linkText);
       if (listText === linkText && listText.length) {
-        console.log('No extraneous text, so non-inline');
         // Reclassify the link as non-inline.
         result = false;
       }

package/testaro/embAc.js

@@ -8,59 +8,37 @@
 
 // ########## IMPORTS
 
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Get locators for all misembedded elements.
-  const loc = page.locator(
-    'a a, a button, a input, a select, button a, button button, button input, button select'
+  // Initialize the locators and result.
+  const all = await init(
+    page, 'a a, a button, a input, a select, button a, button button, button input, button select'
   );
-  const locs = await loc.all();
-  // Initialize the result.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
   // For each locator:
-  for (const loc of locs) {
-    // Get data on its element.
-    const parentTagName = await loc.evaluate(element => element.parentElement.tagName);
-    const elData = await getLocatorData(loc);
-    // Add data to the standard result.
-    totals[2]++;
-    if (withItems) {
-      standardInstances.push({
-        ruleID: 'embAc',
-        what: `Interactive element is embedded in a ${parentTagName === 'A' ? 'link' : 'button'}`,
-        ordinalSeverity: 2,
-        tagName: elData.tagName,
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
-    }
-  };
-  if (! withItems) {
-    standardInstances.push({
-      ruleID: 'embAc',
-      what: 'Interactive elements are contained by links or buttons',
-      ordinalSeverity: 2,
-      count: totals[2],
-      tagName: '',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
+  for (const loc of all.allLocs) {
+    // Get whether its embedder is a link or a button.
+    const embedderTagName = await loc.evaluate(element => {
+      const embedder = element.parentElement.closest('a, button');
+      return embedder ? embedder.tagName : '';
     });
+    let param = 'a link or button';
+    if (embedderTagName === 'A') {
+      param = 'a link';
+    }
+    else if (embedderTagName === 'BUTTON') {
+      param = 'a button';
+    }
+    all.locs.push([loc, param]);
   }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = [
+    'Interactive element is embedded in __param__',
+    'Interactive elements are contained by links or buttons'
+  ];
+  return await report(withItems, all, 'embAc', whats, 2);
 };

package/testaro/filter.js

@@ -8,95 +8,29 @@
 
 // ########## IMPORTS
 
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Get locators for all elements in the body.
-  const locAll = page.locator('body *');
-  const locsAll = await locAll.all();
-  // Initialize the standard results.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Initialize the instance locators.
-  const locs = [];
+  // Initialize the locators and result.
+  const all = await init(page, 'body *');
   // For each locator:
-  for (const loc of locsAll) {
-    // If it has a filter style:
-    const hasFilter = await loc.evaluate(element => {
-      const styleDec = window.getComputedStyle(element);
+  for (const loc of all.allLocs) {
+    // Get whether its element violates the rule.
+    const isBad = await loc.evaluate(el => {
+      const styleDec = window.getComputedStyle(el);
       return styleDec.filter !== 'none';
     });
-    if (hasFilter) {
-      // Add it to the instance locators.
-      locs.push(loc);
+    // If it does:
+    if (isBad) {
+      // Add the locator to the array of violators.
+      all.locs.push(loc);
     }
   }
-  // For each instance locator:
-  for (const loc of locs) {
-    // Get data on its element.
-    const impact = await loc.evaluate(element => element.querySelectorAll('*').length);
-    const elData = await getLocatorData(loc);
-    // Add to the standard result.
-    totals[2]++;
-    totals[1] += impact;
-    // If itemization is required:
-    if (withItems) {
-      // Add a standard instance for the element.
-      standardInstances.push({
-        ruleID: 'filter',
-        what: `Element has a filter style; impacted element count: ${impact}`,
-        ordinalSeverity: 2,
-        tagName: elData.tagName,
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
-    }
-  }
-  // If itemization is not required and there are any instances:
-  if (! withItems && totals[2]) {
-    // Adda summary instance:
-    standardInstances.push({
-      ruleID: 'filter',
-      what: 'Elements have filter styles',
-      ordinalSeverity: 2,
-      count: totals[2],
-      tagName: '',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-    // If any impact occurred:
-    if (totals[1]) {
-      // Add a summary instance.
-      standardInstances.push({
-        ruleID: 'filter',
-        what: 'Elements are impacted by elements with filter styles',
-        ordinalSeverity: 1,
-        count: totals[1],
-        tagName: '',
-        id: '',
-        location: {
-          doc: '',
-          type: '',
-          spec: ''
-        },
-        excerpt: ''
-      });
-    }
-  }
-  // Return the result.
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = ['Element has a filter style', 'Elements have filter styles'];
+  return await report(withItems, all, 'filter', whats, 2);
 };

package/testaro/focVis.js

@@ -6,88 +6,43 @@
 
 // ########## IMPORTS
 
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Get a locator for the initially visible links.
-  const locAll = page.locator('a:visible');
-  const locsAll = await locAll.all();
-  // Get locators for those that are off the display when focused.
-  const locs = [];
-  for (const loc of locsAll) {
-    const isOff = await loc.evaluate(element => {
-      const isAbove = element.offsetTop + element.offsetHeight <= 0;
-      const isLeft = element.offsetLeft + element.offsetWidth <= 0;
-      const isOff = isAbove || isLeft;
-      return isOff;
+  // Initialize the locators and result.
+  const all = await init(page, 'a:visible');
+  // For each locator:
+  for (const loc of all.allLocs) {
+    // Get how its element violates the rule, if it does.
+    const isBad = await loc.evaluate(el => {
+      const isAbove = el.offsetTop + el.offsetHeight <= 0;
+      const isLeft = el.offsetLeft + el.offsetWidth <= 0;
+      return [isAbove, isLeft];
     });
-    if (isOff) {
-      locs.push(loc);
-    }
-  }
-  // Initialize the standard result.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // For each off-display link:
-  for (const loc of locs) {
-    // Get data on it.
-    const elData = await getLocatorData(loc);
-    // Add to the totals.
-    totals[2]++;
-    if (withItems) {
-      let where;
-      if (elData.location.type === 'selector') {
-        where = 'above or to the left of';
+    // If it does:
+    if (isBad[0] || isBad[1]) {
+      // Add the locator to the array of violators.
+      let param;
+      if (isBad[0] && isBad[1]) {
+        param = 'above and to the left of';
+      }
+      else if (isBad[0]) {
+        param = 'above';
       }
       else {
-        const isLeft = elData.location.spec.x < 0;
-        const isAbove = elData.location.spec.y < 0;
-        if (isLeft && isAbove) {
-          where = 'above and to the left of';
-        }
-        else if (isLeft) {
-          where = 'to the left of';
-        }
-        else if (isAbove) {
-          where = 'above';
-        }
-        else {
-          where = 'possibly above or to the left of';
-        }
+        param = 'to the left of';
       }
-      standardInstances.push({
-        ruleID: 'focVis',
-        what: `Visible link is ${where} the display`,
-        ordinalSeverity: 2,
-        tagName: 'A',
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
+      all.locs.push([loc, param]);
     }
   }
-  if (! withItems) {
-    standardInstances.push({
-      ruleID: 'focVis',
-      what: 'Visible links are above or to the left of the display',
-      ordinalSeverity: 2,
-      tagName: 'A',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = [
+    'Visible link is __param__ the display',
+    'Visible links are above or to the left of the display'
+  ];
+  return await report(withItems, all, 'focVis', whats, 2);
 };

package/testaro/hr.js

@@ -7,61 +7,20 @@
 
 // ########## IMPORTS
 
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
-// Performs the test.
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Initialize the standard result.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for all applicable elements.
-  const locAll = page.locator('body hr');
-  const locsAll = await locAll.all();
-  // For each of them:
-  for (const loc of locsAll) {
-    // Add to the totals.
-    totals[0]++;
-    // If itemization is required:
-    if (withItems) {
-      // Get data on the element.
-      const elData = await getLocatorData(loc);
-      // Add a standard instance.
-      standardInstances.push({
-        ruleID: 'hr',
-        what: 'Element instead of styling is used for vertical segmentation',
-        ordinalSeverity: 0,
-        tagName: 'HR',
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
-    }
-  }
-  // If itemization is not required and there are instances:
-  if (! withItems && totals[0]) {
-    // Add a summary instance.
-    standardInstances.push({
-      ruleID: 'hr',
-      what: 'Elements instead of styling are used for vertical segmentation',
-      ordinalSeverity: 0,
-      count: totals[0],
-      tagName: 'HR',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Initialize the locators and result.
+  const all = await init(page, 'body hr');
+  all.locs = all.allLocs;
+  // Populate and return the result.
+  const whats = [
+    'Element instead of styling is used for vertical segmentation',
+    'Elements instead of styling are used for vertical segmentation'
+  ];
+  return await report(withItems, all, 'hr', whats, 0, 'HR');
 };

package/testaro/labClash.js

@@ -5,80 +5,42 @@
   labels are additive, not conflicting.
 */
 
-// ########## IMPORTS
-
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Initialize the standard result.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for eligible elements.
-  const locAll = page.locator('button, input:not([type=hidden]), select, textarea');
-  const locsAll = await locAll.all();
-  // For each of them:
-  for (const loc of locsAll) {
-    // Get its label types.
-    const labelTypes = await loc.evaluate(element => {
+  // Initialize the locators and result.
+  const all = await init(page, 'button, input:not([type=hidden]), select, textarea');
+  // For each locator:
+  for (const loc of all.allLocs) {
+    // Get the label types of its element.
+    const labelTypes = await loc.evaluate(el => {
       const labelTypes = [];
-      // Attribute label.
-      if (element.hasAttribute('aria-label')) {
-        labelTypes.push('aria-label');
-      }
-      // Reference label.
-      if (element.hasAttribute('aria-labelledby')) {
-        labelTypes.push('aria-labelledby');
-      }
+      // Attribute and reference labels.
+      ['aria-label', 'aria-labelledby'].forEach(type => {
+        if (el.hasAttribute(type)) {
+          labelTypes.push(type);
+        }
+      });
       // Explicit and implicit labels.
-      const labels = Array.from(element.labels);
+      const labels = Array.from(el.labels);
       if (labels.length) {
         labelTypes.push('label');
       }
       return labelTypes;
     });
-    // If it has clashing labels:
+    // If it has more than 1:
     if (labelTypes.length > 1) {
-      // Add to the standard result.
-      totals[2]++;
-      if (withItems) {
-        const elData = await getLocatorData(loc);
-        standardInstances.push({
-          ruleID: 'labClash',
-          what: `Element has inconsistent label types (${labelTypes.join(', ')})`,
-          ordinalSeverity: 2,
-          tagName: elData.tagName,
-          id: elData.id,
-          location: elData.location,
-          excerpt: elData.excerpt
-        });
-      }
-    }
-    // If there are any instances and itemization is not required:
-    if (totals[2] && ! withItems) {
-      // Add a summary standard instance.
-      standardInstances.push({
-        ruleID: 'labClash',
-        what: 'Elements have inconsistent label types',
-        count: totals[2],
-        ordinalSeverity: 2,
-        tagName: '',
-        id: '',
-        location: {
-          doc: '',
-          type: '',
-          spec: ''
-        },
-        excerpt: ''
-      });
+      // Add the locator and a list of them to the array of violators.
+      all.locs.push([loc, labelTypes.join(', ')]);
     }
   }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = [
+    'Element has inconsistent label types (__param__)', 'Elements have inconsistent label types'
+  ];
+  return await report(withItems, all, 'labClash', whats, 2);
 };

package/testaro/lineHeight.js

@@ -7,98 +7,37 @@
   their subtrees are excluded.
 */
 
-// ########## IMPORTS
-
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
-// Gets the ratio of line height to font size not reached, as text, from an ordinal severity.
-const getRatio = ordinalSeverity => ['1.5', '1.3', '1.1', '0.9'][ordinalSeverity];
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Initialize the standard result.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for all body elements with any descendant non-spacing text.
-  const locAll = page.locator('body *', {hasText: /[^\s]/});
-  const locsAll = await locAll.all();
-  // For each of them:
-  for (const loc of locsAll) {
-    // Get data on it.
-    const facts = await loc.evaluate(element => {
-      const styleDec = window.getComputedStyle(element);
+  // Initialize the locators and result.
+  const all = await init(page, 'body *', {hasText: /[^\s]/});
+  // For each locator:
+  for (const loc of all.allLocs) {
+    // Get whether its element violates the rule.
+    const data = await loc.evaluate(el => {
+      const styleDec = window.getComputedStyle(el);
       const {fontSize, lineHeight} = styleDec;
       return {
         fontSize: Number.parseFloat(fontSize),
         lineHeight: Number.parseFloat(lineHeight)
       };
     });
-    // If its line height is substandard:
-    const ratio = facts.lineHeight / facts.fontSize;
-    let ordinalSeverity = -1;
-    if (ratio < 0.9) {
-      ordinalSeverity = 3;
-    }
-    else if (ratio < 1.1) {
-      ordinalSeverity = 2;
-    }
-    else if (ratio < 1.3) {
-      ordinalSeverity = 1;
-    }
-    else if (ratio < 1.5) {
-      ordinalSeverity = 0;
+    // If it does:
+    const isBad = data.lineHeight < 1.5 * data.fontSize;
+    if (isBad) {
+      // Add the locator to the array of violators.
+      all.locs.push([loc, `font size ${data.fontSize} px, line height ${data.lineHeight} px`]);
     }
-    if (ordinalSeverity > -1) {
-      // Add to the totals.
-      totals[ordinalSeverity]++;
-      // If itemization is required:
-      if (withItems) {
-        // Get data on the element.
-        const elData = await getLocatorData(loc);
-        // Add a standard instance.
-        standardInstances.push({
-          ruleID: 'lineHeight',
-          what:
-          `Element line height ${facts.lineHeight} px is less than ${getRatio(ordinalSeverity)} times its font size ${facts.fontSize} px`,
-          ordinalSeverity,
-          tagName: elData.tagName,
-          id: elData.id,
-          location: elData.location,
-          excerpt: elData.excerpt
-        });
-      }
-    }
-  }
-  // If itemization is not required:
-  if (! withItems) {
-    // For each ordinal severity:
-    [0, 1, 2, 3].forEach(ordinalSeverity => {
-      // If there are instances with it:
-      if (totals[ordinalSeverity]) {
-        // Add a summary instance.
-        standardInstances.push({
-          ruleID: 'lineHeight',
-          what:
-          `Elements have line heights less than ${getRatio(ordinalSeverity)} times their font sizes`,
-          ordinalSeverity,
-          count: totals[ordinalSeverity],
-          tagName: '',
-          id: '',
-          location: {
-            doc: '',
-            type: '',
-            spec: ''
-          },
-          excerpt: ''
-        });
-      }
-    });
   }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = [
+    'Element line height is less than 1.5 times its font size (__param__)',
+    'Elements have line heights less than 1.5 times their font sizes'
+  ];
+  return await report(withItems, all, 'lineHeight', whats, 1);
 };

package/testaro/linkAmb.js

@@ -5,61 +5,38 @@
   Text contents are compared case-insensitively.
 */
 
-// ########## IMPORTS
-
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 // Module to get locator data.
 const {getLocatorData} = require('../procs/getLocatorData');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for the visible links with destinations.
-  const locAll = page.locator('a[href]:visible');
-  const locsAll = await locAll.all();
-  // Get data on them.
-  const excerpts = new Set();
-  for (const loc of locsAll) {
+  // Initialize the locators and result.
+  const all = await init(page, 'a[href]:visible');
+  const linkTexts = new Set();
+  // For each locator:
+  for (const loc of all.allLocs) {
+    // Get its text.
     const elData = await getLocatorData(loc);
-    if (excerpts.has(elData.excerpt.toLowerCase())) {
-      totals[2]++;
-      if (withItems) {
-        standardInstances.push({
-          ruleID: 'linkAmb',
-          what: 'Link has the same text as, but a different destination from, another',
-          ordinalSeverity: 2,
-          tagName: 'A',
-          id: elData.id,
-          location: elData.location,
-          excerpt: elData.excerpt
-        });
-      }
+    // If a previous link has the same text:
+    const linkText = elData.excerpt.toLowerCase();
+    if (linkTexts.has(linkText)) {
+      // Add the locator to the array of violators.
+      all.locs.push(loc);
     }
+    // Otherwise, i.e. if this is the first link with the text:
     else {
-      excerpts.add(elData.excerpt.toLowerCase());
+      // Record its text.
+      linkTexts.add(linkText);
     }
   }
-  if (! withItems && totals[2]) {
-    standardInstances.push({
-      ruleID: 'linkAmb',
-      what: 'Links have the same texts but different destinations',
-      count: totals[2],
-      ordinalSeverity: 2,
-      tagName: 'A',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = [
+    'Link has the same text as, but a different destination from, another',
+    'Links have the same texts but different destinations'
+  ];
+  return await report(withItems, all, 'linkAmb', whats, 2);
 };

package/testaro/linkExt.js

@@ -5,61 +5,17 @@
   risk miscommunication of the externality and remove control from the user.
 */
 
-// ########## IMPORTS
-
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for links with target=_blank attributes.
-  const locAll = page.locator('a[target=_blank]');
-  const locs = await locAll.all();
-  // Add to the result.
-  totals[0] = locs.length;
-  // If itemization is required:
-  if (withItems) {
-    // For each such link:
-    for (const loc of locs) {
-      // Get data on it.
-      const elData = await getLocatorData(loc);
-      // Add to the result.
-      standardInstances.push({
-        ruleID: 'linkExt',
-        what: 'Link has a target=_blank attribute',
-        ordinalSeverity: 0,
-        tagName: 'A',
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
-    }
-  }
-  // Otherwise, i.e. if itemization is not required:
-  else {
-    // Add a summary instance.
-    standardInstances.push({
-      ruleID: 'linkExt',
-      what: 'Links have target=_blank attributes',
-      count: totals[0],
-      ordinalSeverity: 0,
-      tagName: 'A',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Initialize the locators and result.
+  const all = await init(page, 'a[target=_blank]');
+  all.locs = all.allLocs;
+  // Populate and return the result.
+  const whats = ['Link has a target=_blank attribute', 'Links have target=_blank attributes'];
+  return await report(withItems, all, 'linkExt', whats, 0);
 };

package/testaro/linkTitle.js

@@ -1,66 +1,36 @@
 /*
   linkTitle
   Related to Tenon rule 79.
-  This test reports links with title attributes with values contained in the link text contents.
+  This test reports links with title attributes whose values the link text contains.
 */
 
-// ########## IMPORTS
-
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 // Module to get locator data.
 const {getLocatorData} = require('../procs/getLocatorData');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for the links with title attributes.
-  const locAll = page.locator('a[title]');
-  const locs = await locAll.all();
-  // For each of them:
-  for (const loc of locs) {
-    // Get data on it.
-    const title = await loc.getAttribute('title');
+  // Initialize the locators and result.
+  const all = await init(page, 'a[title]');
+  // For each locator:
+  for (const loc of all.allLocs) {
+    // Get whether its element violates the rule.
     const elData = await getLocatorData(loc);
-    // If the title value is contained in the excerpt:
-    if (elData.excerpt.toLowerCase().includes(title.toLowerCase())) {
-      // Add to the result.
-      totals[0]++;
-      if (withItems) {
-        standardInstances.push({
-          ruleID: 'linkTitle',
-          what: 'Link has a title attribute that repeats link text content',
-          ordinalSeverity: 0,
-          tagName: 'A',
-          id: elData.id,
-          location: elData.location,
-          excerpt: elData.excerpt
-        });
-      }
+    const title = await loc.getAttribute('title');
+    const isBad = elData.excerpt.toLowerCase().includes(title.toLowerCase());
+    // If it does:
+    if (isBad) {
+      // Add the locator to the array of violators.
+      all.locs.push(loc);
     }
   }
-  // If itemization is not required and there are any instances:
-  if (! withItems && totals[0]) {
-    // Add a summary instance to the result.
-    standardInstances.push({
-      ruleID: 'linkTitle',
-      what: 'Links have title attributes that repeat link text contents',
-      count: totals[0],
-      ordinalSeverity: 0,
-      tagName: 'A',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = [
+    'Link has a title attribute that repeats link text content',
+    'Links have title attributes that repeat link text contents'
+  ];
+  return await report(withItems, all, 'linkTitle', whats, 0);
 };

package/testaro/linkTo.js

@@ -4,62 +4,17 @@
   This test reports failures to equip links with destinations.
 */
 
-// ########## IMPORTS
-
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for the visible links without href attributes.
-  const locAll = page.locator('a:not([href]):visible');
-  const locs = await locAll.all();
-  // For each of them:
-  for (const loc of locs) {
-    // If itemization is required:
-    if (withItems) {
-      // Get data on the element.
-      const elData = await getLocatorData(loc);
-      // Add an instance to the result.
-      standardInstances.push({
-        ruleID: 'linkTo',
-        what: 'Link has no href attribute',
-        ordinalSeverity: 2,
-        tagName: 'A',
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
-    }
-  }
-  // Add to the totals.
-  totals[2] = locs.length;
-  // If itemization is not required:
-  if (! withItems) {
-    // Add a summary instance to the result.
-    standardInstances.push({
-      ruleID: 'linkTo',
-      what: 'Links are missing href attributes',
-      count: totals[2],
-      ordinalSeverity: 2,
-      tagName: 'A',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  // Return the result.
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Initialize the locators and result.
+  const all = await init(page, 'a:not([href]):visible');
+  all.locs = all.allLocs;
+  // Populate and return the result.
+  const whats = ['Link has no href attribute', 'inks are missing href attributes'];
+  return await report(withItems, all, 'linkTo', whats, 2);
 };

package/testaro/linkUl.js

@@ -8,82 +8,36 @@
   merely to discover which passages are links.
 */
 
-// ########## IMPORTS
-
-// Module to get locator data.
-const {getLocatorData} = require('../procs/getLocatorData');
+// Module to perform common operations.
+const {init, report} = require('../procs/testaro');
 // Module to classify links.
 const {isInlineLink} = require('../procs/isInlineLink');
 
 // ########## FUNCTIONS
 
+// Runs the test and returns the result.
 exports.reporter = async (page, withItems) => {
-  // Initialize the result.
-  const data = {};
-  const totals = [0, 0, 0, 0];
-  const standardInstances = [];
-  // Get locators for all inline links.
-  const locAll = page.locator('a');
-  const locsAll = await locAll.all();
-  const inlineLocs = [];
-  for (const loc of locsAll) {
-    if (await isInlineLink(loc)) {
-      inlineLocs.push(loc);
-    }
-  }
-  // Get locators for all non-underlined inline links.
-  const locs = [];
-  for (const loc of inlineLocs) {
-    const isUnderlined = await loc.evaluate(element => {
-      const styleDec = window.getComputedStyle(element);
+  // Initialize the locators and result.
+  const all = await init(page, 'a');
+  // For each locator:
+  for (const loc of all.allLocs) {
+    // Get whether its element is underlined.
+    const isUnderlined = await loc.evaluate(el => {
+      const styleDec = window.getComputedStyle(el);
       return styleDec.textDecorationLine === 'underline';
     });
+    // If it is not:
     if (! isUnderlined) {
-      locs.push(loc);
+      // Get whether it is inline.
+      const isInline = await isInlineLink(loc);
+      // If it is:
+      if (isInline) {
+        // Add the locator to the array of violators.
+        all.locs.push(loc);
+      }
     }
   }
-  // Add to the totals.
-  totals[1] = locs.length;
-  // If itemization is required:
-  if (withItems) {
-    // For each non-underlined inline link:
-    for (const loc of locs) {
-      // Get data on it.
-      const elData = await getLocatorData(loc);
-      // Add an instance to the result.
-      standardInstances.push({
-        ruleID: 'linkUl',
-        what: 'Link is inline but has no underline',
-        ordinalSeverity: 1,
-        tagName: 'A',
-        id: elData.id,
-        location: elData.location,
-        excerpt: elData.excerpt
-      });
-    }
-  }
-  // Otherwise, i.e. if itemization is not required:
-  else {
-    // Add a summary instance to the result.
-    standardInstances.push({
-      ruleID: 'linkUl',
-      what: 'Inline links are missing underlines',
-      count: totals[1],
-      ordinalSeverity: 1,
-      tagName: 'A',
-      id: '',
-      location: {
-        doc: '',
-        type: '',
-        spec: ''
-      },
-      excerpt: ''
-    });
-  }
-  // Return the result.
-  return {
-    data,
-    totals,
-    standardInstances
-  };
+  // Populate and return the result.
+  const whats = ['Link is inline but has no underline', 'Inline links are missing underlines'];
+  return await report(withItems, all, 'linkUl', whats, 1);
 };

package/validation/tests/jobs/embAc.json

@@ -67,6 +67,11 @@
           "=",
           "BUTTON"
         ],
+        [
+          "standardResult.instances.0.id",
+          "=",
+          "buttonInLink"
+        ],
         [
           "standardResult.instances.0.location.doc",
           "=",
@@ -75,12 +80,12 @@
         [
           "standardResult.instances.0.location.type",
           "=",
-          "box"
+          "selector"
         ],
         [
-          "standardResult.instances.0.location.spec.x",
-          ">",
-          0
+          "standardResult.instances.0.location.spec",
+          "=",
+          "#buttonInLink"
         ],
         [
           "standardResult.instances.0.excerpt",

package/validation/tests/jobs/filter.json

@@ -55,7 +55,7 @@
         [
           "standardResult.totals.1",
           "=",
-          7
+          0
         ],
         [
           "standardResult.instances.0.ruleID",
@@ -65,7 +65,7 @@
         [
           "standardResult.instances.0.what",
           "i",
-          ": 5"
+          "Element has"
         ],
         [
           "standardResult.instances.0.tagName",
@@ -127,7 +127,12 @@
         [
           "standardResult.totals.1",
           "=",
-          7
+          0
+        ],
+        [
+          "standardResult.instances.length",
+          "=",
+          1
         ],
         [
           "standardResult.instances.0.ruleID",
@@ -139,20 +144,10 @@
           "i",
           "Elements have"
         ],
-        [
-          "standardResult.instances.1.ordinalSeverity",
-          "=",
-          1
-        ],
         [
           "standardResult.instances.0.count",
           "=",
           2
-        ],
-        [
-          "standardResult.instances.1.count",
-          "=",
-          7
         ]
       ],
       "rules": [

package/validation/tests/jobs/lineHeight.json

@@ -21,7 +21,7 @@
       "stopOnFail": true,
       "expect": [
         [
-          "standardResult.totals.3",
+          "standardResult.totals.1",
           "=",
           1
         ],
@@ -38,12 +38,12 @@
         [
           "standardResult.instances.0.what",
           "i",
-          "is less than 0.9 times"
+          "is less than 1.5 times"
         ],
         [
           "standardResult.instances.0.ordinalSeverity",
           "=",
-          3
+          1
         ],
         [
           "standardResult.instances.0.tagName",
@@ -88,7 +88,7 @@
       "stopOnFail": true,
       "expect": [
         [
-          "standardResult.totals.3",
+          "standardResult.totals.1",
           "=",
           1
         ],
@@ -115,7 +115,7 @@
         [
           "standardResult.instances.0.what",
           "i",
-          "heights less than 0.9 times"
+          "heights less than 1.5 times"
         ]
       ],
       "rules": [

package/validation/tests/targets/embAc/bad.html

@@ -10,7 +10,7 @@
     <main>
       <h1>Page with embedded interactive elements</h1>
       <p>All of the following embeddings violate the HTML specification for <a href="https://html.spec.whatwg.org/multipage/text-level-semantics.html#the-a-element">links</a> or <a href="https://html.spec.whatwg.org/multipage/form-elements.html#the-button-element">buttons</a>.</p>
-      <p>Bug 1. This link to <a href="https://en.wikipedia.org/wiki/Button">information about <button type="button">buttons</button> like this</a> contains one.</p>
+      <p>Bug 1. This link to <a href="https://en.wikipedia.org/wiki/Button">information about <button id="buttonInLink" type="button">buttons</button> like this</a> contains one.</p>
       <p>Bug 2. This link to <a href="https://en.wikipedia.org/wiki/Input_method">information about checkboxes such as <input type="checkbox" aria-label="yes or no"> this</a> contains one.</p>
       <p>Bug 3. This link to <a href="https://en.wikipedia.org/wiki/Drop-down_list">information about drop-down lists such as <select aria-label="choose one"><option>A</option><option>B</option></select></a> contains one.</p>
       <p>Bugs 4 and 5. This link to <a href="https://en.wikipedia.org/wiki/HTML">information about HTML text inputs (<input type="text" aria-label="input">), <button type="button">buttons</button>, etc.</a> contains a text input and a button.</p>